[PATCH] drm/gma500: use vma_pages().
On Sat, May 21, 2016 at 3:21 PM, Muhammad Falak R Wani wrote: > Replace explicit computation of vma page count by a call to > vma_pages() > > Signed-off-by: Muhammad Falak R Wani Thanks, queued for gma500-next > --- > drivers/gpu/drm/gma500/framebuffer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/gma500/framebuffer.c > b/drivers/gpu/drm/gma500/framebuffer.c > index 7440bf9..5486e7e 100644 > --- a/drivers/gpu/drm/gma500/framebuffer.c > +++ b/drivers/gpu/drm/gma500/framebuffer.c > @@ -125,7 +125,7 @@ static int psbfb_vm_fault(struct vm_area_struct *vma, > struct vm_fault *vmf) > unsigned long phys_addr = (unsigned long)dev_priv->stolen_base + > psbfb->gtt->offset; > > - page_num = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT; > + page_num = vma_pages(vma); > address = (unsigned long)vmf->virtual_address - (vmf->pgoff << > PAGE_SHIFT); > > vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot); > -- > 1.9.1 >
[Bug 104791] ACPI errors on Lenovo C50-30 (AE_AML_INFINITE_LOOP, argument type mismatch)
https://bugzilla.kernel.org/show_bug.cgi?id=104791 --- Comment #9 from James --- This patch does stop the infinite loop on my machine. (Although now with or without it nouveau seems to cause delays starting GNOME 3, but that's another bug report.) -- You are receiving this mail because: You are watching the assignee of the bug.
[PATCH 16/54] MAINTAINERS: Add file patterns for drm device tree bindings
Submitters of device tree binding documentation may forget to CC the subsystem maintainer if this is missing. Signed-off-by: Geert Uytterhoeven Cc: David Airlie Cc: dri-devel at lists.freedesktop.org --- Please apply this patch directly if you want to be involved in device tree binding documentation for your subsystem. --- MAINTAINERS | 3 +++ 1 file changed, 3 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index c79b99dd3a0bf22d..75138c09dd603093 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3868,6 +3868,9 @@ T:git git://people.freedesktop.org/~airlied/linux S: Maintained F: drivers/gpu/drm/ F: drivers/gpu/vga/ +F: Documentation/devicetree/bindings/display/ +F: Documentation/devicetree/bindings/gpu/ +F: Documentation/devicetree/bindings/video/ F: Documentation/DocBook/gpu.* F: include/drm/ F: include/uapi/drm/ -- 1.9.1
Unanswered bug report in the Vulkan Intel driver
Hello, First sorry, for the potential double post in the two different mailing list. I was told in Phoronix to direct my complains here. One month ago I submitted a bug report with a workaround patch for a clear violation of the Vulkan spec ( https://bugs.freedesktop.org/show_bug.cgi?id=95034 ). In addition to my bug report, there are other old reports that are marked as new in ( https://bugs.freedesktop.org/buglist.cgi?component=Drivers%2FVulkan%2Fintel&list_id=580327&product=Mesa&resolution=--- ). This gives the impression that these bug reports are not being readed. Greetings, Ronie Salgado -- next part -- An HTML attachment was scrubbed... URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20160522/f3645d0b/attachment.html>
[Bug 104791] ACPI errors on Lenovo C50-30 (AE_AML_INFINITE_LOOP, argument type mismatch)
https://bugzilla.kernel.org/show_bug.cgi?id=104791 --- Comment #10 from Peter Wu --- (In reply to James from comment #9) > This patch does stop the infinite loop on my machine. Cool, can I add your Tested-by: James <... at googlemail.com> to the patch? > (Although now with or without it nouveau seems to cause delays starting > GNOME 3, but that's another bug report.) If it is a second or so, that is likely the card switching on or off. With or without this patch you can disable the power saving by setting the module option nouveau.runpm=0 (kernel cmdline) or "options nouveau runpm=0" (modprobe.conf snippet). Do you still experience a delay after that? -- You are receiving this mail because: You are watching the assignee of the bug.
[Bug 118701] New: x86_64 GMA500 reports /dev/dri/card0: failed to set DRM interface version 1.4: Inappropriate ioctl for device
https://bugzilla.kernel.org/show_bug.cgi?id=118701 Bug ID: 118701 Summary: x86_64 GMA500 reports /dev/dri/card0: failed to set DRM interface version 1.4: Inappropriate ioctl for device Product: Drivers Version: 2.5 Kernel Version: 4.6 Hardware: Intel OS: Linux Tree: Mainline Status: NEW Severity: normal Priority: P1 Component: Video(DRI - non Intel) Assignee: drivers_video-dri at kernel-bugs.osdl.org Reporter: smf.linux at ntlworld.com Regression: No Created attachment 217091 --> https://bugzilla.kernel.org/attachment.cgi?id=217091&action=edit Xorg.0.log, lspci and dmesg outputs. MSI U180 atom netbook using gma500 driver works fine if the kernel is build as 32bit however if I build the kernel as 64bit the Xserver fails to start and reports: [27.260] (EE) /dev/dri/card0: failed to set DRM interface version 1.4: Inappropriate ioctl for device Please find attached Xorg.0.log, lspci and dmesg outputs. Any suggestions as to what is wrong ? -- You are receiving this mail because: You are watching the assignee of the bug.
[Bug 104791] ACPI errors on Lenovo C50-30 (AE_AML_INFINITE_LOOP, argument type mismatch)
https://bugzilla.kernel.org/show_bug.cgi?id=104791 --- Comment #11 from James --- (In reply to Peter Wu from comment #10) > (In reply to James from comment #9) > > This patch does stop the infinite loop on my machine. > > Cool, can I add your Tested-by: James <... at googlemail.com> to the patch? Yes you may. Please note I tested this patch against the current Fedora 23 kernel, 4.4.9-300.fc23.x86_64. > > (Although now with or without it nouveau seems to cause delays starting > > GNOME 3, but that's another bug report.) > > If it is a second or so, that is likely the card switching on or off. With > or without this patch you can disable the power saving by setting the module > option nouveau.runpm=0 (kernel cmdline) or "options nouveau runpm=0" > (modprobe.conf snippet). Do you still experience a delay after that? It was more like 10 seconds. However the delay did disappear after using runpm=0. (I generally don't use the nVidia chip on this machine even under Windows, it's an 820A on 4 PCIe lanes. I've not seen it show performance advantage over the built-in Intel HD5500, I don't know why Lenovo bothered with it.) -- You are receiving this mail because: You are watching the assignee of the bug.
TRIDENT Ciberbladei1 DRI Status
Hi, I am a Linux GNOME user for many years, my PC H/W is based on Cyberbladei1 video chip. I have seen some work by Alan reported at XOrg. May I just ask ask about DRI status? I am looking into a possibility of 3D acceleration as it is supported by my H/W. I can offer some testing and debugging if that is of any help. Many thanks in advance. Kind regards -- Tomas Kral
[Nouveau] [PATCH] gpu/nouveau/nouveau_acpi.c: Fix Type Mismatch ACPI warning
On Fri, May 20, 2016 at 02:22:57AM +, Marcos Souza wrote:
[..]
> > > I don't know if this is the right thing to do, I just looked at
> > intel_acpi.c to check how to use/check for ACPI Package.
> > > The patch below silenced the "type mismatch" warnings, and some of the
> > "evaluated _DSM" ones.
> > >
> > > If this is not the right approach, please let me know how to fix it, I
> > don't have knowledge in ACPI, but I really want to help.
> > >
> > > drivers/gpu/drm/nouveau/nouveau_acpi.c | 14 +-
> > > 1 file changed, 1 insertion(+), 13 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/nouveau/nouveau_acpi.c
> > b/drivers/gpu/drm/nouveau/nouveau_acpi.c
> > > index cdf5227..f04aef3 100644
> > > --- a/drivers/gpu/drm/nouveau/nouveau_acpi.c
> > > +++ b/drivers/gpu/drm/nouveau/nouveau_acpi.c
> > > @@ -73,22 +73,10 @@ static const char nouveau_op_dsm_muid[] = {
> > >
> > > static int nouveau_optimus_dsm(acpi_handle handle, int func, int arg,
> > uint32_t *result)
> > > {
> > > - int i;
> > > union acpi_object *obj;
> > > - char args_buff[4];
> > > - union acpi_object argv4 = {
> > > - .buffer.type = ACPI_TYPE_BUFFER,
> > > - .buffer.length = 4,
> > > - .buffer.pointer = args_buff
> > > - };
> > > -
> > > - /* ACPI is little endian, AABBCCDD becomes {DD,CC,BB,AA} */
> > > - for (i = 0; i < 4; i++)
> > > - args_buff[i] = (arg >> i * 8) & 0xFF;
> > > -
> > > *result = 0;
> > > obj = acpi_evaluate_dsm_typed(handle, nouveau_op_dsm_muid,
> > 0x0100,
> > > - func, &argv4, ACPI_TYPE_BUFFER);
> > > + func, NULL, ACPI_TYPE_PACKAGE);
This effectively removes the fourth parameter (actually, using a zero
as fourth argument), making the function useless.
> > The last parameter you give to `acpi_evaluate_dsm_typed()` is the return
> > type
> > you expect (see [3]), which will be a buffer if func is 0, and is
> > implementation dependent otherwise (see section 9.14.1 _DSM of [4]). So you
> > donât want to change it to ACPI_TYPE_PACKAGE. If you look at the
> > implementation
> > of `acpi_evaluate_dsm()` (which is called by `acpi_evaluate_dsm_typed()`),
> > it
> > will automatically create a package for the 4th argument, if you pass it a
> > NULL
> > pointer (see [5]).
> >
> > [3]:
> > https://github.com/torvalds/linux/blob/46c13450624e36302547a2ac3695f2350fe7ffc3/include/acpi/acpi_bus.h#L69
> > [4]: http://www.acpi.info/DOWNLOADS/ACPI_5_Errata%20A.pdf
> > [5]:
> > https://github.com/torvalds/linux/blob/46c13450624e36302547a2ac3695f2350fe7ffc3/drivers/acpi/utils.c#L628
>
>
> Thanks for all the links. I'll read the docs and send a new version of the
> patch when it makes more sense instead of just replacing random things.
The warning is unavoidable, most firmware expect a Buffer for the fourth
argument (counting from 0, this is Arg3). Excerpt from the DSM method on
a recent Skylake laptop (Clevo P651, but this format is found on many
other models from various manufacturers too):
If ((Arg2 == 0x1A))
{
CreateField (Arg3, 0x18, 0x02, OMPR)
CreateField (Arg3, Zero, One, FLCH)
CreateField (Arg3, One, One, DVSR)
CreateField (Arg3, 0x02, One, DVSC)
(The sections below refer to the one in the ACPI 6.1 document that can
be found at http://uefi.org/specifications.)
The first parameter for CreateField is evaluated as buffer (sec 19.6.21).
According to 19.3.5.6 (Data Types and Type Conversions) an implicit
conversion to a Buffer is only possible from an Integer and String, a
Package does not belong to the possibilities.
Note that the return value may be an integer for unsupported revision
IDs or UUIDs (like 0x8002). These should be compatible with Buffers
though as stated above and acpi_check_dsm() can handle that case, but
unfortunately sets a Package as fourth argument and can therefore not be
used in nouveau.
--
Kind regards,
Peter Wu
https://lekensteyn.nl
[Bug 95451] UVD errors after unsuspending
https://bugs.freedesktop.org/show_bug.cgi?id=95451 --- Comment #2 from Vedran MiletiÄ --- The issue I get is a different one, possibly bug 92836. -- You are receiving this mail because: You are the assignee for the bug. -- next part -- An HTML attachment was scrubbed... URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20160522/19f6f0e9/attachment.html>
[Bug 92836] amdgpu does not resume properly from suspend
https://bugs.freedesktop.org/show_bug.cgi?id=92836 --- Comment #13 from Vedran MiletiÄ --- David, can you try newer kernel? I get the same errors with Fedora kernel 4.5.4 on 01:00.0 VGA compatible controller [0300]: Advanced Micro Devices, Inc. [AMD/ATI] Tonga XT / Amethyst XT [Radeon R9 380X / R9 M295X] [1002:6938] (rev f1) but the errors are non-fatal, i.e. there is graphics corruption but no hangs. Restarting X removes graphics corruption. -- You are receiving this mail because: You are the assignee for the bug. -- next part -- An HTML attachment was scrubbed... URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20160522/187516f2/attachment.html>
[Bug 95526] [AMDGPU][CIK] Suspend to disk deadlocks system (never worked)
https://bugs.freedesktop.org/show_bug.cgi?id=95526 Bug ID: 95526 Summary: [AMDGPU][CIK] Suspend to disk deadlocks system (never worked) Product: DRI Version: unspecified Hardware: Other OS: All Status: NEW Severity: normal Priority: medium Component: DRM/AMDgpu Assignee: dri-devel at lists.freedesktop.org Reporter: shawn.starr at rogers.com Current kernel: 4.7.0-0.rc0.git2.3.fc23.x86_64 with CIK enabled in AMDGPU. If I use the following command: echo disk > /sys/power/state The laptop deadlocks and never attempts to freeze/write memory to disk. This has never worked for me with AMDGPU with CIK enabled, so I don't know if there's a point to bisect from. -- You are receiving this mail because: You are the assignee for the bug. -- next part -- An HTML attachment was scrubbed... URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20160522/7a41175a/attachment.html>
[Bug 95527] [radeonsi][CIK][VDPAU] Unable to use VDPAU locks up X
https://bugs.freedesktop.org/show_bug.cgi?id=95527 Bug ID: 95527 Summary: [radeonsi][CIK][VDPAU] Unable to use VDPAU locks up X Product: Mesa Version: unspecified Hardware: Other OS: All Status: NEW Severity: normal Priority: medium Component: Drivers/Gallium/radeonsi Assignee: dri-devel at lists.freedesktop.org Reporter: shawn.starr at rogers.com QA Contact: dri-devel at lists.freedesktop.org I am currently using kernel module AMDGPU with CIK enabled: Attached is Xorg.log - Mesa is git master from 2016-05-20 - LLVM 3.9 trunk is from same date - Kernel compiled is 4.7.0-0.rc0.git2.3.fc23.x86_64 (Fedora) w/ AMDGPU CIK enabled When using VLC, if it attempts to use VDPAU it shows nothing, if I close VLC it crashes X, I can ssh into system however. -- You are receiving this mail because: You are the assignee for the bug. -- next part -- An HTML attachment was scrubbed... URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20160522/705d9a52/attachment-0001.html>
[Bug 95527] [radeonsi][CIK][VDPAU] Unable to use VDPAU locks up X
https://bugs.freedesktop.org/show_bug.cgi?id=95527 --- Comment #1 from Shawn Starr --- Created attachment 123967 --> https://bugs.freedesktop.org/attachment.cgi?id=123967&action=edit Xorg log file -- You are receiving this mail because: You are the assignee for the bug. -- next part -- An HTML attachment was scrubbed... URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20160522/7684a57f/attachment.html>
[Bug 95527] [radeonsi][CIK][VDPAU] Unable to use VDPAU locks up X
https://bugs.freedesktop.org/show_bug.cgi?id=95527 --- Comment #2 from Shawn Starr --- I am also using the latest AMDGPU DDX from git -- You are receiving this mail because: You are the assignee for the bug. -- next part -- An HTML attachment was scrubbed... URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20160522/93cd37bd/attachment.html>
[Bug 92836] amdgpu does not resume properly from suspend
https://bugs.freedesktop.org/show_bug.cgi?id=92836 --- Comment #14 from David Walker --- (In reply to Vedran MiletiÄ from comment #13) > David, can you try newer kernel? I get the same errors with Fedora kernel > 4.5.4 on > > 01:00.0 VGA compatible controller [0300]: Advanced Micro Devices, Inc. > [AMD/ATI] Tonga XT / Amethyst XT [Radeon R9 380X / R9 M295X] [1002:6938] > (rev f1) > > but the errors are non-fatal, i.e. there is graphics corruption but no > hangs. Restarting X removes graphics corruption. Sorry, Vendran, but I ended up buying another laptop (this time from a company that specializes in Linux laptops), so I no longer have a testbed for this. -- You are receiving this mail because: You are the assignee for the bug. -- next part -- An HTML attachment was scrubbed... URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20160522/e115723f/attachment.html>
[Bug 95528] BioShock issues on Tonga
https://bugs.freedesktop.org/show_bug.cgi?id=95528 Bug ID: 95528 Summary: BioShock issues on Tonga Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal Priority: medium Component: Drivers/Gallium/radeonsi Assignee: dri-devel at lists.freedesktop.org Reporter: mike at fireburn.co.uk QA Contact: dri-devel at lists.freedesktop.org Hi I've been having issues starting the game with high settings at 4k resolution on Tonga, at lower settings I'm seeing graphical glitches https://www.youtube.com/watch?v=ZyKjahCamLQ If I start the game in low settings and turn up the settings the game freezes up (I've also had the same issues with high settings on DiRT) I'm running agd5f's drm-next-4.8-wip branch, I've also tried with kernel 4.5 & 4.6 The issue goes away if I'm running llvm-3.8 & Mesa 11.2.2 or running llvm-3.8 with Mesa-git, I can't compile Mesa 11.2.2 with llvm-git This is a prime system Skylake/Tonga - I don't have any issues starting these games on Skylake or see any graphical glitches (of course the game is very slow with these settings) I think these are the same issues that were spotted on Phoronix too Once the apitrace is uploaded I'll post the link -- You are receiving this mail because: You are the assignee for the bug. -- next part -- An HTML attachment was scrubbed... URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20160522/d8ecb488/attachment.html>
[Bug 95528] BioShock issues on Tonga
https://bugs.freedesktop.org/show_bug.cgi?id=95528 Mike Lothian changed: What|Removed |Added CC||mike at fireburn.co.uk --- Comment #1 from Mike Lothian --- Created attachment 123970 --> https://bugs.freedesktop.org/attachment.cgi?id=123970&action=edit Settings that wouldn't allow the game to start with radeonsi (Page 1) -- You are receiving this mail because: You are the assignee for the bug. -- next part -- An HTML attachment was scrubbed... URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20160522/0280e54b/attachment.html>
[Bug 95528] BioShock issues on Tonga
https://bugs.freedesktop.org/show_bug.cgi?id=95528 --- Comment #2 from Mike Lothian --- Created attachment 123971 --> https://bugs.freedesktop.org/attachment.cgi?id=123971&action=edit Settings that wouldn't allow the game to start with radeonsi (Page 2) -- You are receiving this mail because: You are the assignee for the bug. -- next part -- An HTML attachment was scrubbed... URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20160522/1db65e0c/attachment.html>
[Bug 95528] BioShock issues on Tonga
https://bugs.freedesktop.org/show_bug.cgi?id=95528 --- Comment #3 from Mike Lothian --- To clarify, when the settings are too high, the same starts and plays the intro videos but at the point where the cursor normally appears and the main menu is shown, the screen just remains black. I can switch out of the app but I can't kill the process. The only way to stop it is to restart the machine - the graphics card remains powered -- You are receiving this mail because: You are the assignee for the bug. -- next part -- An HTML attachment was scrubbed... URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20160522/fb34f65b/attachment-0001.html>
[Bug 95528] BioShock issues on Tonga
https://bugs.freedesktop.org/show_bug.cgi?id=95528 --- Comment #4 from Mike Lothian --- Trace taken with Apitrace 7.1 can be downloaded from https://drive.google.com/file/d/0BySKFkadlRnpOC04aEJCNGNKeVk/view?usp=sharing -- You are receiving this mail because: You are the assignee for the bug. -- next part -- An HTML attachment was scrubbed... URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20160522/a77bc16d/attachment.html>
[PATCH] staging: lustre: llite: kzalloc/copy_to_user to memdup_user
On Mon, May 23, 2016 at 07:49:29AM +1000, Tobin C Harding wrote: > kzalloc call followed by copy_to_user can be replaced by call to memdup_user. > > Signed-off-by: Tobin C Harding Why did you send this twice? > --- > drivers/gpu/drm/gma500/gma_display.c | 2 +- > drivers/staging/lustre/lustre/llite/dir.c | 22 +++--- > 2 files changed, 8 insertions(+), 16 deletions(-) > > diff --git a/drivers/gpu/drm/gma500/gma_display.c > b/drivers/gpu/drm/gma500/gma_display.c > index 5bf765d..8a1fb25 100644 > --- a/drivers/gpu/drm/gma500/gma_display.c > +++ b/drivers/gpu/drm/gma500/gma_display.c > @@ -285,7 +285,7 @@ void gma_crtc_dpms(struct drm_crtc *crtc, int mode) > > /* Wait for vblank for the disable to take effect */ > gma_wait_for_vblank(dev); > - > +l What? What does this have to do with lustre? It's kind of obvious you didn't build this :( Please be more careful in the future. greg k-h
