[Bug 41367] [r300g, bisected] WebGL test runner regression
https://bugs.freedesktop.org/show_bug.cgi?id=41367 --- Comment #2 from Pavel Ondračka 2011-10-02 01:54:26 PDT --- Yes, only the gl-fragcoord tests regressed and with your webgl-fix.patch all is back to normal (7131 of 7545 passed). -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 41367] [r300g, bisected] WebGL test runner regression
https://bugs.freedesktop.org/show_bug.cgi?id=41367 Tom Stellard changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #3 from Tom Stellard 2011-10-02 15:48:52 PDT --- Fix in git master commit d64c6d2ffc086bde7a025269b80c0980f7d908f1. Thanks for testing, this caught several bugs. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 12/25] vmwgfx: Add screen object support
On Fri, Sep 30, 2011 at 12:05 AM, Konrad Rzeszutek Wilk
wrote:
> On Wed, Sep 28, 2011 at 04:10:08PM +0200, Thomas Hellstrom wrote:
>> From: Jakob Bornecrantz
>>
>> Signed-off-by: Jakob Bornecrantz
>> Signed-off-by: Thomas Hellstrom
>> ---
>> drivers/gpu/drm/vmwgfx/Makefile | 2 +-
>> drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 34 ++-
>> drivers/gpu/drm/vmwgfx/vmwgfx_drv.h | 1 +
>> drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 165 +-
>> drivers/gpu/drm/vmwgfx/vmwgfx_kms.h | 10 +
>> drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c | 5 +-
>> drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c | 566
>> ++
>> 7 files changed, 752 insertions(+), 31 deletions(-)
>> create mode 100644 drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c
>>
>> diff --git a/drivers/gpu/drm/vmwgfx/Makefile
>> b/drivers/gpu/drm/vmwgfx/Makefile
>> index e13a118..586869c 100644
>> --- a/drivers/gpu/drm/vmwgfx/Makefile
>> +++ b/drivers/gpu/drm/vmwgfx/Makefile
>> @@ -5,6 +5,6 @@ vmwgfx-y := vmwgfx_execbuf.o vmwgfx_gmr.o vmwgfx_kms.o
>> vmwgfx_drv.o \
>> vmwgfx_fb.o vmwgfx_ioctl.o vmwgfx_resource.o vmwgfx_buffer.o \
>> vmwgfx_fifo.o vmwgfx_irq.o vmwgfx_ldu.o vmwgfx_ttm_glue.o \
>> vmwgfx_overlay.o vmwgfx_marker.o vmwgfx_gmrid_manager.o \
>> - vmwgfx_fence.o vmwgfx_dmabuf.o
>> + vmwgfx_fence.o vmwgfx_dmabuf.o vmwgfx_scrn.o
>>
>> obj-$(CONFIG_DRM_VMWGFX) := vmwgfx.o
>> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c
>> b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c
>> index d4829cb..d1e1325 100644
>> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c
>> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c
>> @@ -451,22 +451,28 @@ static int vmw_driver_load(struct drm_device *dev,
>> unsigned long chipset)
>> dev_priv->fman = vmw_fence_manager_init(dev_priv);
>> if (unlikely(dev_priv->fman == NULL))
>> goto out_no_fman;
>> +
>> + /* Need to start the fifo to check if we can do screen objects */
>> + ret = vmw_3d_resource_inc(dev_priv, true);
>> + if (unlikely(ret != 0))
>> + goto out_no_fifo;
>> + vmw_kms_save_vga(dev_priv);
>> + DRM_INFO("%s", vmw_fifo_have_3d(dev_priv) ?
>> + "Detected device 3D availability.\n" :
>> + "Detected no device 3D availability.\n");
>
> You could just do:
> DRM_INFO("Detected %s 3D availability\n", vmw_fifo_have_3d(dev_priv) ?
> "device" : "no device");
>
> but I see you are moving code, so that perhaps belongs to another patch.
You are right, I'll add that.
Cheers Jakob.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 10/25] vmwgfx: Refactor common display unit functions to shared file
On Thu, Sep 29, 2011 at 11:50 PM, Konrad Rzeszutek Wilk
wrote:
> On Wed, Sep 28, 2011 at 04:10:06PM +0200, Thomas Hellstrom wrote:
>> From: Jakob Bornecrantz
>>
>> More preparation for Screen Object support.
>>
>> Signed-off-by: Jakob Bornecrantz
>> Signed-off-by: Thomas Hellstrom
>> ---
>> drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 238 +++
>> drivers/gpu/drm/vmwgfx/vmwgfx_kms.h | 31 -
>> drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c | 268
>> ++-
>> 3 files changed, 282 insertions(+), 255 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
>> b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
>> index 68c6351..0c4179b 100644
>> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
>> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
>> @@ -1152,3 +1152,241 @@ u32 vmw_get_vblank_counter(struct drm_device *dev,
>> int crtc)
>> {
>> return 0;
>> }
>> +
>> +
>> +/*
>> + * Small shared kms functions.
>> + */
>> +
>> +int vmw_du_update_layout(struct vmw_private *dev_priv, unsigned num,
>> + struct drm_vmw_rect *rects)
>> +{
>> + struct drm_device *dev = dev_priv->dev;
>> + struct vmw_display_unit *du;
>> + struct drm_connector *con;
>> + int i;
>> +
>> + mutex_lock(&dev->mode_config.mutex);
>> +
>> +#if 0
>> + DRM_INFO("%s: new layout ", __func__);
>> + for (i = 0; i < (int)num; i++)
>
> Would it be easier to make 'i' be 'unsigned int' ?
>
>> + DRM_INFO("(%i, %i %ux%u) ", rects[i].x, rects[i].y,
>> + rects[i].w, rects[i].h);
>> + DRM_INFO("\n");
>> +#else
>> + (void)i;
>
> ?
> What does that do?
>
> [edit: Ah, you are moving the code, so the patch looks fine then.
> Thought I am still confused by this invocation - perhaps it makes sense
> to clean this part of the code in another patch?]
The "i" variable is only used in the commented code, and the (void)i; statement
hides the "unused variable error".
Cheers Jakob.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 05/25] vmwgfx: Make sure the reserved area is at the start of vram
On Thu, Sep 29, 2011 at 11:42 PM, Konrad Rzeszutek Wilk wrote: > On Wed, Sep 28, 2011 at 04:10:01PM +0200, Thomas Hellstrom wrote: >> From: Jakob Bornecrantz >> >> Signed-off-by: Jakob Bornecrantz >> Reviewed-by: Thomas Hellstrom >> --- >> drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 5 - >> 1 files changed, 4 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c >> b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c >> index c14eb76..8ac6cee 100644 >> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c >> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c >> @@ -716,7 +716,10 @@ static int vmw_surface_dmabuf_pin(struct >> vmw_framebuffer *vfb) >> struct vmw_framebuffer_surface *vfbs = >> vmw_framebuffer_to_vfbs(&vfb->base); >> unsigned long size = vfbs->base.base.pitch * vfbs->base.base.height; >> - int ret; >> + struct ttm_placement ne_placement = vmw_vram_ne_placement; >> + int ret = 0; > > So why the 'int ret = 0' ? That looks like it belongs to > a different patch? It doesn't do anything and is not a part of any later patch, then again its okay to be paranoid. Cheers Jakob. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 06/25] vmwgfx: Some comments and BUG_ON
On Thu, Sep 29, 2011 at 11:42 PM, Konrad Rzeszutek Wilk wrote: > On Wed, Sep 28, 2011 at 04:10:02PM +0200, Thomas Hellstrom wrote: >> From: Jakob Bornecrantz >> >> Signed-off-by: Jakob Bornecrantz >> Reviewed-by: Thomas Hellstrom >> --- >> drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c | 5 + >> 1 files changed, 5 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c >> b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c >> index df1c7c5..207f595 100644 >> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c >> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c >> @@ -680,6 +680,9 @@ static int vmw_resize_cmd_bounce(struct vmw_sw_context >> *sw_context, >> * Creates a fence object and submits a command stream marker. >> * If this fails for some reason, We sync the fifo and return NULL. >> * It is then safe to fence buffers with a NULL pointer. >> + * >> + * If @p_handle is not NULL @file_priv must also not be not NULL. Creates > > not be not? > I think you meant: > > "must also not be NULL" > > >> + * a userspace handle if @p_handle is not NULL, does not if otherwise. > > "does not if otherwise".. how about ", otherwise not." Thanks I'll fix that. Cheers Jakob. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 41367] [r300g, bisected] WebGL test runner regression
https://bugs.freedesktop.org/show_bug.cgi?id=41367 --- Comment #2 from Pavel Ondra?ka 2011-10-02 01:54:26 PDT --- Yes, only the gl-fragcoord tests regressed and with your webgl-fix.patch all is back to normal (7131 of 7545 passed). -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 41367] [r300g, bisected] WebGL test runner regression
https://bugs.freedesktop.org/show_bug.cgi?id=41367 Tom Stellard changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #3 from Tom Stellard 2011-10-02 15:48:52 PDT --- Fix in git master commit d64c6d2ffc086bde7a025269b80c0980f7d908f1. Thanks for testing, this caught several bugs. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
