[Bug 30665] r200 overflow command buffer error
https://bugs.freedesktop.org/show_bug.cgi?id=30665 --- Comment #1 from Frederic Crozat 2010-11-01 05:05:53 PDT --- confirming issue with 2.6.36 final kernel, libdrm 2.4.22 and gnome-shell 2.29.1 / clutter 1.5.x -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 30665] r200 overflow command buffer error
https://bugs.freedesktop.org/show_bug.cgi?id=30665 --- Comment #2 from Alex Deucher 2010-11-01 06:08:25 PDT --- Is this still an issue with mesa from git master or the 7.9 branch? This patch specifically: http://cgit.freedesktop.org/mesa/mesa/commit/?h=7.9&id=6936fbc03999354075da4d5b91b1ee7ce190fa80 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 30761] White textures on people in sauerbraten
https://bugs.freedesktop.org/show_bug.cgi?id=30761 --- Comment #11 from Tom Stellard 2010-11-01 10:07:59 PDT --- (In reply to comment #10) > I didn't play very long but I did not observe the whited-out textures on > models > any more. This appears to be fixed. Sorry I did not provide the requested > details earlier; only my laptop runs an ati card and I don't use it very > often. > > If it's not too much trouble, can you provide an overview of the fix that is > suspected to have corrected this bug, just for posterity? I'd appreciate it. > :) > > Thanks again. You could always bisect it to see which commit fixed your problem, but my guess is that it was one of these: a15cf3cd0b21d593033a3abd2b1788de292001bd aa43176ebd26227947b07221f4e475c52bd7a76b 9d2ab6cb00e72fd8b53d0f97578758504b49ee23 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 30754] X server crashes with SEGFAULT when using virtualbox on Evergreen
https://bugs.freedesktop.org/show_bug.cgi?id=30754 Alex Deucher changed: What|Removed |Added CC||othe...@pervalidus.net --- Comment #2 from Alex Deucher 2010-11-01 11:01:28 PDT --- *** Bug 31299 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 31250] Unigine Sanctuary v2.2: menus are broken
https://bugs.freedesktop.org/show_bug.cgi?id=31250 --- Comment #2 from Tom Stellard 2010-11-01 12:01:00 PDT --- If it works with RADEON_NO_TCL=1, then it is probably a vertex shader bug. Can you post the output of RADEON_DEBUG=vp? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 30665] r200 overflow command buffer error
https://bugs.freedesktop.org/show_bug.cgi?id=30665 --- Comment #3 from Frederic Crozat 2010-11-01 13:38:49 PDT --- Just tested 7.9 + r200 6936fbc03999354075da4d5b91b1ee7ce190fa80 commit : still no change. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 1/4] drivers/gpu/drm/vmwgfx: Fix k.alloc switched arguments
On 11/01/2010 12:52 AM, Matt Turner wrote: On Sun, Oct 31, 2010 at 6:33 PM, Joe Perches wrote: Signed-off-by: Joe Perches --- drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c |2 +- drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c b/drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c index a01c47d..29113c9 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c @@ -557,7 +557,7 @@ int vmw_kms_init_legacy_display_system(struct vmw_private *dev_priv) return -EINVAL; } - dev_priv->ldu_priv = kmalloc(GFP_KERNEL, sizeof(*dev_priv->ldu_priv)); + dev_priv->ldu_priv = kmalloc(sizeof(*dev_priv->ldu_priv), GFP_KERNEL); if (!dev_priv->ldu_priv) return -ENOMEM; diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c b/drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c index df2036e..f1a52f9 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c @@ -585,7 +585,7 @@ int vmw_overlay_init(struct vmw_private *dev_priv) return -ENOSYS; } - overlay = kmalloc(GFP_KERNEL, sizeof(*overlay)); + overlay = kmalloc(sizeof(*overlay), GFP_KERNEL); if (!overlay) return -ENOMEM; -- 1.7.3.1.g432b3.dirty Oh! That's a bad one. Indeed. Reviewed-by: Matt Turner Reviewed-by: Thomas Hellstrom ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 31250] Unigine Sanctuary v2.2: menus are broken
https://bugs.freedesktop.org/show_bug.cgi?id=31250 --- Comment #3 from Pavel Ondračka 2010-11-01 15:06:33 PDT --- Created an attachment (id=39969) --> (https://bugs.freedesktop.org/attachment.cgi?id=39969) output with RADEON_DEBUG=vp -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH] drm/radeon/kms: don't disable shared encoders on pre-DCE3 display blocks
The A/B links aren't independantly useable on these blocks so when
we disable the encoders, make sure to only disable the encoder when
there is no connector using it.
Should fix:
https://bugs.freedesktop.org/show_bug.cgi?id=18564
Signed-off-by: Alex Deucher
Cc: sta...@kernel.org
---
drivers/gpu/drm/radeon/radeon_encoders.c | 18 ++
1 files changed, 18 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/radeon/radeon_encoders.c
b/drivers/gpu/drm/radeon/radeon_encoders.c
index ae58b68..b862be6 100644
--- a/drivers/gpu/drm/radeon/radeon_encoders.c
+++ b/drivers/gpu/drm/radeon/radeon_encoders.c
@@ -1547,6 +1547,23 @@ static void radeon_atom_encoder_disable(struct
drm_encoder *encoder)
struct radeon_device *rdev = dev->dev_private;
struct radeon_encoder *radeon_encoder = to_radeon_encoder(encoder);
struct radeon_encoder_atom_dig *dig;
+
+ /* check for pre-DCE3 cards with shared encoders;
+* can't really use the links individually, so don't disable
+* the encoder if it's in use by another connector
+*/
+ if (!ASIC_IS_DCE3(rdev)) {
+ struct drm_encoder *other_encoder;
+ struct radeon_encoder *other_radeon_encoder;
+
+ list_for_each_entry(other_encoder,
&dev->mode_config.encoder_list, head) {
+ other_radeon_encoder = to_radeon_encoder(other_encoder);
+ if ((radeon_encoder->encoder_id ==
other_radeon_encoder->encoder_id) &&
+ drm_helper_encoder_in_use(other_encoder))
+ goto disable_done;
+ }
+ }
+
radeon_atom_encoder_dpms(encoder, DRM_MODE_DPMS_OFF);
switch (radeon_encoder->encoder_id) {
@@ -1586,6 +1603,7 @@ static void radeon_atom_encoder_disable(struct
drm_encoder *encoder)
break;
}
+disable_done:
if (radeon_encoder_is_digital(encoder)) {
if (atombios_get_encoder_mode(encoder) ==
ATOM_ENCODER_MODE_HDMI)
r600_hdmi_disable(encoder);
--
1.7.1.1
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 30665] r200 overflow command buffer error
https://bugs.freedesktop.org/show_bug.cgi?id=30665 --- Comment #1 from Frederic Crozat 2010-11-01 05:05:53 PDT --- confirming issue with 2.6.36 final kernel, libdrm 2.4.22 and gnome-shell 2.29.1 / clutter 1.5.x -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 30665] r200 overflow command buffer error
https://bugs.freedesktop.org/show_bug.cgi?id=30665 --- Comment #2 from Alex Deucher 2010-11-01 06:08:25 PDT --- Is this still an issue with mesa from git master or the 7.9 branch? This patch specifically: http://cgit.freedesktop.org/mesa/mesa/commit/?h=7.9&id=6936fbc03999354075da4d5b91b1ee7ce190fa80 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 30761] White textures on people in sauerbraten
https://bugs.freedesktop.org/show_bug.cgi?id=30761 --- Comment #11 from Tom Stellard 2010-11-01 10:07:59 PDT --- (In reply to comment #10) > I didn't play very long but I did not observe the whited-out textures on > models > any more. This appears to be fixed. Sorry I did not provide the requested > details earlier; only my laptop runs an ati card and I don't use it very > often. > > If it's not too much trouble, can you provide an overview of the fix that is > suspected to have corrected this bug, just for posterity? I'd appreciate it. > :) > > Thanks again. You could always bisect it to see which commit fixed your problem, but my guess is that it was one of these: a15cf3cd0b21d593033a3abd2b1788de292001bd aa43176ebd26227947b07221f4e475c52bd7a76b 9d2ab6cb00e72fd8b53d0f97578758504b49ee23 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 30754] X server crashes with SEGFAULT when using virtualbox on Evergreen
https://bugs.freedesktop.org/show_bug.cgi?id=30754 Alex Deucher changed: What|Removed |Added CC||others1 at pervalidus.net --- Comment #2 from Alex Deucher 2010-11-01 11:01:28 PDT --- *** Bug 31299 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 31250] Unigine Sanctuary v2.2: menus are broken
https://bugs.freedesktop.org/show_bug.cgi?id=31250 --- Comment #2 from Tom Stellard 2010-11-01 12:01:00 PDT --- If it works with RADEON_NO_TCL=1, then it is probably a vertex shader bug. Can you post the output of RADEON_DEBUG=vp? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 30665] r200 overflow command buffer error
https://bugs.freedesktop.org/show_bug.cgi?id=30665 --- Comment #3 from Frederic Crozat 2010-11-01 13:38:49 PDT --- Just tested 7.9 + r200 6936fbc03999354075da4d5b91b1ee7ce190fa80 commit : still no change. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[PATCH 1/4] drivers/gpu/drm/vmwgfx: Fix k.alloc switched arguments
On 11/01/2010 12:52 AM, Matt Turner wrote: > On Sun, Oct 31, 2010 at 6:33 PM, Joe Perches wrote: > >> Signed-off-by: Joe Perches >> --- >> drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c |2 +- >> drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c |2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c >> b/drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c >> index a01c47d..29113c9 100644 >> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c >> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c >> @@ -557,7 +557,7 @@ int vmw_kms_init_legacy_display_system(struct >> vmw_private *dev_priv) >> return -EINVAL; >> } >> >> - dev_priv->ldu_priv = kmalloc(GFP_KERNEL, >> sizeof(*dev_priv->ldu_priv)); >> + dev_priv->ldu_priv = kmalloc(sizeof(*dev_priv->ldu_priv), >> GFP_KERNEL); >> >> if (!dev_priv->ldu_priv) >> return -ENOMEM; >> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c >> b/drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c >> index df2036e..f1a52f9 100644 >> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c >> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c >> @@ -585,7 +585,7 @@ int vmw_overlay_init(struct vmw_private *dev_priv) >> return -ENOSYS; >> } >> >> - overlay = kmalloc(GFP_KERNEL, sizeof(*overlay)); >> + overlay = kmalloc(sizeof(*overlay), GFP_KERNEL); >> if (!overlay) >> return -ENOMEM; >> >> -- >> 1.7.3.1.g432b3.dirty >> > Oh! That's a bad one. > Indeed. > Reviewed-by: Matt Turner > Reviewed-by: Thomas Hellstrom > ___ > dri-devel mailing list > dri-devel at lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel >
[Bug 31250] Unigine Sanctuary v2.2: menus are broken
https://bugs.freedesktop.org/show_bug.cgi?id=31250 --- Comment #3 from Pavel Ondra?ka 2010-11-01 15:06:33 PDT --- Created an attachment (id=39969) --> (https://bugs.freedesktop.org/attachment.cgi?id=39969) output with RADEON_DEBUG=vp -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
Radeon drm: dpms backlight problem / question / bug?
On my Dell Precision M6500, backlight power switching does not work, neither by using bl_power in /sys/backlight/... nor by using DPMS: * Any changes of bl_power are simply and silently ignored (no effect, except that brightness is set to minimum), although brightness tuning works fine (in other words: Both the generic ACPI BIOS driver and the in-kernel Dell laptop backlight driver can control backlight brightness, but not backlight power). * If DPMS becomes active, the screen contents on the internal display slowly becomes garbled or fades away (so video output drivers seem to be off), but the backlight remains on (which is very bad for battery power). The external screen (on display port) behaves even worse: It enters energy saving mode (backlight off) and immediately wakes up again, continuously cycling the backlight power every few seconds. Another problem which optically looks the same: Zapping the X server (Xorg 1.9.1, radeon 6.13.2) with Ctrl-Alt-Bksp leaves the system in an undefined state: * Similar to DPMS, the display fades away or gets garbled (video output off), but the backlight remains on. * It does not switch to the text console automatically, nor is it possible to switch manually with Ctrl-Alt-Fn. Configuration: * Kernel 2.6.35.7-grsec * Radeon DRM with KMS * Radeon framebuffer with backlight control enabled * The Radeon chip is a JUNIPER 0x1002:0x68A0, the kernel should contain all the microcode needed for it. * The displays are LCD1: INTERNAL_UNIPHY and DFP1: INTERNAL_UNIPHY1 Questions: * Is this configuration expected to work, i.e. is DPMS expected to be able to control the backlight power? * If it is, what should I check or try next, what information do you need? * If it is known not to work, is there any chance that the situation changes in the forseeable future? Many thanks in advance for your help! -- Prof. Dr. Klaus Kusche Private address: Rainstra?e 9/1, 88316 Isny, Germany +49 7562 6211377 Klaus.Kusche at computerix.info http://www.computerix.info Office address: NTA Isny gGmbH, Seidenstra?e 12-35, 88316 Isny, Germany +49 7562 9707 36 kusche at nta-isny.de http://www.nta-isny.de
[RESEND] Wayland: swrast-gallium in combination with EGL/pipe_swrast.so?
[RESEND] due to rejects of too big screenshots attachment. (I am sorry about that, now as JPEG + 75% resized, ~100K should be fair now). - Sedat - On Sun, Oct 31, 2010 at 7:34 PM, Sedat Dilek wrote: > Hi, > > I am playing with Wayland this weekend. > > Unfortunately, my RV250 is not r300g-compatible. > > As a workaround I wanted to build and use swrast-gallium for Wayland > (compositor). > > Immediately, when I have "dri" in my autogen line like > "--with-state-trackers=dri,glx,egl" I get also r300_dri.so (r300g) and > EGL/pipe_r300.so auto-built. > > My RV250 has problems to use pipe_r300.so (see below). > I must confirm that "dri" as state-tracker is required to get run > Wayland here (after several builds). > > NOTE: > After several starts of the compositor, I got Wayland running with a > background image (JPG). > But this is very weaky. > > Building mesa with "--with-state-trackers=glx,egl" (no dri set) > results in an unuseable Wayland. > > Next problem is I cannot run Wayland with a mesa compiled with > --disable-gallium. > So Gallium seems to be a must-have as Chia-I Wu confirmed on the > wayland-devel ML. > > In the end - as a more stable solution - I want to use swrastg_dri.so > + EGL/pipe_swrast.so instead. > The mesa build-system is not recognizing this wish of mine. > > Is my workaround idea wrong? > If not, is it a good idea to modify mesa-buildsystem to have *only* > swrastg_dri.so + EGL/pipe_swrast.so built (NO r300* stuff)? > > Thanks in advance. > > > Kind Regards, > - Sedat - > > P.S.: The background shows Walter (a friend of mine) in the > cathedral/dome of Aachen/Germany. > > P.S.S.: > > An autogen line looks like this... > > ./autogen.sh --prefix=/opt/wayland --with-driver=dri > --with-dri-driverdir=/opt/wayland/lib/dri --with-dri-drivers=swrast > --enable-gallium-swrast --with-state-trackers=dri,glx,egl > --disable-glu --disable-glut --disable-glw --enable-egl --enable-gles2 > > ...results in: > > /opt/wayland/lib/dri: > insgesamt 46476 > -rwxr-xr-x 1 sd sd 17052104 31. Okt 18:37 r300_dri.so > -rwxr-xr-x 1 sd sd 14074224 31. Okt 18:37 swrast_dri.so > -rwxr-xr-x 1 sd sd 16456880 31. Okt 18:37 swrastg_dri.so > > /opt/wayland/lib/egl: > insgesamt 22804 > -rwxr-xr-x 1 sd sd ? ?85060 31. Okt 18:37 egl_dri2.so > -rwxr-xr-x 1 sd sd ?1352956 31. Okt 18:37 egl_gallium.so > -rwxr-xr-x 1 sd sd ? ?47832 31. Okt 18:37 egl_glx.so > -rwxr-xr-x 1 sd sd ?3591936 31. Okt 18:37 pipe_r300.so > -rwxr-xr-x 1 sd sd ?3434328 31. Okt 18:37 pipe_swrast.so > -rwxr-xr-x 1 sd sd 14830212 31. Okt 18:37 st_GL.so > > This leads to errors when starting the Wayland compositor: > > sd at tbox:~/src/wayland/wayland/compositor$ LC_ALL=C ./compositor -b > ../../backgrounds/dscn1843.jpg > r300: Warning: Unknown chipset 0x4c66 > radeon: The kernel rejected CS, see dmesg for more information. > > Fact is pipe_r300.so is used: > > # lsof | grep wayland | grep -v bash > firefox-b 4421 ? ? ? ? sd ?mem ? ? ? REG ? ? ? ?8,5 ? 285608 > 260977 /opt/wayland/lib/libEGL.so.1.0 > firefox-b 4421 ? ? ? ? sd ?mem ? ? ? REG ? ? ? ?8,5 ?4416992 > 308578 /opt/wayland/lib/libcairo.so.2.11101.0 > lt-compos 4523 ? ? ? ? sd ?cwd ? ? ? DIR ? ? ? ?8,3 ? ? 4096 > 528742 /home/sd/src/wayland/wayland/compositor > lt-compos 4523 ? ? ? ? sd ?txt ? ? ? REG ? ? ? ?8,3 ? 151648 > 528963 /home/sd/src/wayland/wayland/compositor/.libs/lt-compositor > lt-compos 4523 ? ? ? ? sd ?mem ? ? ? REG ? ? ? ?8,5 14830212 > 260984 /opt/wayland/lib/egl/st_GL.so > lt-compos 4523 ? ? ? ? sd ?mem ? ? ? REG ? ? ? ?8,5 ?3591936 > 260981 /opt/wayland/lib/egl/pipe_r300.so > lt-compos 4523 ? ? ? ? sd ?mem ? ? ? REG ? ? ? ?8,5 ?1352956 > 260983 /opt/wayland/lib/egl/egl_gallium.so > lt-compos 4523 ? ? ? ? sd ?mem ? ? ? REG ? ? ? ?8,5 ? 130800 > 260935 /opt/wayland/lib/libGLESv2.so.2.0.0 > lt-compos 4523 ? ? ? ? sd ?mem ? ? ? REG ? ? ? ?8,5 ? 285608 > 260977 /opt/wayland/lib/libEGL.so.1.0 > lt-compos 4523 ? ? ? ? sd ?mem ? ? ? REG ? ? ? ?8,3 ? ?78296 > 528849 /home/sd/src/wayland/wayland/wayland/.libs/libwayland-server.so.0.0.0 > -- next part -- A non-text attachment was scrubbed... Name: wayland_compositor_walter_resized.jpg Type: image/jpeg Size: 106209 bytes Desc: not available URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20101101/b78f48c3/attachment-0001.jpg>
[PATCH] drm/i915/sdvo: Fix harmless build warning
Peter Stuge wrote:
> Dongdong Deng wrote:
>> Removing the following harmless build warning to let compiler happy.
>
>> @@ -1170,7 +1170,8 @@ static void intel_sdvo_mode_set(struct drm_encoder
>> *encoder,
>> switch (sdvo_pixel_multiply) {
>> case 1: rate = SDVO_CLOCK_RATE_MULT_1X; break;
>> case 2: rate = SDVO_CLOCK_RATE_MULT_2X; break;
>> -case 4: rate = SDVO_CLOCK_RATE_MULT_4X; break;
>> +case 4:
>> +default: rate = SDVO_CLOCK_RATE_MULT_4X;
>> }
>> if (!intel_sdvo_set_clock_rate_mult(intel_sdvo, rate))
>> return;
>
> Even if the default case can not trigger, is 4x a good default multiplier?
>
> Also, shouldn't there be a break; also in the default: case?
Hello Peter,
In the last maintree, the warning have gone with following changing. :-)
switch (pixel_multiplier) {
default:
case 1: rate = SDVO_CLOCK_RATE_MULT_1X; break;
case 2: rate = SDVO_CLOCK_RATE_MULT_2X; break;
case 4: rate = SDVO_CLOCK_RATE_MULT_4X; break;
}
Thanks,
Dongdong
>
>
> //Peter
>
