Re: test-net.c failure

2018-01-31 Thread Rupert Gallagher
I meant to disable it when configuring the source, and thus when running make 
check. The test fails on 2.3.0 only, the 2.2 branch did not have this problem.

Sent from ProtonMail Mobile

On Wed, Jan 31, 2018 at 05:56, Prasad K  wrote:

> The dovecot.conf file from CentOS-7 contains this :
>
> --- snip ---
> # A comma separated list of IPs or hosts where to listen in for connections.
> # "*" listens in all IPv4 interfaces, "::" listens in all IPv6 interfaces.
> # If you want to specify non-default ports or anything more complex,
> # edit conf.d/master.conf.
> #listen = *, ::
> --- snip ---
>
> HTH
>
> --
> Prasad
>
> On 30/01/18 11:35 PM, Rupert Gallagher wrote:
>
>> test-net.c:79: Assert failed: strcmp(net_ip2addr(&ip), "::5") == 0
>> test-net.c:83: Assert failed: strcmp(net_ip2addr(&ip), "::5") == 0
>> net_ip2addr()  : 
>> FAILED
>>
>> Hello,
>> Is it possible to disable DOVECOT_IPV6?
>> We do not use IPv6 (and hope we shall never do on e-mails).

Re: test-net.c failure

2018-01-31 Thread Aki Tuomi
This test is not dependant on the configuration file. I have to see under which 
exact circumstances does it fail. It should not fail even if you don't have 
IPv6 enabled on your system.

Aki

> On January 31, 2018 at 10:09 AM Rupert Gallagher  wrote:
> 
> 
> I meant to disable it when configuring the source, and thus when running make 
> check. The test fails on 2.3.0 only, the 2.2 branch did not have this problem.
> 
> Sent from ProtonMail Mobile
> 
> On Wed, Jan 31, 2018 at 05:56, Prasad K  wrote:
> 
> > The dovecot.conf file from CentOS-7 contains this :
> >
> > --- snip ---
> > # A comma separated list of IPs or hosts where to listen in for connections.
> > # "*" listens in all IPv4 interfaces, "::" listens in all IPv6 interfaces.
> > # If you want to specify non-default ports or anything more complex,
> > # edit conf.d/master.conf.
> > #listen = *, ::
> > --- snip ---
> >
> > HTH
> >
> > --
> > Prasad
> >
> > On 30/01/18 11:35 PM, Rupert Gallagher wrote:
> >
> >> test-net.c:79: Assert failed: strcmp(net_ip2addr(&ip), "::5") == 0
> >> test-net.c:83: Assert failed: strcmp(net_ip2addr(&ip), "::5") == 0
> >> net_ip2addr()  : 
> >> FAILED
> >>
> >> Hello,
> >> Is it possible to disable DOVECOT_IPV6?
> >> We do not use IPv6 (and hope we shall never do on e-mails).


lda: Warning: Failed to parse return-path header: Invalid character in localpart

2018-01-31 Thread Christian Authmann

Hello,

Sometimes, when delivering mails, this warning appears in my syslog:

> lda(...): Warning: Failed to parse return-path header: Invalid 
character in localpart


dovecot-lda still exits with 0 and the mail is inserted into my inbox.


Looking at the mails in question, I determined that the error is caused 
by a multiline Return-Path header. Here's a testcase:


--- snip ---
Return-Path:
  
From: "Nowhere" 
To: redac...@example.com
Subject: Testcase for lda warnings
Date: Wed, 31 Jan 2018 12:00:00 +

This is a message body.
--- snap ---

Copy into a file, with \r\n line endings, then run something like this:
> cat testcase.txt | /usr/lib/dovecot/dovecot-lda -e -d ''
with a username recognized by your running dovecot installation.

The header is 'Return-Path:', \r\n, two spaces, '<...>', \r\n

According to rfc2822 folding rules, that should be valid - the 
Return-Path header allows CFWS at that location.



The error message originates in lib-lda/mail-deliver.c in 
mail_deliver_get_return_address(), while the invalid character message 
seems to originate from one of several places in lib-lda/mail-deliver.c



Ciao,
Christian Authmann




Re: lda: Warning: Failed to parse return-path header: Invalid character in localpart

2018-01-31 Thread Stephan Bosch
Op 1/31/2018 om 6:17 PM schreef Christian Authmann:
> Hello,
>
> Sometimes, when delivering mails, this warning appears in my syslog:
>
> > lda(...): Warning: Failed to parse return-path header: Invalid
> character in localpart
>
> dovecot-lda still exits with 0 and the mail is inserted into my inbox.
>
>
> Looking at the mails in question, I determined that the error is
> caused by a multiline Return-Path header. Here's a testcase:
>
> --- snip ---
> Return-Path:
>   
> From: "Nowhere" 
> To: redac...@example.com
> Subject: Testcase for lda warnings
> Date: Wed, 31 Jan 2018 12:00:00 +
>
> This is a message body.
> --- snap ---
>
> Copy into a file, with \r\n line endings, then run something like this:
> > cat testcase.txt | /usr/lib/dovecot/dovecot-lda -e -d ''
> with a username recognized by your running dovecot installation.
>
> The header is 'Return-Path:', \r\n, two spaces, '<...>', \r\n
>
> According to rfc2822 folding rules, that should be valid - the
> Return-Path header allows CFWS at that location.
>
>
> The error message originates in lib-lda/mail-deliver.c in
> mail_deliver_get_return_address(), while the invalid character message
> seems to originate from one of several places in lib-lda/mail-deliver.c

This is Dovecot v2.3.0 right?

Regards,

Stephan.



Re: lda: Warning: Failed to parse return-path header: Invalid character in localpart

2018-01-31 Thread Christian Authmann

Hello,
On 31.01.2018 22:35, Stephan Bosch wrote:

Op 1/31/2018 om 6:17 PM schreef Christian Authmann:

Hello,

Sometimes, when delivering mails, this warning appears in my syslog:


lda(...): Warning: Failed to parse return-path header: Invalid

character in localpart

dovecot-lda still exits with 0 and the mail is inserted into my inbox.


Looking at the mails in question, I determined that the error is
caused by a multiline Return-Path header. Here's a testcase:

--- snip ---
Return-Path:
   
From: "Nowhere" 
To: redac...@example.com
Subject: Testcase for lda warnings
Date: Wed, 31 Jan 2018 12:00:00 +

This is a message body.
--- snap ---

Copy into a file, with \r\n line endings, then run something like this:

cat testcase.txt | /usr/lib/dovecot/dovecot-lda -e -d ''

with a username recognized by your running dovecot installation.

The header is 'Return-Path:', \r\n, two spaces, '<...>', \r\n

According to rfc2822 folding rules, that should be valid - the
Return-Path header allows CFWS at that location.


The error message originates in lib-lda/mail-deliver.c in
mail_deliver_get_return_address(), while the invalid character message
seems to originate from one of several places in lib-lda/mail-deliver.c


This is Dovecot v2.3.0 right?

Regards,

Stephan.


yes, 2.3.0 (c8b89eb), archlinux, x64. Sorry for not mentioning it earlier.

Ciao,
Christian


Re: lda: Warning: Failed to parse return-path header: Invalid character in localpart

2018-01-31 Thread Stephan Bosch
Op 1/31/2018 om 10:44 PM schreef Christian Authmann:
> Hello,
> On 31.01.2018 22:35, Stephan Bosch wrote:
>> Op 1/31/2018 om 6:17 PM schreef Christian Authmann:
>>> Hello,
>>>
>>> Sometimes, when delivering mails, this warning appears in my syslog:
>>>
 lda(...): Warning: Failed to parse return-path header: Invalid
>>> character in localpart
>>>
>>> dovecot-lda still exits with 0 and the mail is inserted into my inbox.
>>>
>>>
>>> Looking at the mails in question, I determined that the error is
>>> caused by a multiline Return-Path header. Here's a testcase:
>>>
>>> --- snip ---
>>> Return-Path:
>>>    
>>> From: "Nowhere" 
>>> To: redac...@example.com
>>> Subject: Testcase for lda warnings
>>> Date: Wed, 31 Jan 2018 12:00:00 +
>>>
>>> This is a message body.
>>> --- snap ---
>>>
>>> Copy into a file, with \r\n line endings, then run something like this:
 cat testcase.txt | /usr/lib/dovecot/dovecot-lda -e -d ''
>>> with a username recognized by your running dovecot installation.
>>>
>>> The header is 'Return-Path:', \r\n, two spaces, '<...>', \r\n
>>>
>>> According to rfc2822 folding rules, that should be valid - the
>>> Return-Path header allows CFWS at that location.
>>>
>>>
>>> The error message originates in lib-lda/mail-deliver.c in
>>> mail_deliver_get_return_address(), while the invalid character message
>>> seems to originate from one of several places in lib-lda/mail-deliver.c
>>
>> This is Dovecot v2.3.0 right?
>>
>> Regards,
>>
>> Stephan.
>
> yes, 2.3.0 (c8b89eb), archlinux, x64. Sorry for not mentioning it
> earlier.

Whoops, yes, problem is obvious.

Regards,

Stephan.



AuthDatabase CheckPassword broken?

2018-01-31 Thread Mark Foley
I had been using the CheckPassword authentication interface with dovecot 
2.2.15, 
https://wiki2.dovecot.org/AuthDatabase/CheckPassword, and it was working.

After upgrading to 2.2.33.2 CheckPassword no longer works. The referenced wiki 
page says, 

Checkpassword Interface

Read  NUL  NUL from fd 3. 

I've checked the information read from fd 3 with 2.2.33.2 and I get  
followed by 3
nulls. I'm guessing the 2nd null is supposed to be the password.

Why is this no longer working? How can I fix it?

THX --Mark