Re: ntp in /etc/services

2020-08-12 Thread Hal Murray via devel
> Is that a bug, or should I remove that chunk of text?

That doesn't seem very clear.  Let me try again.

The documentation mentions /etc/services
The current code doesn't use it.  It passes "123" rather than "ntp" to the DNS 
lookup routines.

How should we fix that?
  1) fix documentation (easy, remove 2 lines)
  2) change code to use /etc/services

The second choice might be interesting for some reason that I'm not aware of.

There is another possibility -- a configure time option.  That doesn't seem 
interesting to me but might be appropriate if using /etc/services is the right 
thing to do but some systems don't support it or we decide not to use 
/etc/services in the normal case but there is some obscure case that needs it.


-- 
These are my opinions.  I hate spam.



___
devel mailing list
devel@ntpsec.org
http://lists.ntpsec.org/mailman/listinfo/devel


Re: 'MODE_BROADCASTx'Mime-Version: 1.0

2020-08-12 Thread Gary E. Miller via devel
Yo Hal!

On Tue, 11 Aug 2020 21:10:08 -0700
Hal Murray  wrote:

> There are a handful of modes that we don't support.  I changed them
> from MODE_FOO to MODE_FOOx so any use would break at compile time and
> we would fix it.  That was back in April.

I'm just now seeing this error.

> My best guess is that you have only half updated your system.  You
> have a new ntpmon but it is using an old pylib/magic.py

You can see I have the new one installed:

pi4 ~ # find / -xdev -name magic.py -exec ls -l {} \;
-rw-r--r-- 1 root root 4557 Aug 11 19:43 
/usr/local/lib/python3.7/site-packages/ntp/magic.py
-rw-r--r-- 1 root root 4557 Feb 24 12:55 
/usr/local/lib/python2.7/site-packages/ntp/magic.py
-rw-r--r-- 1 root root 4557 Aug 11 18:33 
/usr/local/lib/python3.6/site-packages/ntp/magic.py
-rw-r--r-- 1 root root 4557 Sep 25  2017 
/usr/local/src/NTP/ntpsec/pylib/magic.py
-rw-r--r-- 1 root root 4557 Aug 11 19:43 
/usr/local/src/NTP/ntpsec/build/main/pylib/magic.py

pi4 ~ # python -V
Python 3.7.8

pi4 ~ # echo $PYTHONPATH
/usr/local/lib/python3.7/site-packages

RGDS
GARY
---
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
g...@rellim.com  Tel:+1 541 382 8588

Veritas liberabit vos. -- Quid est veritas?
"If you can't measure it, you can't improve it." - Lord Kelvin


pgpDUB8MoBWlY.pgp
Description: OpenPGP digital signature
___
devel mailing list
devel@ntpsec.org
http://lists.ntpsec.org/mailman/listinfo/devel


Re: 'MODE_BROADCASTx'

2020-08-12 Thread Hal Murray via devel
> You can see I have the new one installed:

Then either the new one is buggy or you aren't using it at runtime.

All the magic.py-s that you ls-ed have the same length.  That's suspicious.  I 
have 3 different lengths but none of them match yours.
-rw-r--r-- 1 root root 4229 Sep 15  2019 /usr/local/lib64/python2.7/site-packag
es/ntp/magic.py
-rw-r--r-- 1 root root 4309 Apr 25 17:16 /usr/local/lib64/python3.7/site-packag
es/ntp/magic.py
-rw-r--r-- 1 root root 4337 Aug  6 14:46 /usr/local/lib64/python3.8/site-packag
es/ntp/magic.py


MODE_BROADCASTx comes from include/ntp.h

magic.py is made by a script.  It just copies the right chunks from ntp.h and 
changes #define xx yy to xx = yy.  (or something close to that)  You can 
easily check to see if your magic.py has MODE_BROADCASTx or the old 
MODE_BROADCAST (without the x).


Did you do a clean build after git pull?  If not, then maybe waf wasn't smart 
to rebuild magic.py
(I use a script to do configure and build, starting with rm -r build.)


-- 
These are my opinions.  I hate spam.



___
devel mailing list
devel@ntpsec.org
http://lists.ntpsec.org/mailman/listinfo/devel


Re: 'MODE_BROADCASTx'

2020-08-12 Thread Gary E. Miller via devel
Yo Hal!

On Wed, 12 Aug 2020 13:03:01 -0700
Hal Murray  wrote:

> > You can see I have the new one installed:  
> 
> Then either the new one is buggy or you aren't using it at runtime.

Which does not narrow it down much.

> magic.py is made by a script.  It just copies the right chunks from
> ntp.h and changes #define xx yy to xx = yy.  (or something close to
> that)  You can easily check to see if your magic.py has
> MODE_BROADCASTx or the old MODE_BROADCAST (without the x).

It had the old one:

build/main/ntpclients/ntp/magic.py:MODE_BROADCAST   = 5 # broadcast 
mode 
> Did you do a clean build after git pull?

./waf clean
./waf configure --refclock=all && ./waf build  &&./waf install

>  If not, then maybe waf
> wasn't smart to rebuild magic.py

Maybe so.

I did a complete "rm -R ntpsec" and git clone.  Which I thought I had done
already, and now it works.  So maybe the c;ean is a problem?  My previous
file times would also indicate that.

RGDS
GARY
---
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
g...@rellim.com  Tel:+1 541 382 8588

Veritas liberabit vos. -- Quid est veritas?
"If you can't measure it, you can't improve it." - Lord Kelvin


pgpjSqb2TEEv8.pgp
Description: OpenPGP digital signature
___
devel mailing list
devel@ntpsec.org
http://lists.ntpsec.org/mailman/listinfo/devel


Re: [secur...@ntpsec.org] Bug#964395: Does CVE-2020-13817 affect ntpsec?

2020-08-12 Thread Richard Laager via devel
I don't think I ever got an answer on this one.

On 7/6/20 11:28 PM, Richard Laager via security wrote:
> Another NTP CVE (which is already public)... does this affect NTPsec?
> 
> On 7/6/20 12:55 PM, Moritz Muehlenhoff wrote:
>> This was assigned CVE-2020-13817 for ntp.org:
>>   http://support.ntp.org/bin/view/Main/NtpBug3596
>>   https://bugs.ntp.org/show_bug.cgi?id=3596
>>   http://bk.ntp.org/ntp-stable/?PAGE=patch&REV=5e312021VVVkyioYBR_aeIP1LqMCVg
>>   http://bk.ntp.org/ntp-stable/?PAGE=patch&REV=5e4a536dzxRWAzMw-KsKjm04l6joNA

-- 
Richard



signature.asc
Description: OpenPGP digital signature
___
devel mailing list
devel@ntpsec.org
http://lists.ntpsec.org/mailman/listinfo/devel


Re: ntp in /etc/services

2020-08-12 Thread Richard Laager via devel
On 8/12/20 4:44 AM, Hal Murray via devel wrote:
>> Is that a bug, or should I remove that chunk of text?
> 
> That doesn't seem very clear.  Let me try again.
> 
> The documentation mentions /etc/services
> The current code doesn't use it.  It passes "123" rather than "ntp" to the 
> DNS 
> lookup routines.
> 
> How should we fix that?
>   1) fix documentation (easy, remove 2 lines)
>   2) change code to use /etc/services

#1 please. There's no need to use /etc/services and that's not a common
thing for daemons these days to require.

With my Debian packager hat on, getting a port in Debian's /etc/services
is another level of complication that I don't want to have to deal with.

-- 
Richard



signature.asc
Description: OpenPGP digital signature
___
devel mailing list
devel@ntpsec.org
http://lists.ntpsec.org/mailman/listinfo/devel


Re: ntp in /etc/services

2020-08-12 Thread ASSI via devel
Richard Laager via devel writes:
> With my Debian packager hat on, getting a port in Debian's /etc/services
> is another level of complication that I don't want to have to deal with.

Not to mention that /etc/services has gone away in some distributions
recently (moved to /usr/etc/services) and you will have to use
nsswitch.conf either directly or indirectly to figure out whether you
should use it at all.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Samples for the Waldorf Blofeld:
http://Synth.Stromeko.net/Downloads.html#BlofeldSamplesExtra
___
devel mailing list
devel@ntpsec.org
http://lists.ntpsec.org/mailman/listinfo/devel