Re: [PATCH 2/4] qapi/migration: Deprecate migrate argument @detach
On Wed, May 21, 2025 at 08:37:09AM +0200, Markus Armbruster wrote:
> Argument @detach has always been ignored. Start the clock to get rid
> of it.
>
> Cc: Peter Xu
> Cc: Fabiano Rosas
> Signed-off-by: Markus Armbruster
> ---
> docs/about/deprecated.rst | 5 +
> qapi/migration.json | 18 +-
> 2 files changed, 14 insertions(+), 9 deletions(-)
>
> diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst
> index 9665bc6fcf..ef4ea84e69 100644
> --- a/docs/about/deprecated.rst
> +++ b/docs/about/deprecated.rst
> @@ -179,6 +179,11 @@ Use ``job-dismiss`` instead.
>
> Use ``job-finalize`` instead.
>
> +``migrate`` argument ``detach`` (since 10.1)
> +
> +
> +This argument has always been ignored.
> +
> ``query-migrationthreads`` (since 9.2)
> ''
>
> diff --git a/qapi/migration.json b/qapi/migration.json
> index 8b9c53595c..ecd266f98e 100644
> --- a/qapi/migration.json
> +++ b/qapi/migration.json
> @@ -1660,6 +1660,10 @@
> #
> # @resume: resume one paused migration, default "off". (since 3.0)
> #
> +# Features:
> +#
> +# @deprecated: Argument @detach is deprecated.
> +#
> # Since: 0.14
> #
> # .. admonition:: Notes
> @@ -1668,19 +1672,14 @@
> #migration's progress and final result (this information is
> #provided by the 'status' member).
> #
> -# 2. All boolean arguments default to false.
There's one more boolean ("resume") exists, but probably not a huge
deal.. All booleans if not mentioned should have a default-false semantics
at least to me.
Reviewed-by: Peter Xu
> -#
> -# 3. The user Monitor's "detach" argument is invalid in QMP and
> -#should not be used.
> -#
> -# 4. The uri argument should have the Uniform Resource Identifier
> +# 2. The uri argument should have the Uniform Resource Identifier
> #of default destination VM. This connection will be bound to
> #default network.
> #
> -# 5. For now, number of migration streams is restricted to one,
> +# 3. For now, number of migration streams is restricted to one,
> #i.e. number of items in 'channels' list is just 1.
> #
> -# 6. The 'uri' and 'channels' arguments are mutually exclusive;
> +# 4. The 'uri' and 'channels' arguments are mutually exclusive;
> #exactly one of the two should be present.
> #
> # .. qmp-example::
> @@ -1724,7 +1723,8 @@
> { 'command': 'migrate',
>'data': {'*uri': 'str',
> '*channels': [ 'MigrationChannel' ],
> - '*detach': 'bool', '*resume': 'bool' } }
> + '*detach': { 'type': 'bool', 'features': [ 'deprecated' ] },
> + '*resume': 'bool' } }
>
> ##
> # @migrate-incoming:
> --
> 2.48.1
>
--
Peter Xu
Re: [PATCH 2/4] qapi/migration: Deprecate migrate argument @detach
On Wed, May 21, 2025 at 04:28:33PM +0200, Markus Armbruster wrote:
> Peter Xu writes:
>
> > On Wed, May 21, 2025 at 08:37:09AM +0200, Markus Armbruster wrote:
> >> Argument @detach has always been ignored. Start the clock to get rid
> >> of it.
> >>
> >> Cc: Peter Xu
> >> Cc: Fabiano Rosas
> >> Signed-off-by: Markus Armbruster
> >> ---
> >> docs/about/deprecated.rst | 5 +
> >> qapi/migration.json | 18 +-
> >> 2 files changed, 14 insertions(+), 9 deletions(-)
> >>
> >> diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst
> >> index 9665bc6fcf..ef4ea84e69 100644
> >> --- a/docs/about/deprecated.rst
> >> +++ b/docs/about/deprecated.rst
> >> @@ -179,6 +179,11 @@ Use ``job-dismiss`` instead.
> >>
> >> Use ``job-finalize`` instead.
> >>
> >> +``migrate`` argument ``detach`` (since 10.1)
> >> +
> >> +
> >> +This argument has always been ignored.
> >> +
> >> ``query-migrationthreads`` (since 9.2)
> >> ''
> >>
> >> diff --git a/qapi/migration.json b/qapi/migration.json
> >> index 8b9c53595c..ecd266f98e 100644
> >> --- a/qapi/migration.json
> >> +++ b/qapi/migration.json
> >> @@ -1660,6 +1660,10 @@
> >> #
> >> # @resume: resume one paused migration, default "off". (since 3.0)
> >> #
> >> +# Features:
> >> +#
> >> +# @deprecated: Argument @detach is deprecated.
> >> +#
> >> # Since: 0.14
> >> #
> >> # .. admonition:: Notes
> >> @@ -1668,19 +1672,14 @@
> >> #migration's progress and final result (this information is
> >> #provided by the 'status' member).
> >> #
> >> -# 2. All boolean arguments default to false.
> >
> > There's one more boolean ("resume") exists, but probably not a huge
> > deal.. All booleans if not mentioned should have a default-false semantics
> > at least to me.
>
> Its default remains documented. It's visible above :)
Ah, indeed!
--
Peter Xu
Re: [PATCH v2 18/24] qapi/migration: Deprecate capabilities commands
On Mon, Jun 30, 2025 at 04:59:07PM -0300, Fabiano Rosas wrote: > The concept of capabilities is being merged into the concept of > parameters. From now on, the commands that handle capabilities are > deprecated in favor of the commands that handle parameters. > > Affected commands: > > - migrate-set-capabilities > - query-migrate-capabilities > > Signed-off-by: Fabiano Rosas > --- > docs/about/deprecated.rst | 12 > migration/migration-hmp-cmds.c | 6 ++ > qapi/migration.json| 16 ++-- > 3 files changed, 32 insertions(+), 2 deletions(-) > > diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst > index 42037131de..15474833ea 100644 > --- a/docs/about/deprecated.rst > +++ b/docs/about/deprecated.rst > @@ -605,3 +605,15 @@ command documentation for details on the ``fdset`` usage. > > The ``zero-blocks`` capability was part of the block migration which > doesn't exist anymore since it was removed in QEMU v9.1. > + > +``migrate-set-capabilities`` command (since 10.1) > +' > + > +This command was deprecated. Use ``migrate-set-parameters`` instead > +which now supports setting capabilities. > + > +``query-migrate-capabilities`` command (since 10.1) > +''' Don't forget to update the versions. Reviewed-by: Peter Xu -- Peter Xu
