Introduction
Hello all, I am looking to get more involved in the Fedora Project and contributing back into it. I have been using Linux since Red Hat Linux 5.1 was released in 1998. Since then, I have been able to provide a variety of contributions back to various projects including Debian, Ubuntu, and even FreeBSD. I tend to work mostly in either C, Python, or Rust but can work in a variety of languages. Over the last few years, Fedora has become one of my main drivers for development and I'd like to give back and help maintain some packages in need of loving. I am looking forward to joining the community and offering my assistance. Sincerely, Loren M. Lang https://github.com/penguin359/ -- Sent from my Nexus 4 with K-9 Mail. Please excuse my brevity. -- ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Help with creating first PR for a package
After looking through the orphaned packages, I found one that looks like a good candidate for me to help with, python-cachelib, as this package is not that large and I am well-versed in Python. I've cloned it down and worked on bringing it more up-to-date. Now that I have something passing the test suite, I thought I'd file a PR and start a discussion. I forked the project on Pagure.io, but found that even with my own personal fork, I don't seem to have commit access to it without being in the Packagers group. Is that standard? I thought the point of the fork was to allow non-packagers to use the PR mechanism as an easy mechanism for sponsors to view proposals. In any case, I decided to through it up on GitHub temporarily so I could at least create a Remote PR. https://src.fedoraproject.org/rpms/python-cachelib/pull-request/6 I am considering becoming a [co-]maintainer if needed to help keep this package in good, solid shape, however it does look like it has been adopted by topazus in the last couple of days since I started working on it. I am also working on setting up a Python 3.13 environment to debug the issue reported in bug #2251780. Thanks, -- Loren M. Lang lor...@north-winds.org http://www.north-winds.org/ Public Key: http://www.north-winds.org/lorenl_pubkey.asc Fingerprint: 7896 E099 9FC7 9F6C E0ED E103 222D F356 A57A 98FA signature.asc Description: PGP signature -- ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: Help with creating first PR for a package
On Sun, Feb 18, 2024 at 06:08:53AM -0300, Priscila Gutierres wrote: > I created this post based on my own experience: > https://dev.to/prinewgirl/a-recipe-made-to-create-your-first-pr-for-the-fedora-project-21be > Hope it helps. Thanks, with these and an Kan-Ru's instructions, I was able to successfully push up my changes to my fork on Pagure. However, I did have one issue with the sources. The push initially failed with the error: Source file (or tarball) 'cachelib-0.12.0.tar.gz' wasn't uploaded to the lookaside cache. I assume that this is another restriction of not being a packager? However, I didn't see this addressed in the provided docs. I was able to bypass it with --no-verify, but the Fedora CI build that was triggered when I made my Pull Request fails since it couldn't find the uploaded sources. I was able to manually submit a passing CI build by pushing up the SRPM. -Loren > > Em dom., 18 de fev. de 2024 às 05:32, Ondrej Mosnáček > escreveu: > > > On Sun, 18 Feb 2024 at 09:23, Kan-Ru Chen wrote: > > > > > > Hi, > > > > > > On Sun, Feb 18, 2024, at 10:52 AM, Loren M. Lang wrote: > > > > I've cloned it down and worked on bringing it more up-to-date. Now that > > > > I have something passing the test suite, I thought I'd file a PR and > > > > start a discussion. I forked the project on Pagure.io, but found that > > > > even with my own personal fork, I don't seem to have commit access to > > it > > > > without being in the Packagers group. Is that standard? I thought the > > > > point of the fork was to allow non-packagers to use the PR mechanism as > > > > an easy mechanism for sponsors to view proposals. > > > > > > > > In any case, I decided to through it up on GitHub temporarily so I > > could > > > > at least create a Remote PR. > > > > > > > > https://src.fedoraproject.org/rpms/python-cachelib/pull-request/6 > > > > > > I have recently done this. You need to use fedpkg to clone the > > repository then > > > it will setup the hook for authentication with FAS. > > > > > > For example if you have fork at `fork/penguin359/rpms/python-cachelib` > > then use > > > this command to clone > > > > > > fedpkg clone -a forks/penguin359/rpms/python-cachelib > > > > > > then in the cloned repo you can push normally. > > > > FWIW. it is documented here: > > > > https://docs.fedoraproject.org/en-US/ci/pull-requests/#_you_are_not_a_packager > > -- > > ___ > > devel mailing list -- devel@lists.fedoraproject.org > > To unsubscribe send an email to devel-le...@lists.fedoraproject.org > > Fedora Code of Conduct: > > https://docs.fedoraproject.org/en-US/project/code-of-conduct/ > > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines > > List Archives: > > https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org > > Do not reply to spam, report it: > > https://pagure.io/fedora-infrastructure/new_issue > > > -- > ___ > devel mailing list -- devel@lists.fedoraproject.org > To unsubscribe send an email to devel-le...@lists.fedoraproject.org > Fedora Code of Conduct: > https://docs.fedoraproject.org/en-US/project/code-of-conduct/ > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines > List Archives: > https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org > Do not reply to spam, report it: > https://pagure.io/fedora-infrastructure/new_issue -- Loren M. Lang lor...@north-winds.org http://www.north-winds.org/ Public Key: http://www.north-winds.org/lorenl_pubkey.asc Fingerprint: 7896 E099 9FC7 9F6C E0ED E103 222D F356 A57A 98FA signature.asc Description: PGP signature -- ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: Help with creating first PR for a package
On Tue, Feb 20, 2024 at 09:45:49AM +0100, Michael J Gruber wrote: > Am Di., 20. Feb. 2024 um 09:21 Uhr schrieb Loren M. Lang > : > > > > On Sun, Feb 18, 2024 at 06:08:53AM -0300, Priscila Gutierres wrote: > > > I created this post based on my own experience: > > > https://dev.to/prinewgirl/a-recipe-made-to-create-your-first-pr-for-the-fedora-project-21be > > > Hope it helps. > > > > Thanks, with these and an Kan-Ru's instructions, I was able to > > successfully push up my changes to my fork on Pagure. However, I did > > have one issue with the sources. The push initially failed with the > > error: > > > > Source file (or tarball) 'cachelib-0.12.0.tar.gz' wasn't uploaded > > to the lookaside cache. > > > > I assume that this is another restriction of not being a packager? > > However, I didn't see this addressed in the provided docs. I was able to > > bypass it with --no-verify, but the Fedora CI build that was triggered > > when I made my Pull Request fails since it couldn't find the uploaded > > sources. > > > > I was able to manually submit a passing CI build by pushing up the SRPM. > > > > Hi there, > > I've uploaded the sources to the lookaside cache for you, after > checking and confirming what you had checked already. I guess that is > the reason why uploads are allowed for packagers only - because you > confirm upfront that you will do these checks :) Thanks! I see most of the automatic CI tests are running and passing after my push now that the sources are present. However, there is one odd failure dist-git test. Too many arguments provided to cd. I suspect it froms from this line in metadata.yml for the Ansible recipe running the test: cd $TMT_SOURCE_DIR/*/ Likely, it's expanding to a path with a space, but I don't see anything on my end that should be causing the issue. > > As for the PR, it's the maintainer's decision, of course. I would > rewrite history at least to fold sources update in with the spec file > bump, and probably also the updated test exceptions. I followed your suggestion and squashed those commits together. Thanks, Loren > > Cheers > Michael > -- > ___ > devel mailing list -- devel@lists.fedoraproject.org > To unsubscribe send an email to devel-le...@lists.fedoraproject.org > Fedora Code of Conduct: > https://docs.fedoraproject.org/en-US/project/code-of-conduct/ > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines > List Archives: > https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org > Do not reply to spam, report it: > https://pagure.io/fedora-infrastructure/new_issue -- Loren M. Lang lor...@north-winds.org http://www.north-winds.org/ Public Key: http://www.north-winds.org/lorenl_pubkey.asc Fingerprint: 7896 E099 9FC7 9F6C E0ED E103 222D F356 A57A 98FA signature.asc Description: PGP signature -- ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: A fix for the FTBFS issue with the jed text editor
On Sun, Jan 19, 2025 at 07:16:57PM +0900, Mamoru TASAKA wrote: > Benson Muite wrote on 2025/01/19 19:04: > > Hi Loren, > > > > On Sun, Jan 19, 2025, at 12:50 PM, Loren M. Lang wrote: > > > I just noticed that jed was on the FTBFS list and was failing to build > > > on Fedora and due to be removed. I've created a fix that should resolve > > > the issue and put together a Pull Request for review here: > > > > > > https://src.fedoraproject.org/rpms/jed/pull-request/1 > > > > > > I am not yet in the packagers group so I will need a sponsor to upload > > > it. Also, I am willing to take over maintainership of this package if it > > > is currently orphaned. > > > > > > > It does not seem to be orphaned, please contact the maintainer, most > > maintainers welcome a co-maintainer.. > > jed is marked in "List of long term FTBFS packages to be retired in 2 weeks" > https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/2P77TH7L3E63ODMWMMG23MIGFSL3IQTS/ > > Perhaps current maintainers are unresponsive. Yes, and looking through the commit history, it doesn't look like there's evidence of any regular maintainer going back years unless that is Fedora Release Engineer. Actually, the bigger item is I'd like to be subscribed to any events I'd need to respond to with issues. There isn't much development needed with this package, but I would like to know how to subscribe to the jed component on Bugzilla or other feed in case there are future bugs that need to be resolved. I also contributed a fix for apt-cacher-ng for a different FTBFS bug last week that had been open for a couple of months. However, that package does appear to have a maintainer that, while busy at times, is responsive to help. > > > > > > Please let me know what the next steps are. > > > > > > > Steps to join the packager group: > > https://docs.fedoraproject.org/en-US/package-maintainers/Joining_the_Package_Maintainers/ I have gone through most of those steps now, though I think I still need to send an introduction email. Right now, I'm just working on developing a list of good quality contributions for buildling my credibility. Thanks! > > > > An informal guide: > > https://jamezone.org/pleasure/software/Fedora/packager/ > > > > Mamoru > -- > ___ > devel mailing list -- devel@lists.fedoraproject.org > To unsubscribe send an email to devel-le...@lists.fedoraproject.org > Fedora Code of Conduct: > https://docs.fedoraproject.org/en-US/project/code-of-conduct/ > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines > List Archives: > https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org > Do not reply to spam, report it: > https://pagure.io/fedora-infrastructure/new_issue -- Loren M. Lang lor...@north-winds.org http://www.north-winds.org/ IRC: penguin359 Public Key: http://www.north-winds.org/lorenl_pubkey.asc Fingerprint: 7896 E099 9FC7 9F6C E0ED E103 222D F356 A57A 98FA signature.asc Description: PGP signature -- ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: FTB due to 'too many arguments to function'
On Sun, Jan 19, 2025 at 05:28:04PM +, Fedora-Devel Mailing List wrote:
> Il 19/01/25 18:23, Michael J Gruber ha scritto:
> > Mattia Verga via devel venit, vidit, dixit 2025-01-19 18:19:24:
> >> I see several of my packages are FTB in the running mass rebuild due to
> >> something like:
> >>
> >> error: too many arguments to function ‘DoInterlace’; expected 0, have 1
> >>
>
> For example:
>
> https://kojipkgs.fedoraproject.org//work/tasks/7044/127997044/build.log
I decided to take a detailed look into this one error as a learning
example. In this case, it's a legitimate error that was introduced in
the 1.6.3 release of this software back in June 2023:
https://github.com/ahp-electronics/libahp-gt/commit/d785e134ce4aeff690c73a231ffc2660d763e5b7#diff-0f1ca71fe88ebdd7ff146df4cfad479a2816256a1f583e0ba28d3038ba8efb30R531
You can see that a call was added to
case SetTrackingMode:
...
ahp_gt_get_tracking_mode(cmd[0]);
however, in that same commit, the function was defined to take no
arguments:
int ahp_gt_get_tracking_mode() {
And in other places, it is called without arguments:
case GetTrackingMode:
sprintf(msg, "%c#", ahp_gt_get_tracking_mode());
This looks like a one-letter typo as a set version of the function
exists elsewhere:
void ahp_gt_set_tracking_mode(int mode) {
Which does take the missing argument. Also, you can see that this typo
was fixed upstream on December 4th for the 1.7.1 release:
https://github.com/ahp-electronics/libahp-gt/commit/324c0914e5dd3b23b5af5e871ba5dc0f790bddce#diff-0f1ca71fe88ebdd7ff146df4cfad479a2816256a1f583e0ba28d3038ba8efb30R541
This is something that would have always been a bug in the code, but due
to C's relaxed rules with function prototypes (prior to C23), has
simply went unnoticed for a year and a half. If you are curious, I've
created a minimal patch that fixes the build error with GCC 15. Feel
free to pull this in or reject it if you'd rather just bump to a newer
release:
https://src.fedoraproject.org/rpms/libahp-gt/pull-request/1
Hope this helps understand the build failure a little better.
>
> I don't know much of C, from what I've read online those functions are
> declared without arguments and then used with arguments. It seems this
> is now throwing an error, while before the mass rebuild just worked:
>
> /builddir/build/BUILD/libahp-gt-1.7.0-build/libahp-gt-1.7.0/ahp_gt.c: In
> function ‘synscan_poll’:
> /builddir/build/BUILD/libahp-gt-1.7.0-build/libahp-gt-1.7.0/ahp_gt.c:541:17:
> error: too many arguments to function ‘ahp_gt_get_tracking_mode’;
> expected 0, have 1
> 541 | ahp_gt_get_tracking_mode(cmd[0]);
> | ^~~~ ~~
> In file included from
> /builddir/build/BUILD/libahp-gt-1.7.0-build/libahp-gt-1.7.0/ahp_gt.c:26:
> /builddir/build/BUILD/libahp-gt-1.7.0-build/libahp-gt-1.7.0/redhat-linux-build/ahp_gt.h:1037:16:
>
> note: declared here
> 1037 | DLL_EXPORT int ahp_gt_get_tracking_mode();
> | ^~~~
>
> Mattia
>
>
> --
> ___
> devel mailing list -- devel@lists.fedoraproject.org
> To unsubscribe send an email to devel-le...@lists.fedoraproject.org
> Fedora Code of Conduct:
> https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives:
> https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
> Do not reply to spam, report it:
> https://pagure.io/fedora-infrastructure/new_issue
--
Loren M. Lang
lor...@north-winds.org
http://www.north-winds.org/
IRC: penguin359
Public Key: http://www.north-winds.org/lorenl_pubkey.asc
Fingerprint: 7896 E099 9FC7 9F6C E0ED E103 222D F356 A57A 98FA
signature.asc
Description: PGP signature
--
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
Re: Orphaning naev, naev-data
On Fri, Jan 24, 2025 at 10:25:38PM +, Jonathan Dieter wrote: > Hey everyone, > > Naev now has a new dependency on lyaml which is not yet in Fedora. I > don't really play the game anymore, so I'm orphaning it. There are two > packages, naev (the game) and naev-data (the game data files). If > anyone's interested, go ahead and grab it! Looks interesting! I have some Lua experience and lyaml doesn't seem to be too difficult. I might take a whack at it. > > Thanks, > > Jonathan > -- > ___ > devel mailing list -- devel@lists.fedoraproject.org > To unsubscribe send an email to devel-le...@lists.fedoraproject.org > Fedora Code of Conduct: > https://docs.fedoraproject.org/en-US/project/code-of-conduct/ > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines > List Archives: > https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org > Do not reply to spam, report it: > https://pagure.io/fedora-infrastructure/new_issue -- Loren M. Lang lor...@north-winds.org http://www.north-winds.org/ IRC: penguin359 Public Key: http://www.north-winds.org/lorenl_pubkey.asc Fingerprint: 7896 E099 9FC7 9F6C E0ED E103 222D F356 A57A 98FA signature.asc Description: PGP signature -- ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
A fix for the FTBFS issue with the jed text editor
I just noticed that jed was on the FTBFS list and was failing to build on Fedora and due to be removed. I've created a fix that should resolve the issue and put together a Pull Request for review here: https://src.fedoraproject.org/rpms/jed/pull-request/1 I am not yet in the packagers group so I will need a sponsor to upload it. Also, I am willing to take over maintainership of this package if it is currently orphaned. Please let me know what the next steps are. Thanks, -- Loren M. Lang lor...@north-winds.org http://www.north-winds.org/ IRC: penguin359 Matrix: @penguin359:matrix.org Public Key: http://www.north-winds.org/lorenl_pubkey.asc Fingerprint: 7896 E099 9FC7 9F6C E0ED E103 222D F356 A57A 98FA signature.asc Description: PGP signature -- ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
