Re: [edk2-devel] [PATCH v2 0/7] Uncrustify GoogleTest update

2023-10-24 Thread VivianNK 

Hi, following up to see if there's any update on this.

Thanks for your help,

- Vivian

On 9/27/2023 12:43 PM, Vivian Nowka-Keane wrote:

Hi Mike,

Can you help merge this? Looks like it has all of the reviews.

Thank you!
- Vivian

On 9/12/2023 7:42 AM, Michael D Kinney wrote:

Series Reviewed-by: Michael D Kinney


-Original Message-
From:devel@edk2.groups.io    On Behalf Of 
VivianNK

Sent: Wednesday, August 16, 2023 2:15 PM
To:devel@edk2.groups.io
Subject: [edk2-devel] [PATCH v2 0/7] Uncrustify GoogleTest update

v1 -> v2:
  - Update commit message to explain the audit only mode change is
    temporary to prevent intermediate CI failures.
  - Format patch Cc's correctly

v1 archive:https://edk2.groups.io/g/devel/message/107665

VivianNK (7):
   .pytool: Set uncrustify check to audit only (temporary)
   .pytool: Add cpp support to uncrustify plugin
   MdeModulePkg: Apply uncrustify formatting to relevant files.
   MdePkg: Apply uncrustify formatting to relevant files
   SecurityPkg: Apply uncrustify formatting to relevant files
   UnitTestFrameworkPkg: Apply uncrustify formatting to relevant files
   .pytool: Undo uncrustify check change

  .pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py
|   2 +-
  .pytool/Plugin/UncrustifyCheck/uncrustify.cfg
|   4 +-
MdeModulePkg/Library/UefiSortLib/GoogleTest/UefiSortLibGoogleTest.cpp
|  37 +-
MdeModulePkg/Test/Mock/Include/GoogleTest/Library/MockPciHostBridgeLib.h 


|   4 +-

MdeModulePkg/Test/Mock/Library/GoogleTest/MockPciHostBridgeLib/MockPciHostBri 


dgeLib.cpp |   8 +-

MdePkg/Test/GoogleTest/Library/BaseSafeIntLib/SafeIntLibUintnIntnUnitTests32. 


cpp    | 114 ++--

MdePkg/Test/GoogleTest/Library/BaseSafeIntLib/SafeIntLibUintnIntnUnitTests64. 


cpp    | 114 ++--
MdePkg/Test/GoogleTest/Library/BaseSafeIntLib/TestBaseSafeIntLib.cpp
| 563 ++--
  MdePkg/Test/Mock/Include/GoogleTest/Library/MockHobLib.h
|   6 +-
MdePkg/Test/Mock/Include/GoogleTest/Library/MockPeiServicesLib.h
|   6 +-
  MdePkg/Test/Mock/Include/GoogleTest/Library/MockUefiLib.h
|   4 +-

MdePkg/Test/Mock/Include/GoogleTest/Library/MockUefiRuntimeServicesTableLib.h 


|   4 +-
MdePkg/Test/Mock/Library/GoogleTest/MockHobLib/MockHobLib.cpp
|  40 +-

MdePkg/Test/Mock/Library/GoogleTest/MockPeiServicesLib/MockPeiServicesLib.cpp 


|  52 +-
MdePkg/Test/Mock/Library/GoogleTest/MockUefiLib/MockUefiLib.cpp
|   6 +-

MdePkg/Test/Mock/Library/GoogleTest/MockUefiRuntimeServicesTableLib/MockUefiR 


untimeServicesTableLib.cpp |  12 +-

SecurityPkg/Library/SecureBootVariableLib/GoogleTest/SecureBootVariableLibGoo 


gleTest.cpp    | 205 ---

SecurityPkg/Test/Mock/Include/GoogleTest/Library/MockPlatformPKProtectionLib. 


h  |   4 +-

SecurityPkg/Test/Mock/Library/GoogleTest/MockPlatformPKProtectionLib/MockPlat 


formPKProtectionLib.cpp    |   4 +-
  UnitTestFrameworkPkg/Include/Library/GoogleTestLib.h
|   2 +-

UnitTestFrameworkPkg/Test/GoogleTest/Sample/SampleGoogleTest/SampleGoogleTest 


.cpp   |  76 +--
  21 files changed, 664 insertions(+), 603 deletions(-)

--
2.41.0.windows.3



-=-=-=-=-=-=
Groups.io Links: You receive all messages sent to this group.
View/Reply Online 
(#107809):https://edk2.groups.io/g/devel/message/107809

Mute This Topic:https://groups.io/mt/100788665/1643496
Group Owner:devel+ow...@edk2.groups.io
Unsubscribe:https://edk2.groups.io/g/devel/unsub
[michael.d.kin...@intel.com]
-=-=-=-=-=-=







-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110011): https://edk2.groups.io/g/devel/message/110011
Mute This Topic: https://groups.io/mt/100788665/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH v1 0/1] Add MockBiosIdLib to BoardModulePkg

2024-05-08 Thread VivianNK 
This patch adds a mock library for MockBiosIdLib.
REF: 
https://github.com/VivianNK/edk2-platforms/tree/vnowkakeane/MockBiosIdLib_v1

Cc: Eric Dong 
Cc: Liming Gao 

Signed-off-by: Vivian Nowka-Keane 

Bhavani Subramanian (1):
  BoardModulePkg: Added Mock library for BiosIdLib

 Platform/Intel/BoardModulePkg/BoardModulePkg.dec   
|  1 +
 Platform/Intel/BoardModulePkg/Test/BoardModulePkgHostTest.dsc  
| 32 +++
 
Platform/Intel/BoardModulePkg/Test/Mock/Include/GoogleTest/Library/MockBiosIdLib.h
 | 31 ++
 
Platform/Intel/BoardModulePkg/Test/Mock/Library/GoogleTest/MockBiosIdLib/MockBiosIdLib.cpp
 | 11 +++
 
Platform/Intel/BoardModulePkg/Test/Mock/Library/GoogleTest/MockBiosIdLib/MockBiosIdLib.inf
 | 33 
 5 files changed, 108 insertions(+)
 create mode 100644 
Platform/Intel/BoardModulePkg/Test/BoardModulePkgHostTest.dsc
 create mode 100644 
Platform/Intel/BoardModulePkg/Test/Mock/Include/GoogleTest/Library/MockBiosIdLib.h
 create mode 100644 
Platform/Intel/BoardModulePkg/Test/Mock/Library/GoogleTest/MockBiosIdLib/MockBiosIdLib.cpp
 create mode 100644 
Platform/Intel/BoardModulePkg/Test/Mock/Library/GoogleTest/MockBiosIdLib/MockBiosIdLib.inf

-- 
2.43.0.windows.1

[edk2-devel] [PATCH v1 1/1] BoardModulePkg: Added Mock library for BiosIdLib

2024-05-08 Thread VivianNK 
From: Bhavani Subramanian 

Added a gmock for GoogleTests that pull in BiosIdLib.

Cc: Eric Dong 
Cc: Liming Gao 

Signed-off-by: Vivian Nowka-Keane 
---
 Platform/Intel/BoardModulePkg/BoardModulePkg.dec   
|  1 +
 Platform/Intel/BoardModulePkg/Test/BoardModulePkgHostTest.dsc  
| 32 +++
 
Platform/Intel/BoardModulePkg/Test/Mock/Include/GoogleTest/Library/MockBiosIdLib.h
 | 31 ++
 
Platform/Intel/BoardModulePkg/Test/Mock/Library/GoogleTest/MockBiosIdLib/MockBiosIdLib.cpp
 | 11 +++
 
Platform/Intel/BoardModulePkg/Test/Mock/Library/GoogleTest/MockBiosIdLib/MockBiosIdLib.inf
 | 33 
 5 files changed, 108 insertions(+)

diff --git a/Platform/Intel/BoardModulePkg/BoardModulePkg.dec 
b/Platform/Intel/BoardModulePkg/BoardModulePkg.dec
index 26e662f711d1..5efb1a0348ff 100644
--- a/Platform/Intel/BoardModulePkg/BoardModulePkg.dec
+++ b/Platform/Intel/BoardModulePkg/BoardModulePkg.dec
@@ -22,6 +22,7 @@
 
 [Includes]
   Include
+  Test/Mock/Include  # MU_CHANGE
 
 [LibraryClasses]
   ##  @libraryclassProvide services to access CMOS area.
diff --git a/Platform/Intel/BoardModulePkg/Test/BoardModulePkgHostTest.dsc 
b/Platform/Intel/BoardModulePkg/Test/BoardModulePkgHostTest.dsc
new file mode 100644
index ..846a1e9f8b33
--- /dev/null
+++ b/Platform/Intel/BoardModulePkg/Test/BoardModulePkgHostTest.dsc
@@ -0,0 +1,32 @@
+## @fileBoardModulePkgHostTest.dsc
+#
+#  Copyright (c) Microsoft Corporation.
+#  SPDX-License-Identifier: BSD-2-Clause-Patent
+#
+#  Description
+#
+##
+
+[Defines]
+PLATFORM_NAME   = BoardModulePkgHostTest
+PLATFORM_GUID   = 67275336-A324-4F69-BD38-70A4C7898F06
+PLATFORM_VERSION= 0.1
+DSC_SPECIFICATION   = 0x00010005
+OUTPUT_DIRECTORY= Build/BoardModulePkg/HostTest
+SUPPORTED_ARCHITECTURES = IA32|X64|AARCH64
+BUILD_TARGETS   = NOOPT
+SKUID_IDENTIFIER= DEFAULT
+
+!include UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc
+
+[LibraryClasses]
+
+[Components]
+  #
+  # List of Unit test packages
+  #
+
+  #
+  # Build HOST_APPLICATION Libraries With GoogleTest
+  #
+  BoardModulePkg/Test/Mock/Library/GoogleTest/MockBiosIdLib/MockBiosIdLib.inf
diff --git 
a/Platform/Intel/BoardModulePkg/Test/Mock/Include/GoogleTest/Library/MockBiosIdLib.h
 
b/Platform/Intel/BoardModulePkg/Test/Mock/Include/GoogleTest/Library/MockBiosIdLib.h
new file mode 100644
index ..8f8a82da2807
--- /dev/null
+++ 
b/Platform/Intel/BoardModulePkg/Test/Mock/Include/GoogleTest/Library/MockBiosIdLib.h
@@ -0,0 +1,31 @@
+/** @file MockBiosIdLib.h
+  Google Test mocks for BiosIdLib
+
+  Copyright (c) Microsoft Corporation.
+  SPDX-License-Identifier: BSD-2-Clause-Patent
+**/
+
+#ifndef MOCK_BIOS_ID_LIB_H_
+#define MOCK_BIOS_ID_LIB_H_
+
+#include 
+#include 
+extern "C" {
+  #include 
+  #include 
+  #include 
+}
+
+struct MockBiosIdLib {
+  MOCK_INTERFACE_DECLARATION (MockBiosIdLib);
+
+  MOCK_FUNCTION_DECLARATION (
+EFI_STATUS,
+GetBiosId,
+(
+ OUT BIOS_ID_IMAGE *BiosIdImage OPTIONAL
+)
+);
+};
+
+#endif
diff --git 
a/Platform/Intel/BoardModulePkg/Test/Mock/Library/GoogleTest/MockBiosIdLib/MockBiosIdLib.cpp
 
b/Platform/Intel/BoardModulePkg/Test/Mock/Library/GoogleTest/MockBiosIdLib/MockBiosIdLib.cpp
new file mode 100644
index ..8b64e8a66acd
--- /dev/null
+++ 
b/Platform/Intel/BoardModulePkg/Test/Mock/Library/GoogleTest/MockBiosIdLib/MockBiosIdLib.cpp
@@ -0,0 +1,11 @@
+/** @file MockBiosIdLib.cpp
+  Google Test mocks for BiosIdLib
+
+  Copyright (c) Microsoft Corporation.
+  SPDX-License-Identifier: BSD-2-Clause-Patent
+**/
+
+#include 
+
+MOCK_INTERFACE_DEFINITION (MockBiosIdLib);
+MOCK_FUNCTION_DEFINITION (MockBiosIdLib, GetBiosId, 1, EFIAPI);
diff --git 
a/Platform/Intel/BoardModulePkg/Test/Mock/Library/GoogleTest/MockBiosIdLib/MockBiosIdLib.inf
 
b/Platform/Intel/BoardModulePkg/Test/Mock/Library/GoogleTest/MockBiosIdLib/MockBiosIdLib.inf
new file mode 100644
index ..f60bc3724f6a
--- /dev/null
+++ 
b/Platform/Intel/BoardModulePkg/Test/Mock/Library/GoogleTest/MockBiosIdLib/MockBiosIdLib.inf
@@ -0,0 +1,33 @@
+## @file MockBiosIdLib.inf
+# Google Test mocks for BiosIdLib
+#
+# Copyright (c) Microsoft Corporation.
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+##
+
+[Defines]
+  INF_VERSION= 0x00010005
+  BASE_NAME  = MockBiosIdLib
+  FILE_GUID  = FD03FA6D-7447-499C-B3AF-D89450F7739A
+  MODULE_TYPE= HOST_APPLICATION
+  VERSION_STRING = 1.0
+  LIBRARY_CLASS  = BiosIdLib
+  PI_SPECIFICATION_VERSION   = 0x0001000A
+
+#
+#  VALID_ARCHITECTURES   = IA32 X64
+#
+
+[Sources]
+  MockBiosIdLib.cpp
+
+[Packages]
+  MdePkg/MdePkg.dec
+  UnitTestFrameworkPkg/UnitTestFrameworkPkg.dec
+  BoardModulePkg/BoardModulePkg.dec
+
+[LibraryClasses]
+  GoogleTestLib
+
+[BuildOptio

[edk2-devel] [PATCH v1 0/1] MinPlatformPkg: Fix DxePhatAcpiLib.inf path

2024-05-09 Thread VivianNK 
REF: https://github.com/VivianNK/edk2-platforms/tree/remove_unused_inf

Bug fix. When building MinPlatformPkg, a build error occured because the inf was
not found. The path was incorrect -- DxePhatAcpiLib folder doesn't
exist, PhatAcpiLib does.

Cc: Chasel Chiu 
Cc: Nate DeSimone 
Signed-off-by: Vivian Nowka-Keane 

Vivian Nowka-Keane (1):
  MinPlatformPkg: Fix DxePhatAcpiLib.inf path in dsc

 Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.43.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118781): https://edk2.groups.io/g/devel/message/118781
Mute This Topic: https://groups.io/mt/106014297/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH v1 1/1] MinPlatformPkg: Fix DxePhatAcpiLib.inf path in dsc

2024-05-09 Thread VivianNK 
When building MinPlatformPkg, a build error occured because the inf was
not found. The path was incorrect -- DxePhatAcpiLib folder doesn't
exist, PhatAcpiLib does.

Cc: Chasel Chiu 
Cc: Nate DeSimone 
Signed-off-by: Vivian Nowka-Keane 
---
 Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc 
b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
index ecb4d8f65efa..f81ad3cabf56 100644
--- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
+++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
@@ -64,7 +64,7 @@
   
PciSegmentInfoLib|MinPlatformPkg/Pci/Library/PciSegmentInfoLibSimple/PciSegmentInfoLibSimple.inf
   
PlatformBootManagerLib|MinPlatformPkg/Bds/Library/DxePlatformBootManagerLib/DxePlatformBootManagerLib.inf
   AslUpdateLib|MinPlatformPkg/Acpi/Library/DxeAslUpdateLib/DxeAslUpdateLib.inf
-  PhatAcpiLib|MinPlatformPkg/Acpi/Library/DxePhatAcpiLib/DxePhatAcpiLib.inf
+  PhatAcpiLib|MinPlatformPkg/Acpi/Library/PhatAcpiLib/DxePhatAcpiLib.inf
 
   #
   # Misc
@@ -209,7 +209,7 @@
   MinPlatformPkg/Library/BaseLargeVariableLib/BaseLargeVariableReadLib.inf
   MinPlatformPkg/Library/BaseLargeVariableLib/BaseLargeVariableWriteLib.inf
 
-  MinPlatformPkg/Acpi/Library/DxePhatAcpiLib/DxePhatAcpiLib.inf
+  MinPlatformPkg/Acpi/Library/PhatAcpiLib/DxePhatAcpiLib.inf
 
 [BuildOptions]
   *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES
-- 
2.43.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118782): https://edk2.groups.io/g/devel/message/118782
Mute This Topic: https://groups.io/mt/106014298/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH v1 0/7] Uncrustify GoogleTest update

2023-08-09 Thread VivianNK 
Introduce cpp-specific formatting rules to Uncrustify for readability:
 * indent_class: indent lines inside of a class
 * indent_extern: indent lines inside of an extern

Apply all Uncrustify formatting rules defined in the config to existing
cpp and header files (GoogleTest files).

Moving forward all GoogleTest files will be included in uncrustify
formatting checks, leading to more consistency and greater readability.

VivianNK (7):
  .pytool: Set uncrustify check to audit only
  .pytool: Add cpp support to uncrustify plugin
  MdeModulePkg: Applyy uncrustify formatting to relevant files.
  MdePkg: Apply uncrustify formatting to relevant files
  SecurityPkg: Apply uncrustify formatting to relevant files
  UnitTestFrameworkPkg: Apply uncrustify formatting to relevant files
  .pytool: Undo uncrustify check change

 .pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py  
 |   2 +-
 .pytool/Plugin/UncrustifyCheck/uncrustify.cfg  
 |   4 +-
 MdeModulePkg/Library/UefiSortLib/GoogleTest/UefiSortLibGoogleTest.cpp  
 |  37 +-
 MdeModulePkg/Test/Mock/Include/GoogleTest/Library/MockPciHostBridgeLib.h   
 |   4 +-
 
MdeModulePkg/Test/Mock/Library/GoogleTest/MockPciHostBridgeLib/MockPciHostBridgeLib.cpp
 |   8 +-
 
MdePkg/Test/GoogleTest/Library/BaseSafeIntLib/SafeIntLibUintnIntnUnitTests32.cpp
| 114 ++--
 
MdePkg/Test/GoogleTest/Library/BaseSafeIntLib/SafeIntLibUintnIntnUnitTests64.cpp
| 114 ++--
 MdePkg/Test/GoogleTest/Library/BaseSafeIntLib/TestBaseSafeIntLib.cpp   
 | 563 ++--
 MdePkg/Test/Mock/Include/GoogleTest/Library/MockHobLib.h   
 |   6 +-
 MdePkg/Test/Mock/Include/GoogleTest/Library/MockPeiServicesLib.h   
 |   6 +-
 MdePkg/Test/Mock/Include/GoogleTest/Library/MockUefiLib.h  
 |   4 +-
 MdePkg/Test/Mock/Include/GoogleTest/Library/MockUefiRuntimeServicesTableLib.h  
 |   4 +-
 MdePkg/Test/Mock/Library/GoogleTest/MockHobLib/MockHobLib.cpp  
 |  40 +-
 MdePkg/Test/Mock/Library/GoogleTest/MockPeiServicesLib/MockPeiServicesLib.cpp  
 |  52 +-
 MdePkg/Test/Mock/Library/GoogleTest/MockUefiLib/MockUefiLib.cpp
 |   6 +-
 
MdePkg/Test/Mock/Library/GoogleTest/MockUefiRuntimeServicesTableLib/MockUefiRuntimeServicesTableLib.cpp
 |  12 +-
 
SecurityPkg/Library/SecureBootVariableLib/GoogleTest/SecureBootVariableLibGoogleTest.cpp
| 205 ---
 SecurityPkg/Test/Mock/Include/GoogleTest/Library/MockPlatformPKProtectionLib.h 
 |   4 +-
 
SecurityPkg/Test/Mock/Library/GoogleTest/MockPlatformPKProtectionLib/MockPlatformPKProtectionLib.cpp
|   4 +-
 UnitTestFrameworkPkg/Include/Library/GoogleTestLib.h   
 |   2 +-
 
UnitTestFrameworkPkg/Test/GoogleTest/Sample/SampleGoogleTest/SampleGoogleTest.cpp
   |  76 +--
 21 files changed, 664 insertions(+), 603 deletions(-)

-- 
2.41.0.windows.3



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107665): https://edk2.groups.io/g/devel/message/107665
Mute This Topic: https://groups.io/mt/100655288/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH v2 0/7] Uncrustify GoogleTest update

2023-08-16 Thread VivianNK 
v1 -> v2:
 - Update commit message to explain the audit only mode change is
   temporary to prevent intermediate CI failures. 
 - Format patch Cc's correctly

v1 archive:https://edk2.groups.io/g/devel/message/107665

VivianNK (7):
  .pytool: Set uncrustify check to audit only (temporary)
  .pytool: Add cpp support to uncrustify plugin
  MdeModulePkg: Apply uncrustify formatting to relevant files.
  MdePkg: Apply uncrustify formatting to relevant files
  SecurityPkg: Apply uncrustify formatting to relevant files
  UnitTestFrameworkPkg: Apply uncrustify formatting to relevant files
  .pytool: Undo uncrustify check change

 .pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py  
 |   2 +-
 .pytool/Plugin/UncrustifyCheck/uncrustify.cfg  
 |   4 +-
 MdeModulePkg/Library/UefiSortLib/GoogleTest/UefiSortLibGoogleTest.cpp  
 |  37 +-
 MdeModulePkg/Test/Mock/Include/GoogleTest/Library/MockPciHostBridgeLib.h   
 |   4 +-
 
MdeModulePkg/Test/Mock/Library/GoogleTest/MockPciHostBridgeLib/MockPciHostBridgeLib.cpp
 |   8 +-
 
MdePkg/Test/GoogleTest/Library/BaseSafeIntLib/SafeIntLibUintnIntnUnitTests32.cpp
| 114 ++--
 
MdePkg/Test/GoogleTest/Library/BaseSafeIntLib/SafeIntLibUintnIntnUnitTests64.cpp
| 114 ++--
 MdePkg/Test/GoogleTest/Library/BaseSafeIntLib/TestBaseSafeIntLib.cpp   
 | 563 ++--
 MdePkg/Test/Mock/Include/GoogleTest/Library/MockHobLib.h   
 |   6 +-
 MdePkg/Test/Mock/Include/GoogleTest/Library/MockPeiServicesLib.h   
 |   6 +-
 MdePkg/Test/Mock/Include/GoogleTest/Library/MockUefiLib.h  
 |   4 +-
 MdePkg/Test/Mock/Include/GoogleTest/Library/MockUefiRuntimeServicesTableLib.h  
 |   4 +-
 MdePkg/Test/Mock/Library/GoogleTest/MockHobLib/MockHobLib.cpp  
 |  40 +-
 MdePkg/Test/Mock/Library/GoogleTest/MockPeiServicesLib/MockPeiServicesLib.cpp  
 |  52 +-
 MdePkg/Test/Mock/Library/GoogleTest/MockUefiLib/MockUefiLib.cpp
 |   6 +-
 
MdePkg/Test/Mock/Library/GoogleTest/MockUefiRuntimeServicesTableLib/MockUefiRuntimeServicesTableLib.cpp
 |  12 +-
 
SecurityPkg/Library/SecureBootVariableLib/GoogleTest/SecureBootVariableLibGoogleTest.cpp
| 205 ---
 SecurityPkg/Test/Mock/Include/GoogleTest/Library/MockPlatformPKProtectionLib.h 
 |   4 +-
 
SecurityPkg/Test/Mock/Library/GoogleTest/MockPlatformPKProtectionLib/MockPlatformPKProtectionLib.cpp
|   4 +-
 UnitTestFrameworkPkg/Include/Library/GoogleTestLib.h   
 |   2 +-
 
UnitTestFrameworkPkg/Test/GoogleTest/Sample/SampleGoogleTest/SampleGoogleTest.cpp
   |  76 +--
 21 files changed, 664 insertions(+), 603 deletions(-)

-- 
2.41.0.windows.3



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107809): https://edk2.groups.io/g/devel/message/107809
Mute This Topic: https://groups.io/mt/100788665/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 0/7] Uncrustify GoogleTest update

2023-09-27 Thread VivianNK 

Hi Mike,

Can you help merge this? Looks like it has all of the reviews.

Thank you!
- Vivian

On 9/12/2023 7:42 AM, Michael D Kinney wrote:

Series Reviewed-by: Michael D Kinney


-Original Message-
From:devel@edk2.groups.ioOn Behalf Of VivianNK
Sent: Wednesday, August 16, 2023 2:15 PM
To:devel@edk2.groups.io
Subject: [edk2-devel] [PATCH v2 0/7] Uncrustify GoogleTest update

v1 -> v2:
  - Update commit message to explain the audit only mode change is
temporary to prevent intermediate CI failures.
  - Format patch Cc's correctly

v1 archive:https://edk2.groups.io/g/devel/message/107665

VivianNK (7):
   .pytool: Set uncrustify check to audit only (temporary)
   .pytool: Add cpp support to uncrustify plugin
   MdeModulePkg: Apply uncrustify formatting to relevant files.
   MdePkg: Apply uncrustify formatting to relevant files
   SecurityPkg: Apply uncrustify formatting to relevant files
   UnitTestFrameworkPkg: Apply uncrustify formatting to relevant files
   .pytool: Undo uncrustify check change

  .pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py
|   2 +-
  .pytool/Plugin/UncrustifyCheck/uncrustify.cfg
|   4 +-
  MdeModulePkg/Library/UefiSortLib/GoogleTest/UefiSortLibGoogleTest.cpp
|  37 +-
  MdeModulePkg/Test/Mock/Include/GoogleTest/Library/MockPciHostBridgeLib.h
|   4 +-

MdeModulePkg/Test/Mock/Library/GoogleTest/MockPciHostBridgeLib/MockPciHostBri
dgeLib.cpp |   8 +-

MdePkg/Test/GoogleTest/Library/BaseSafeIntLib/SafeIntLibUintnIntnUnitTests32.
cpp| 114 ++--

MdePkg/Test/GoogleTest/Library/BaseSafeIntLib/SafeIntLibUintnIntnUnitTests64.
cpp| 114 ++--
  MdePkg/Test/GoogleTest/Library/BaseSafeIntLib/TestBaseSafeIntLib.cpp
| 563 ++--
  MdePkg/Test/Mock/Include/GoogleTest/Library/MockHobLib.h
|   6 +-
  MdePkg/Test/Mock/Include/GoogleTest/Library/MockPeiServicesLib.h
|   6 +-
  MdePkg/Test/Mock/Include/GoogleTest/Library/MockUefiLib.h
|   4 +-

MdePkg/Test/Mock/Include/GoogleTest/Library/MockUefiRuntimeServicesTableLib.h
|   4 +-
  MdePkg/Test/Mock/Library/GoogleTest/MockHobLib/MockHobLib.cpp
|  40 +-

MdePkg/Test/Mock/Library/GoogleTest/MockPeiServicesLib/MockPeiServicesLib.cpp
|  52 +-
  MdePkg/Test/Mock/Library/GoogleTest/MockUefiLib/MockUefiLib.cpp
|   6 +-

MdePkg/Test/Mock/Library/GoogleTest/MockUefiRuntimeServicesTableLib/MockUefiR
untimeServicesTableLib.cpp |  12 +-

SecurityPkg/Library/SecureBootVariableLib/GoogleTest/SecureBootVariableLibGoo
gleTest.cpp| 205 ---

SecurityPkg/Test/Mock/Include/GoogleTest/Library/MockPlatformPKProtectionLib.
h  |   4 +-

SecurityPkg/Test/Mock/Library/GoogleTest/MockPlatformPKProtectionLib/MockPlat
formPKProtectionLib.cpp|   4 +-
  UnitTestFrameworkPkg/Include/Library/GoogleTestLib.h
|   2 +-

UnitTestFrameworkPkg/Test/GoogleTest/Sample/SampleGoogleTest/SampleGoogleTest
.cpp   |  76 +--
  21 files changed, 664 insertions(+), 603 deletions(-)

--
2.41.0.windows.3



-=-=-=-=-=-=
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107809):https://edk2.groups.io/g/devel/message/107809
Mute This Topic:https://groups.io/mt/100788665/1643496
Group Owner:devel+ow...@edk2.groups.io
Unsubscribe:https://edk2.groups.io/g/devel/unsub
[michael.d.kin...@intel.com]
-=-=-=-=-=-=







-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109129): https://edk2.groups.io/g/devel/message/109129
Mute This Topic: https://groups.io/mt/100788665/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-