Re: [edk2-devel] [PATCH v2 0/4] DynamicTablesPkg: Pcie generation updates

2022-07-08 Thread PierreGondois 

Hello Jeff,
I had some questions about the V1 at:
https://edk2.groups.io/g/devel/topic/92089320#90932
https://edk2.groups.io/g/devel/topic/92089321#90933

Regards,
Pierre

On 7/7/22 18:59, Jeff Brasen wrote:

Pierre,

  Any thoughts on this v2 version?

-Jeff



-Original Message-
From: Jeff Brasen 
Sent: Friday, July 1, 2022 10:33 AM
To: devel@edk2.groups.io
Cc: pierre.gond...@arm.com; sami.muja...@arm.com;
alexei.fedo...@arm.com; Jeff Brasen 
Subject: [PATCH v2 0/4] DynamicTablesPkg: Pcie generation updates

Add fixes/features to dynamic PCIe support

- Correct issue with translation in generated ACPI tables.
- Allow for more than 16 controllers to be generated.
- Allow optional use of segment number as UID for cases where ACPI path is
needed in other places.
- Add support for override protocol that allows platform specific modification
of node prior to creation.

Update:
v2 - Add IsPosDecode logic to translation patch

Jeff Brasen (4):
   DynamicTablesPkg: AcpiSsdtPcieLibArm: Correct translation value
   DynamicTablesPkg: AcpiSsdtPcieLibArm: Allow use of segment number as
 UID
   DynamicTablesPkg: AcpiSsdtPcieLibArm: Support UID > 0xF
   DynamicTablesPkg: AcpiSsdtPcieLibArm: Add support for override
 protocol

  DynamicTablesPkg/DynamicTablesPkg.dec |  6 ++
  .../Protocol/SsdtPcieOverrideProtocol.h   | 63 
  .../AcpiSsdtPcieLibArm/SsdtPcieGenerator.c| 73 ---
  .../AcpiSsdtPcieLibArm/SsdtPcieGenerator.h|  2 +-
  .../Arm/AcpiSsdtPcieLibArm/SsdtPcieLibArm.inf |  7 ++
  5 files changed, 139 insertions(+), 12 deletions(-)  create mode 100644
DynamicTablesPkg/Include/Protocol/SsdtPcieOverrideProtocol.h

--
2.25.1





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91177): https://edk2.groups.io/g/devel/message/91177
Mute This Topic: https://groups.io/mt/92113674/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: 回复: [edk2-devel] [PATCH v2 2/7] MdePkg: Allow PcdFSBClock to by Dynamic

2022-07-08 Thread Anthony PERARD via groups.io 
On Fri, Jul 08, 2022 at 10:14:35AM +0800, gaoliming wrote:
> Ray:
>  The problem is that PcdFSBClock is configured as Dynamic on OVMF. 

> Anthony:
>  Have you any suggestion for this problem?
> 
> Liming
> 
> 发件人: devel@edk2.groups.io  代表 ray_l...@hotmail.com
> 发送时间: 2022年7月7日 12:13
> 收件人: Anthony PERARD ; devel@edk2.groups.io
> 主题: Re: [edk2-devel] [PATCH v2 2/7] MdePkg: Allow PcdFSBClock to by Dynamic
> 
> On Thu, Mar 25, 2021 at 11:47 PM, Anthony PERARD wrote:
> 
> - ## This value is used to configure X86 Processor FSB clock.
> - # @Prompt FSB Clock.
> - gEfiMdePkgTokenSpaceGuid.PcdFSBClock|2|UINT32|0x000c
> 
> hi, Sir
> 
> This change caused the OVMF failed to load in QEMU when compiled with 
> "SOURCE_DEBUG_ENABLE" as True.
> 
> the verbose message of QEMU shows:
> 
> ASSERT [SecMain] d:\myedk2\edk2\MdePkg\Library\BasePcdLibNull\PcdLib.c(95): 
> ((BOOLEAN)(0==1))
> 
> The failure point is  PcdGet32 (PcdFSBClock) of debugtimer.c,  I  rolled back 
> above change, then issue disappeared.

What if you revert c37cbc030d96 ("OvmfPkg: Switch timer in build time
for OvmfPkg") instead? That commit seems to introduce PcdFSBClock as
dynamic in OvmfPkg*.dsc. But revert isn't going to be possible so
instead you could move "PcdFSBClock" to the [PcdsFixedAtBuild] sections
of all "OvmfPkg*.dsc". The dynamic nature of the pcd was only meant to
be used by OvmfXen, and no other platforms.

Cheers,

-- 
Anthony PERARD


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91178): https://edk2.groups.io/g/devel/message/91178
Mute This Topic: https://groups.io/mt/92243726/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH v2] BaseTools/Capsule: Add support for signtool to input subject name to sign capsule file

2022-07-08 Thread Lin, Jason1 
From: Jason1 Lin 

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3928

Windows-based system using signtool.exe to sign the capsule.
Add the support to using "--subject-name" argument to assign
the subject name used to sign the capsule file.
This argument would pass to signtool.exe as a part of input
argument with "/n" flag.

NOTE: If using signtool.exe to sign capsule at least need to
  choose one of "--pfx-file" and "--subject-name"
  argument to input the value.

Signed-off-by: Jason1 Lin 
Cc: Bob Feng 
Cc: Liming Gao 
Cc: Yuwei Chen 
Cc: Michael D Kinney 
Cc: Dakota Chiang 
---
 BaseTools/Source/Python/Capsule/GenerateCapsule.py | 39 
 1 file changed, 32 insertions(+), 7 deletions(-)

diff --git a/BaseTools/Source/Python/Capsule/GenerateCapsule.py 
b/BaseTools/Source/Python/Capsule/GenerateCapsule.py
index b8039db878..af49a3ec20 100644
--- a/BaseTools/Source/Python/Capsule/GenerateCapsule.py
+++ b/BaseTools/Source/Python/Capsule/GenerateCapsule.py
@@ -10,7 +10,7 @@
 # keep the tool as simple as possible, it has the following limitations:
 #   * Do not support vendor code bytes in a capsule.
 #
-# Copyright (c) 2018 - 2019, Intel Corporation. All rights reserved.
+# Copyright (c) 2018 - 2022, Intel Corporation. All rights reserved.
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 #
 
@@ -42,7 +42,7 @@ __version__ = '0.9'
 __copyright__   = 'Copyright (c) 2018, Intel Corporation. All rights reserved.'
 __description__ = 'Generate a capsule.\n'
 
-def SignPayloadSignTool (Payload, ToolPath, PfxFile, Verbose = False):
+def SignPayloadSignTool (Payload, ToolPath, PfxFile, SubjectName, Verbose = 
False):
 #
 # Create a temporary directory
 #
@@ -72,7 +72,10 @@ def SignPayloadSignTool (Payload, ToolPath, PfxFile, Verbose 
= False):
 Command = Command + '"{Path}" '.format (Path = os.path.join (ToolPath, 
'signtool.exe'))
 Command = Command + 'sign /fd sha256 /p7ce DetachedSignedData /p7co 
1.2.840.113549.1.7.2 '
 Command = Command + '/p7 {TempDir} '.format (TempDir = TempDirectoryName)
-Command = Command + '/f {PfxFile} '.format (PfxFile = PfxFile)
+if PfxFile is not None:
+Command = Command + '/f {PfxFile} '.format (PfxFile = PfxFile)
+if SubjectName is not None:
+Command = Command + '/n {SubjectName} '.format (SubjectName = 
SubjectName)
 Command = Command + TempFileName
 if Verbose:
 print (Command)
@@ -105,7 +108,7 @@ def SignPayloadSignTool (Payload, ToolPath, PfxFile, 
Verbose = False):
 shutil.rmtree (TempDirectoryName)
 return Signature
 
-def VerifyPayloadSignTool (Payload, CertData, ToolPath, PfxFile, Verbose = 
False):
+def VerifyPayloadSignTool (Payload, CertData, ToolPath, PfxFile, SubjectName, 
Verbose = False):
 print ('signtool verify is not supported.')
 raise ValueError ('GenerateCapsule: error: signtool verify is not 
supported.')
 
@@ -249,6 +252,7 @@ if __name__ == '__main__':
 HardwareInstance = ConvertJsonValue (Config, 
'HardwareInstance', ValidateUnsignedInteger, Required = False, Default = 0)
 MonotonicCount   = ConvertJsonValue (Config, 
'MonotonicCount', ValidateUnsignedInteger, Required = False, Default = 0)
 SignToolPfxFile  = ConvertJsonValue (Config, 
'SignToolPfxFile', os.path.expandvars, Required = False, Default = None, Open = 
True)
+SignToolSubjectName  = ConvertJsonValue (Config, 
'SignToolSubjectName', os.path.expandvars, Required = False, Default = None, 
Open = True)
 OpenSslSignerPrivateCertFile = ConvertJsonValue (Config, 
'OpenSslSignerPrivateCertFile', os.path.expandvars, Required = False, Default = 
None, Open = True)
 OpenSslOtherPublicCertFile   = ConvertJsonValue (Config, 
'OpenSslOtherPublicCertFile', os.path.expandvars, Required = False, Default = 
None, Open = True)
 OpenSslTrustedPublicCertFile = ConvertJsonValue (Config, 
'OpenSslTrustedPublicCertFile', os.path.expandvars, Required = False, Default = 
None, Open = True)
@@ -264,6 +268,7 @@ if __name__ == '__main__':
 HardwareInstance,
 UpdateImageIndex,
 SignToolPfxFile,
+SignToolSubjectName,
 OpenSslSignerPrivateCertFile,
 OpenSslOtherPublicCertFile,
 OpenSslTrustedPublicCertFile,
@@ -303,6 +308,7 @@ if __name__ == '__main__':
 UpdateImageIndex = ConvertJsonValue (Config, 
'UpdateImageIndex', ValidateUnsignedInteger, Required = False, Default = 1)
 MonotonicCount   = ConvertJsonValue (Config, 
'MonotonicCount', ValidateUnsignedInteger, Required = False, Default = 0)
 SignToolPfxFile  = Con

[edk2-devel] [PATCH v3] BaseTools/Capsule: Add support for signtool to input subject name to sign capsule file

2022-07-08 Thread Lin, Jason1 
From: Jason1 Lin 

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3928

Windows-based system using signtool.exe to sign the capsule.
Add the support to using "--subject-name" argument to assign
the subject name used to sign the capsule file.
This argument would pass to signtool.exe as a part of input
argument with "/n" flag.

NOTE: If using signtool.exe to sign capsule at least need to
  choose one of "--pfx-file" and "--subject-name"
  argument to input the value.

Signed-off-by: Jason1 Lin 
Cc: Bob Feng 
Cc: Liming Gao 
Cc: Yuwei Chen 
Cc: Michael D Kinney 
Cc: Dakota Chiang 
---
 BaseTools/Source/Python/Capsule/GenerateCapsule.py | 43 
 1 file changed, 34 insertions(+), 9 deletions(-)

diff --git a/BaseTools/Source/Python/Capsule/GenerateCapsule.py 
b/BaseTools/Source/Python/Capsule/GenerateCapsule.py
index b8039db878..35435946c6 100644
--- a/BaseTools/Source/Python/Capsule/GenerateCapsule.py
+++ b/BaseTools/Source/Python/Capsule/GenerateCapsule.py
@@ -10,7 +10,7 @@
 # keep the tool as simple as possible, it has the following limitations:
 #   * Do not support vendor code bytes in a capsule.
 #
-# Copyright (c) 2018 - 2019, Intel Corporation. All rights reserved.
+# Copyright (c) 2018 - 2022, Intel Corporation. All rights reserved.
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 #
 
@@ -38,11 +38,11 @@ from Common.Edk2.Capsule.FmpPayloadHeader  import 
FmpPayloadHeaderClass
 # Globals for help information
 #
 __prog__= 'GenerateCapsule'
-__version__ = '0.9'
-__copyright__   = 'Copyright (c) 2018, Intel Corporation. All rights reserved.'
+__version__ = '0.10'
+__copyright__   = 'Copyright (c) 2022, Intel Corporation. All rights reserved.'
 __description__ = 'Generate a capsule.\n'
 
-def SignPayloadSignTool (Payload, ToolPath, PfxFile, Verbose = False):
+def SignPayloadSignTool (Payload, ToolPath, PfxFile, SubjectName, Verbose = 
False):
 #
 # Create a temporary directory
 #
@@ -72,7 +72,10 @@ def SignPayloadSignTool (Payload, ToolPath, PfxFile, Verbose 
= False):
 Command = Command + '"{Path}" '.format (Path = os.path.join (ToolPath, 
'signtool.exe'))
 Command = Command + 'sign /fd sha256 /p7ce DetachedSignedData /p7co 
1.2.840.113549.1.7.2 '
 Command = Command + '/p7 {TempDir} '.format (TempDir = TempDirectoryName)
-Command = Command + '/f {PfxFile} '.format (PfxFile = PfxFile)
+if PfxFile is not None:
+Command = Command + '/f {PfxFile} '.format (PfxFile = PfxFile)
+if SubjectName is not None:
+Command = Command + '/n {SubjectName} '.format (SubjectName = 
SubjectName)
 Command = Command + TempFileName
 if Verbose:
 print (Command)
@@ -105,7 +108,7 @@ def SignPayloadSignTool (Payload, ToolPath, PfxFile, 
Verbose = False):
 shutil.rmtree (TempDirectoryName)
 return Signature
 
-def VerifyPayloadSignTool (Payload, CertData, ToolPath, PfxFile, Verbose = 
False):
+def VerifyPayloadSignTool (Payload, CertData, ToolPath, PfxFile, SubjectName, 
Verbose = False):
 print ('signtool verify is not supported.')
 raise ValueError ('GenerateCapsule: error: signtool verify is not 
supported.')
 
@@ -249,6 +252,7 @@ if __name__ == '__main__':
 HardwareInstance = ConvertJsonValue (Config, 
'HardwareInstance', ValidateUnsignedInteger, Required = False, Default = 0)
 MonotonicCount   = ConvertJsonValue (Config, 
'MonotonicCount', ValidateUnsignedInteger, Required = False, Default = 0)
 SignToolPfxFile  = ConvertJsonValue (Config, 
'SignToolPfxFile', os.path.expandvars, Required = False, Default = None, Open = 
True)
+SignToolSubjectName  = ConvertJsonValue (Config, 
'SignToolSubjectName', os.path.expandvars, Required = False, Default = None, 
Open = True)
 OpenSslSignerPrivateCertFile = ConvertJsonValue (Config, 
'OpenSslSignerPrivateCertFile', os.path.expandvars, Required = False, Default = 
None, Open = True)
 OpenSslOtherPublicCertFile   = ConvertJsonValue (Config, 
'OpenSslOtherPublicCertFile', os.path.expandvars, Required = False, Default = 
None, Open = True)
 OpenSslTrustedPublicCertFile = ConvertJsonValue (Config, 
'OpenSslTrustedPublicCertFile', os.path.expandvars, Required = False, Default = 
None, Open = True)
@@ -264,6 +268,7 @@ if __name__ == '__main__':
 HardwareInstance,
 UpdateImageIndex,
 SignToolPfxFile,
+SignToolSubjectName,
 OpenSslSignerPrivateCertFile,
 OpenSslOtherPublicCertFile,
 OpenSslTrustedPublicCertFile,
@@ -303,6 +308,7 @@ if __name__ == '__main__':
 UpdateImageIndex = ConvertJsonValue (Config, 
'UpdateImageI

[edk2-devel] [PATCH v3] [edk2-platforms] Silicon/Intel/FitGen: Fix CheckOverlap would do incorrect split BiosModule action in corner case

2022-07-08 Thread Lin, Jason1 
From: Jason1 Lin 

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3922

[Description]
CheckOverlap function would do incorrect split on the BiosModule which not 
happen overlap.
This would cause incorrect value locate in FIT entry record.

[Condition]
- This BiosModule base address is lower than input address.
- This BiosModule size is smaller than input size.

[Resolution]
- Do the check on BiosModule size and input size value to prevent possible
  negative value.

Signed-off-by: Jason1 Lin 
Cc: Bob Feng 
Cc: Liming Gao 
Cc: Yuwei Chen 
Cc: Dakota Chiang 
Cc: Vanessa Chuang 
---
 Silicon/Intel/Tools/FitGen/FitGen.c | 31 
 Silicon/Intel/Tools/FitGen/FitGen.h |  2 +-
 2 files changed, 32 insertions(+), 1 deletion(-)

diff --git a/Silicon/Intel/Tools/FitGen/FitGen.c 
b/Silicon/Intel/Tools/FitGen/FitGen.c
index 577ce48b10..6af7f8e2d9 100644
--- a/Silicon/Intel/Tools/FitGen/FitGen.c
+++ b/Silicon/Intel/Tools/FitGen/FitGen.c
@@ -820,11 +820,42 @@ CheckOverlap (
   IN UINT32 Address,
   IN UINT32 Size
   )
+/*++
+
+Routine Description:
+
+  Check whether the input address and size is overlap with any BiosModule.
+  If happen overlap, need to be deal with this case.
+  ---  +--+ <-- BiosModule A Base   
+--+
+   |   |  | |  
|
+   |  | |  
BiosModule  |
+   |  | |  A   
|
+   |  | |  
|
+  BiosModule A +--+ <-- [Input] Address >   
+--+
+  Size |  ||
+   |  ||[Input] Size
+   +--+  -- 
+--+
+   |  | |  
BiosModule  |
+   |   |  | |  B   
|
+  ---  +--+ 
+--+
+
+Arguments:
+
+  Address - The address of the buffer that required to check.
+  Size- The size of the buffer that required to check.
+
+Returns:
+
+  None
+
+--*/
+
 {
   INTN  Index;
 
   for (Index = 0; Index < (INTN)gFitTableContext.BiosModuleNumber; Index ++) {
 if ((gFitTableContext.BiosModule[Index].Address <= Address) &&
+(gFitTableContext.BiosModule[Index].Size >= Size) &&
 ((gFitTableContext.BiosModule[Index].Size - Size) >= (Address - 
gFitTableContext.BiosModule[Index].Address))) {
   UINT32  TempSize;
   INT32   SubIndex;
diff --git a/Silicon/Intel/Tools/FitGen/FitGen.h 
b/Silicon/Intel/Tools/FitGen/FitGen.h
index 80a1423ceb..769e2fda99 100644
--- a/Silicon/Intel/Tools/FitGen/FitGen.h
+++ b/Silicon/Intel/Tools/FitGen/FitGen.h
@@ -31,7 +31,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 // Utility version information
 //
 #define UTILITY_MAJOR_VERSION 0
-#define UTILITY_MINOR_VERSION 66
+#define UTILITY_MINOR_VERSION 67
 #define UTILITY_DATE  __DATE__
 
 //
-- 
2.37.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91181): https://edk2.groups.io/g/devel/message/91181
Mute This Topic: https://groups.io/mt/92249869/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH 1/1] BaseTools: add '-p' for Linux 'cp' command.

2022-07-08 Thread Yuwei Chen 
Currently BaseTools use 'cp' command for PcdValueInit and GenMake
process, as the command can not keep the time info of the source
file, which will cause incremental build issue in Linux system,
thus the '-p' need be added to keep the source file's attributes
in copy process.

This patch fixes this issue.

Cc: Bob Feng 
Cc: Liming Gao 
Signed-off-by: Yuwei Chen 
---
 BaseTools/Source/Python/AutoGen/GenMake.py| 2 +-
 BaseTools/Source/Python/Workspace/DscBuildData.py | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/BaseTools/Source/Python/AutoGen/GenMake.py 
b/BaseTools/Source/Python/AutoGen/GenMake.py
index 92c7bf0cdad5..daec9c6d54b2 100755
--- a/BaseTools/Source/Python/AutoGen/GenMake.py
+++ b/BaseTools/Source/Python/AutoGen/GenMake.py
@@ -120,7 +120,7 @@ class BuildFile(object):
 },
 
 POSIX_PLATFORM : {
-"CP":   "cp -f",
+"CP":   "cp -p -f",
 "MV":   "mv -f",
 "RM":   "rm -f",
 "MD":   "mkdir -p",
diff --git a/BaseTools/Source/Python/Workspace/DscBuildData.py 
b/BaseTools/Source/Python/Workspace/DscBuildData.py
index a599c5bb7688..e9f68384b429 100644
--- a/BaseTools/Source/Python/Workspace/DscBuildData.py
+++ b/BaseTools/Source/Python/Workspace/DscBuildData.py
@@ -2932,7 +2932,7 @@ class DscBuildData(PlatformBuildClassObject):
 MakeApp = MakeApp + PcdMakefileEnd
 MakeApp = MakeApp + AppTarget % ("""\tcopy $(APPLICATION) 
$(APPFILE) /y """)
 else:
-MakeApp = MakeApp + AppTarget % ("""\tcp $(APPLICATION) $(APPFILE) 
""")
+MakeApp = MakeApp + AppTarget % ("""\tcp -p $(APPLICATION) 
$(APPFILE) """)
 MakeApp = MakeApp + '\n'
 IncludeFileFullPaths = []
 for includefile in IncludeFiles:
@@ -2955,7 +2955,7 @@ class DscBuildData(PlatformBuildClassObject):
 else:
 PcdValueCommonPath = 
os.path.normpath(mws.join(GlobalData.gGlobalDefines["EDK_TOOLS_PATH"], 
"Source/C/Common/PcdValueCommon.c"))
 MakeApp = MakeApp + '%s/PcdValueCommon.c : %s\n' % 
(self.OutputPath, PcdValueCommonPath)
-MakeApp = MakeApp + '\tcp -f %s %s/PcdValueCommon.c\n' % 
(PcdValueCommonPath, self.OutputPath)
+MakeApp = MakeApp + '\tcp -p -f %s %s/PcdValueCommon.c\n' % 
(PcdValueCommonPath, self.OutputPath)
 MakeFileName = os.path.join(self.OutputPath, 'Makefile')
 MakeApp += "$(OBJECTS) : %s\n" % MakeFileName
 SaveFileOnChange(MakeFileName, MakeApp, False)
-- 
2.27.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91182): https://edk2.groups.io/g/devel/message/91182
Mute This Topic: https://groups.io/mt/92250878/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 0/4] DynamicTablesPkg: Pcie generation updates

2022-07-08 Thread Jeff Brasen via groups.io 
Ok, I never got those responses, will have to check what happened with my 
email. Will respond to those.

> -Original Message-
> From: Pierre Gondois 
> Sent: Friday, July 8, 2022 1:31 AM
> To: Jeff Brasen ; devel@edk2.groups.io
> Cc: sami.muja...@arm.com; alexei.fedo...@arm.com
> Subject: Re: [PATCH v2 0/4] DynamicTablesPkg: Pcie generation updates
> 
> External email: Use caution opening links or attachments
> 
> 
> Hello Jeff,
> I had some questions about the V1 at:
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk
> 2.groups.io%2Fg%2Fdevel%2Ftopic%2F92089320%2390932&data=05%7
> C01%7Cjbrasen%40nvidia.com%7C8a911ded72fd403690f208da60b3e0a9%7C
> 43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637928622942274065%7C
> Unknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJB
> TiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=p3jCMX%
> 2Fi0wf60FA2DgsGV7b3Vq6qw8jP6Kjp82YOoKg%3D&reserved=0
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk
> 2.groups.io%2Fg%2Fdevel%2Ftopic%2F92089321%2390933&data=05%7
> C01%7Cjbrasen%40nvidia.com%7C8a911ded72fd403690f208da60b3e0a9%7C
> 43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637928622942274065%7C
> Unknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJB
> TiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=IBjcEWb5
> VY7iXXkwOuP5LZN8c3aFdB25ophGXAVfHjQ%3D&reserved=0
> 
> Regards,
> Pierre
> 
> On 7/7/22 18:59, Jeff Brasen wrote:
> > Pierre,
> >
> >   Any thoughts on this v2 version?
> >
> > -Jeff
> >
> >
> >> -Original Message-
> >> From: Jeff Brasen 
> >> Sent: Friday, July 1, 2022 10:33 AM
> >> To: devel@edk2.groups.io
> >> Cc: pierre.gond...@arm.com; sami.muja...@arm.com;
> >> alexei.fedo...@arm.com; Jeff Brasen 
> >> Subject: [PATCH v2 0/4] DynamicTablesPkg: Pcie generation updates
> >>
> >> Add fixes/features to dynamic PCIe support
> >>
> >> - Correct issue with translation in generated ACPI tables.
> >> - Allow for more than 16 controllers to be generated.
> >> - Allow optional use of segment number as UID for cases where ACPI
> >> path is needed in other places.
> >> - Add support for override protocol that allows platform specific
> >> modification of node prior to creation.
> >>
> >> Update:
> >> v2 - Add IsPosDecode logic to translation patch
> >>
> >> Jeff Brasen (4):
> >>DynamicTablesPkg: AcpiSsdtPcieLibArm: Correct translation value
> >>DynamicTablesPkg: AcpiSsdtPcieLibArm: Allow use of segment number
> as
> >>  UID
> >>DynamicTablesPkg: AcpiSsdtPcieLibArm: Support UID > 0xF
> >>DynamicTablesPkg: AcpiSsdtPcieLibArm: Add support for override
> >>  protocol
> >>
> >>   DynamicTablesPkg/DynamicTablesPkg.dec |  6 ++
> >>   .../Protocol/SsdtPcieOverrideProtocol.h   | 63 
> >>   .../AcpiSsdtPcieLibArm/SsdtPcieGenerator.c| 73 -
> --
> >>   .../AcpiSsdtPcieLibArm/SsdtPcieGenerator.h|  2 +-
> >>   .../Arm/AcpiSsdtPcieLibArm/SsdtPcieLibArm.inf |  7 ++
> >>   5 files changed, 139 insertions(+), 12 deletions(-)  create mode
> >> 100644 DynamicTablesPkg/Include/Protocol/SsdtPcieOverrideProtocol.h
> >>
> >> --
> >> 2.25.1
> >


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91183): https://edk2.groups.io/g/devel/message/91183
Mute This Topic: https://groups.io/mt/92113674/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 2/4] DynamicTablesPkg: AcpiSsdtPcieLibArm: Allow use of segment number as UID

2022-07-08 Thread Jeff Brasen via groups.io 
So to detail the use case we have an embedded device on a known controller (we 
know the segment number) by forcing the autogeneration to the segment number we 
could in another SSDT create the subdevice node right. With just \SB\PCI9\D0x 
as the scope right? If we had a callback I suppose we don't need that. I think 
we could handle that with the proposed change you had in [4/4] if we just chain 
the implementation of GeneratePciDeviceInfo to our second place we would 
implement this. I think we can drop this patch and do it that way. Will move 
additional thoughts to the other patch.

Thanks,
Jeff


> -Original Message-
> From: Pierre Gondois 
> Sent: Monday, July 4, 2022 2:38 AM
> To: Jeff Brasen ; devel@edk2.groups.io
> Cc: sami.muja...@arm.com; alexei.fedo...@arm.com
> Subject: Re: [PATCH 2/4] DynamicTablesPkg: AcpiSsdtPcieLibArm: Allow use
> of segment number as UID
> 
> External email: Use caution opening links or attachments
> 
> 
> Hello Jeff,
> I understand that since the _UID value is generated, it is not possible for an
> external module to guess its value.
> However, the pcd (and the case you detailed) seem to be really specific.
> If you need an interface in the AmlLib to locate an AML node based on
> custom callback, we can help.
> Would this fit your need ?
> Also I don't understand how having a known _UID would ease locating the
> PCI device node.
> 
> Regards,
> Pierre
> 
> On 7/1/22 17:54, Jeff Brasen wrote:
> > I don't think there are any requirements that this should be mapped this
> way which is why I added this under a PCD to enable it. We have a use case
> where it would be helpful to know the ACPI path of the PCIe controllers
> externally and using the segment number for that would allow us to do this
> without having to have matching logic that calculates the PCIe UID from the
> CM object list again.
> >
> > Thanks,
> > Jeff
> >
> >
> >> -Original Message-
> >> From: Pierre Gondois 
> >> Sent: Friday, July 1, 2022 6:42 AM
> >> To: Jeff Brasen ; devel@edk2.groups.io
> >> Cc: sami.muja...@arm.com; alexei.fedo...@arm.com
> >> Subject: Re: [PATCH 2/4] DynamicTablesPkg: AcpiSsdtPcieLibArm: Allow
> >> use of segment number as UID
> >>
> >> External email: Use caution opening links or attachments
> >>
> >>
> >> Hello Jeff,
> >>
> >>   From "PCI Firmware Specification Revision 3.3", s4.1.2.
> >> "MCFG Table Description", the "PCI Segment Group Number" field of the
> >> MCFG table must match the value returned by the _SEG object in the
> >> corresponding object.
> >>
> >> I didn't find any constraint about the _UID value. Would it be
> >> possible to know why this is required ?
> >>
> >> Regards,
> >> Pierre
> >>
> >> On 6/30/22 17:48, Jeff Brasen wrote:
> >>> Add support for selecting to use index or segment number as UID and
> >> name.
> >>> This allows the path of the nodes to be well known.
> >>>
> >>> Signed-off-by: Jeff Brasen 
> >>> ---
> >>>DynamicTablesPkg/DynamicTablesPkg.dec |  3 +++
> >>>.../AcpiSsdtPcieLibArm/SsdtPcieGenerator.c| 19
> >> ++-
> >>>.../Arm/AcpiSsdtPcieLibArm/SsdtPcieLibArm.inf |  3 +++
> >>>3 files changed, 24 insertions(+), 1 deletion(-)
> >>>
> >>> diff --git a/DynamicTablesPkg/DynamicTablesPkg.dec
> >>> b/DynamicTablesPkg/DynamicTablesPkg.dec
> >>> index 9b74c5a671..a890a048be 100644
> >>> --- a/DynamicTablesPkg/DynamicTablesPkg.dec
> >>> +++ b/DynamicTablesPkg/DynamicTablesPkg.dec
> >>> @@ -57,5 +57,8 @@
> >>>  # Non BSA Compliant 16550 Serial HID
> >>>
> >>>
> >>
> gEdkiiDynamicTablesPkgTokenSpaceGuid.PcdNonBsaCompliant16550SerialHi
> >> d|
> >>> ""|VOID*|0x4008
> >>>
> >>> +  # Use PCI segment numbers as UID
> >>> +
> >>> +
> >>
> gEdkiiDynamicTablesPkgTokenSpaceGuid.PcdPciUseSegmentAsUid|FALSE|B
> >> OO
> >>> + LEAN|0x4009
> >>> +
> >>>[Guids]
> >>>  gEdkiiDynamicTablesPkgTokenSpaceGuid = { 0xab226e66, 0x31d8,
> >>> 0x4613, { 0x87, 0x9d, 0xd2, 0xfa, 0xb6, 0x10, 0x26, 0x3c } } diff
> >>> --git
> >>>
> >>
> a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenera
> >> t
> >>> or.c
> >>>
> >>
> b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenera
> >> t
> >>> or.c
> >>> index f0d15f69a4..85782af380 100644
> >>> ---
> >>>
> >>
> a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenera
> >> t
> >>> or.c
> >>> +++
> >> b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGen
> >>> +++ erator.c
> >>> @@ -996,6 +996,7 @@ BuildSsdtPciTableEx (
> >>>  UINTN Index;
> >>>  EFI_ACPI_DESCRIPTION_HEADER   **TableList;
> >>>  ACPI_PCI_GENERATOR*Generator;
> >>> +  UINT32Uid;
> >>>
> >>>  ASSERT (This != NULL);
> >>>  ASSERT (AcpiTableInfo != NULL); @@ -1051,13 +1052,29 @@
> >>> BuildSsdtPciTableEx (
> >>>  *Table = TableList;
> >>>
> >>>  for (Index = 0; Index < PciCount; Index++) {
> >>> +if (PcdGetBool (PcdPciUseSegmentAsUid)) {
> >>> +  Uid =

Re: [edk2-devel] [PATCH 4/4] DynamicTablesPkg: AcpiSsdtPcieLibArm: Add support for override protocol

2022-07-08 Thread Jeff Brasen via groups.io 
I think this would work. Instead of GeneratePciDeviceInfo the function we would 
want to break out would be GeneratePciSlots. I'll work on changing my patch 
series to this. Unless you have a better name will call this library 
SsdtPciSupportLib and place in under Library/Common

Going to also pass PciInfo into AddOscMethod in this new approach in case 
client needs to have different _OSC per controller (And to GeneratePciSlots as 
well).

Thanks,
Jeff

> -Original Message-
> From: Pierre Gondois 
> Sent: Monday, July 4, 2022 2:48 AM
> To: Jeff Brasen ; devel@edk2.groups.io
> Cc: sami.muja...@arm.com; alexei.fedo...@arm.com
> Subject: Re: [PATCH 4/4] DynamicTablesPkg: AcpiSsdtPcieLibArm: Add
> support for override protocol
> 
> External email: Use caution opening links or attachments
> 
> 
> Hello Jeff,
> I think it would ideally be better to have the code adding/replacing the
> methods/objects you noted inside the edk2/edk2-platfoms repositories. The
> methods/objects that you want to replace seem to only concern:
> -the objects available in the 'Device (PCIx)' node -the _OSC method
> 
> If a library with the following two methods (extracted from
> SsdtPcieLibArm.inf) was created, would it be sufficient for all the
> replacements you want to do ?
> Like this we would have a generic implementation and specific ones.
> 
> EFI_STATUS
> EFIAPI
> GeneratePciDeviceInfo (
>IN  CONST CM_ARM_PCI_CONFIG_SPACE_INFO  *PciInfo,
>INUINT32Uid,
>IN  OUT   AML_OBJECT_NODE_HANDLEPciNode
>)
> 
> EFI_STATUS
> EFIAPI
> AddOscMethod (
>IN  OUT   AML_OBJECT_NODE_HANDLE  PciNode
>)
> 
> Regards,
> Pierre
> 
> On 7/1/22 17:52, Jeff Brasen wrote:
> > Currently we do the following in this call.
> >
> > Remove and replace the _OSC method on certain targets. I originally
> > had this pass the template over but removed that when I added this
> > more generic override support Add a _RST method to the root port
> > device sub node Add a _DSD for device properties Conditionally add an
> > entry for the device attached to the PCIe bus if we need to add
> > properties or _RST methods. This will likely eventually move to
> > another driver (which is the purpose of patch 2/4 in this series)
> >
> > I figured trying to get the generator to handle that would be more difficult
> as these would be hard to generalize.
> >
> >
> > Thanks,
> > Jeff
> >
> >> -Original Message-
> >> From: Pierre Gondois 
> >> Sent: Friday, July 1, 2022 6:40 AM
> >> To: Jeff Brasen ; devel@edk2.groups.io
> >> Cc: sami.muja...@arm.com; alexei.fedo...@arm.com
> >> Subject: Re: [PATCH 4/4] DynamicTablesPkg: AcpiSsdtPcieLibArm: Add
> >> support for override protocol
> >>
> >> External email: Use caution opening links or attachments
> >>
> >>
> >> Hello Jeff,
> >> Is it possible to know what the UpdateTable() function would do ?
> >> Maybe it would be possible to integrate the alternative
> >> implementation without adding a new protocol.
> >>
> >> Regards,
> >> Pierre
> >>
> >> On 6/30/22 17:48, Jeff Brasen wrote:
> >>> Some platfoms may want to modify the ACPI table created.
> >>> Add support for protocol that can provide an alternative
> implementation.
> >>>
> >>> Signed-off-by: Jeff Brasen 
> >>> ---
> >>>DynamicTablesPkg/DynamicTablesPkg.dec |  3 +
> >>>.../Protocol/SsdtPcieOverrideProtocol.h   | 63
> +++
> >>>.../AcpiSsdtPcieLibArm/SsdtPcieGenerator.c| 31 -
> >>>.../Arm/AcpiSsdtPcieLibArm/SsdtPcieLibArm.inf |  4 ++
> >>>4 files changed, 98 insertions(+), 3 deletions(-)
> >>>create mode 100644
> >>> DynamicTablesPkg/Include/Protocol/SsdtPcieOverrideProtocol.h
> >>>
> >>> diff --git a/DynamicTablesPkg/DynamicTablesPkg.dec
> >>> b/DynamicTablesPkg/DynamicTablesPkg.dec
> >>> index a890a048be..bb66bdaf14 100644
> >>> --- a/DynamicTablesPkg/DynamicTablesPkg.dec
> >>> +++ b/DynamicTablesPkg/DynamicTablesPkg.dec
> >>> @@ -43,6 +43,9 @@
> >>>  # Dynamic Table Factory Protocol GUID
> >>>  gEdkiiDynamicTableFactoryProtocolGuid = { 0x91d1e327, 0xfe5a,
> >>> 0x49b8, { 0xab, 0x65, 0xe, 0xce, 0x2d, 0xdb, 0x45, 0xec } }
> >>>
> >>> +  # Protocol to override PCI SSDT table generation
> >>> + gEdkiiDynamicTableSsdtPcieOverrideProtocolGuid = { 0x962e8b44,
> >>> + 0x23b3, 0x41da, { 0x9f, 0x36, 0xca, 0xde, 0x68, 0x49, 0xfb, 0xf6 }
> >>> + }
> >>> +
> >>>[PcdsFixedAtBuild]
> >>>
> >>>  # Maximum number of Custom ACPI Generators diff --git
> >>> a/DynamicTablesPkg/Include/Protocol/SsdtPcieOverrideProtocol.h
> >>> b/DynamicTablesPkg/Include/Protocol/SsdtPcieOverrideProtocol.h
> >>> new file mode 100644
> >>> index 00..29568a0159
> >>> --- /dev/null
> >>> +++ b/DynamicTablesPkg/Include/Protocol/SsdtPcieOverrideProtocol.h
> >>> @@ -0,0 +1,63 @@
> >>> +/** @file
> >>> +
> >>> +  Copyright (c) 2022, NVIDIA CORPORATION. All rights reserved.
> >>> +
> >>> +  SPDX-License-Identifier: BSD-2-Clause-Patent
> >>> +
> >>> +*

Re: [edk2-devel] [PATCH v3 00/11] Enhance Secure Boot Variable Libraries

2022-07-08 Thread Ard Biesheuvel 
I think this series has broken some ARM platforms, please double check.

https://ci.linaro.org/job/leg-virt-tianocore-edk2-upstream/4573/console


On Thu, 7 Jul 2022 at 03:09, Yao, Jiewen  wrote:
>
> Merged https://github.com/tianocore/edk2/pull/3050
>
>
>
> From: Kun Qin 
> Sent: Thursday, July 7, 2022 1:44 AM
> To: devel@edk2.groups.io; Yao, Jiewen 
> Cc: Wang, Jian J ; Xu, Min M ; 
> Sean Brogan ; Ard Biesheuvel 
> ; Justen, Jordan L ; 
> Gerd Hoffmann ; Rebecca Cran ; Peter 
> Grehan ; Boeuf, Sebastien ; 
> Andrew Fish ; Ni, Ray 
> Subject: Re: [edk2-devel] [PATCH v3 00/11] Enhance Secure Boot Variable 
> Libraries
>
>
>
> Hi Jiewen,
>
> Yes, the "https://github.com/kuqin12/edk2/tree/secure_boot_enhance_v3"; is the 
> branch I generate these patch series. And they have not been changed after 
> sending v3 patches.
>
> I confirm that:
> 1. the latest update 256220d82191effae32d91897ab0f65a4fa0641b is identical to 
> the one I submitted to mailing list;
> 2. the branch passed EDKII CI when I prepared this branch and the PR is 
> Secure boot enhance v3 by kuqin12 · Pull Request #3035 · tianocore/edk2 
> (github.com).
>
> Thanks a lot for the help! Please let me know if you encounter any issues 
> when merging these patches.
>
> Regards,
> Kun
>
> On 7/5/2022 10:19 PM, Yao, Jiewen wrote:
>
> Hi
>
> I am going to merge this. However, I realize that my mailbox filtered patch 
> 6/11 and 10/11.
>
> So I am going to merge the one in 
> https://github.com/kuqin12/edk2/tree/secure_boot_enhance_v3
>
>
>
> Please double confirm:
>
> 1) the latest one 256220d82191effae32d91897ab0f65a4fa0641b is identical to 
> the one you submitted to EDKII mailing list.
>
> 2) the latest one passed the EDKII CI.
>
>
>
> Once you confirm above, I will start merging process.
>
>
>
> Thank you
>
> Yao Jiewen
>
>
>
> -Original Message-
>
> From: devel@edk2.groups.io  On Behalf Of Kun Qin
>
> Sent: Friday, July 1, 2022 7:54 AM
>
> To: devel@edk2.groups.io
>
> Cc: Yao, Jiewen ; Wang, Jian J ;
>
> Xu, Min M ; Sean Brogan ;
>
> Ard Biesheuvel ; Justen, Jordan L
>
> ; Gerd Hoffmann ; Rebecca
>
> Cran ; Peter Grehan ; Boeuf,
>
> Sebastien ; Andrew Fish ; Ni,
>
> Ray 
>
> Subject: [edk2-devel] [PATCH v3 00/11] Enhance Secure Boot Variable Libraries
>
>
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3909
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3910
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3911
>
>
>
> This is a follow-up of a previously submitted patch series based on top
>
> of master branch: https://edk2.groups.io/g/devel/message/90491.
>
>
>
> The main changes between v2 and v3 patches are:
>
>   - Added reviewed-by and acked-by tags collected from previous iteration
>
>   - Updated default timestamp for default secure boot variable enrollment
>
>
>
> The updated changes are verified on QEMU based Q35 virtual platform as
>
> well as proprietary physical platforms.
>
>
>
> Patch v3 branch:
>
> https://github.com/kuqin12/edk2/tree/secure_boot_enhance_v3
>
>
>
> Cc: Jiewen Yao 
>
> Cc: Jian J Wang 
>
> Cc: Min Xu 
>
> Cc: Sean Brogan 
>
> Cc: Ard Biesheuvel 
>
> Cc: Jordan Justen 
>
> Cc: Gerd Hoffmann 
>
> Cc: Rebecca Cran 
>
> Cc: Peter Grehan 
>
> Cc: Sebastien Boeuf 
>
> Cc: Andrew Fish 
>
> Cc: Ray Ni 
>
>
>
> Kun Qin (8):
>
>   SecurityPkg: UefiSecureBoot: Definitions of cert and payload
>
> structures
>
>   SecurityPkg: PlatformPKProtectionLib: Added PK protection interface
>
>   SecurityPkg: SecureBootVariableLib: Updated time based payload creator
>
>   SecurityPkg: SecureBootVariableProvisionLib: Updated implementation
>
>   SecurityPkg: Secure Boot Drivers: Added common header files
>
>   SecurityPkg: SecureBootConfigDxe: Updated invocation pattern
>
>   OvmfPkg: Pipeline: Resolve SecureBootVariableLib dependency
>
>   EmulatorPkg: Pipeline: Resolve SecureBootVariableLib dependency
>
>
>
> kuqin (3):
>
>   SecurityPkg: SecureBootVariableLib: Updated signature list creator
>
>   SecurityPkg: SecureBootVariableLib: Added newly supported interfaces
>
>   SecurityPkg: SecureBootVariableLib: Added unit tests
>
>
>
>  SecurityPkg/EnrollFromDefaultKeysApp/EnrollFromDefaultKeysApp.c
>
> |1 +
>
>
>
> SecurityPkg/Library/PlatformPKProtectionLibVarPolicy/PlatformPKProtectionLib
>
> VarPolicy.c   |   51 +
>
>  SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.c
>
> |  485 -
>
>
>
> SecurityPkg/Library/SecureBootVariableLib/UnitTest/MockPlatformPKProtectio
>
> nLib.c  |   36 +
>
>  SecurityPkg/Library/SecureBootVariableLib/UnitTest/MockUefiLib.c
>
> |  201 ++
>
>
>
> SecurityPkg/Library/SecureBootVariableLib/UnitTest/MockUefiRuntimeServices
>
> TableLib.c  |   13 +
>
>
>
> SecurityPkg/Library/SecureBootVariableLib/UnitTest/SecureBootVariableLibUnit
>
> Test.c| 2037 
>
>
>
> SecurityPkg/Library/SecureBootVariableProvisionLib/SecureBootVariableProvisi
>
> onLib.c   |  145 +-
>
>
>
> SecurityPkg/VariableAuthenticated/SecureBootConf

Re: [edk2-devel] [PATCH] MinPlatformPkg: Resolve SecureBootVariableLib dependency

2022-07-08 Thread Oram, Isaac W 
Reviewed-by: Isaac Oram 

-Original Message-
From: devel@edk2.groups.io  On Behalf Of Zhiguang Liu
Sent: Thursday, July 7, 2022 8:44 PM
To: devel@edk2.groups.io
Cc: Liu, Zhiguang ; Kun Qin ; Chiu, 
Chasel ; Desimone, Nathaniel L 
; Oram, Isaac W ; Gao, 
Liming ; Dong, Eric 
Subject: [edk2-devel] [PATCH] MinPlatformPkg: Resolve SecureBootVariableLib 
dependency

The new changes in SecureBootVariableLib brought in a new dependency of 
PlatformPKProtectionLib.
This change added the new library instance from SecurityPkg to resolve 
MinPlatformPkg builds.

Cc: Kun Qin 
Cc: Chasel Chiu 
Cc: Nate DeSimone 
Cc: Isaac Oram 
Cc: Liming Gao 
Cc: Eric Dong 
Signed-off-by: Zhiguang Liu 
---
 Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc 
b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
index 58a18fae6e..b77d55dfd5 100644
--- a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
+++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
@@ -141,6 +141,7 @@
   AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf
   
SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf
   
SecureBootVariableProvisionLib|SecurityPkg/Library/SecureBootVariableProvisionLib/SecureBootVariableProvisionLib.inf
+  
+ PlatformPKProtectionLib|SecurityPkg/Library/PlatformPKProtectionLibVar
+ Policy/PlatformPKProtectionLibVarPolicy.inf
 !endif
 
   SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.inf
--
2.16.2.windows.1








-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91187): https://edk2.groups.io/g/devel/message/91187
Mute This Topic: https://groups.io/mt/92244799/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] MinPlatformPkg: Resolve SecureBootVariableLib dependency

2022-07-08 Thread Oram, Isaac W 
Pushed as 4775d4e4f8..a3f3f4bde7

-Original Message-
From: devel@edk2.groups.io  On Behalf Of Oram, Isaac W
Sent: Friday, July 8, 2022 10:34 AM
To: devel@edk2.groups.io; Liu, Zhiguang 
Cc: Kun Qin ; Chiu, Chasel ; 
Desimone, Nathaniel L ; Gao, Liming 
; Dong, Eric 
Subject: Re: [edk2-devel] [PATCH] MinPlatformPkg: Resolve SecureBootVariableLib 
dependency

Reviewed-by: Isaac Oram 

-Original Message-
From: devel@edk2.groups.io  On Behalf Of Zhiguang Liu
Sent: Thursday, July 7, 2022 8:44 PM
To: devel@edk2.groups.io
Cc: Liu, Zhiguang ; Kun Qin ; Chiu, 
Chasel ; Desimone, Nathaniel L 
; Oram, Isaac W ; Gao, 
Liming ; Dong, Eric 
Subject: [edk2-devel] [PATCH] MinPlatformPkg: Resolve SecureBootVariableLib 
dependency

The new changes in SecureBootVariableLib brought in a new dependency of 
PlatformPKProtectionLib.
This change added the new library instance from SecurityPkg to resolve 
MinPlatformPkg builds.

Cc: Kun Qin 
Cc: Chasel Chiu 
Cc: Nate DeSimone 
Cc: Isaac Oram 
Cc: Liming Gao 
Cc: Eric Dong 
Signed-off-by: Zhiguang Liu 
---
 Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc 
b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
index 58a18fae6e..b77d55dfd5 100644
--- a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
+++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
@@ -141,6 +141,7 @@
   AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf
   
SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf
   
SecureBootVariableProvisionLib|SecurityPkg/Library/SecureBootVariableProvisionLib/SecureBootVariableProvisionLib.inf
+  
+ PlatformPKProtectionLib|SecurityPkg/Library/PlatformPKProtectionLibVar
+ Policy/PlatformPKProtectionLibVarPolicy.inf
 !endif
 
   SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.inf
--
2.16.2.windows.1













-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91188): https://edk2.groups.io/g/devel/message/91188
Mute This Topic: https://groups.io/mt/92244799/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH v1 1/1] ArmVirtPkg: Pipeline: Resolving newly introduced dependency

2022-07-08 Thread Kun Qin 
The new changes in SecureBootVariableLib brought in a new dependency
of PlatformPKProtectionLib.

This change added the new library instance from SecurityPkg to resolve
ArmVirtPkg builds.

Cc: Ard Biesheuvel 
Cc: Leif Lindholm 
Cc: Sami Mujawar 
Cc: Gerd Hoffmann 

Signed-off-by: Kun Qin 
---
 ArmVirtPkg/ArmVirt.dsc.inc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc
index 4732bd76d6d0..c39e2506a3ea 100644
--- a/ArmVirtPkg/ArmVirt.dsc.inc
+++ b/ArmVirtPkg/ArmVirt.dsc.inc
@@ -170,6 +170,7 @@ [LibraryClasses.common]
   AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf
   
SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf
   
SecureBootVariableProvisionLib|SecurityPkg/Library/SecureBootVariableProvisionLib/SecureBootVariableProvisionLib.inf
+  
PlatformPKProtectionLib|SecurityPkg/Library/PlatformPKProtectionLibVarPolicy/PlatformPKProtectionLibVarPolicy.inf
 
   # re-use the UserPhysicalPresent() dummy implementation from the ovmf tree
   PlatformSecureLib|OvmfPkg/Library/PlatformSecureLib/PlatformSecureLib.inf
-- 
2.37.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91189): https://edk2.groups.io/g/devel/message/91189
Mute This Topic: https://groups.io/mt/92259742/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v3 00/11] Enhance Secure Boot Variable Libraries

2022-07-08 Thread Kun Qin 

Hi Ard,

I thought pipeline should have caught this type of errors. Sorry for the 
inconvenience.


A patch was sent here to fix this issue:
https://edk2.groups.io/g/devel/message/91189

Regards,
Kun

On 7/8/2022 9:38 AM, Ard Biesheuvel wrote:

I think this series has broken some ARM platforms, please double check.

https://ci.linaro.org/job/leg-virt-tianocore-edk2-upstream/4573/console


On Thu, 7 Jul 2022 at 03:09, Yao, Jiewen  wrote:

Merged https://github.com/tianocore/edk2/pull/3050



From: Kun Qin 
Sent: Thursday, July 7, 2022 1:44 AM
To: devel@edk2.groups.io; Yao, Jiewen 
Cc: Wang, Jian J ; Xu, Min M ; Sean Brogan ; Ard 
Biesheuvel ; Justen, Jordan L ; Gerd Hoffmann ; 
Rebecca Cran ; Peter Grehan ; Boeuf, Sebastien ; Andrew Fish 
; Ni, Ray 
Subject: Re: [edk2-devel] [PATCH v3 00/11] Enhance Secure Boot Variable 
Libraries



Hi Jiewen,

Yes, the "https://github.com/kuqin12/edk2/tree/secure_boot_enhance_v3"; is the 
branch I generate these patch series. And they have not been changed after sending v3 
patches.

I confirm that:
1. the latest update 256220d82191effae32d91897ab0f65a4fa0641b is identical to 
the one I submitted to mailing list;
2. the branch passed EDKII CI when I prepared this branch and the PR is Secure 
boot enhance v3 by kuqin12 · Pull Request #3035 · tianocore/edk2 (github.com).

Thanks a lot for the help! Please let me know if you encounter any issues when 
merging these patches.

Regards,
Kun

On 7/5/2022 10:19 PM, Yao, Jiewen wrote:

Hi

I am going to merge this. However, I realize that my mailbox filtered patch 
6/11 and 10/11.

So I am going to merge the one in 
https://github.com/kuqin12/edk2/tree/secure_boot_enhance_v3



Please double confirm:

1) the latest one 256220d82191effae32d91897ab0f65a4fa0641b is identical to the 
one you submitted to EDKII mailing list.

2) the latest one passed the EDKII CI.



Once you confirm above, I will start merging process.



Thank you

Yao Jiewen



-Original Message-

From: devel@edk2.groups.io  On Behalf Of Kun Qin

Sent: Friday, July 1, 2022 7:54 AM

To: devel@edk2.groups.io

Cc: Yao, Jiewen ; Wang, Jian J ;

Xu, Min M ; Sean Brogan ;

Ard Biesheuvel ; Justen, Jordan L

; Gerd Hoffmann ; Rebecca

Cran ; Peter Grehan ; Boeuf,

Sebastien ; Andrew Fish ; Ni,

Ray 

Subject: [edk2-devel] [PATCH v3 00/11] Enhance Secure Boot Variable Libraries



REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3909

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3910

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3911



This is a follow-up of a previously submitted patch series based on top

of master branch: https://edk2.groups.io/g/devel/message/90491.



The main changes between v2 and v3 patches are:

   - Added reviewed-by and acked-by tags collected from previous iteration

   - Updated default timestamp for default secure boot variable enrollment



The updated changes are verified on QEMU based Q35 virtual platform as

well as proprietary physical platforms.



Patch v3 branch:

https://github.com/kuqin12/edk2/tree/secure_boot_enhance_v3



Cc: Jiewen Yao 

Cc: Jian J Wang 

Cc: Min Xu 

Cc: Sean Brogan 

Cc: Ard Biesheuvel 

Cc: Jordan Justen 

Cc: Gerd Hoffmann 

Cc: Rebecca Cran 

Cc: Peter Grehan 

Cc: Sebastien Boeuf 

Cc: Andrew Fish 

Cc: Ray Ni 



Kun Qin (8):

   SecurityPkg: UefiSecureBoot: Definitions of cert and payload

 structures

   SecurityPkg: PlatformPKProtectionLib: Added PK protection interface

   SecurityPkg: SecureBootVariableLib: Updated time based payload creator

   SecurityPkg: SecureBootVariableProvisionLib: Updated implementation

   SecurityPkg: Secure Boot Drivers: Added common header files

   SecurityPkg: SecureBootConfigDxe: Updated invocation pattern

   OvmfPkg: Pipeline: Resolve SecureBootVariableLib dependency

   EmulatorPkg: Pipeline: Resolve SecureBootVariableLib dependency



kuqin (3):

   SecurityPkg: SecureBootVariableLib: Updated signature list creator

   SecurityPkg: SecureBootVariableLib: Added newly supported interfaces

   SecurityPkg: SecureBootVariableLib: Added unit tests



  SecurityPkg/EnrollFromDefaultKeysApp/EnrollFromDefaultKeysApp.c

|1 +



SecurityPkg/Library/PlatformPKProtectionLibVarPolicy/PlatformPKProtectionLib

VarPolicy.c   |   51 +

  SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.c

|  485 -



SecurityPkg/Library/SecureBootVariableLib/UnitTest/MockPlatformPKProtectio

nLib.c  |   36 +

  SecurityPkg/Library/SecureBootVariableLib/UnitTest/MockUefiLib.c

|  201 ++



SecurityPkg/Library/SecureBootVariableLib/UnitTest/MockUefiRuntimeServices

TableLib.c  |   13 +



SecurityPkg/Library/SecureBootVariableLib/UnitTest/SecureBootVariableLibUnit

Test.c| 2037 



SecurityPkg/Library/SecureBootVariableProvisionLib/SecureBootVariableProvisi

onLib.c   |  145 +-



SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigIm

pl.c  |  128 +-



SecurityPkg/VariableA

[edk2-devel] [PATCH v3 0/3] DynamicTablesPkg: Pcie generation updates

2022-07-08 Thread Jeff Brasen via groups.io 


Add fixes/features to dynamic PCIe support

 - Correct issue with translation in generated ACPI tables.
 - Allow for more than 16 controllers to be generated.
 - Add support library to allow for override of _OSC and slot info.

Updates:
 v3 - Remove segment as UID patch, convert override to library
 v2 - Add IsPosDecode logic to translation patch


Jeff Brasen (3):
  DynamicTablesPkg: AcpiSsdtPcieLibArm: Correct translation value
  DynamicTablesPkg: AcpiSsdtPcieLibArm: Support UID > 0xF
  DynamicTablesPkg: AcpiSsdtPcieLibArm: Create support library

 .../Include/Library/SsdtPcieSupportLib.h  |  73 +++
 .../AcpiSsdtPcieLibArm/SsdtPcieGenerator.c| 191 ++---
 .../AcpiSsdtPcieLibArm/SsdtPcieGenerator.h|  17 +-
 .../Arm/AcpiSsdtPcieLibArm/SsdtPcieLibArm.inf |   2 +-
 .../SsdtPcieOscTemplate.asl   |   0
 .../SsdtPcieSupportLib/SsdtPcieSupportLib.c   | 200 ++
 .../SsdtPcieSupportLib/SsdtPcieSupportLib.inf |  30 +++
 .../SsdtPcieSupportLibPrivate.h   |  25 +++
 8 files changed, 349 insertions(+), 189 deletions(-)
 create mode 100644 DynamicTablesPkg/Include/Library/SsdtPcieSupportLib.h
 rename DynamicTablesPkg/Library/{Acpi/Arm/AcpiSsdtPcieLibArm => 
Common/SsdtPcieSupportLib}/SsdtPcieOscTemplate.asl (100%)
 create mode 100644 
DynamicTablesPkg/Library/Common/SsdtPcieSupportLib/SsdtPcieSupportLib.c
 create mode 100644 
DynamicTablesPkg/Library/Common/SsdtPcieSupportLib/SsdtPcieSupportLib.inf
 create mode 100644 
DynamicTablesPkg/Library/Common/SsdtPcieSupportLib/SsdtPcieSupportLibPrivate.h

-- 
2.25.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91191): https://edk2.groups.io/g/devel/message/91191
Mute This Topic: https://groups.io/mt/92260869/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH v3 1/3] DynamicTablesPkg: AcpiSsdtPcieLibArm: Correct translation value

2022-07-08 Thread Jeff Brasen via groups.io 
The translation value in ACPI should be the difference between the CPU and PCIe 
address.



Signed-off-by: Jeff Brasen 

---

 .../Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c | 18 --

 1 file changed, 12 insertions(+), 6 deletions(-)



diff --git 
a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c 
b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c

index a34018151f..d4c5f47b07 100644

--- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c

+++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c

@@ -540,6 +540,7 @@ GeneratePciCrs (

   UINT32   RefCount;

   CM_ARM_PCI_ADDRESS_MAP_INFO  *AddrMapInfo;

   AML_OBJECT_NODE_HANDLE   CrsNode;

+  BOOLEAN  IsPosDecode;

 

   ASSERT (Generator != NULL);

   ASSERT (CfgMgrProtocol != NULL);

@@ -609,6 +610,11 @@ GeneratePciCrs (

 }

 

 Translation = (AddrMapInfo->CpuAddress != AddrMapInfo->PciAddress);

+if (AddrMapInfo->CpuAddress >= AddrMapInfo->PciAddress) {

+  IsPosDecode = TRUE;

+} else {

+  IsPosDecode = FALSE;

+}

 

 switch (AddrMapInfo->SpaceCode) {

   case PCI_SS_IO:

@@ -616,12 +622,12 @@ GeneratePciCrs (

FALSE,

TRUE,

TRUE,

-   TRUE,

+   IsPosDecode,

3,

0,

AddrMapInfo->PciAddress,

AddrMapInfo->PciAddress + AddrMapInfo->AddressSize - 1,

-   Translation ? AddrMapInfo->CpuAddress : 0,

+   Translation ? AddrMapInfo->CpuAddress - 
AddrMapInfo->PciAddress : 0,

AddrMapInfo->AddressSize,

0,

NULL,

@@ -635,7 +641,7 @@ GeneratePciCrs (

   case PCI_SS_M32:

 Status = AmlCodeGenRdDWordMemory (

FALSE,

-   TRUE,

+   IsPosDecode,

TRUE,

TRUE,

TRUE,

@@ -643,7 +649,7 @@ GeneratePciCrs (

0,

AddrMapInfo->PciAddress,

AddrMapInfo->PciAddress + AddrMapInfo->AddressSize - 1,

-   Translation ? AddrMapInfo->CpuAddress : 0,

+   Translation ? AddrMapInfo->CpuAddress - 
AddrMapInfo->PciAddress : 0,

AddrMapInfo->AddressSize,

0,

NULL,

@@ -657,7 +663,7 @@ GeneratePciCrs (

   case PCI_SS_M64:

 Status = AmlCodeGenRdQWordMemory (

FALSE,

-   TRUE,

+   IsPosDecode,

TRUE,

TRUE,

TRUE,

@@ -665,7 +671,7 @@ GeneratePciCrs (

0,

AddrMapInfo->PciAddress,

AddrMapInfo->PciAddress + AddrMapInfo->AddressSize - 1,

-   Translation ? AddrMapInfo->CpuAddress : 0,

+   Translation ? AddrMapInfo->CpuAddress - 
AddrMapInfo->PciAddress : 0,

AddrMapInfo->AddressSize,

0,

NULL,

-- 

2.25.1





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91192): https://edk2.groups.io/g/devel/message/91192
Mute This Topic: https://groups.io/mt/92260870/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH v3 2/3] DynamicTablesPkg: AcpiSsdtPcieLibArm: Support UID > 0xF

2022-07-08 Thread Jeff Brasen via groups.io 
Add support for PCIe devices with UID > 0xF.
This is done by using the next value in the name so
PCI5, PC26, etc

Signed-off-by: Jeff Brasen 
---
 .../Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c  | 5 -
 .../Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.h  | 2 +-
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git 
a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c 
b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c
index d4c5f47b07..68ecae96be 100644
--- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c
+++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c
@@ -824,7 +824,10 @@ GeneratePciDevice (
 
   // Write the name of the PCI device.
   CopyMem (AslName, "PCIx", AML_NAME_SEG_SIZE + 1);
-  AslName[AML_NAME_SEG_SIZE - 1] = AsciiFromHex (Uid);
+  AslName[AML_NAME_SEG_SIZE - 1] = AsciiFromHex (Uid & 0xF);
+  if (Uid > 0xF) {
+AslName[AML_NAME_SEG_SIZE - 2] = AsciiFromHex ((Uid >> 4) & 0xF);
+  }
 
   // ASL: Device (PCIx) {}
   Status = AmlCodeGenDevice (AslName, ScopeNode, &PciNode);
diff --git 
a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.h 
b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.h
index 59a0d601a3..515a3e1785 100644
--- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.h
+++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.h
@@ -31,7 +31,7 @@
 Corresponding changes would be needed to support the Name and
 UID fields describing the Pci root complexes.
 */
-#define MAX_PCI_ROOT_COMPLEXES_SUPPORTED  16
+#define MAX_PCI_ROOT_COMPLEXES_SUPPORTED  256
 
 // _SB scope of the AML namespace.
 #define SB_SCOPE  "\\_SB_"
-- 
2.25.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91194): https://edk2.groups.io/g/devel/message/91194
Mute This Topic: https://groups.io/mt/92260872/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH v3 3/3] DynamicTablesPkg: AcpiSsdtPcieLibArm: Create support library

2022-07-08 Thread Jeff Brasen via groups.io 
Add support library to allow for customization of _OSC and slot info.

The functions in the library are unchanged,

with the exception of adding PciInfo pointer to the APIs.



Signed-off-by: Jeff Brasen 

---

 .../Include/Library/SsdtPcieSupportLib.h  |  73 +++

 .../AcpiSsdtPcieLibArm/SsdtPcieGenerator.c| 168 +--

 .../AcpiSsdtPcieLibArm/SsdtPcieGenerator.h|  15 --

 .../Arm/AcpiSsdtPcieLibArm/SsdtPcieLibArm.inf |   2 +-

 .../SsdtPcieOscTemplate.asl   |   0

 .../SsdtPcieSupportLib/SsdtPcieSupportLib.c   | 200 ++

 .../SsdtPcieSupportLib/SsdtPcieSupportLib.inf |  30 +++

 .../SsdtPcieSupportLibPrivate.h   |  25 +++

 8 files changed, 332 insertions(+), 181 deletions(-)

 create mode 100644 DynamicTablesPkg/Include/Library/SsdtPcieSupportLib.h

 rename DynamicTablesPkg/Library/{Acpi/Arm/AcpiSsdtPcieLibArm => 
Common/SsdtPcieSupportLib}/SsdtPcieOscTemplate.asl (100%)

 create mode 100644 
DynamicTablesPkg/Library/Common/SsdtPcieSupportLib/SsdtPcieSupportLib.c

 create mode 100644 
DynamicTablesPkg/Library/Common/SsdtPcieSupportLib/SsdtPcieSupportLib.inf

 create mode 100644 
DynamicTablesPkg/Library/Common/SsdtPcieSupportLib/SsdtPcieSupportLibPrivate.h



diff --git a/DynamicTablesPkg/Include/Library/SsdtPcieSupportLib.h 
b/DynamicTablesPkg/Include/Library/SsdtPcieSupportLib.h

new file mode 100644

index 00..f65431ef28

--- /dev/null

+++ b/DynamicTablesPkg/Include/Library/SsdtPcieSupportLib.h

@@ -0,0 +1,73 @@

+/** @file

+  Ssdt PCie Support Library

+

+  Copyright (c) 2021 - 2022, Arm Limited. All rights reserved.

+

+  SPDX-License-Identifier: BSD-2-Clause-Patent

+**/

+

+#ifndef SSDT_PCIE_SUPPORT_LIB_H_

+#define SSDT_PCIE_SUPPORT_LIB_H_

+

+#pragma pack(1)

+

+/** Structure used to map integer to an index.

+*/

+typedef struct MappingTable {

+  /// Mapping table.

+  /// Contains the Index <-> integer mapping

+  UINT32*Table;

+

+  /// Last used index of the Table.

+  /// Bound by MaxIndex.

+  UINT32LastIndex;

+

+  /// Number of entries in the Table.

+  UINT32MaxIndex;

+} MAPPING_TABLE;

+

+#pragma pack()

+

+/** Add an _OSC template method to the PciNode.

+

+  The _OSC method is provided as an AML blob. The blob is

+  parsed and attached at the end of the PciNode list of variable elements.

+

+  @param [in]   PciInfo Pci device information.

+  @param [in, out]  PciNode Pci node to amend.

+

+  @retval EFI_SUCCESS The function completed successfully.

+  @retval EFI_INVALID_PARAMETER   Invalid parameter.

+  @retval EFI_OUT_OF_RESOURCESCould not allocate memory.

+**/

+EFI_STATUS

+EFIAPI

+AddOscMethod (

+  IN  CONST CM_ARM_PCI_CONFIG_SPACE_INFO  *PciInfo,

+  IN  OUT   AML_OBJECT_NODE_HANDLEPciNode

+  );

+

+/** Generate Pci slots devices.

+

+  PCI Firmware Specification - Revision 3.3,

+  s4.8 "Generic ACPI PCI Slot Description" requests to describe the PCI slot

+  used. It should be possible to enumerate them, but this is additional

+  information.

+

+  @param [in]   PciInfo Pci device information.

+  @param [in]  MappingTable The mapping table structure.

+  @param [in, out]  PciNode Pci node to amend.

+

+  @retval EFI_SUCCESSSuccess.

+  @retval EFI_INVALID_PARAMETER  Invalid parameter.

+  @retval EFI_OUT_OF_RESOURCES   Failed to allocate memory.

+**/

+EFI_STATUS

+EFIAPI

+GeneratePciSlots (

+  IN  CONST CM_ARM_PCI_CONFIG_SPACE_INFO  *PciInfo,

+  IN  CONST MAPPING_TABLE *MappingTable,

+  IN  OUT   AML_OBJECT_NODE_HANDLEPciNode

+  );

+

+#endif // SSDT_PCIE_SUPPORT_LIB_H_

diff --git 
a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c 
b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c

index 68ecae96be..62cec3753c 100644

--- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c

+++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c

@@ -29,6 +29,7 @@

 #include 

 #include 

 #include 

+#include 

 #include 

 

 #include "SsdtPcieGenerator.h"

@@ -280,86 +281,6 @@ GeneratePciDeviceInfo (

   return Status;

 }

 

-/** Generate Pci slots devices.

-

-  PCI Firmware Specification - Revision 3.3,

-  s4.8 "Generic ACPI PCI Slot Description" requests to describe the PCI slot

-  used. It should be possible to enumerate them, but this is additional

-  information.

-

-  @param [in]  MappingTable  The mapping table structure.

-  @param [in, out]  PciNode Pci node to amend.

-

-  @retval EFI_SUCCESSSuccess.

-  @retval EFI_INVALID_PARAMETER  Invalid parameter.

-  @retval EFI_OUT_OF_RESOURCES   Failed to allocate memory.

-**/

-STATIC

-EFI_STATUS

-EFIAPI

-GeneratePciSlots (

-  IN  CONST MAPPING_TABLE   *MappingTable,

-  IN  OUT   AML_OBJECT_NODE_HANDLE  PciNode

-  )

-{

-  EFI_STATUS  Status;

-  UINT32

[edk2-devel] [edk2-platforms][PATCH v1 0/7] Resolving SecureBootVariableLib dependency

2022-07-08 Thread Kun Qin 
The new changes in SecureBootVariableLib brought in a new dependency
of PlatformPKProtectionLib.

This patch series added the new library instance from SecurityPkg to
resolve edk2 platforms build.

Patch v1 branch: https://github.com/kuqin12/edk2-platforms/tree/fix_sb_dep

Cc: Ard Biesheuvel 
Cc: Leif Lindholm 
Cc: Graeme Gregory 
Cc: Radoslaw Biernacki 
Cc: Masami Hiramatsu 
Cc: Nhi Pham 
Cc: Vu Nguyen 
Cc: Thang Nguyen 
Cc: Chuong Tran 
Cc: Thomas Abraham 
Cc: Sami Mujawar 
Cc: Abner Chang 
Cc: Gilbert Chen 
Cc: Daniel Schaefer 
Cc: Jeremy Linton 
Cc: Peng Xie 
Cc: Ling Jia 
Cc: Yiqi Shu 

Kun Qin (7):
  RaspberryPi: Pipeline: Resolving newly introduced dependency
  U5SeriesPkg: Pipeline: Resolving newly introduced dependency
  VExpressPkg: Pipeline: Resolving newly introduced dependency
  Qemu: Pipeline: Resolving newly introduced dependency
  Socionext: Pipeline: Resolving newly introduced dependency
  AmpereAltraPkg: Pipeline: Resolving newly introduced dependency
  PhytiumCommonPkg: Pipeline: Resolving newly introduced dependency

 Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 1 +
 Platform/Qemu/SbsaQemu/SbsaQemu.dsc  | 1 +
 Platform/RaspberryPi/RPi3/RPi3.dsc   | 1 +
 Platform/RaspberryPi/RPi4/RPi4.dsc   | 1 +
 Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc   | 1 +
 Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc | 1 +
 Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 1 +
 Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc | 1 +
 Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc| 1 +
 9 files changed, 9 insertions(+)

-- 
2.37.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91195): https://edk2.groups.io/g/devel/message/91195
Mute This Topic: https://groups.io/mt/92260955/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [edk2-platforms][PATCH v1 1/7] RaspberryPi: Pipeline: Resolving newly introduced dependency

2022-07-08 Thread Kun Qin 
The new changes in SecureBootVariableLib brought in a new dependency
of PlatformPKProtectionLib.

This change added the new library instance from SecurityPkg to resolve
RaspberryPi platforms build.

Cc: Ard Biesheuvel 
Cc: Leif Lindholm 
Cc: Jeremy Linton 

Signed-off-by: Kun Qin 
---
 Platform/RaspberryPi/RPi3/RPi3.dsc | 1 +
 Platform/RaspberryPi/RPi4/RPi4.dsc | 1 +
 2 files changed, 2 insertions(+)

diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc 
b/Platform/RaspberryPi/RPi3/RPi3.dsc
index 0eed03c097f8..4e7377a00036 100644
--- a/Platform/RaspberryPi/RPi3/RPi3.dsc
+++ b/Platform/RaspberryPi/RPi3/RPi3.dsc
@@ -169,6 +169,7 @@ [LibraryClasses.common]
   PlatformSecureLib|OvmfPkg/Library/PlatformSecureLib/PlatformSecureLib.inf
   
SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf
   
SecureBootVariableProvisionLib|SecurityPkg/Library/SecureBootVariableProvisionLib/SecureBootVariableProvisionLib.inf
+  
PlatformPKProtectionLib|SecurityPkg/Library/PlatformPKProtectionLibVarPolicy/PlatformPKProtectionLibVarPolicy.inf
 !else
   
TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf
   
AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf
diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc 
b/Platform/RaspberryPi/RPi4/RPi4.dsc
index eabddd7382cf..8ba0ca61851e 100644
--- a/Platform/RaspberryPi/RPi4/RPi4.dsc
+++ b/Platform/RaspberryPi/RPi4/RPi4.dsc
@@ -166,6 +166,7 @@ [LibraryClasses.common]
   AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf
   
SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf
   
SecureBootVariableProvisionLib|SecurityPkg/Library/SecureBootVariableProvisionLib/SecureBootVariableProvisionLib.inf
+  
PlatformPKProtectionLib|SecurityPkg/Library/PlatformPKProtectionLibVarPolicy/PlatformPKProtectionLibVarPolicy.inf
 
   # re-use the UserPhysicalPresent() dummy implementation from the ovmf tree
   PlatformSecureLib|OvmfPkg/Library/PlatformSecureLib/PlatformSecureLib.inf
-- 
2.37.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91196): https://edk2.groups.io/g/devel/message/91196
Mute This Topic: https://groups.io/mt/92260958/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [edk2-platforms][PATCH v1 3/7] VExpressPkg: Pipeline: Resolving newly introduced dependency

2022-07-08 Thread Kun Qin 
The new changes in SecureBootVariableLib brought in a new dependency
of PlatformPKProtectionLib.

This change added the new library instance from SecurityPkg to resolve
ArmVExpress platforms build.

Cc: Ard Biesheuvel 
Cc: Thomas Abraham 
Cc: Sami Mujawar 

Signed-off-by: Kun Qin 
---
 Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc 
b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc
index e637f8933f79..17e4a3fd13d7 100644
--- a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc
+++ b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc
@@ -143,6 +143,7 @@ [LibraryClasses.common]
   AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf
   
SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf
   
SecureBootVariableProvisionLib|SecurityPkg/Library/SecureBootVariableProvisionLib/SecureBootVariableProvisionLib.inf
+  
PlatformPKProtectionLib|SecurityPkg/Library/PlatformPKProtectionLibVarPolicy/PlatformPKProtectionLibVarPolicy.inf
 
   # re-use the UserPhysicalPresent() dummy implementation from the ovmf tree
   PlatformSecureLib|OvmfPkg/Library/PlatformSecureLib/PlatformSecureLib.inf
-- 
2.37.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91198): https://edk2.groups.io/g/devel/message/91198
Mute This Topic: https://groups.io/mt/92260960/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [edk2-platforms][PATCH v1 2/7] U5SeriesPkg: Pipeline: Resolving newly introduced dependency

2022-07-08 Thread Kun Qin 
The new changes in SecureBootVariableLib brought in a new dependency
of PlatformPKProtectionLib.

This change added the new library instance from SecurityPkg to resolve
U5SeriesPkg platforms build.

Cc: Abner Chang 
Cc: Gilbert Chen 
Cc: Daniel Schaefer 

Signed-off-by: Kun Qin 
---
 Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc   | 1 +
 Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc | 1 +
 2 files changed, 2 insertions(+)

diff --git a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc 
b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
index 7b36b2c885e0..fc1ed012a541 100644
--- a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
+++ b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
@@ -127,6 +127,7 @@ [LibraryClasses]
   AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf
   
SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf
   
SecureBootVariableProvisionLib|SecurityPkg/Library/SecureBootVariableProvisionLib/SecureBootVariableProvisionLib.inf
+  
PlatformPKProtectionLib|SecurityPkg/Library/PlatformPKProtectionLibVarPolicy/PlatformPKProtectionLibVarPolicy.inf
 !else
   
TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf
   
AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf
diff --git 
a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc 
b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc
index 26895a75ec2f..e59955d09452 100644
--- a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc
+++ b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc
@@ -127,6 +127,7 @@ [LibraryClasses]
   AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf
   
SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf
   
SecureBootVariableProvisionLib|SecurityPkg/Library/SecureBootVariableProvisionLib/SecureBootVariableProvisionLib.inf
+  
PlatformPKProtectionLib|SecurityPkg/Library/PlatformPKProtectionLibVarPolicy/PlatformPKProtectionLibVarPolicy.inf
 !else
   
TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf
   
AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf
-- 
2.37.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91197): https://edk2.groups.io/g/devel/message/91197
Mute This Topic: https://groups.io/mt/92260959/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [edk2-platforms][PATCH v1 6/7] AmpereAltraPkg: Pipeline: Resolving newly introduced dependency

2022-07-08 Thread Kun Qin 
The new changes in SecureBootVariableLib brought in a new dependency
of PlatformPKProtectionLib.

This change added the new library instance from SecurityPkg to resolve
AmpereAltraPkg platforms build.

Cc: Nhi Pham 
Cc: Vu Nguyen 
Cc: Thang Nguyen 
Cc: Chuong Tran 
Cc: Leif Lindholm 

Signed-off-by: Kun Qin 
---
 Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc 
b/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc
index f4007d654ec8..f2c991b6aa6d 100644
--- a/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc
+++ b/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc
@@ -144,6 +144,7 @@ [LibraryClasses.common]
   BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf
   
SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf
   
SecureBootVariableProvisionLib|SecurityPkg/Library/SecureBootVariableProvisionLib/SecureBootVariableProvisionLib.inf
+  
PlatformPKProtectionLib|SecurityPkg/Library/PlatformPKProtectionLibVarPolicy/PlatformPKProtectionLibVarPolicy.inf
 
   #
   # re-use the UserPhysicalPresent() dummy implementation from the ovmf tree
-- 
2.37.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91201): https://edk2.groups.io/g/devel/message/91201
Mute This Topic: https://groups.io/mt/92260967/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [edk2-platforms][PATCH v1 5/7] Socionext: Pipeline: Resolving newly introduced dependency

2022-07-08 Thread Kun Qin 
The new changes in SecureBootVariableLib brought in a new dependency
of PlatformPKProtectionLib.

This change added the new library instance from SecurityPkg to resolve
DeveloperBox platforms build.

Cc: Ard Biesheuvel 
Cc: Leif Lindholm 
Cc: Masami Hiramatsu 

Signed-off-by: Kun Qin 
---
 Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc 
b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
index 8419c89318fb..917c1532fb3c 100644
--- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
+++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
@@ -55,6 +55,7 @@ [LibraryClasses]
 !if $(SECURE_BOOT_ENABLE) == TRUE
   
SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf
   
SecureBootVariableProvisionLib|SecurityPkg/Library/SecureBootVariableProvisionLib/SecureBootVariableProvisionLib.inf
+  
PlatformPKProtectionLib|SecurityPkg/Library/PlatformPKProtectionLibVarPolicy/PlatformPKProtectionLibVarPolicy.inf
 !endif
 
 [LibraryClasses.common.SEC]
-- 
2.37.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91200): https://edk2.groups.io/g/devel/message/91200
Mute This Topic: https://groups.io/mt/92260963/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [edk2-platforms][PATCH v1 4/7] Qemu: Pipeline: Resolving newly introduced dependency

2022-07-08 Thread Kun Qin 
The new changes in SecureBootVariableLib brought in a new dependency
of PlatformPKProtectionLib.

This change added the new library instance from SecurityPkg to resolve
SbsaQemu platform builds.

Cc: Ard Biesheuvel 
Cc: Leif Lindholm 
Cc: Graeme Gregory 
Cc: Radoslaw Biernacki 

Signed-off-by: Kun Qin 
---
 Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc 
b/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
index 97014e2fb630..c912424173a6 100644
--- a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
+++ b/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
@@ -158,6 +158,7 @@ [LibraryClasses.common]
   AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf
   
SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf
   
SecureBootVariableProvisionLib|SecurityPkg/Library/SecureBootVariableProvisionLib/SecureBootVariableProvisionLib.inf
+  
PlatformPKProtectionLib|SecurityPkg/Library/PlatformPKProtectionLibVarPolicy/PlatformPKProtectionLibVarPolicy.inf
 
   # re-use the UserPhysicalPresent() dummy implementation from the ovmf tree
   PlatformSecureLib|OvmfPkg/Library/PlatformSecureLib/PlatformSecureLib.inf
-- 
2.37.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91199): https://edk2.groups.io/g/devel/message/91199
Mute This Topic: https://groups.io/mt/92260961/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [edk2-platforms][PATCH v1 7/7] PhytiumCommonPkg: Pipeline: Resolving newly introduced dependency

2022-07-08 Thread Kun Qin 
The new changes in SecureBootVariableLib brought in a new dependency
of PlatformPKProtectionLib.

This change added the new library instance from SecurityPkg to resolve
PhytiumCommonPkg platforms build.

Cc: Leif Lindholm 
Cc: Peng Xie 
Cc: Ling Jia 
Cc: Yiqi Shu 

Signed-off-by: Kun Qin 
---
 Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc 
b/Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc
index 2565b8ac626a..42fe2a5c2246 100644
--- a/Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc
+++ b/Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc
@@ -83,6 +83,7 @@ [LibraryClasses.common]
   SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.inf
   
SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf
   
SecureBootVariableProvisionLib|SecurityPkg/Library/SecureBootVariableProvisionLib/SecureBootVariableProvisionLib.inf
+  
PlatformPKProtectionLib|SecurityPkg/Library/PlatformPKProtectionLibVarPolicy/PlatformPKProtectionLibVarPolicy.inf
 
   TimerLib|ArmPkg/Library/ArmArchTimerLib/ArmArchTimerLib.inf
   
TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf
-- 
2.37.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91202): https://edk2.groups.io/g/devel/message/91202
Mute This Topic: https://groups.io/mt/92260969/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-