Re: PSA: MOZ_OVERRIDE and MOZ_FINAL are gone
On 22/03/2015 00:37, Ehsan Akhgari wrote: > I just landed bug 1145631, which removes the MOZ_OVERRIDE and MOZ_FINAL > macros. Please use the override and final keywords from now on. > > Cheers, http://mxr.mozilla.org/comm-central/search?string=MOZ_FINAL Too many hits, displaying the first 1000 http://mxr.mozilla.org/comm-central/search?string=MOZ_OVERRIDE Too many hits, displaying the first 1000 Phil -- Philip Chee , http://flashblock.mozdev.org/ http://xsidebar.mozdev.org Guard us from the she-wolf and the wolf, and guard us from the thief, oh Night, and so be good for us to pass. ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: PSA: MOZ_OVERRIDE and MOZ_FINAL are gone
On Sun, Mar 22, 2015 at 03:03:32PM +0800, Philip Chee wrote: > On 22/03/2015 00:37, Ehsan Akhgari wrote: > > I just landed bug 1145631, which removes the MOZ_OVERRIDE and > > MOZ_FINAL macros. Please use the override and final keywords from > > now on. > > > > Cheers, > > http://mxr.mozilla.org/comm-central/search?string=MOZ_FINAL Too many > hits, displaying the first 1000 > > http://mxr.mozilla.org/comm-central/search?string=MOZ_OVERRIDE Too > many hits, displaying the first 1000 Not sure what you're trying to say here. If it's about bug 1146094, be aware that comm-central mxr search also returns matches for mozilla-central, and that since bug 1145631 is not merged to mozilla-central yet, well, most matches still come from there (and even when it is merged, there's a delay between something reaching m-c and mxr/dxr being updated) Grep tells me there are 52 MOZ_FINAL and 805 MOZ_OVERRIDE in comm-central. Mike ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: PSA: MOZ_OVERRIDE and MOZ_FINAL are gone
Are the override and final keywords available only in Gecko 39 onwards, or can we assume that these keywords will work in earlier branches? For example, say I have a patch using these keywords that needs to be uplifted to Aurora or Beta, should I use the old macros in the uplifted patch and not in the mozilla-central patch? Cheers, Chris. On Sunday, March 22, 2015 at 5:38:53 AM UTC+13, Ehsan Akhgari wrote: > I just landed bug 1145631, which removes the MOZ_OVERRIDE and MOZ_FINAL > macros. Please use the override and final keywords from now on. > > Cheers, > -- > Ehsan ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: PSA: MOZ_OVERRIDE and MOZ_FINAL are gone
On Sun, Mar 22, 2015 at 8:43 AM, wrote: > > Are the override and final keywords available only in Gecko 39 onwards, or can we assume that these keywords will work in earlier branches? > > For example, say I have a patch using these keywords that needs to be uplifted to Aurora or Beta, should I use the old macros in the uplifted patch and not in the mozilla-central patch? We're officially dropping support for gcc-4.6 in Gecko 38, so uplifting to there should be fine. We should use the old macros for 37. Cheers, Bob ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: PSA: MOZ_OVERRIDE and MOZ_FINAL are gone
On 2015-03-22 3:03 AM, Philip Chee wrote: On 22/03/2015 00:37, Ehsan Akhgari wrote: I just landed bug 1145631, which removes the MOZ_OVERRIDE and MOZ_FINAL macros. Please use the override and final keywords from now on. Cheers, http://mxr.mozilla.org/comm-central/search?string=MOZ_FINAL Too many hits, displaying the first 1000 http://mxr.mozilla.org/comm-central/search?string=MOZ_OVERRIDE Too many hits, displaying the first 1000 https://hg.mozilla.org/comm-central/rev/94adb5945ec3 ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
