[GitHub] [zeppelin] huage1994 commented on pull request #4392: [ZEPPELIN-5694] Support apache kyuubi

2022-07-09 Thread GitBox


huage1994 commented on PR #4392:
URL: https://github.com/apache/zeppelin/pull/4392#issuecomment-1179534988

   Hi all!  
   I have updated the doc for the review of @pan3793 .
   
   And  though we now use `KyuubiHiveDriver`,  I found the following code still 
relies on `HiveDriver`.
   ```
 if (jdbcURL != null && jdbcURL.startsWith("jdbc:hive2://")) {
   HiveUtils.startHiveMonitorThread(statement, context,
   Boolean.parseBoolean(getProperty("hive.log.display", 
"true")), this);
 }
   ```
   
   I would fix this problem.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [zeppelin] naveensrinivasan commented on pull request #4386: chore: Set permissions for GitHub actions

2022-07-09 Thread GitBox


naveensrinivasan commented on PR #4386:
URL: https://github.com/apache/zeppelin/pull/4386#issuecomment-1179591269

   @jongyoul Is there anything else required to merge this? Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org