Re: Help Verify Apache(incubating) TVM Release RC
Hi, I’ve not had an extensive look but I note this license in your license file: LLVM Release License While a BSD style license (I think) it not listen in Apaches list of compatible licenses. You’ll also note it include other 3rd party licensed buts of software, these would need to be checked if they are compatible with ALv2 and listed in the LICENSE file if your include any code under those licenses. I's also suggest you use the work in progress DISCLAIMER [1], as it more likely your first release will pass an IPMC votes if you do so. Thanks, Justin 1. https://incubator.apache.org/policy/incubation.html#disclaimers - To unsubscribe, e-mail: dev-unsubscr...@tvm.apache.org For additional commands, e-mail: dev-h...@tvm.apache.org
Re: Help Verify Apache(incubating) TVM Release RC
Thanks Justin! This is exactly kind of feedback we are looking for. The community would like to hold the release to the highest possible standard, which means we would like to make sure the release meet the criteria of the standard disclaimer. We will look into the compatibility issue of LLVM license. TQ On Sat, Nov 23, 2019 at 12:04 AM Justin Mclean wrote: > Hi, > > I’ve not had an extensive look but I note this license in your license > file: > LLVM Release License > > While a BSD style license (I think) it not listen in Apaches list of > compatible licenses. You’ll also note it include other 3rd party licensed > buts of software, these would need to be checked if they are compatible > with ALv2 and listed in the LICENSE file if your include any code under > those licenses. > > I's also suggest you use the work in progress DISCLAIMER [1], as it more > likely your first release will pass an IPMC votes if you do so. > > Thanks, > Justin > > 1. https://incubator.apache.org/policy/incubation.html#disclaimers > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
Re: [apache/incubator-tvm] [DEV][DRAFT] TVM v0.6 Release candidate (#4259)
@tqchen , @yzhliu - please send request to review release candidate to dev@ list for TVM because not everyone probably subscribe or follow the Github repo list. Before going to general@ list, let's vet and review the release candidate in the podling community to reduce the noise in the channel. Thanks -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/apache/incubator-tvm/issues/4259#issuecomment-557824121
Re: [apache/incubator-tvm] [DEV][DRAFT] TVM v0.6 Release candidate (#4259)
Thanks Henry This thread is already on dev@ :) — all github thread with RFC and DEV tags are automatically mirrored at dev@ -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/apache/incubator-tvm/issues/4259#issuecomment-557824758
Re: [apache/incubator-tvm] [DEV][DRAFT] TVM v0.6 Release candidate (#4259)
To further reduce the noise for our ASF PMC members and mentors, I would recommend future tag release related thread with [RELEASE] prefix, so our those who only want to watch related thread can setup email filter to watch this prefix -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/apache/incubator-tvm/issues/4259#issuecomment-557825521
Re: Help Verify Apache(incubating) TVM Release RC
Hi, I checked the release candidate further: - Signatures and hashes good - DISCLAIMER exists - LICENSE is missing a few things - NOTICE needs some minor adjustments - Some files are missing ASF headers e.g. [1][2][3][4][5] (+ others) - Some files incorrectly have an ASF headers or have ASF lines with a unneeded copyright line. e.g [6][7][8][9][10][11] and many many other files. - No unexpected binary files You'll need to remove all "Copyright (c) by Contributors” where the files were donated to the ASF (and there’s signed ICLAS for everyone that worked on that file) so it clear what is a 3rd party file and what is not. Because of the above issue it impossible to work out what is missing in LICENCE, this will be a subset: - Code zlib licensed in [6] - BSD code in [9] (this is not ALv2 likened as mentioned the LICENSE file) - ASv2 licensed code in [11] - BSD code in [12] In NOTICE is incorrect to say “2017 and onwards”, it should just be 2019. Thanks, Justin 1. ./nnvm/tests/cpp/unittest.mk 2. ./nnvm/make/config.mk 3. ./ docs/_static/css/tvm_theme.css 4. apps/android_rpc/app/src/main/jni/Android.mk 5. apps/ios_rpc/tvmrpc/Base.lproj/LaunchScreen.storyboard 6. /nnvm/include/nnvm/op.h 7. ./src/schedule/bound.cc 8. ./src/schedule/bound.cc 9. vi ./3rdparty/picojson/picojson.h 10. ./vta/src/de10nano/cma_api.cc 11. /3rdparty/compiler-rt/builtin_fp16.h 12. ./3rdparty/dmlc-core/include/dmlc/concurrentqueue.h - To unsubscribe, e-mail: dev-unsubscr...@tvm.apache.org For additional commands, e-mail: dev-h...@tvm.apache.org
Re: Help Verify Apache(incubating) TVM Release RC
Thanks Justin for helping, we'll make modification accordingly. On Sat, Nov 23, 2019 at 2:15 PM Justin Mclean wrote: > > Hi, > > I checked the release candidate further: > - Signatures and hashes good > - DISCLAIMER exists > - LICENSE is missing a few things > - NOTICE needs some minor adjustments > - Some files are missing ASF headers e.g. [1][2][3][4][5] (+ others) > - Some files incorrectly have an ASF headers or have ASF lines with a > unneeded copyright line. e.g [6][7][8][9][10][11] and many many other files. > - No unexpected binary files > > You'll need to remove all "Copyright (c) by Contributors” where the > files were donated to the ASF (and there’s signed ICLAS for everyone that > worked on that file) so it clear what is a 3rd party file and what is not. > > Because of the above issue it impossible to work out what is missing in > LICENCE, this will be a subset: > - Code zlib licensed in [6] > - BSD code in [9] (this is not ALv2 likened as mentioned the LICENSE file) > - ASv2 licensed code in [11] > - BSD code in [12] > > In NOTICE is incorrect to say “2017 and onwards”, it should just be 2019. > > Thanks, > Justin > > 1. ./nnvm/tests/cpp/unittest.mk > 2. ./nnvm/make/config.mk > 3. ./ docs/_static/css/tvm_theme.css > 4. apps/android_rpc/app/src/main/jni/Android.mk > 5. apps/ios_rpc/tvmrpc/Base.lproj/LaunchScreen.storyboard > 6. /nnvm/include/nnvm/op.h > 7. ./src/schedule/bound.cc > 8. ./src/schedule/bound.cc > 9. vi ./3rdparty/picojson/picojson.h > 10. ./vta/src/de10nano/cma_api.cc > 11. /3rdparty/compiler-rt/builtin_fp16.h > 12. ./3rdparty/dmlc-core/include/dmlc/concurrentqueue.h > > > - > To unsubscribe, e-mail: dev-unsubscr...@tvm.apache.org > For additional commands, e-mail: dev-h...@tvm.apache.org > -- Yizhi Liu - To unsubscribe, e-mail: dev-unsubscr...@tvm.apache.org For additional commands, e-mail: dev-h...@tvm.apache.org
Re: Help Verify Apache(incubating) TVM Release RC
Hi Justin, for ./3rdparty/compiler-rt/builtin_fp16.h , from [here](https://github.com/llvm-mirror/compiler-rt/blob/master/LICENSE.TXT#L240-L241) it says it was dual licensed under University of Illinois and the MIT license, though the current LICENSE file declares ALv2. I believe the builtin_fp16.h file was collected before its license be changed to ALv2. Shall we say it is ALv2, or MIT? And would you mind advise what was wrong with the following files? 6. /nnvm/include/nnvm/op.h - looks zlib is not used there? 7 ./src/schedule/bound.cc On Sat, Nov 23, 2019 at 2:54 PM YiZhi Liu wrote: > > Thanks Justin for helping, we'll make modification accordingly. > > On Sat, Nov 23, 2019 at 2:15 PM Justin Mclean > wrote: > > > > Hi, > > > > I checked the release candidate further: > > - Signatures and hashes good > > - DISCLAIMER exists > > - LICENSE is missing a few things > > - NOTICE needs some minor adjustments > > - Some files are missing ASF headers e.g. [1][2][3][4][5] (+ others) > > - Some files incorrectly have an ASF headers or have ASF lines with a > > unneeded copyright line. e.g [6][7][8][9][10][11] and many many other files. > > - No unexpected binary files > > > > You'll need to remove all "Copyright (c) by Contributors” where the > > files were donated to the ASF (and there’s signed ICLAS for everyone that > > worked on that file) so it clear what is a 3rd party file and what is not. > > > > Because of the above issue it impossible to work out what is missing in > > LICENCE, this will be a subset: > > - Code zlib licensed in [6] > > - BSD code in [9] (this is not ALv2 likened as mentioned the LICENSE file) > > - ASv2 licensed code in [11] > > - BSD code in [12] > > > > In NOTICE is incorrect to say “2017 and onwards”, it should just be 2019. > > > > Thanks, > > Justin > > > > 1. ./nnvm/tests/cpp/unittest.mk > > 2. ./nnvm/make/config.mk > > 3. ./ docs/_static/css/tvm_theme.css > > 4. apps/android_rpc/app/src/main/jni/Android.mk > > 5. apps/ios_rpc/tvmrpc/Base.lproj/LaunchScreen.storyboard > > 6. /nnvm/include/nnvm/op.h > > 7. ./src/schedule/bound.cc > > 8. ./src/schedule/bound.cc > > 9. vi ./3rdparty/picojson/picojson.h > > 10. ./vta/src/de10nano/cma_api.cc > > 11. /3rdparty/compiler-rt/builtin_fp16.h > > 12. ./3rdparty/dmlc-core/include/dmlc/concurrentqueue.h > > > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@tvm.apache.org > > For additional commands, e-mail: dev-h...@tvm.apache.org > > > > > -- > Yizhi Liu -- Yizhi Liu Bay Area, the United States - To unsubscribe, e-mail: dev-unsubscr...@tvm.apache.org For additional commands, e-mail: dev-h...@tvm.apache.org
Re: Help Verify Apache(incubating) TVM Release RC
Re LLVM’s license issue. I believe MIT is a safer choice for compiler-rt before we confirm with ASF. Because strictly LLVM’s apache license comes with an exemption Clause which needs to be reviewed. Given that the code is also dual licensed under MIT, we should take that as a safer choice until we get official position from the ASF wrt to the exemption TQ On Sat, Nov 23, 2019 at 4:39 PM YiZhi Liu wrote: > Hi Justin, > > for ./3rdparty/compiler-rt/builtin_fp16.h , from > [here]( > https://github.com/llvm-mirror/compiler-rt/blob/master/LICENSE.TXT#L240-L241 > ) > it says it was dual licensed under University of Illinois and the MIT > license, though the current LICENSE file declares ALv2. I believe the > builtin_fp16.h file was collected before its license be changed to > ALv2. Shall we say it is ALv2, or MIT? > > And would you mind advise what was wrong with the following files? > 6. /nnvm/include/nnvm/op.h - looks zlib is not used there? > 7 ./src/schedule/bound.cc > > On Sat, Nov 23, 2019 at 2:54 PM YiZhi Liu wrote: > > > > Thanks Justin for helping, we'll make modification accordingly. > > > > On Sat, Nov 23, 2019 at 2:15 PM Justin Mclean > wrote: > > > > > > Hi, > > > > > > I checked the release candidate further: > > > - Signatures and hashes good > > > - DISCLAIMER exists > > > - LICENSE is missing a few things > > > - NOTICE needs some minor adjustments > > > - Some files are missing ASF headers e.g. [1][2][3][4][5] (+ others) > > > - Some files incorrectly have an ASF headers or have ASF lines with a > unneeded copyright line. e.g [6][7][8][9][10][11] and many many other files. > > > - No unexpected binary files > > > > > > You'll need to remove all "Copyright (c) by Contributors” where > the files were donated to the ASF (and there’s signed ICLAS for everyone > that worked on that file) so it clear what is a 3rd party file and what is > not. > > > > > > Because of the above issue it impossible to work out what is missing > in LICENCE, this will be a subset: > > > - Code zlib licensed in [6] > > > - BSD code in [9] (this is not ALv2 likened as mentioned the LICENSE > file) > > > - ASv2 licensed code in [11] > > > - BSD code in [12] > > > > > > In NOTICE is incorrect to say “2017 and onwards”, it should just be > 2019. > > > > > > Thanks, > > > Justin > > > > > > 1. ./nnvm/tests/cpp/unittest.mk > > > 2. ./nnvm/make/config.mk > > > 3. ./ docs/_static/css/tvm_theme.css > > > 4. apps/android_rpc/app/src/main/jni/Android.mk > > > 5. apps/ios_rpc/tvmrpc/Base.lproj/LaunchScreen.storyboard > > > 6. /nnvm/include/nnvm/op.h > > > 7. ./src/schedule/bound.cc > > > 8. ./src/schedule/bound.cc > > > 9. vi ./3rdparty/picojson/picojson.h > > > 10. ./vta/src/de10nano/cma_api.cc > > > 11. /3rdparty/compiler-rt/builtin_fp16.h > > > 12. ./3rdparty/dmlc-core/include/dmlc/concurrentqueue.h > > > > > > > > > - > > > To unsubscribe, e-mail: dev-unsubscr...@tvm.apache.org > > > For additional commands, e-mail: dev-h...@tvm.apache.org > > > > > > > > > -- > > Yizhi Liu > > > > -- > Yizhi Liu > Bay Area, the United States > > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
Re: [apache/incubator-tvm] [DEV][DRAFT] TVM v0.6 Release candidate (#4259)
Thanks, @tqchen, Yes, I just noticed the emails also sent to dev@ list too :+1: -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/apache/incubator-tvm/issues/4259#issuecomment-557856274
Re: [apache/incubator-tvm] [RFC] Auto TensorCore CodeGen (#4105)
Closed #4105. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/apache/incubator-tvm/issues/4105#event-2825758382
