Re: JavaHL problem with NativeException
On 27.07.2022 22:18, Daniel Sahlberg wrote: Den tis 26 juli 2022 kl 10:55 skrev Branko Čibej : On 15.07.2022 23:19, Daniel Sahlberg wrote: > Den fre 15 juli 2022 kl 10:46 skrev Thomas Singer > : > > Hi SVN developers, > > > Hi Thomas, > > Thanks for the detailed report! > > First, there are 2 classes of NativeException, one in > org.tigris.subversion.javahl package, the other in > org.apache.subversion.javahl package. They only slightly differ in a > constructor parameter. I recommend to use one class with 2 > constructors > instead. > > > I'm not experienced enough in the Java world to fully grasp this but I > assume the org.tigtis package is older and that it has been kept for > historical reasons (not to break an API used by older applications). The org.tigris package is obsolete but indeed kept for compatibility. We shouldn't even try to "improve" it by using some common implementation. When compiling, there are a bunch of warnings: [[[ ... /home/dsg/svn_trunk/subversion/bindings/javahl/src/org/tigris/subversion/javahl/SVNClient.java:1605: warning: [dep-ann] deprecated item is not annotated with @Deprecated public void diff(String target1, Revision revision1, String target2, ... ]]] I assume this is because the function is @deprecated in the docstring but not formally annotated as @Deprecated. Would this be a reasonable improvement or should the code be considered frozen? It's frozen, don't bother with it. Nobody should be using it any longer. -- Brane
Re: missing --force option for "svn log" (useful with --diff)
On 16.07.2022 16:23, Vincent Lefevre wrote: When using "svn log --diff", one may need diff options. One has --diff-cmd, --internal-diff and -x, but --force is missing, though it would be useful too (in particular with --diff-cmd to textify diff inputs). What would --force do?
Re: JavaHL problem with NativeException
Den fre 29 juli 2022 kl 16:29 skrev Branko Čibej : > On 27.07.2022 22:18, Daniel Sahlberg wrote: > > Den tis 26 juli 2022 kl 10:55 skrev Branko Čibej : > >> On 15.07.2022 23:19, Daniel Sahlberg wrote: >> > Den fre 15 juli 2022 kl 10:46 skrev Thomas Singer >> > : >> > >> > Hi SVN developers, >> > >> > >> > Hi Thomas, >> > >> > Thanks for the detailed report! >> > >> > First, there are 2 classes of NativeException, one in >> > org.tigris.subversion.javahl package, the other in >> > org.apache.subversion.javahl package. They only slightly differ in a >> > constructor parameter. I recommend to use one class with 2 >> > constructors >> > instead. >> > >> > >> > I'm not experienced enough in the Java world to fully grasp this but I >> > assume the org.tigtis package is older and that it has been kept for >> > historical reasons (not to break an API used by older applications). >> >> The org.tigris package is obsolete but indeed kept for compatibility. We >> shouldn't even try to "improve" it by using some common implementation. >> > > When compiling, there are a bunch of warnings: > > [[[ > ... > /home/dsg/svn_trunk/subversion/bindings/javahl/src/org/tigris/subversion/javahl/SVNClient.java:1605: > warning: [dep-ann] deprecated item is not annotated with @Deprecated > public void diff(String target1, Revision revision1, String target2, > ... > ]]] > > I assume this is because the function is @deprecated in the docstring but > not formally annotated as @Deprecated. > > Would this be a reasonable improvement or should the code be considered > frozen? > > > It's frozen, don't bother with it. Nobody should be using it any longer. > Still it causes compile time warnings that could mask other warnings. /Daniel
Re: missing --force option for "svn log" (useful with --diff)
On Fri, Jul 29, 2022 at 5:30 PM Branko Čibej wrote: > > On 16.07.2022 16:23, Vincent Lefevre wrote: > > When using "svn log --diff", one may need diff options. > > One has --diff-cmd, --internal-diff and -x, but --force > > is missing, though it would be useful too (in particular > > with --diff-cmd to textify diff inputs). > > What would --force do? I believe that this post is relevant to Vincent's request: https://stackoverflow.com/q/72815562. -- With best regards, Pavel Lyalyakin VisualSVN Team
