[VOTE] PIP-352: Event time based topic compactor

[Marek Czajkowski]

Hi, Pulsar Community
I would like to start voting thread for PIP-352: Event time based topic
compactor
Proposal PR https://github.com/apache/pulsar/pull/22710
Implementation PR https://github.com/apache/pulsar/pull/22517

Thanks


-- 


*Marek Czajkowski*

Backend developer

Website: www.ds.pl

Email: marek.czajkow...@ds.pl

Mob: +48 698167319

Dynamic Solutions sp. z o.o. sp.k.

ul. Poleska 45/1, 15-114 Białystok

Your personal data controller is Dynamic Solutions Sp. z o.o. sp. k.
For GDPR compliance details, visit our website
.

[VOTE] DotPulsar Release 3.3.1-rc.1

[David Jensen]

Hi everyone,

Please review and vote on the release candidate for the version 3.3.1, as 
follows:

[ ] +1, Approve the release
[ ] -1, Do not approve the release (please provide specific comments)

DotPulsar's KEYS file contains the PGP keys we used to sign this release:
https://downloads.apache.org/pulsar/KEYS

Please download these packages and review this release candidate:
- Review release notes
- Download the source package (verify shasum, and asc) and follow the
README.md to build and run DotPulsar.

The vote will be open for at least 72 hours. It is adopted by majority 
approval, with at least 3 PMC affirmative votes.

Guide for Validating DotPulsar Release on Linux and MacOS
https://github.com/apache/pulsar-dotpulsar/blob/master/docs/release_validation_linux_macos.md

Source file:
https://dist.apache.org/repos/dist/dev/pulsar/pulsar-dotpulsar-3.3.1-rc.1/

Nuget package:
https://www.nuget.org/packages/DotPulsar/3.3.1-rc.1

The tag to be voted upon:
https://github.com/apache/pulsar-dotpulsar/tree/3.3.1-rc.1

SHA-512 checksums:
42bcc0e05935a15580e5a6a8795579f46b1d450167e661deff5eb8b3fb23da104e9e1fef6a916aef124a4440421cf88a9e1905d52891c824069ff96c84a02dab
  pulsar-dotpulsar-3.3.1-src.tar.gz

Re: [DISCUSS] PIP-361: Support URI, DNS, RID, IP based Token building from client's X.509 Certificate SAN Extensions

[naresh]

Can someone help with this ?

On Sat, Jun 15, 2024 at 1:54 PM naresh  wrote:

> Hello,
>
> This is my PIP Request at https://github.com/apache/pulsar/pull/22917
>
> If this PIP is acceptable, i am considering the following for the code
> changes:
>
>1. Enhance the existing
>org.apache.pulsar.broker.authentication.AuthenticationProviderTls class to
>support these changes
>2. Create a new class
>org.apache.pulsar.broker.authentication.AuthenticationProviderTlsSan thats
>backward compatible with current implementation
>
> Currently, I have made code changes on my local to support option-2.
> Before I go far, requesting some feedback on the overall proposal.
>
> Thanks
> Naresh
>

Re: [DISCUSS] PIP-361: Support URI, DNS, RID, IP based Token building from client's X.509 Certificate SAN Extensions

[Zixuan Liu]

Hi naresh,

Right now the Pulsar can only get the role from a common name, your PIP is
an awesome idea that supports URI, DNS, RID, IP based Token as role, and is
very helpful for large organizations.

In this PIP, you will introduce many configurations of identity mechanisms,
which are complex if users are not clear about their application scenarios.

I voted 0 for this PIP, and I suggest you implement your authentication
provider by https://pulsar.apache.org/docs/next/security-extending.

Thanks,
Zixuan

naresh  于2024年6月15日周六 16:24写道：

> Hello,
>
> This is my PIP Request at https://github.com/apache/pulsar/pull/22917
>
> If this PIP is acceptable, i am considering the following for the code
> changes:
>
>1. Enhance the existing
>org.apache.pulsar.broker.authentication.AuthenticationProviderTls class
> to
>support these changes
>2. Create a new class
>org.apache.pulsar.broker.authentication.AuthenticationProviderTlsSan
> thats
>backward compatible with current implementation
>
> Currently, I have made code changes on my local to support option-2. Before
> I go far, requesting some feedback on the overall proposal.
>
> Thanks
> Naresh
>

Re: [DISCUSS] PIP-364: Introduce a new load balance algorithm AvgShedder.

[Lari Hotari]

Thanks, you have done great analysis. I think it makes sense to take this 
forward.

-Lari

On 2024/06/20 04:12:59 thetumbled wrote:
> Hi, Pulsar Community.
> I open a new PIP to introduce a new load balance algorithm AvgShedder, 
> which can fix some problems that current algo meet, such as load jitter, 
> heterogeneous environment, slow load balancing, over placement problem, over 
> unloading problem.
> I have done many tests to prove out my analysis and post them in the PR, 
> hope them will be helpful to you!
> link: https://github.com/apache/pulsar/pull/22946
> 
> Thanks,
> Wenzhi Feng(thetumbled)

Re: [VOTE] PIP-352: Event time based topic compactor

[Lari Hotari]

+1 (binding)

-Lari

On 2024/06/20 08:25:28 Marek Czajkowski wrote:
> Hi, Pulsar Community
> I would like to start voting thread for PIP-352: Event time based topic
> compactor
> Proposal PR https://github.com/apache/pulsar/pull/22710
> Implementation PR https://github.com/apache/pulsar/pull/22517
> 
> Thanks
> 
> 
> -- 
> 
> 
> *Marek Czajkowski*
> 
> Backend developer
> 
> Website: www.ds.pl
> 
> Email: marek.czajkow...@ds.pl
> 
> Mob: +48 698167319
> 
> Dynamic Solutions sp. z o.o. sp.k.
> 
> ul. Poleska 45/1, 15-114 Białystok
> 
> Your personal data controller is Dynamic Solutions Sp. z o.o. sp. k.
> For GDPR compliance details, visit our website
> .
> 

Re: [VOTE] DotPulsar Release 3.3.1-rc.1

[Lari Hotari]

+1 (binding)

- verified source release file hash and signature
- ran build
- validated the Nuget package using a simple Pulsar app

Using dotnet sdk 8.0.302 (dotnet --version) on MacOS arm64.
Used the documented validation process on MacOS:
https://github.com/apache/pulsar-dotpulsar/blob/master/docs/release_validation_linux_macos.md

-Lari

On 2024/06/20 11:09:01 David Jensen wrote:
> Hi everyone,
> 
> Please review and vote on the release candidate for the version 3.3.1, as 
> follows:
> 
> [ ] +1, Approve the release
> [ ] -1, Do not approve the release (please provide specific comments)
> 
> DotPulsar's KEYS file contains the PGP keys we used to sign this release:
> https://downloads.apache.org/pulsar/KEYS
> 
> Please download these packages and review this release candidate:
> - Review release notes
> - Download the source package (verify shasum, and asc) and follow the
> README.md to build and run DotPulsar.
> 
> The vote will be open for at least 72 hours. It is adopted by majority 
> approval, with at least 3 PMC affirmative votes.
> 
> Guide for Validating DotPulsar Release on Linux and MacOS
> https://github.com/apache/pulsar-dotpulsar/blob/master/docs/release_validation_linux_macos.md
> 
> Source file:
> https://dist.apache.org/repos/dist/dev/pulsar/pulsar-dotpulsar-3.3.1-rc.1/
> 
> Nuget package:
> https://www.nuget.org/packages/DotPulsar/3.3.1-rc.1
> 
> The tag to be voted upon:
> https://github.com/apache/pulsar-dotpulsar/tree/3.3.1-rc.1
> 
> SHA-512 checksums:
> 42bcc0e05935a15580e5a6a8795579f46b1d450167e661deff5eb8b3fb23da104e9e1fef6a916aef124a4440421cf88a9e1905d52891c824069ff96c84a02dab
>   pulsar-dotpulsar-3.3.1-src.tar.gz
> 

Re: [DISCUSS] Cherry-pick PIP-344 Correct the behavior of the public API pulsarClient.getPartitionsForTopic

[Yubiao Feng]

Hi all

Now `3.0.x` has this fix, but the newest version(`3.3.x`) doesn't contain
this fix, which is somewhat confusing, so I want to cherry-pick it to
`branch-3.3`.

The thread will remain open for 48 hours.
If there is no objection, I will perform the cherry-picking.

Thanks
Yubiao Feng


On Mon, Jun 17, 2024 at 11:48 PM Yubiao Feng 
wrote:

> Hi all
>
> I would like to start a discussion to cherry-pick PIP-344 into `branch-3.0`
> - https://github.com/apache/pulsar/pull/22206
> - https://github.com/apache/pulsar/pull/22773
> - https://github.com/apache/pulsar/pull/22838
>
> This PIP fixed the wrong behavior for a public API, the wrong behavior may
> cause unexpected partitioned topic creation when users call
> "pulsarClient.getPartitionsForTopic".
>
> So I want to cherry-pick it into the long-term support version `3.0.x`
>
> The thread will keep open for 48 hours. If there is no objections,
> I will perform the cherry-picking.
>
> Thanks
> Yubiao Feng
>

Re: [DISCUSS] Cherry-pick PIP-356 Support Geo-Replication starts at earliest position

[Yubiao Feng]

Hi all

Addational: I want to cherry-pick it to `branch-3.3` too.

The thread will remain open for 48 hours.
If there is no objection, I will perform the cherry-picking.

Thanks
Yubiao Feng


On Wed, Jun 19, 2024 at 10:29 PM Yubiao Feng 
wrote:

> Hi all
>
> I would like to start a discussion to cherry-pick PIP-356 into `branch-3.0`
> - https://github.com/apache/pulsar/pull/22856
>
> This PIP added an optional config to let the Geo Replicator start at the
> earliest position, which is very useful for the scenario of migrating older
> messages to the target cluster. So it is very useful for the old cluster, I
> want to cherry-pick it into the long-term support version `3.0.x`.
>
> The thread will remain in the open state for 48 hours.
> If there is no objection, I will perform the cherry-picking.
>
> Thanks
> Yubiao Feng
>

[DISCUSS] Cherry-pick PIP-321 Introduce allowed-cluster at the namespace level

[Kai Wang]

Hi all

I would like to start a discussion to cherry-pick PIP-321 into `branch-3.0`
and `branch-3.3`
- https://github.com/apache/pulsar/pull/22378

This PIP Introduced `allowed-clusters` at the namespace level to address if
replication is only enabled at the topic level, the replicator will connect
fail when creating a producer issue. I want to cherry-pick it into the
version `3.0.x` and `3.3.x`.

The thread will remain in the open state for 48 hours.
If there is no objection, I will perform the cherry-picking.

Thanks
Kai

Re: [DISCUSS] PIP-363: Add callback parameters to the method: org.apache.pulsar.client.impl.SendCallback.sendComplete.

[Zixuan Liu]

+1

Jie crossover  于2024年6月19日周三 16:12写道：

> Hi, Pulsar Community.
>
> I have created a PIP  to add an `OpSendMsgStats` parameter to the
> `SendCallback` interface.
> This will help us implement `messaging.publish.messages` metric.
> PIP link: https://github.com/apache/pulsar/pull/22940
> OpenTelemetry Messaging Metrics link:
>
> https://opentelemetry.io/docs/specs/semconv/messaging/messaging-metrics/#metric-messagingpublishduration
> --
> Best Regards！
> crossoverJie
>

Re: [DISCUSS] PIP-363: Add callback parameters to the method: org.apache.pulsar.client.impl.SendCallback.sendComplete.

[太上玄元道君]

Hi Jie,

I support the PIP but there are something we need to consider:
OpenTelemetry-javagent[1] and Apache Skywalking-javaagent[2] enhanced
`SendCallback` to monitor sending messages, if we change the method sign,
the java-agents can't work.
It will be great that you can make it compatible, or, we have to push PRs
to OpenTelemetry/Skywalking to fix it.

Links:
[1]
https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/instrumentation/pulsar/pulsar-2.8/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/pulsar/v2_8/ProducerImplInstrumentation.java
[2]
https://github.com/dao-jun/skywalking-java/blob/main/apm-sniffer/apm-sdk-plugin/pulsar-common/src/main/java/org/apache/skywalking/apm/plugin/pulsar/common/SendCallbackInterceptor.java

Thanks,
Tao Jiuming

Zixuan Liu  于2024年6月21日周五 12:25写道：

> +1
>
> Jie crossover  于2024年6月19日周三 16:12写道：
>
> > Hi, Pulsar Community.
> >
> > I have created a PIP  to add an `OpSendMsgStats` parameter to the
> > `SendCallback` interface.
> > This will help us implement `messaging.publish.messages` metric.
> > PIP link: https://github.com/apache/pulsar/pull/22940
> > OpenTelemetry Messaging Metrics link:
> >
> >
> https://opentelemetry.io/docs/specs/semconv/messaging/messaging-metrics/#metric-messagingpublishduration
> > --
> > Best Regards！
> > crossoverJie
> >
>

Re: [VOTE] DotPulsar Release 3.3.1-rc.1

[Daniel Blankensteiner]

+1 (binding)

- Ran the automated tests

Using dotnet sdk 8.0.302 (dotnet --version) on Windows 11.

/db

Lari Hotari skrev den 2024-06-20 19:23:

+1 (binding)

- verified source release file hash and signature
- ran build
- validated the Nuget package using a simple Pulsar app

Using dotnet sdk 8.0.302 (dotnet --version) on MacOS arm64.
Used the documented validation process on MacOS:
https://github.com/apache/pulsar-dotpulsar/blob/master/docs/release_validation_linux_macos.md

-Lari

On 2024/06/20 11:09:01 David Jensen wrote:

Hi everyone,

Please review and vote on the release candidate for the version 3.3.1, 
as follows:


[ ] +1, Approve the release
[ ] -1, Do not approve the release (please provide specific comments)

DotPulsar's KEYS file contains the PGP keys we used to sign this 
release:

https://downloads.apache.org/pulsar/KEYS

Please download these packages and review this release candidate:
- Review release notes
- Download the source package (verify shasum, and asc) and follow the
README.md to build and run DotPulsar.

The vote will be open for at least 72 hours. It is adopted by majority 
approval, with at least 3 PMC affirmative votes.


Guide for Validating DotPulsar Release on Linux and MacOS
https://github.com/apache/pulsar-dotpulsar/blob/master/docs/release_validation_linux_macos.md

Source file:
https://dist.apache.org/repos/dist/dev/pulsar/pulsar-dotpulsar-3.3.1-rc.1/

Nuget package:
https://www.nuget.org/packages/DotPulsar/3.3.1-rc.1

The tag to be voted upon:
https://github.com/apache/pulsar-dotpulsar/tree/3.3.1-rc.1

SHA-512 checksums:
42bcc0e05935a15580e5a6a8795579f46b1d450167e661deff5eb8b3fb23da104e9e1fef6a916aef124a4440421cf88a9e1905d52891c824069ff96c84a02dab 
 pulsar-dotpulsar-3.3.1-src.tar.gz

Re: [DISCUSS] PIP-363: Add callback parameters to the method: org.apache.pulsar.client.impl.SendCallback.sendComplete.

[Jie crossover]

Hi Jiuming,
You are right, because the data sent in batches cannot be obtained in the
current pulsar-client, so when this feature is released, we need to add an
agent based on the latest version in OTel and Skywalking.

-- 
Best Regards！
crossoverJie


太上玄元道君  于2024年6月21日周五 13:30写道：

> Hi Jie,
>
> I support the PIP but there are something we need to consider:
> OpenTelemetry-javagent[1] and Apache Skywalking-javaagent[2] enhanced
> `SendCallback` to monitor sending messages, if we change the method sign,
> the java-agents can't work.
> It will be great that you can make it compatible, or, we have to push PRs
> to OpenTelemetry/Skywalking to fix it.
>
> Links:
> [1]
>
> https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/instrumentation/pulsar/pulsar-2.8/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/pulsar/v2_8/ProducerImplInstrumentation.java
> [2]
>
> https://github.com/dao-jun/skywalking-java/blob/main/apm-sniffer/apm-sdk-plugin/pulsar-common/src/main/java/org/apache/skywalking/apm/plugin/pulsar/common/SendCallbackInterceptor.java
>
> Thanks,
> Tao Jiuming
>
> Zixuan Liu  于2024年6月21日周五 12:25写道：
>
> > +1
> >
> > Jie crossover  于2024年6月19日周三 16:12写道：
> >
> > > Hi, Pulsar Community.
> > >
> > > I have created a PIP  to add an `OpSendMsgStats` parameter to the
> > > `SendCallback` interface.
> > > This will help us implement `messaging.publish.messages` metric.
> > > PIP link: https://github.com/apache/pulsar/pull/22940
> > > OpenTelemetry Messaging Metrics link:
> > >
> > >
> >
> https://opentelemetry.io/docs/specs/semconv/messaging/messaging-metrics/#metric-messagingpublishduration
> > > --
> > > Best Regards！
> > > crossoverJie
> > >
> >
>