Re: [VOTE] PIP-325: Add command to abort transaction
+1 (binding) Regards, Penghui On Mon, Jan 8, 2024 at 4:00 PM Enrico Olivelli wrote: > +1 (binding) > > > Enrico > > Il Lun 8 Gen 2024, 03:55 ruihongzhou ha > scritto: > > > Hi community, > > > > This thread is to start a vote for PIP-325: Add command to abort > > transaction. > > > > PIP: https://github.com/apache/pulsar/pull/21731 > > > > Releted PR: https://github.com/apache/pulsar/pull/21630 > > > > Discussion thread: > > https://lists.apache.org/thread/ssgngyrlgx36zvygvsd5b2dm5q6krn0f > > > > Ruihong > > > > > > > > ruihongzhou > > ruihongz...@qq.com > > > > > > > > >
Re: [VERIFY] Pulsar Release 3.2.0 Candidate 1
Hi Zike, Thanks for reporting this, drop this candidate, I will raise a new candidate after the fix. Regards Jiwei Guo (Tboy) On Fri, Jan 12, 2024 at 10:46 AM Zike Yang wrote: > There is a regression bug introduced in 3.2.0: > https://github.com/apache/pulsar/issues/21888 > The producer name will be conflicted when multiple consumers in the > same topic and subscription send messages to the same DLQ > concurrently. > > I will provide a fix later. > > Best, > Zike Yang > > On Tue, Jan 9, 2024 at 8:34 PM houxiaoyu wrote: > > > > +1 (non-binding) > > > > > > - Checksum and signatures > > - Build on Mac, using JDK17.0.8 > > - Run Pulsar standalone and produce/consume case > > > > Thanks, > > Xiaoyu Hou > > > > guo jiwei 于2024年1月9日周二 16:15写道： > > > > > > This is the first release candidate for Apache Pulsar version 3.2.0. > > > > > > It fixes the following issues: > > > https://github.com/apache/pulsar/milestone/36?closed=1 > > > > > > *** Please download, test and verify on this release. This release > > > candidate verification will stay open until Jan 15 *** > > > > > > Note that we are verifying upon the source (tag), binaries are > provided for > > > convenience. > > > > > > Source and binary files: > > > > https://dist.apache.org/repos/dist/dev/pulsar/pulsar-3.2.0-candidate-1/ > > > > > > SHA-512 checksums: > > > > > > > cf4e661d78f4194f4cde88e102bc9a734e2777613c5315f09115d64236759fbc5ded868c7e0cc3d07813c3fd34b1b123ca6f06f4335d6c9c96393789c6eda5bc > > > > > > apache-pulsar-3.2.0-bin.tar.gz > > > > > > > 6ebe72de801db9a3f51dde39587b93d947904856385a21020319edb6988776fd68ec079471bcce5db17ea1b79c58e22ebf89a854debb40437ad9dc2bc2350357 > > > > > > apache-pulsar-3.2.0-src.tar.gz > > > > > > Maven staging repo: > > > > https://repository.apache.org/content/repositories/orgapachepulsar-1259/ > > > > > > The tag to verify: > > > v3.2.0-candidate-1 (4ab09374ade3c1402812c3c6be0d07984ab373a4) > > > https://github.com/apache/pulsar/commits/v3.2.0-candidate-1/ > > > > > > Pulsar's KEYS file containing PGP keys you use to sign the release: > > > https://dist.apache.org/repos/dist/dev/pulsar/KEYS > > > > > > Docker images: > > > > > > pulsar images: > > > > https://hub.docker.com/layers/technoboy8/pulsar/3.2.0-4ab0937/images/sha256-06d35d60f3bd4f954b8b1b6f4cc4f663556ace5da097173f41a61622e81a76b9?context=repo > > > < > https://hub.docker.com/layers/mattison/pulsar/3.1.0-candidate-1/images/sha256-0efbaad7d893cc5041a46a2d4d56432bda855ae4068a38349777d1be6e98d27d?context=explore > > > > > pulsar-all images: > > > > https://hub.docker.com/layers/technoboy8/pulsar-all/3.2.0-4ab0937/images/sha256-a6f87bc5fd8025f096f35f26d47303267452e35d92f9f974d8536b61543ddbeb?context=repo > > > > > > Please download the source package, and follow the README to build > > > and run the Pulsar standalone service. > > > > > > Note that this RC doesn't require a formal vote, but we would also > > > appreciate your feedback with +1/-1. And please provide specific > > > comments if your feedback is not +1. > > > > > > > > > Regards > > > Jiwei Guo (Tboy) >
Re: [DISCUSS] Break change: could not subscribe partitioned topic with a suffix-matched regexp due to a mistake of PIP-145
Do we have a workaround for this break change? Is disabling PIP-145 can help with it? Regards, Penghui On Fri, Jan 12, 2024 at 6:29 PM Yubiao Feng wrote: > Hi all > > I noticed that the PIP-145 made a break change that caused clients to not > subscribe to partitioned topics with a suffix-matched regexp. > > ### Background > PIP-145(https://github.com/apache/pulsar/issues/14505) moved the logic of > regexp compare from client-side to the broker-side. > After PIP-145, Pulsar uses the partition name(E.g., "topic-partition-0") to > match the Regexp. But the original behavior is to use a partitioned topic > name(E.g., "topic") to match the Regexp. > > ### The behavior change 1 > - start a consumer with `topicPattern`: > `persistent://my-property/my-ns/pattern-.*-1` > - create a partitioned topic `persistent://my-tenant/my-ns/pattern-topic-x` > with `4` partitions > > `3.0.2`: the consumer will automatically add `4` internal consumers for the > `4` partitions. > `2.10.5`: No internal consumers added. > > ### The behavior change 2 > - start a consumer with regexp `persistent://public/default/tp$` > - create a partitioned topic persistent://public/default/tp` with `4` > partitions > > `3.0.2`: the pattern consumer has no internal consumers. > `2.10.5`: the consumer will automatically add `4` internal consumers for > the `4` partitions. > > ### Summary > After PIP-145, there are two behaviors are confused: > - You can not use a suffix-regexp to subscribe to the partitioned topics. > - You will get all partitions if you just want one partition with a > suffix-regexp `-partition-0`. And before PIP-145, you will get no topics. > This behavior is not supported on all versions, but the behavior is not the > same. > > ### Fix > I pushed a PR to revert the behavior to the original(before PIP-145). See: > https://github.com/apache/pulsar/pull/21885. > > > Thanks > Yubiao Femg >
Re: [DISCUSS] Always set a broker side timestamp for message and deprecate some API
IMO, we should enable `AppendBrokerTimestampMetadataInterceptor` by default. Users can still have a way to disable it if they care about the additional metadata stored in each entry. For the `hasBrokerPublishTime` API. The topic might also have historical data without broker publish time. So, it should be fine to keep this API because we don't know how long users will retain their data. Regards, Penghui On Sat, Jan 6, 2024 at 10:35 PM linlin wrote: > Now, if the message's metadata does not set a broker side timestamp, the > ledger expiration check is based on the client's publish time. > > When the client machine's clock is incorrect (eg: set to 1 year later) , > the ledger can not be cleaned up. Issue > https://github.com/apache/pulsar/issues/21347 > > `AppendBrokerTimestampMetadataInterceptor` can set timestamp for messages > on the broker side, but we can not ensure that the > `AppendBrokerTimestampMetadataInterceptor` is always enable > > Therefore, I open this PR(https://github.com/apache/pulsar/pull/21835) to > always set the broker timestamp for messages on the broker side. > > With this change , firstly we should deprecate > AppendBrokerTimestampMetadataInterceptor. > It no longer needs to exist > > Secondly, we should deprecate `hasBrokerPublishTime` in interface Message. > It always returns true. > This API is created in PR (https://github.com/apache/pulsar/pull/11553) > This PR is for the client to obtain BrokerPublishTime, so the > `hasBrokerPublishTime` API is not necessary. >
Re: [VOTE] PIP-325: Add command to abort transaction
+1 (binding) Regards Jiwei Guo (Tboy) On Mon, Jan 15, 2024 at 9:36 AM PengHui Li wrote: > +1 (binding) > > Regards, > Penghui > > On Mon, Jan 8, 2024 at 4:00 PM Enrico Olivelli > wrote: > > > +1 (binding) > > > > > > Enrico > > > > Il Lun 8 Gen 2024, 03:55 ruihongzhou ha > > scritto: > > > > > Hi community, > > > > > > This thread is to start a vote for PIP-325: Add command to abort > > > transaction. > > > > > > PIP: https://github.com/apache/pulsar/pull/21731 > > > > > > Releted PR: https://github.com/apache/pulsar/pull/21630 > > > > > > Discussion thread: > > > https://lists.apache.org/thread/ssgngyrlgx36zvygvsd5b2dm5q6krn0f > > > > > > Ruihong > > > > > > > > > > > > ruihongzhou > > > ruihongz...@qq.com > > > > > > > > > > > > > > >
Re: [DISCUSS] Break change: could not subscribe partitioned topic with a suffix-matched regexp due to a mistake of PIP-145
Hi Penghui > Do we have a workaround for this break change? > Is disabling PIP-145 can help with it? Enabled `enableBrokerSideSubscriptionPatternEvaluation` and setting `patternAutoDiscoveryPeriod` to a little value may solve the problem. Thanks Yubiao Feng On Mon, Jan 15, 2024 at 10:03 AM PengHui Li wrote: > Do we have a workaround for this break change? > Is disabling PIP-145 can help with it? > > Regards, > Penghui > > On Fri, Jan 12, 2024 at 6:29 PM Yubiao Feng > wrote: > > > Hi all > > > > I noticed that the PIP-145 made a break change that caused clients to not > > subscribe to partitioned topics with a suffix-matched regexp. > > > > ### Background > > PIP-145(https://github.com/apache/pulsar/issues/14505) moved the logic > of > > regexp compare from client-side to the broker-side. > > After PIP-145, Pulsar uses the partition name(E.g., "topic-partition-0") > to > > match the Regexp. But the original behavior is to use a partitioned topic > > name(E.g., "topic") to match the Regexp. > > > > ### The behavior change 1 > > - start a consumer with `topicPattern`: > > `persistent://my-property/my-ns/pattern-.*-1` > > - create a partitioned topic > `persistent://my-tenant/my-ns/pattern-topic-x` > > with `4` partitions > > > > `3.0.2`: the consumer will automatically add `4` internal consumers for > the > > `4` partitions. > > `2.10.5`: No internal consumers added. > > > > ### The behavior change 2 > > - start a consumer with regexp `persistent://public/default/tp$` > > - create a partitioned topic persistent://public/default/tp` with `4` > > partitions > > > > `3.0.2`: the pattern consumer has no internal consumers. > > `2.10.5`: the consumer will automatically add `4` internal consumers for > > the `4` partitions. > > > > ### Summary > > After PIP-145, there are two behaviors are confused: > > - You can not use a suffix-regexp to subscribe to the partitioned topics. > > - You will get all partitions if you just want one partition with a > > suffix-regexp `-partition-0`. And before PIP-145, you will get no topics. > > This behavior is not supported on all versions, but the behavior is not > the > > same. > > > > ### Fix > > I pushed a PR to revert the behavior to the original(before PIP-145). > See: > > https://github.com/apache/pulsar/pull/21885. > > > > > > Thanks > > Yubiao Femg > > >
Re: [DISCUSS] Break change: could not subscribe partitioned topic with a suffix-matched regexp due to a mistake of PIP-145
Hi Penghui > Enabled `enableBrokerSideSubscriptionPatternEvaluation` and > setting `patternAutoDiscoveryPeriod` to a little value may > solve the problem. Correct this answer: - Disable `enableBrokerSideSubscriptionPatternEvaluation`(the config on the broker-side) will solve this problem. BYW, setting `patternAutoDiscoveryPeriod`(the config on the client-side) to a little value may make new topic subscribing faster. Thanks Yubiao Feng On Mon, Jan 15, 2024 at 10:58 AM Yubiao Feng wrote: > Hi Penghui > > > Do we have a workaround for this break change? > > Is disabling PIP-145 can help with it? > > Enabled `enableBrokerSideSubscriptionPatternEvaluation` and setting > `patternAutoDiscoveryPeriod` to a little value may solve the problem. > > > Thanks > Yubiao Feng > > On Mon, Jan 15, 2024 at 10:03 AM PengHui Li wrote: > >> Do we have a workaround for this break change? >> Is disabling PIP-145 can help with it? >> >> Regards, >> Penghui >> >> On Fri, Jan 12, 2024 at 6:29 PM Yubiao Feng >> wrote: >> >> > Hi all >> > >> > I noticed that the PIP-145 made a break change that caused clients to >> not >> > subscribe to partitioned topics with a suffix-matched regexp. >> > >> > ### Background >> > PIP-145(https://github.com/apache/pulsar/issues/14505) moved the logic >> of >> > regexp compare from client-side to the broker-side. >> > After PIP-145, Pulsar uses the partition name(E.g., >> "topic-partition-0") to >> > match the Regexp. But the original behavior is to use a partitioned >> topic >> > name(E.g., "topic") to match the Regexp. >> > >> > ### The behavior change 1 >> > - start a consumer with `topicPattern`: >> > `persistent://my-property/my-ns/pattern-.*-1` >> > - create a partitioned topic >> `persistent://my-tenant/my-ns/pattern-topic-x` >> > with `4` partitions >> > >> > `3.0.2`: the consumer will automatically add `4` internal consumers for >> the >> > `4` partitions. >> > `2.10.5`: No internal consumers added. >> > >> > ### The behavior change 2 >> > - start a consumer with regexp `persistent://public/default/tp$` >> > - create a partitioned topic persistent://public/default/tp` with `4` >> > partitions >> > >> > `3.0.2`: the pattern consumer has no internal consumers. >> > `2.10.5`: the consumer will automatically add `4` internal consumers for >> > the `4` partitions. >> > >> > ### Summary >> > After PIP-145, there are two behaviors are confused: >> > - You can not use a suffix-regexp to subscribe to the partitioned >> topics. >> > - You will get all partitions if you just want one partition with a >> > suffix-regexp `-partition-0`. And before PIP-145, you will get no >> topics. >> > This behavior is not supported on all versions, but the behavior is not >> the >> > same. >> > >> > ### Fix >> > I pushed a PR to revert the behavior to the original(before PIP-145). >> See: >> > https://github.com/apache/pulsar/pull/21885. >> > >> > >> > Thanks >> > Yubiao Femg >> > >> >
Re: [VOTE] PIP-325: Add command to abort transaction
+1 (binding) Thanks, Yunze On Mon, Jan 15, 2024 at 10:25 AM guo jiwei wrote: > > +1 (binding) > > > Regards > Jiwei Guo (Tboy) > > > On Mon, Jan 15, 2024 at 9:36 AM PengHui Li wrote: > > > +1 (binding) > > > > Regards, > > Penghui > > > > On Mon, Jan 8, 2024 at 4:00 PM Enrico Olivelli > > wrote: > > > > > +1 (binding) > > > > > > > > > Enrico > > > > > > Il Lun 8 Gen 2024, 03:55 ruihongzhou ha > > > scritto: > > > > > > > Hi community, > > > > > > > > This thread is to start a vote for PIP-325: Add command to abort > > > > transaction. > > > > > > > > PIP: https://github.com/apache/pulsar/pull/21731 > > > > > > > > Releted PR: https://github.com/apache/pulsar/pull/21630 > > > > > > > > Discussion thread: > > > > https://lists.apache.org/thread/ssgngyrlgx36zvygvsd5b2dm5q6krn0f > > > > > > > > Ruihong > > > > > > > > > > > > > > > > ruihongzhou > > > > ruihongz...@qq.com > > > > > > > > > > > > > > > > > > > > >
[VOTE] Pulsar Client Go Release 0.12.0 Candidate 2
Hi everyone, Please review and vote on the release candidate #2 for the version 0.12.0, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) This is the second release candidate for Apache Pulsar Go client, version 0.12.0. The release note/changelog for Go client 0.12.0: https://github.com/apache/pulsar-client-go/pull/1153/files Pulsar Client Go's KEYS file contains PGP keys we used to sign this release: https://downloads.apache.org/pulsar/KEYS Please download these packages and review this release candidate: - Review release notes: https://github.com/apache/pulsar-client-go/pull/1153 - Download the source package (verify shasum, and asc) and follow the README.md to build and run the pulsar-client-go. The vote will be open for at least 72 hours. It is adopted by majority approval, with at least 3 PMC affirmative votes. Source file: https://dist.apache.org/repos/dist/dev/pulsar/pulsar-client-go-0.12.0-candidate-2/ The tag to be voted upon: v0.12.0-candidate-2 https://github.com/apache/pulsar-client-go/tree/v0.12.0-candidate-2 SHA-512 checksums: e3c0845f60989b9ca4f6cf683d750c9361ca0e15ae7f8d990cfe14d7af86bd80475aeeda95870f2b8ef6fe8ec5fdbd59c67876546e282d76baae9a1737c6a7aa apache-pulsar-client-go-0.12.0-src.tar.gz
