Re: [DISCUSS] PIP-304: Make PublishContext provide the message metadata

2023-10-07 Thread kecona
Hi yubiao,

The above message metadata is confusing to you. The message metadata refers
to `org.apache.pulsar.common.api.proto.MessageMetadata`.

This PIP has been updated, could you review it again?

Thanks,
Kecona

kecona  于2023年10月7日周六 12:48写道:

> Hi all,
>
> I wrote a PIP to make PublishContext provide the message metadata, see
> https://github.com/apache/pulsar/pull/21311.
>
> An implementation for this PIP:
> https://github.com/apache/pulsar/pull/21245(reverting)
>
> Please let me know your thoughts!
>
> Thanks,
> Kecona
>


Re: [VOTE] PIP-302 Introduce refreshAsync API for TableView

2023-10-07 Thread PengHui Li
+1

Thanks,
Penghui

On Wed, Sep 27, 2023 at 3:09 PM Zike Yang  wrote:

> +1
>
> BR,
> Zike Yang
>
> On Wed, Sep 27, 2023 at 3:05 PM Xiangying Meng 
> wrote:
> >
> > Hi dev,
> >This thread is to start a vote for PIP-302 Add new API
> > refreshAsync for TableView.
> > Discuss thread:
> https://lists.apache.org/thread/o085y2314o0fymvx0x8pojmgjwcwn59q
> > PIP: https://github.com/apache/pulsar/pull/21166
> >
> > BR,
> > Xiangying
>


Re: [VOTE] PIP-302 Introduce refreshAsync API for TableView

2023-10-07 Thread guo jiwei
+1


Regards
Jiwei Guo (Tboy)


On Sat, Oct 7, 2023 at 8:07 PM PengHui Li  wrote:

> +1
>
> Thanks,
> Penghui
>
> On Wed, Sep 27, 2023 at 3:09 PM Zike Yang  wrote:
>
> > +1
> >
> > BR,
> > Zike Yang
> >
> > On Wed, Sep 27, 2023 at 3:05 PM Xiangying Meng 
> > wrote:
> > >
> > > Hi dev,
> > >This thread is to start a vote for PIP-302 Add new API
> > > refreshAsync for TableView.
> > > Discuss thread:
> > https://lists.apache.org/thread/o085y2314o0fymvx0x8pojmgjwcwn59q
> > > PIP: https://github.com/apache/pulsar/pull/21166
> > >
> > > BR,
> > > Xiangying
> >
>


Re: [DISCUSS] PIP-304: Make PublishContext provide the message metadata

2023-10-07 Thread Yubiao Feng
Hi Kecona

Sorry, I think I did not clear what I wanted to say. And correct it: could
you add more detail to the Motivation, for example: I need the field
`ordering_key` to do something, but I can not get it from Publish Context.

Thanks
Yubiao Feng

On Sat, Oct 7, 2023 at 3:53 PM kecona  wrote:

> Hi yubiao,
>
> The above message metadata is confusing to you. The message metadata refers
> to `org.apache.pulsar.common.api.proto.MessageMetadata`.
>
> This PIP has been updated, could you review it again?
>
> Thanks,
> Kecona
>
> kecona  于2023年10月7日周六 12:48写道:
>
> > Hi all,
> >
> > I wrote a PIP to make PublishContext provide the message metadata, see
> > https://github.com/apache/pulsar/pull/21311.
> >
> > An implementation for this PIP:
> > https://github.com/apache/pulsar/pull/21245(reverting)
> >
> > Please let me know your thoughts!
> >
> > Thanks,
> > Kecona
> >
>


Re: [VOTE] PIP-302 Introduce refreshAsync API for TableView

2023-10-07 Thread Yubiao Feng
+1 (no-binding)

And correct the link of PIP:
- https://github.com/apache/pulsar/pull/21271

Thanks
Yubiao Feng

On Wed, Sep 27, 2023 at 3:04 PM Xiangying Meng  wrote:

> Hi dev,
>This thread is to start a vote for PIP-302 Add new API
> refreshAsync for TableView.
> Discuss thread:
> https://lists.apache.org/thread/o085y2314o0fymvx0x8pojmgjwcwn59q
> PIP: https://github.com/apache/pulsar/pull/21166
>
> BR,
> Xiangying
>


Re: [VOTE] PIP-302 Introduce refreshAsync API for TableView

2023-10-07 Thread Baodi Shi
+1 (no-binding)


Thanks,
Baodi Shi


On Oct 7, 2023 at 21:06:35, Yubiao Feng 
wrote:

> +1 (no-binding)
>
> And correct the link of PIP:
> - https://github.com/apache/pulsar/pull/21271
>
> Thanks
> Yubiao Feng
>
> On Wed, Sep 27, 2023 at 3:04 PM Xiangying Meng 
> wrote:
>
> Hi dev,
>
>This thread is to start a vote for PIP-302 Add new API
>
> refreshAsync for TableView.
>
> Discuss thread:
>
> https://lists.apache.org/thread/o085y2314o0fymvx0x8pojmgjwcwn59q
>
> PIP: https://github.com/apache/pulsar/pull/21166
>
>
> BR,
>
> Xiangying
>
>
>


Re: [VOTE] PIP-302 Introduce refreshAsync API for TableView

2023-10-07 Thread Dezhi Liu
+1

Thanks,
Dezhi

On 2023/09/27 07:04:43 Xiangying Meng wrote:
> Hi dev,
>This thread is to start a vote for PIP-302 Add new API
> refreshAsync for TableView.
> Discuss thread: 
> https://lists.apache.org/thread/o085y2314o0fymvx0x8pojmgjwcwn59q
> PIP: https://github.com/apache/pulsar/pull/21166
> 
> BR,
> Xiangying
> 


Re: [DISCUSS] PIP-304: Make PublishContext provide the message metadata

2023-10-07 Thread Zixuan Liu
+1

Thanks,
Zixuan

Yubiao Feng  于2023年10月7日周六 21:05写道:
>
> Hi Kecona
>
> Sorry, I think I did not clear what I wanted to say. And correct it: could
> you add more detail to the Motivation, for example: I need the field
> `ordering_key` to do something, but I can not get it from Publish Context.
>
> Thanks
> Yubiao Feng
>
> On Sat, Oct 7, 2023 at 3:53 PM kecona  wrote:
>
> > Hi yubiao,
> >
> > The above message metadata is confusing to you. The message metadata refers
> > to `org.apache.pulsar.common.api.proto.MessageMetadata`.
> >
> > This PIP has been updated, could you review it again?
> >
> > Thanks,
> > Kecona
> >
> > kecona  于2023年10月7日周六 12:48写道:
> >
> > > Hi all,
> > >
> > > I wrote a PIP to make PublishContext provide the message metadata, see
> > > https://github.com/apache/pulsar/pull/21311.
> > >
> > > An implementation for this PIP:
> > > https://github.com/apache/pulsar/pull/21245(reverting)
> > >
> > > Please let me know your thoughts!
> > >
> > > Thanks,
> > > Kecona
> > >
> >


Re: [VOTE] PIP-302 Introduce refreshAsync API for TableView

2023-10-07 Thread 太上玄元道君
+1 (no-binding)


Xiangying Meng 于2023年9月27日 周三15:05写道:

> Hi dev,
>This thread is to start a vote for PIP-302 Add new API
> refreshAsync for TableView.
> Discuss thread:
> https://lists.apache.org/thread/o085y2314o0fymvx0x8pojmgjwcwn59q
> PIP: https://github.com/apache/pulsar/pull/21166
>
> BR,
> Xiangying
>


Re: [VOTE] PIP-300: Add custom dynamic configuration for plugins

2023-10-07 Thread 太上玄元道君
+1 (no-binding)


Zixuan Liu 于2023年9月26日 周二10:54写道:

> Hi Pulsar Community,
>
> Voting for PIP-300: https://github.com/apache/pulsar/pull/21127
> Discussion thread:
> https://lists.apache.org/thread/ysnsnollgy1b6w1dsvmx1t1y2rz1tyd6
>
> Thanks,
> Zixuan
>


Re: [VOTE] PIP-302 Introduce refreshAsync API for TableView

2023-10-07 Thread Yunze Xu
Totally I'm +0 at the moment. I'm still wondering which issue you
really want to resolve. I left a comment
https://github.com/apache/pulsar/pull/21271#issuecomment-1751899833.
Generally you can get latest value unless the producer is far quicker
than the reader. However, even with the refreshAsync() method, in the
future's callback, the data could still be updated.

>From my perspective, this proposal only makes sense when you can
guarantee there is no more data written to the topic when you call
methods of TableView. But if so, a simple `boolean hasReachedLatest()`
method could do the trick.

Thanks,
Yunze

On Sun, Oct 8, 2023 at 2:12 PM 太上玄元道君  wrote:
>
> +1 (no-binding)
>
>
> Xiangying Meng 于2023年9月27日 周三15:05写道:
>
> > Hi dev,
> >This thread is to start a vote for PIP-302 Add new API
> > refreshAsync for TableView.
> > Discuss thread:
> > https://lists.apache.org/thread/o085y2314o0fymvx0x8pojmgjwcwn59q
> > PIP: https://github.com/apache/pulsar/pull/21166
> >
> > BR,
> > Xiangying
> >