Re: [DISCUSS] Dropping the StreamingDispatcher
+1, I totally agree with this idea. Enrico Olivelli 于2023年4月4日周二 14:47写道： > Hello, > It has been a long time that we have in the Pulsar code a new > experimental Dispatcher implementation named StreamingDispatcher. > > https://github.com/apache/pulsar/pull/9056 > > There are many flaky tests about that feature and I believe that it > has never been used in Production by anyone, because it happened a few > times that we did some changes in the regular Dispatcher and > introduced bugs on the StreamingDispacther (usually manifested as > flaky tests) > > > I propose to drop the StreamingDispatcher code for Pulsar 3.0. > I don't think we need a PIP for this, it is an experimental code that > was never delivered as a production ready feature. > > If anyone is aware of users please chime in. > > If anyone wants to sponsor that feature and objects in removing this > dead code (that we still have to maintain) please help us in > completing the feature. > > On paper it is a very appealing feature, and I am disappointed in dropping > it. > On the other hand, this is dead code that we have to maintain with zero > benefit > > Thoughts ? > > Enrico >
Re: [DISCUSS] Dropping the StreamingDispatcher
If the flaky tests were the only concern, I think we can just disable these tests. Whatever, this config in `ServiceConfiguration` has existed for a long time, though when it was introduced, the PIP rule was not clear so there is no PIP for it. Thanks, Yunze On Tue, Apr 4, 2023 at 3:09 PM Gavin gao wrote: > > +1, I totally agree with this idea. > > Enrico Olivelli 于2023年4月4日周二 14:47写道： > > > Hello, > > It has been a long time that we have in the Pulsar code a new > > experimental Dispatcher implementation named StreamingDispatcher. > > > > https://github.com/apache/pulsar/pull/9056 > > > > There are many flaky tests about that feature and I believe that it > > has never been used in Production by anyone, because it happened a few > > times that we did some changes in the regular Dispatcher and > > introduced bugs on the StreamingDispacther (usually manifested as > > flaky tests) > > > > > > I propose to drop the StreamingDispatcher code for Pulsar 3.0. > > I don't think we need a PIP for this, it is an experimental code that > > was never delivered as a production ready feature. > > > > If anyone is aware of users please chime in. > > > > If anyone wants to sponsor that feature and objects in removing this > > dead code (that we still have to maintain) please help us in > > completing the feature. > > > > On paper it is a very appealing feature, and I am disappointed in dropping > > it. > > On the other hand, this is dead code that we have to maintain with zero > > benefit > > > > Thoughts ? > > > > Enrico > >
Re: [VOTE] PIP-254: Support configuring client version with a description suffix
Close this vote by 5 binding +1s * Penghui * Bo * Lin Lin * Enrico * Michael and 2 non-binding +1s: * Zike * Cong Zhao Thanks, Yunze On Mon, Apr 3, 2023 at 11:39 AM Michael Marshall wrote: > > +1 (binding) > > Thanks, > Michael > > On Wed, Mar 29, 2023 at 3:51 AM Enrico Olivelli wrote: > > > > +1 (binding) > > > > Enrico > > > > Il giorno mer 29 mar 2023 alle ore 09:16 丛搏 ha scritto: > > > > > > +1 (binding) > > > > > > Thanks, > > > Bo > > > > > > Lin Lin 于2023年3月27日周一 17:49写道： > > > > > > > > +1 > > > > > > > > Thanks, > > > > Lin Lin > > > > > > > > On 2023/03/15 07:54:20 Yunze Xu wrote: > > > > > Hi all, > > > > > > > > > > This thread is to start the vote for PIP-254. > > > > > > > > > > Discussion thread: > > > > > https://lists.apache.org/thread/65cf7w76tt23sbsjnr8rpfxqf1nt9s9l > > > > > > > > > > PIP link: https://github.com/apache/pulsar/issues/19705 > > > > > > > > > > Thanks, > > > > > Yunze > > > > >
Pulsar Flaky test report 2023-04-03 for PR builds in CI
Dear community, Here's a report of the flaky tests in Pulsar CI during the observation period of 2023-03-27 - 2023-04-03 https://github.com/nicoloboschi/pulsar-flakes/tree/master/2023-03-27-to-2023-04-03 Most flaky tests: org.apache.pulsar.broker.loadbalance.extensions.ExtensibleLoadManagerImplTest.stateCheck 9 org.apache.pulsar.broker.loadbalance.extensions.ExtensibleLoadManagerImplTest.testSplitBundleAdminAPI 4 org.apache.bookkeeper.mledger.impl.ManagedLedgerErrorsTest.recoverLongTimeAfterMultipleWriteErrors 4 org.apache.pulsar.broker.loadbalance.extensions.ExtensibleLoadManagerImplTest.initializeState 3 org.apache.pulsar.broker.loadbalance.extensions.ExtensibleLoadManagerImplTest.testAssign 2 More flaky test issues: https://github.com/apache/pulsar/issues?q=flaky+sort%3Aupdated-desc+is%3Aopen+is:issue To coordinate the work, 1) please search for an existing issues or search for all flaky issues with "flaky" or the test class name (without package) in the search: https://github.com/apache/pulsar/issues?q=is%3Aopen+flaky+sort%3Aupdated-desc 2) If there isn't an issue for a particular flaky test failure that you'd like to fix, please create an issue using the "Flaky test" template at https://github.com/apache/pulsar/issues/new/choose 3) Please comment on the issue that you are working on. More contributions are welcome! Nicolò Boschi
Re: Pulsar Flaky test report 2023-04-03 for PR builds in CI
Hi, Thank you for the report. We are fixing the errors from ExtensibleLoadManagerImplTest. Regards, Heesung On Tue, Apr 4, 2023 at 3:01 AM Nicolò Boschi wrote: > Dear community, > Here's a report of the flaky tests in Pulsar CI during the observation > period of 2023-03-27 - 2023-04-03 > > > https://github.com/nicoloboschi/pulsar-flakes/tree/master/2023-03-27-to-2023-04-03 > > > Most flaky tests: > > org.apache.pulsar.broker.loadbalance.extensions.ExtensibleLoadManagerImplTest.stateCheck > 9 > > org.apache.pulsar.broker.loadbalance.extensions.ExtensibleLoadManagerImplTest.testSplitBundleAdminAPI > 4 > > org.apache.bookkeeper.mledger.impl.ManagedLedgerErrorsTest.recoverLongTimeAfterMultipleWriteErrors > 4 > > org.apache.pulsar.broker.loadbalance.extensions.ExtensibleLoadManagerImplTest.initializeState > 3 > > org.apache.pulsar.broker.loadbalance.extensions.ExtensibleLoadManagerImplTest.testAssign > 2 > More flaky test issues: > > https://github.com/apache/pulsar/issues?q=flaky+sort%3Aupdated-desc+is%3Aopen+is:issue > > > To coordinate the work, > 1) please search for an existing issues or search for all flaky issues with > "flaky" or the test class name (without package) in the search: > > https://github.com/apache/pulsar/issues?q=is%3Aopen+flaky+sort%3Aupdated-desc > 2) If there isn't an issue for a particular flaky test failure that you'd > like to fix, please create an issue using the "Flaky test" template at > https://github.com/apache/pulsar/issues/new/choose > 3) Please comment on the issue that you are working on. > > > More contributions are welcome! > Nicolò Boschi >
