Re: [DISCUSS] We must change the way we review PIPs
Summarizing so far: Non-binding: Girish Sharma, Nitin Goyal Binding: Christophe Bornet, Penghui Li, Jun Ma, Yu Liu, Lari Questions: 1. Girish - Why do we need to keep the voting in the mailng list? Since it’s mandatory by ASF. Also, I prefer to change the process step by step. This is a big change as it is. 2. Tison - Do we keep the voting in the mailing list? Yes 3. Enrico: Discussion on high level details should remain in the mailing list. Judging from PIPs I read, I would say the majority of the feedback is not in the scope of the PIP, but in the scope certain section / part of the PIP. if 90% of the comments already transpire in the PR, I don’t think it will benefit for the mere 10%. Also, human beings are hard at using two systems at the same time :) A big plus for discussions on PR is that it’s public and everybody can pitch in (For example, Eron Wright was invited to help on a PIP for Open ID Connect (Michael) by team members. If the barrier was: joing the mailing list, we wouldn’t get it. If it’s very critical for you, we can just leave it open, and let people decide where to comment. WDYT? 4. Lari - can we consider separate repo. It’s possible of course, but I fear the following: - It’s yet another repo to clone and search. Majority of PIPs are Pulsar related and majority of Pulsar contributors have that cloned, used and up to date weekly / daily. It’s would create less friction if it is on main repo. You need to search? Pulsar is already there, ready. - Previous discussion long time ago had many decision points which eventually “klled” the initiative. We can always move it if it really causes a pain point to many people. WDYT? > On 31 Mar 2023, at 23:05, Lari Hotari wrote: > > +1 > > Could we consider a separate repository for the PIP files? > > -Lari > > On Thu, 30 Mar 2023, 23.27 Asaf Mesika, wrote: > >> Hi all, >> >> In the last 2 months, I've increased my PIP review time (I do it in >> cycles), and reviewed quite a few PIPs. >> >> My conclusion as a result of that: >> >> It's nearly impossible to review PIPs using a mailing list. >> We must fix it soon. >> >> *Why?* >> 1. Let's say you review the PIP and find 10 issues. Once you quote and >> comment on those ten points, you basically started 10 threads of >> conversations. >> After 2-3 ping pongs with quotes of quotes of quotes, it takes you forever >> to read each thread properly. You find your CTRL-F to search to find your >> original quote, and reply. Load it up again in your head, switching to the >> PIP tab to read it again. >> After 10 ping pongs, it becomes almost an impossible mission. >> >> I can say I'm 75% tired just from the process, not from the review itself. >> >> 2. It's non collaborative by design. >> After 10 ping pongs, the ability of someone to come and join the discussion >> is 0. They need to go through so many replies, which are half quotes, find >> the original reply, and browse to the PIP. >> It's no wonder people drop off the PIP review once we cross 5-6 replies. >> It's no wonder, nobody joins after 10 replies. >> >> 3. It's not open to the public. Non collaborative. >> You can't just get a link, and join the review. Not only because of (1) and >> (2). You need to join the mailing list. You don't get the past emails to >> reply. Just joining the list is a high enough bar for many people. >> I personally participated in review of proposals in OpenTelemetry in the >> last 6 months, even though I'm just an occasional user. Why? They were >> conducted on GitHub PR , so it was easy for me - click a link and reply. >> >> 4. All over the place >> Sometimes people comment on the GitHub issue. >> Sometimes on the mailing list. >> Not a single place. >> >> 5. No history. >> Ok, finally the author was convinced. I can't see just the changes. They >> need to explicitly tell me something was changed. >> >> 6. Delete All. >> They can go crazy, after 1 year, edit the GitHub issue , delete all the >> text and write "Kafka is the king". No history, nobody can stop them. It's >> their issue. >> >> 7. Show me all the approved PIPs >> Hard to track it today, hard to maintain it updated. >> >> 8. Resolved comments >> Even though you managed to read all 35 replies so far, in reply 36 you see >> the author agreed to all 8 out of 10 suggestions. You have no idea of >> knowing that in advance. You just wasted 1 hour. >> >> >> *What do I suggest?* >> >> PR is the main tool we have that allows multiple threaded discussion. >> Git provides history. You can't delete it without approval from PMC >> members. >> >> 1. We'll create a folder named "pip" in the pulsar main repo. It will >> contain one markdown file for each PIP. The file will be named >> "pip-xxx.md".I will write below how to obtain XXX before you start. >> 2. To create a PIP, you grab "pip/template.md" and use it to compose your >> file in the pip folder. >> 3. You submit this file as a PR named "PIP-xxx: short description". >
Re: [VOTE] Pulsar Release 2.9.5 Candidate 2
+1 (Binding) • Built from the source package (maven 3.8.6 OpenJDK 11.0) • Ran binary package standalone with pub/sub • Ran docker image(pulsar-all) standalone with pub/sub • Ran License check Best, Mattison On Mar 28, 2023, 22:23 +0800, guo jiwei , wrote: > +1 (binding) > > - Checked the signature > - Start standalone > - Publish and consume messages > - Verified Function and State Function > - Verified Cassandra connector > - Build from the source package > > > > Regards > Jiwei Guo (Tboy) > > On Tue, Mar 28, 2023 at 2:34 PM 丛搏 wrote: > > > > +1 (binding) > > > > os: mac 12.3.1, Intel > > java: OpenJDK 17.0.1 > > > > - Checked the signature > > - Checked LICENSE > > - Start standalone > > - Publish and consume messages > > - Verified Function and State Function > > - Verified Cassandra connector > > - Build from the source package (maven 3.8.6, openJDK 17.0.1) > > - Run a simple transaction check > > > > Thanks, > > Bo > > > > Cong Zhao 于2023年3月27日周一 23:09写道： > > > > > > > > This is the third release candidate for Apache Pulsar, version 2.9.5. > > > > > > > > This release contains 103 commits by 30 contributors. > > > > https://github.com/apache/pulsar/compare/v2.9.4...v2.9.5-candidate-2 > > > > > > > > *** Please download, test, and vote on this release. This vote will stay > > > > open > > > > for at least 72 hours *** > > > > > > > > Note that we are voting upon the source (tag), binaries are provided for > > > > convenience. > > > > > > > > Source and binary files: > > > > https://dist.apache.org/repos/dist/dev/pulsar/pulsar-2.9.5-candidate-2/ > > > > > > > > SHA-512 checksums: > > > > 5e1d0c1b38441cdcb36a2f4e59ab9755b39a5c4a0136e078e91ab9bc2169016f195268692cafd6f13a45248dba2e97959b41f3cfbc8659e3cbd0bade0c954998 > > > > apache-pulsar-2.9.5-bin.tar.gz > > > > > > > > 72c9f47005636c6e629dd5117b15fdc13bfd9c7efe107be77a9d55b7dfcdda2f941003eb120ea8beeffe44c41bc41c385a2e5a9cb6540d2fe83a6d04ea53a7389d > > > > apache-pulsar-2.9.5-src.tar.gz > > > > > > > > 73d286af64e189cf91c0511d360d98371b7ade1eec67bc6acf6ff766784e9e40388d3da8ae99a206369feaf398b254fff36e2206077041c37b8055ee7edde86eea > > > > apache-pulsar-offloaders-2.9.5-bin.tar.gz > > > > > > > > Maven staging repo: > > > > https://repository.apache.org/content/repositories/orgapachepulsar-1222/ > > > > > > > > The tag to be voted upon: > > > > v2.9.5-candidate-2 (c75c811ee48f51cf74f399f5b364bc1527186b34) > > > > https://github.com/apache/pulsar/releases/tag/v2.9.5-candidate-2 > > > > > > > > Pulsar's KEYS file containing PGP keys you use to sign the release: > > > > https://downloads.apache.org/pulsar/KEYS > > > > > > > > Docker images: > > > > > > > > > > > > https://hub.docker.com/layers/czcoder/pulsar/2.9.5/images/sha256-c6d3435d5699cb3697ee2ddc4f8a45e0ac5e35d8aefd557e280b7cf91366b981?context=explore > > > > > > > > > > > > https://hub.docker.com/layers/czcoder/pulsar-all/2.9.5/images/sha256-a09a8e177ca7856c29dc8b9828cd293c6d44b473add20d1877bb3137b94a20c5?context=explore > > > > > > > > > > > > https://hub.docker.com/layers/czcoder/pulsar-grafana/2.9.5/images/sha256-c43a489c65cf6c407d6c3be6fc7a001227805b1aaa9413115cf55ba11a1e329f?context=explore > > > > > > > > Please download the source package, and follow the README to build > > > > and run the Pulsar standalone service. > > > > > > > > Thanks > > > > Cong Zhao
Re: [DISCUSS] We must change the way we review PIPs
Sent from my iPhone > On Apr 2, 2023, at 7:35 AM, Asaf Mesika wrote: > > Summarizing so far: > > Non-binding: Girish Sharma, Nitin Goyal > Binding: Christophe Bornet, Penghui Li, Jun Ma, Yu Liu, Lari > > Questions: > 1. Girish - Why do we need to keep the voting in the mailng list? > > Since it’s mandatory by ASF. > Also, I prefer to change the process step by step. This is a big change as it > is. Voting on PIPs is something that this PMC decided to do. The ASF mandatory dev list voting is for RELEASES. (and privately for committers and PMC members) I also agree that it is a big change and let’s keep changes minimal. > > 2. Tison - Do we keep the voting in the mailing list? > > Yes > > 3. Enrico: Discussion on high level details should remain in the mailing list. > > Judging from PIPs I read, I would say the majority of the feedback is not in > the scope of the PIP, but in the scope certain section / part of the PIP. if > 90% of the comments already transpire in the PR, I don’t think it will > benefit for the mere 10%. > Also, human beings are hard at using two systems at the same time :) > > A big plus for discussions on PR is that it’s public and everybody can pitch > in (For example, Eron Wright was invited to help on a PIP for Open ID Connect > (Michael) by team members. If the barrier was: joing the mailing list, we > wouldn’t get it. Subscribing to the mailing list is not a barrier. Simply send an email. The only delay is waiting for a moderator to let in through. I know because I’m likely the one who will do this. (The job is mostly ignoring spam.) It is easy to review emails on https://lists.Apache.org and you can start a reply there. > > If it’s very critical for you, we can just leave it open, and let people > decide where to comment. WDYT? > > 4. Lari - can we consider separate repo. > > It’s possible of course, but I fear the following: > - It’s yet another repo to clone and search. Majority of PIPs are Pulsar > related and majority of Pulsar contributors have that cloned, used and up to > date weekly / daily. It’s would create less friction if it is on main repo. > You need to search? Pulsar is already there, ready. Not all PIPs are necessarily about the main repository. Since we publish pips in the website doing these PRs in the pulsar-site repository might be a good option. > - Previous discussion long time ago had many decision points which eventually > “klled” the initiative. > > We can always move it if it really causes a pain point to many people. > > WDYT? Thanks for your initiative! Best, Dave > > > > > > > > >> On 31 Mar 2023, at 23:05, Lari Hotari wrote: >> >> +1 >> >> Could we consider a separate repository for the PIP files? >> >> -Lari >> >>> On Thu, 30 Mar 2023, 23.27 Asaf Mesika, wrote: >>> >>> Hi all, >>> >>> In the last 2 months, I've increased my PIP review time (I do it in >>> cycles), and reviewed quite a few PIPs. >>> >>> My conclusion as a result of that: >>> >>> It's nearly impossible to review PIPs using a mailing list. >>> We must fix it soon. >>> >>> *Why?* >>> 1. Let's say you review the PIP and find 10 issues. Once you quote and >>> comment on those ten points, you basically started 10 threads of >>> conversations. >>> After 2-3 ping pongs with quotes of quotes of quotes, it takes you forever >>> to read each thread properly. You find your CTRL-F to search to find your >>> original quote, and reply. Load it up again in your head, switching to the >>> PIP tab to read it again. >>> After 10 ping pongs, it becomes almost an impossible mission. >>> >>> I can say I'm 75% tired just from the process, not from the review itself. >>> >>> 2. It's non collaborative by design. >>> After 10 ping pongs, the ability of someone to come and join the discussion >>> is 0. They need to go through so many replies, which are half quotes, find >>> the original reply, and browse to the PIP. >>> It's no wonder people drop off the PIP review once we cross 5-6 replies. >>> It's no wonder, nobody joins after 10 replies. >>> >>> 3. It's not open to the public. Non collaborative. >>> You can't just get a link, and join the review. Not only because of (1) and >>> (2). You need to join the mailing list. You don't get the past emails to >>> reply. Just joining the list is a high enough bar for many people. >>> I personally participated in review of proposals in OpenTelemetry in the >>> last 6 months, even though I'm just an occasional user. Why? They were >>> conducted on GitHub PR , so it was easy for me - click a link and reply. >>> >>> 4. All over the place >>> Sometimes people comment on the GitHub issue. >>> Sometimes on the mailing list. >>> Not a single place. >>> >>> 5. No history. >>> Ok, finally the author was convinced. I can't see just the changes. They >>> need to explicitly tell me something was changed. >>> >>> 6. Delete All. >>> They can go crazy, after 1 year, edit the GitHub issue , delete all the >>> text
Re: [VOTE] Pulsar Release 2.10.4 Candidate 3
+1 (Binding) • Built from the source package (maven 3.8.6 OpenJDK 11.0) • Ran binary package standalone with pub/sub • Ran docker image(pulsar-all) standalone with pub/sub • Ran License check Best, Mattison On Mar 27, 2023, 18:58 +0800, 丛搏 , wrote: > +1(binding) > > Please ignore the previous reply, I read it wrong, sorry. > > +1 (binding) > > os: mac 12.3.1, Intel > java: OpenJDK 17.0.1 > > - Checked the signature > - Checked LICENSE > - Start standalone > - Publish and consume messages > - Verified Function and State Function > - Verified Cassandra connector > - Build from the source package (maven 3.8.6, openJDK 11.0.12) > - Run a simple transaction check > > Thanks, > Bo > > > 丛搏 于2023年3月27日周一 18:20写道： > > > > > Hi, Xiangying: > > > > I found in > > https://dist.apache.org/repos/dist/dev/pulsar/pulsar-2.10.4-candidate-3/connectors/ > > has two pulsar-io-debezium-mssql-2.10.4.nar > > > > Thanks, > > Bo > > > > guo jiwei 于2023年3月23日周四 18:27写道： > > > > > > > > +1 (binding) > > > > > > > > - Checked the signature > > > > - Checked LICENSE > > > > - Publish and consume messages > > > > - Verified Function and State Function > > > > - Verified Cassandra connector > > > > - Build from the source package > > > > > > > > > > > > Regards > > > > Jiwei Guo (Tboy) > > > > > > > > On Wed, Mar 22, 2023 at 3:08 PM Xiangying Meng > > > > wrote: > > > > > > > > > > > > This is the third release candidate for Apache Pulsar, version > > > > > > 2.10.4. > > > > > > > > > > > > This release contains 111 commits by 35 contributors. > > > > > > https://github.com/apache/pulsar/compare/v2.10.3...v2.10.4-candidate-3 > > > > > > > > > > > > *** Please download, test and vote on this release. This vote will > > > > > > stay open > > > > > > for at least 72 hours *** > > > > > > > > > > > > Note that we are voting upon the source (tag), binaries are > > > > > > provided for > > > > > > convenience. > > > > > > > > > > > > Source and binary files: > > > > > > https://dist.apache.org/repos/dist/dev/pulsar/pulsar-2.10.4-candidate-3/ > > > > > > > > > > > > SHA-512 checksums: > > > > > > 59f0326643cca9ef16b45b4b522ab5a1c1d8dc32ac19897704f8231f9bd4cef02af722848646332db461a807daacc9cb87993b81dcf1429b1f23e3872a32 > > > > > > apache-pulsar-2.10.4-bin.tar.gz > > > > > > 5b2adbf0d371b79b1dbe141f152848049d19924151fa8827057038d81833accd70cf67429cb003aedb8d44ee705ed0609d49757e74fed377dce77b09d49062e3 > > > > > > apache-pulsar-2.10.4-src.tar.gz > > > > > > > > > > > > Maven staging repo: > > > > > > https://repository.apache.org/content/repositories/orgapachepulsar-1221/ > > > > > > > > > > > > The tag to be voted upon: > > > > > > v2.10.4-candidate-3 > > > > > > (e4898ac8eb37f698f29aa21e40a3abdda5489d45) > > > > > > https://github.com/apache/pulsar/releases/tag/v2.10.4-candidate-3 > > > > > > > > > > > > Pulsar's KEYS file containing PGP keys you use to sign the release: > > > > > > https://downloads.apache.org/pulsar/KEYS > > > > > > > > > > > > Docker images: > > > > > > > > > > > > > > > > > > https://hub.docker.com/layers/xiangyingmeng/pulsar/2.10.4/images/sha256-05bfb482c5b5aa66ac818651d8997745ac7d536ca0cb56bff8199a6de459ac45?context=repo > > > > > > > > > > > > > > > > > > https://hub.docker.com/layers/xiangyingmeng/pulsar-all/2.10.4/images/sha256-d4f3de64a8ec4a9039ac500bbf4a0efae9a9f1d4e0a58e11cab020276dc5e6b3?context=repo > > > > > > > > > > > > Please download the source package, and follow the README to build > > > > > > and run the Pulsar standalone service.
Re: [VOTE] Pulsar Release 2.9.5 Candidate 2
+1 (binding) - Start standalone - Use pulsar-perf to produce and consume - Function and state function works - Cassandra connector works Regards, Penghui On Sun, Apr 2, 2023 at 10:57 PM wrote: > +1 (Binding) > > • Built from the source package (maven 3.8.6 OpenJDK 11.0) > • Ran binary package standalone with pub/sub > • Ran docker image(pulsar-all) standalone with pub/sub > • Ran License check > > > Best, > Mattison > On Mar 28, 2023, 22:23 +0800, guo jiwei , wrote: > > +1 (binding) > > > > - Checked the signature > > - Start standalone > > - Publish and consume messages > > - Verified Function and State Function > > - Verified Cassandra connector > > - Build from the source package > > > > > > > > Regards > > Jiwei Guo (Tboy) > > > > On Tue, Mar 28, 2023 at 2:34 PM 丛搏 wrote: > > > > > > +1 (binding) > > > > > > os: mac 12.3.1, Intel > > > java: OpenJDK 17.0.1 > > > > > > - Checked the signature > > > - Checked LICENSE > > > - Start standalone > > > - Publish and consume messages > > > - Verified Function and State Function > > > - Verified Cassandra connector > > > - Build from the source package (maven 3.8.6, openJDK 17.0.1) > > > - Run a simple transaction check > > > > > > Thanks, > > > Bo > > > > > > Cong Zhao 于2023年3月27日周一 23:09写道： > > > > > > > > > > This is the third release candidate for Apache Pulsar, version > 2.9.5. > > > > > > > > > > This release contains 103 commits by 30 contributors. > > > > > > https://github.com/apache/pulsar/compare/v2.9.4...v2.9.5-candidate-2 > > > > > > > > > > *** Please download, test, and vote on this release. This vote > will stay > > > > > open > > > > > for at least 72 hours *** > > > > > > > > > > Note that we are voting upon the source (tag), binaries are > provided for > > > > > convenience. > > > > > > > > > > Source and binary files: > > > > > > https://dist.apache.org/repos/dist/dev/pulsar/pulsar-2.9.5-candidate-2/ > > > > > > > > > > SHA-512 checksums: > > > > > > 5e1d0c1b38441cdcb36a2f4e59ab9755b39a5c4a0136e078e91ab9bc2169016f195268692cafd6f13a45248dba2e97959b41f3cfbc8659e3cbd0bade0c954998 > > > > > apache-pulsar-2.9.5-bin.tar.gz > > > > > > > > > > > 72c9f47005636c6e629dd5117b15fdc13bfd9c7efe107be77a9d55b7dfcdda2f941003eb120ea8beeffe44c41bc41c385a2e5a9cb6540d2fe83a6d04ea53a7389d > > > > > apache-pulsar-2.9.5-src.tar.gz > > > > > > > > > > > 73d286af64e189cf91c0511d360d98371b7ade1eec67bc6acf6ff766784e9e40388d3da8ae99a206369feaf398b254fff36e2206077041c37b8055ee7edde86eea > > > > > apache-pulsar-offloaders-2.9.5-bin.tar.gz > > > > > > > > > > Maven staging repo: > > > > > > https://repository.apache.org/content/repositories/orgapachepulsar-1222/ > > > > > > > > > > The tag to be voted upon: > > > > > v2.9.5-candidate-2 (c75c811ee48f51cf74f399f5b364bc1527186b34) > > > > > https://github.com/apache/pulsar/releases/tag/v2.9.5-candidate-2 > > > > > > > > > > Pulsar's KEYS file containing PGP keys you use to sign the release: > > > > > https://downloads.apache.org/pulsar/KEYS > > > > > > > > > > Docker images: > > > > > > > > > > > > > > > > https://hub.docker.com/layers/czcoder/pulsar/2.9.5/images/sha256-c6d3435d5699cb3697ee2ddc4f8a45e0ac5e35d8aefd557e280b7cf91366b981?context=explore > > > > > > > > > > > > > > > > https://hub.docker.com/layers/czcoder/pulsar-all/2.9.5/images/sha256-a09a8e177ca7856c29dc8b9828cd293c6d44b473add20d1877bb3137b94a20c5?context=explore > > > > > > > > > > > > > > > > https://hub.docker.com/layers/czcoder/pulsar-grafana/2.9.5/images/sha256-c43a489c65cf6c407d6c3be6fc7a001227805b1aaa9413115cf55ba11a1e329f?context=explore > > > > > > > > > > Please download the source package, and follow the README to build > > > > > and run the Pulsar standalone service. > > > > > > > > > > Thanks > > > > > Cong Zhao >
Re: [VOTE] Pulsar Client Go Release 0.10.0 Candidate 1
Thank you for verifying this release. Closing the vote: 3 binding +1s: * Nozomi Kurihara * Yunze Xu * Mattison 2 non-binding +1s: * Baodi Shi * Takeshi Kimura BR, Zike Yang On Sat, Apr 1, 2023 at 8:43 PM wrote: > > +1 (binding) > > • Built the project > • Ran the simple producer & consumer with pulsar 2.9.4, 2.10.3, 2.11.0 > > > Best, > Mattison > On Mar 30, 2023, 17:39 +0800, Takeshi Kimura , wrote: > > +1 (non-binding) > > > > - verified checksum and signature > > - ran producer and consumer examples > > > > Regards, > > Takeshi Kimura > > > > -元のメッセージ- > > 送信元: Zike Yang > > Reply-To: "dev@pulsar.apache.org" > > 日付: 2023年3月27日 月曜日 21:23 > > 宛先: "dev@pulsar.apache.org" > > 件名: [VOTE] Pulsar Client Go Release 0.10.0 Candidate 1 > > > > Hi everyone, > > Please review and vote on the release candidate #1 for the version > > 0.10.0, as follows: > > [ ] +1, Approve the release > > [ ] -1, Do not approve the release (please provide specific comments) > > > > This is the first release candidate for Apache Pulsar Go client, version > > 0.10.0. > > > > It fixes the following issues: > > https://github.com/apache/pulsar-client-go/milestone/12?closed=1 > > > > Pulsar Client Go's KEYS file contains PGP keys we used to sign this release: > > https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev%2Fpulsar%2FKEYS&data=05%7C01%7Ctakeshki%40yahoo-corp.jp%7C7fa931e704744220829608db2ebe1fcb%7Ca208d369cd4e4f87b11998eaf31df2c3%7C1%7C0%7C638155166332495746%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=sriR%2Bg7eOnCvQ8S5iKk26fND24GXgZXmXDbxcuYMieI%3D&reserved=0 > > > > Please download these packages and review this release candidate: > > - Review release notes: https://github.com/apache/pulsar-client-go/pull/997 > > - Download the source package (verify shasum, and asc) and follow the > > README.md to build and run the pulsar-client-go. > > > > The vote will be open for at least 72 hours. It is adopted by majority > > approval, with at least 3 PMC affirmative votes. > > > > Source file: > > https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev%2Fpulsar%2Fpulsar-client-go-0.10.0-candidate-1%2F&data=05%7C01%7Ctakeshki%40yahoo-corp.jp%7C7fa931e704744220829608db2ebe1fcb%7Ca208d369cd4e4f87b11998eaf31df2c3%7C1%7C0%7C638155166332495746%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=%2F64IHSR%2BcwQZXxJ%2BMsEag9DmMG0lt3IzHBLCLCnM150%3D&reserved=0 > > > > The tag to be voted upon: > > v0.10.0 > > https://github.com/apache/pulsar-client-go/tree/v0.10.0-candidate-1 > > > > SHA-512 checksums: > > 5f26d95061eb535595043ffc23424d9913f11d1b80ca815bdd20577453f6e08c2a5dd8b729d82494c4f5d0260905b231218c6a437995d893c4c25efdb0bb > > apache-pulsar-client-go-0.10.0-src.tar.gz > > > > Zike Yang > >
Re: [DISCUSS] We must change the way we review PIPs
+1 I support having the high-level discussion on the ML, but I can see that becoming confusing if there are multiple places to discuss the PIP. In my view, GitHub is great when you want to discuss specific lines in a PR, but general discussion on the PR's main page is essentially the same as a mailing list, except the formatting is generally better. One issue will be PIP numbering. If we only merge accepted PIPs, but all PIPs get numbers, we'll have holes in our pip/ directory. It might be worth adding a README.md to the pip directory that both explains the process and enumerates the PIPs (both accepted and rejected). For historical reference, Christophe proposed this change within this thread: https://lists.apache.org/thread/m8dr0hz7qn7rkd48bcp430lcq2q3674g The primary objection was a concern about losing PIPs and the issue of questions about merges. I think we'll be able to address those concerns. Thanks, Michael On Sun, Apr 2, 2023 at 11:14 AM Dave Fisher wrote: > > > > Sent from my iPhone > > > On Apr 2, 2023, at 7:35 AM, Asaf Mesika wrote: > > > > Summarizing so far: > > > > Non-binding: Girish Sharma, Nitin Goyal > > Binding: Christophe Bornet, Penghui Li, Jun Ma, Yu Liu, Lari > > > > Questions: > > 1. Girish - Why do we need to keep the voting in the mailng list? > > > > Since it’s mandatory by ASF. > > Also, I prefer to change the process step by step. This is a big change as > > it is. > > Voting on PIPs is something that this PMC decided to do. The ASF mandatory > dev list voting is for RELEASES. (and privately for committers and PMC > members) > > I also agree that it is a big change and let’s keep changes minimal. > > > > > 2. Tison - Do we keep the voting in the mailing list? > > > > Yes > > > > 3. Enrico: Discussion on high level details should remain in the mailing > > list. > > > > Judging from PIPs I read, I would say the majority of the feedback is not > > in the scope of the PIP, but in the scope certain section / part of the > > PIP. if 90% of the comments already transpire in the PR, I don’t think it > > will benefit for the mere 10%. > > Also, human beings are hard at using two systems at the same time :) > > > > A big plus for discussions on PR is that it’s public and everybody can > > pitch in (For example, Eron Wright was invited to help on a PIP for Open ID > > Connect (Michael) by team members. If the barrier was: joing the mailing > > list, we wouldn’t get it. > > Subscribing to the mailing list is not a barrier. Simply send an email. The > only delay is waiting for a moderator to let in through. I know because I’m > likely the one who will do this. (The job is mostly ignoring spam.) > > It is easy to review emails on https://lists.Apache.org and you can start a > reply there. > > > > If it’s very critical for you, we can just leave it open, and let people > > decide where to comment. WDYT? > > > > 4. Lari - can we consider separate repo. > > > > It’s possible of course, but I fear the following: > > - It’s yet another repo to clone and search. Majority of PIPs are Pulsar > > related and majority of Pulsar contributors have that cloned, used and up > > to date weekly / daily. It’s would create less friction if it is on main > > repo. You need to search? Pulsar is already there, ready. > > Not all PIPs are necessarily about the main repository. Since we publish pips > in the website doing these PRs in the pulsar-site repository might be a good > option. > > > - Previous discussion long time ago had many decision points which > > eventually “klled” the initiative. > > > > We can always move it if it really causes a pain point to many people. > > > > WDYT? > > Thanks for your initiative! > > Best, > Dave > > > > > > > > > > > > > > > > > >> On 31 Mar 2023, at 23:05, Lari Hotari wrote: > >> > >> +1 > >> > >> Could we consider a separate repository for the PIP files? > >> > >> -Lari > >> > >>> On Thu, 30 Mar 2023, 23.27 Asaf Mesika, wrote: > >>> > >>> Hi all, > >>> > >>> In the last 2 months, I've increased my PIP review time (I do it in > >>> cycles), and reviewed quite a few PIPs. > >>> > >>> My conclusion as a result of that: > >>> > >>> It's nearly impossible to review PIPs using a mailing list. > >>> We must fix it soon. > >>> > >>> *Why?* > >>> 1. Let's say you review the PIP and find 10 issues. Once you quote and > >>> comment on those ten points, you basically started 10 threads of > >>> conversations. > >>> After 2-3 ping pongs with quotes of quotes of quotes, it takes you forever > >>> to read each thread properly. You find your CTRL-F to search to find your > >>> original quote, and reply. Load it up again in your head, switching to the > >>> PIP tab to read it again. > >>> After 10 ping pongs, it becomes almost an impossible mission. > >>> > >>> I can say I'm 75% tired just from the process, not from the review itself. > >>> > >>> 2. It's non collaborative by design. > >>> After 10 ping pongs, the ability of someone to come and join the > >
Re: [VOTE] PIP-254: Support configuring client version with a description suffix
+1 (binding) Thanks, Michael On Wed, Mar 29, 2023 at 3:51 AM Enrico Olivelli wrote: > > +1 (binding) > > Enrico > > Il giorno mer 29 mar 2023 alle ore 09:16 丛搏 ha scritto: > > > > +1 (binding) > > > > Thanks, > > Bo > > > > Lin Lin 于2023年3月27日周一 17:49写道： > > > > > > +1 > > > > > > Thanks, > > > Lin Lin > > > > > > On 2023/03/15 07:54:20 Yunze Xu wrote: > > > > Hi all, > > > > > > > > This thread is to start the vote for PIP-254. > > > > > > > > Discussion thread: > > > > https://lists.apache.org/thread/65cf7w76tt23sbsjnr8rpfxqf1nt9s9l > > > > > > > > PIP link: https://github.com/apache/pulsar/issues/19705 > > > > > > > > Thanks, > > > > Yunze > > > >
Re: [VOTE] Pulsar Release 2.11.1 Candidate-1
-1 (non-binding) The PR 19989[1] fixes an issue that non-super role users cannot access the tenant's API event if disabled authorization. We should wait for this PR merge, Thanks Yubiao Feng [1] https://github.com/apache/pulsar/pull/19989 On Wed, Mar 22, 2023 at 4:52 PM guo jiwei wrote: > This is the first release candidate for Apache Pulsar, version 2.11.1. > > This release contains 188 commits by 53 contributors. > https://github.com/apache/pulsar/compare/v2.11.0...v2.11.1-candidate-1 > > CI for this release candidate > https://github.com/Technoboy-/pulsar/pull/28 > > *** Please download, test and vote on this release. This vote will stay > open > for at least 72 hours *** > > Note that we are voting upon the source (tag), binaries are provided for > convenience. > > Source and binary files: > https://dist.apache.org/repos/dist/dev/pulsar/pulsar-2.11.1-candidate-1 > > SHA-512 checksums: > > > 7bd5c432fdb888dfcc2a1595efe29206545db535ea996aa4d1ff851e957cc88ce4b54fce912dde84baf8ed40217149a0acffad6c49f02f348721350e5ae895dd > > ./apache-pulsar-2.11.1-bin.tar.gz > > > > 9e7bfac98e57a2a61216da77e48843bc4274828c9da1e695538d92a3ee929b52c4b0d2280feb73980d77f02c03f3c2dbc797673e69df19190ffee8e46760f305 > > ./apache-pulsar-2.11.1-src.tar.gz > > Maven staging repo: > https://repository.apache.org/content/repositories/orgapachepulsar-1220/ > > The tag to be voted upon: > v2.11.1-candidate-1 (7cc41d7dec415acfeb1f96b68faaa2a80440e070) > https://github.com/apache/pulsar/releases/tag/v2.11.1-candidate-1 > > Pulsar's KEYS file containing PGP keys we use to sign the release: > https://dist.apache.org/repos/dist/dev/pulsar/KEYS > > > https://hub.docker.com/layers/mattison/pulsar-all/2.11.1-rc1/images/sha256-3d2c0bacbc6d34fa656466370744dedfd2b5a79df7a1178ea2fad27a6d6a > > > https://hub.docker.com/layers/mattison/pulsar/2.11.1-rc1/images/sha256-1fda65d5637ad579ee36ab09448eb6ff3831583a9ef5b543bae78a565813cd95 > > Please download the source package, and follow the > release-candidate-validation doc to build > and run the Pulsar standalone service. > https://pulsar.apache.org/contribute/validate-release-candidate > > Since the metadata store is changed from ZK to RocksDB, the > verification of the `stateful functions` needs to set the parameter > "export PULSAR_STANDALONE_USE_ZOOKEEPER=1" > > > Regards > Jiwei Guo (Tboy) >
Re: [VOTE] Pulsar Release 2.10.4 Candidate 3
-1 (non-binding) - The PR 19989[1] fixes an issue that non-super role users cannot access the tenant's API event if disabled authorization. We should wait for this PR merge, - The PR 19971[2] fixes the un-forward-compatibility config `saslJaasServerRoleTokenSignerSecretPath`. We should wait for this PR merge too, Thanks Yubiao Feng [1] https://github.com/apache/pulsar/pull/19989 [2] https://github.com/apache/pulsar/pull/19971 On Wed, Mar 22, 2023 at 3:08 PM Xiangying Meng wrote: > This is the third release candidate for Apache Pulsar, version 2.10.4. > > This release contains 111 commits by 35 contributors. > https://github.com/apache/pulsar/compare/v2.10.3...v2.10.4-candidate-3 > > *** Please download, test and vote on this release. This vote will stay > open > for at least 72 hours *** > > Note that we are voting upon the source (tag), binaries are provided for > convenience. > > Source and binary files: > https://dist.apache.org/repos/dist/dev/pulsar/pulsar-2.10.4-candidate-3/ > > SHA-512 checksums: > > 59f0326643cca9ef16b45b4b522ab5a1c1d8dc32ac19897704f8231f9bd4cef02af722848646332db461a807daacc9cb87993b81dcf1429b1f23e3872a32 > apache-pulsar-2.10.4-bin.tar.gz > > 5b2adbf0d371b79b1dbe141f152848049d19924151fa8827057038d81833accd70cf67429cb003aedb8d44ee705ed0609d49757e74fed377dce77b09d49062e3 > apache-pulsar-2.10.4-src.tar.gz > > Maven staging repo: > https://repository.apache.org/content/repositories/orgapachepulsar-1221/ > > The tag to be voted upon: > v2.10.4-candidate-3 > (e4898ac8eb37f698f29aa21e40a3abdda5489d45) > https://github.com/apache/pulsar/releases/tag/v2.10.4-candidate-3 > > Pulsar's KEYS file containing PGP keys you use to sign the release: > https://downloads.apache.org/pulsar/KEYS > > Docker images: > > > > https://hub.docker.com/layers/xiangyingmeng/pulsar/2.10.4/images/sha256-05bfb482c5b5aa66ac818651d8997745ac7d536ca0cb56bff8199a6de459ac45?context=repo > > > > https://hub.docker.com/layers/xiangyingmeng/pulsar-all/2.10.4/images/sha256-d4f3de64a8ec4a9039ac500bbf4a0efae9a9f1d4e0a58e11cab020276dc5e6b3?context=repo > > Please download the source package, and follow the README to build > and run the Pulsar standalone service. >
Re: [VOTE] Pulsar Release 2.9.5 Candidate 2
-1 (non-binding) - The PR 19989[1] fixes an issue that non-super role users cannot access the tenant's API event if disabled authorization. We should wait for this PR merge, Thanks Yubiao Feng [1] https://github.com/apache/pulsar/pull/19989 On Mon, Mar 27, 2023 at 11:09 PM Cong Zhao wrote: > This is the third release candidate for Apache Pulsar, version 2.9.5. > > This release contains 103 commits by 30 contributors. > https://github.com/apache/pulsar/compare/v2.9.4...v2.9.5-candidate-2 > > *** Please download, test, and vote on this release. This vote will stay > open > for at least 72 hours *** > > Note that we are voting upon the source (tag), binaries are provided for > convenience. > > Source and binary files: > https://dist.apache.org/repos/dist/dev/pulsar/pulsar-2.9.5-candidate-2/ > > SHA-512 checksums: > > 5e1d0c1b38441cdcb36a2f4e59ab9755b39a5c4a0136e078e91ab9bc2169016f195268692cafd6f13a45248dba2e97959b41f3cfbc8659e3cbd0bade0c954998 > apache-pulsar-2.9.5-bin.tar.gz > > > 72c9f47005636c6e629dd5117b15fdc13bfd9c7efe107be77a9d55b7dfcdda2f941003eb120ea8beeffe44c41bc41c385a2e5a9cb6540d2fe83a6d04ea53a7389d > apache-pulsar-2.9.5-src.tar.gz > > > 73d286af64e189cf91c0511d360d98371b7ade1eec67bc6acf6ff766784e9e40388d3da8ae99a206369feaf398b254fff36e2206077041c37b8055ee7edde86eea > apache-pulsar-offloaders-2.9.5-bin.tar.gz > > Maven staging repo: > https://repository.apache.org/content/repositories/orgapachepulsar-1222/ > > The tag to be voted upon: > v2.9.5-candidate-2 (c75c811ee48f51cf74f399f5b364bc1527186b34) > https://github.com/apache/pulsar/releases/tag/v2.9.5-candidate-2 > > Pulsar's KEYS file containing PGP keys you use to sign the release: > https://downloads.apache.org/pulsar/KEYS > > Docker images: > > > > https://hub.docker.com/layers/czcoder/pulsar/2.9.5/images/sha256-c6d3435d5699cb3697ee2ddc4f8a45e0ac5e35d8aefd557e280b7cf91366b981?context=explore > > > > https://hub.docker.com/layers/czcoder/pulsar-all/2.9.5/images/sha256-a09a8e177ca7856c29dc8b9828cd293c6d44b473add20d1877bb3137b94a20c5?context=explore > > > > https://hub.docker.com/layers/czcoder/pulsar-grafana/2.9.5/images/sha256-c43a489c65cf6c407d6c3be6fc7a001227805b1aaa9413115cf55ba11a1e329f?context=explore > > Please download the source package, and follow the README to build > and run the Pulsar standalone service. > > Thanks > Cong Zhao >
Re: [VOTE] Pulsar Release 2.9.5 Candidate 2
I see that the 2.9.5 tag was pushed [0]. How do we handle that situation? Thanks, Michael [0] https://lists.apache.org/thread/rqojf378x9j8p58h0q8zvxg31fo07gn4 On Sun, Apr 2, 2023 at 11:35 PM Yubiao Feng wrote: > > -1 (non-binding) > > - The PR 19989[1] fixes an issue that non-super role users cannot access > the tenant's API event if disabled authorization. We should wait for this > PR merge, > > Thanks > Yubiao Feng > > [1] https://github.com/apache/pulsar/pull/19989 > > On Mon, Mar 27, 2023 at 11:09 PM Cong Zhao wrote: > > > This is the third release candidate for Apache Pulsar, version 2.9.5. > > > > This release contains 103 commits by 30 contributors. > > https://github.com/apache/pulsar/compare/v2.9.4...v2.9.5-candidate-2 > > > > *** Please download, test, and vote on this release. This vote will stay > > open > > for at least 72 hours *** > > > > Note that we are voting upon the source (tag), binaries are provided for > > convenience. > > > > Source and binary files: > > https://dist.apache.org/repos/dist/dev/pulsar/pulsar-2.9.5-candidate-2/ > > > > SHA-512 checksums: > > > > 5e1d0c1b38441cdcb36a2f4e59ab9755b39a5c4a0136e078e91ab9bc2169016f195268692cafd6f13a45248dba2e97959b41f3cfbc8659e3cbd0bade0c954998 > > apache-pulsar-2.9.5-bin.tar.gz > > > > > > 72c9f47005636c6e629dd5117b15fdc13bfd9c7efe107be77a9d55b7dfcdda2f941003eb120ea8beeffe44c41bc41c385a2e5a9cb6540d2fe83a6d04ea53a7389d > > apache-pulsar-2.9.5-src.tar.gz > > > > > > 73d286af64e189cf91c0511d360d98371b7ade1eec67bc6acf6ff766784e9e40388d3da8ae99a206369feaf398b254fff36e2206077041c37b8055ee7edde86eea > > apache-pulsar-offloaders-2.9.5-bin.tar.gz > > > > Maven staging repo: > > https://repository.apache.org/content/repositories/orgapachepulsar-1222/ > > > > The tag to be voted upon: > > v2.9.5-candidate-2 (c75c811ee48f51cf74f399f5b364bc1527186b34) > > https://github.com/apache/pulsar/releases/tag/v2.9.5-candidate-2 > > > > Pulsar's KEYS file containing PGP keys you use to sign the release: > > https://downloads.apache.org/pulsar/KEYS > > > > Docker images: > > > > > > > > https://hub.docker.com/layers/czcoder/pulsar/2.9.5/images/sha256-c6d3435d5699cb3697ee2ddc4f8a45e0ac5e35d8aefd557e280b7cf91366b981?context=explore > > > > > > > > https://hub.docker.com/layers/czcoder/pulsar-all/2.9.5/images/sha256-a09a8e177ca7856c29dc8b9828cd293c6d44b473add20d1877bb3137b94a20c5?context=explore > > > > > > > > https://hub.docker.com/layers/czcoder/pulsar-grafana/2.9.5/images/sha256-c43a489c65cf6c407d6c3be6fc7a001227805b1aaa9413115cf55ba11a1e329f?context=explore > > > > Please download the source package, and follow the README to build > > and run the Pulsar standalone service. > > > > Thanks > > Cong Zhao > >
Re: [VOTE] Pulsar Release 2.11.1 Candidate-1
Yes, Thanks Tison and Yubiao. Close this vote. Regards Jiwei Guo (Tboy) On Mon, Apr 3, 2023 at 12:32 PM Yubiao Feng wrote: > > -1 (non-binding) > > The PR 19989[1] fixes an issue that non-super role users cannot access the > tenant's API event if disabled authorization. We should wait for this PR > merge, > > Thanks > Yubiao Feng > > [1] https://github.com/apache/pulsar/pull/19989 > > On Wed, Mar 22, 2023 at 4:52 PM guo jiwei wrote: > > > This is the first release candidate for Apache Pulsar, version 2.11.1. > > > > This release contains 188 commits by 53 contributors. > > https://github.com/apache/pulsar/compare/v2.11.0...v2.11.1-candidate-1 > > > > CI for this release candidate > > https://github.com/Technoboy-/pulsar/pull/28 > > > > *** Please download, test and vote on this release. This vote will stay > > open > > for at least 72 hours *** > > > > Note that we are voting upon the source (tag), binaries are provided for > > convenience. > > > > Source and binary files: > > https://dist.apache.org/repos/dist/dev/pulsar/pulsar-2.11.1-candidate-1 > > > > SHA-512 checksums: > > > > > > 7bd5c432fdb888dfcc2a1595efe29206545db535ea996aa4d1ff851e957cc88ce4b54fce912dde84baf8ed40217149a0acffad6c49f02f348721350e5ae895dd > > > > ./apache-pulsar-2.11.1-bin.tar.gz > > > > > > > > 9e7bfac98e57a2a61216da77e48843bc4274828c9da1e695538d92a3ee929b52c4b0d2280feb73980d77f02c03f3c2dbc797673e69df19190ffee8e46760f305 > > > > ./apache-pulsar-2.11.1-src.tar.gz > > > > Maven staging repo: > > https://repository.apache.org/content/repositories/orgapachepulsar-1220/ > > > > The tag to be voted upon: > > v2.11.1-candidate-1 (7cc41d7dec415acfeb1f96b68faaa2a80440e070) > > https://github.com/apache/pulsar/releases/tag/v2.11.1-candidate-1 > > > > Pulsar's KEYS file containing PGP keys we use to sign the release: > > https://dist.apache.org/repos/dist/dev/pulsar/KEYS > > > > > > https://hub.docker.com/layers/mattison/pulsar-all/2.11.1-rc1/images/sha256-3d2c0bacbc6d34fa656466370744dedfd2b5a79df7a1178ea2fad27a6d6a > > > > > > https://hub.docker.com/layers/mattison/pulsar/2.11.1-rc1/images/sha256-1fda65d5637ad579ee36ab09448eb6ff3831583a9ef5b543bae78a565813cd95 > > > > Please download the source package, and follow the > > release-candidate-validation doc to build > > and run the Pulsar standalone service. > > https://pulsar.apache.org/contribute/validate-release-candidate > > > > Since the metadata store is changed from ZK to RocksDB, the > > verification of the `stateful functions` needs to set the parameter > > "export PULSAR_STANDALONE_USE_ZOOKEEPER=1" > > > > > > Regards > > Jiwei Guo (Tboy) > >
