[DISCUSS] PIP-242: Introduce enableStrictTopicName to reject creating topic with -partition- keyword.

2023-01-28 Thread mattisonchao
Hello everyone.
I hope you guys are all doing well.

I would like to start the discussion for PIP-242 
https://github.com/apache/pulsar/issues/19239,
Please let me know if you have any concerns or questions.

Best,
Mattison

--- Paste original PIP content to help quote --

### Motivation

Currently, the Apache Pulsar broker allows users to create a topic name that 
includes `-partition-`, which is confusing for our developers to identify 
whether this is a partition of a partitioned topic. Plus, we need to add more 
logic to be compatible with this special topic name. for example:

- https://github.com/apache/pulsar/pull/19240
- https://github.com/apache/pulsar/pull/19230
- https://github.com/apache/pulsar/pull/19171
- https://github.com/apache/pulsar/pull/19086
- ...

### Goal
This proposal wants `-partition-` to be a topic name keyword. Users can only 
create a topic with it if the topic is partitioned. For the compatibility 
reason, we want to Introduce a new configuration - `enableStrictTopicName` for 
the broker to help reject creating a topic in the following cases:
1. Create a partitioned topic that includes `-partition-`.
2. Create a topic which is not a partitioned topic.

### API Changes

Add a new configuration, `enableStrictTopicName=false`.

### Implementation

1. Add configuration `enableStrictTopicName=false`.
2. Add rejection logic when the user enables `enableStrictTopicName`.
3. Add warning logs to inform users that we do not recommend creating 
non-partitioned topics with the keyword `-partition-`.
4. Make `enableStrictTopicName=true` in the future.


Re: [DISCUSS] PIP-186: Introduce two phase deletion protocol based on system topic

2023-01-28 Thread Yan Zhao
We need more eyes and votes. Thanks.


Re: [DISCUSS] Code freeze for Pulsar 2.12

2023-01-28 Thread PengHui Li
I have updated the milestone name from 2.12.0 to 3.0.0.

https://github.com/apache/pulsar/milestone/34

Penghui

On Fri, Jan 20, 2023 at 7:07 PM Nicolò Boschi  wrote:

> From my understanding we should follow PIP-175.
> Actually it has not been officially voted on but we can address that
> easily.
>
> Following PIP-175, we have to provide the first LTS release which will be
> 3.0.
> The code freeze should happen 3 weeks before the target date.
> If we target 3 months from now to have 3.0 released, let's say mid April,
> we should consider the time for:
> 1. bureaucracy of the release - ~1 week
> 2. the vote ~ 2 weeks
> 3. the code freeze ~ 3 weeks
>
> So the code freeze should start 6 weeks before the target date, in this
> case at the beginning of March.
> Code freeze is intended as (from PIP-175):
> "The release manager will branch off from master, and he will be
> responsible for selecting the changes that will be cherry-picked in the
> release branch."
>
> So we need to have a release manager that at the beginning of March:
> - creates the 3.0 branch
> - must approve every cherry-pick (the best would be to require to open pull
> requests against the branch 3.0 and have the release manager as submitter
> or reviewer)
> - call the vote on the third week of March
>
>
> This plan makes sense to me.
> The estimate for the above steps are debatable and should be part of
> PIP-175.
>
> Since, as Christophe said, we have tons of new stuff (since August) in the
> master branch we might take a different target date but it also depends on
> the features that are not fully completed but already partially committed
> on the master branch).
> Also this is a new process, it's okay to have some delays for the first LTS
> release.
>
> I'd be happy to guide the 3.0 release
>
> Nicolò Boschi
>
>
> Il giorno ven 20 gen 2023 alle ore 11:46 Christophe Bornet <
> bornet.ch...@gmail.com> ha scritto:
>
> > We could create the release branch some days after the Chinese holidays.
> > The idea is to not wait too long before starting the release activities.
> > Especially since 2.11 has taken so long to release.
> >
> > Le ven. 20 janv. 2023 à 03:41, Dave Fisher  a
> > écrit :
> >
> > > Christophe,
> > >
> > > Given the Chinese New Year what freeze date is being proposed?
> > >
> > > Best,
> > > Dave
> > >
> > > Sent from my iPhone
> > >
> > > > On Jan 19, 2023, at 6:31 PM, Yunze Xu 
> > > wrote:
> > > >
> > > > In addition, next week is the Chinese New Year [1] in China and
> there
> > > > is a long holiday (a week) for Chinese developers. I hope we can
> delay
> > > > this release for a while.
> > > >
> > > > [1] https://en.wikipedia.org/wiki/Chinese_New_Year
> > > >
> > > > Thanks,
> > > > Yunze
> > > >
> > > >> On Fri, Jan 20, 2023 at 10:23 AM Yunze Xu 
> > wrote:
> > > >>
> > > >> I would like to include PIP-224 (even and PIP-229) in the next major
> > > >> releases. These two PIPs have some impacts on the API and could
> bring
> > > >> many benefits to ecosystem developers. But unfortunately the first
> PR
> > > >> of PIP-224 [1] is still not reviewed by anyone. The code has already
> > > >> been added locally and only requires some rebase to resolve
> conflicts.
> > > >>
> > > >> [1] https://github.com/apache/pulsar/pull/19158
> > > >>
> > > >> Thanks,
> > > >> Yunze
> > > >>
> > > >>> On Fri, Jan 20, 2023 at 7:46 AM  wrote:
> > > >>>
> > > >>> Isn't the next version LTS 3.0?
> > > >>>
> > > >>> Best
> > > >>> Mattison
> > > >>> On Jan 20, 2023, 07:11 +0800, Christophe Bornet <
> > > bornet.ch...@gmail.com>, wrote:
> > >  Hi Pulsar community,
> > > 
> > >  It's great that we released Pulsar 2.11. It has taken quite some
> > time
> > > to
> > >  stabilize the release branch and now we have more than 5 months of
> > > awesome
> > >  features and commits on the master branch that would benefit a lot
> > to
> > > our
> > >  users. That's why I'd like to propose to start a code freeze for
> the
> > >  release of Pulsar 2.12 with a target release date by
> > mid/end-february.
> > >  Hopefully this release will be easier to stabilize but we don't
> know
> > > for
> > >  sure, so better to start the release activities asap.
> > >  We also need a release manager. Nicolo proposed himself last time
> > but
> > > had
> > >  to hand over because of his holiday schedule. So Nicolo, maybe
> you'd
> > > like
> > >  to propose yourself again for this one ? Otherwise I'm happy to
> > > volunteer.
> > > 
> > >  Let me know what you think.
> > > 
> > >  Cheers
> > > 
> > >  Christophe
> > >
> >
>