[GitHub] [pulsar] crossoverJie added a comment to the discussion: Is it possible to manually acknowledge messages via msgId?

2022-11-21 Thread GitBox


GitHub user crossoverJie added a comment to the discussion: Is it possible to 
manually acknowledge messages via msgId?

Thanks for the answer, Before this I thought that `individuallyDeletedMessages` 
stored unacknowledged messages.

---
Here is my testing process:

```java
"individuallyDeletedMessages": "[(414:36..414:39]]",
consumer.acknowledge(new MessageIdImpl(414, 35, 1));
consumer.acknowledge(new MessageIdImpl(414, 36, 1));
```
Query `individuallyDeletedMessages` again:
`"individuallyDeletedMessages": "[(414:36..414:39]]",`
The results did not change.

When I restart the consumer:
```java
consumer Message received: 414:35:1:0
consumer Message received: 414:36:1:0
```
The message that was just manually confirmed is still available, At the same 
time:
`"individuallyDeletedMessages": "[]"`

My expected results should be:
After I manually acknowledge the message, the restart consumer does not get the 
message again and at the same time, individuallyDeletedMessages should change.

Is my understanding correct?

thx.

GitHub link: 
https://github.com/apache/pulsar/discussions/18544#discussioncomment-4193283


This is an automatically sent email for dev@pulsar.apache.org.
To unsubscribe, please send an email to: dev-unsubscr...@pulsar.apache.org



[GitHub] [pulsar] crossoverJie added a comment to the discussion: Is it possible to manually acknowledge messages via msgId?

2022-11-21 Thread GitBox


GitHub user crossoverJie added a comment to the discussion: Is it possible to 
manually acknowledge messages via msgId?

The background to my doing this is as follows:

I want to know if the backlog of message topics is caused by message holes.

If so, I would like to manually acknowledge these holes in our admin console 
for the purpose of clearing them.

Have the broker automatically move the `MarkDeletedPosition` and clear the 
backlog of messages.

Any other suggestions to make this work? 
thx.

GitHub link: 
https://github.com/apache/pulsar/discussions/18544#discussioncomment-4193329


This is an automatically sent email for dev@pulsar.apache.org.
To unsubscribe, please send an email to: dev-unsubscr...@pulsar.apache.org



Re: [ANNOUNCE] New Committer: Cong Zhao

2022-11-21 Thread PengHui Li
Congrats! Cong

Thanks,
Penghui

> On Nov 21, 2022, at 13:57, Zixuan Liu  wrote:
> 
> Congrats! Cong
> 
> Best Regards,
> Zixuan
> 
> houxiaoyu  于2022年11月21日周一 12:24写道:
> 
>> Congrats! Cong
>> 
>> Best,
>> Xiaoyu Hou
>> 
>> Haiting Jiang  于2022年11月21日周一 12:10写道:
>> 
>>> The Project Management Committee (PMC) for Apache Pulsar has invited
>>> Cong Zhao (https://github.com/coderzc)
>>> to become a committer and we are pleased to announce that he has
>> accepted.
>>> 
>>> Being a committer enables easier contribution to the
>>> project since there is no need to go via the patch
>>> submission process. This should enable better productivity.
>>> 
>>> Welcome and congratulations, Cong Zhao!
>>> 
>>> Please join us in congratulating and welcoming Cong Zhao onboard!
>>> 
>>> Best Regards,
>>> Haiting on behalf of the Pulsar PMC
>>> 
>> 



[DISCUSS] Release Pulsar Client C++ 3.1.0

2022-11-21 Thread Zike Yang
Hi everyone,

I would like to propose releasing the Pulsar Client C++ 3.1.0

There are several new features and bug fixes in the main branch[0].
And it’s time to release a new version.
Please remind me if you have any important fixes that need to be
included in 3.1.0

[0] https://github.com/apache/pulsar-client-cpp/compare/v3.0.0...main

BR,
Zike Yang


Re: [ANNOUNCE] New Committer: Cong Zhao

2022-11-21 Thread Jun Ma
Congratulations, Cong @coderzc !


From: PengHui Li 
Sent: Monday, November 21, 2022 17:13
To: dev@pulsar.apache.org 
Subject: Re: [ANNOUNCE] New Committer: Cong Zhao

Congrats! Cong

Thanks,
Penghui

> On Nov 21, 2022, at 13:57, Zixuan Liu  wrote:
>
> Congrats! Cong
>
> Best Regards,
> Zixuan
>
> houxiaoyu  于2022年11月21日周一 12:24写道:
>
>> Congrats! Cong
>>
>> Best,
>> Xiaoyu Hou
>>
>> Haiting Jiang  于2022年11月21日周一 12:10写道:
>>
>>> The Project Management Committee (PMC) for Apache Pulsar has invited
>>> Cong Zhao (https://github.com/coderzc)
>>> to become a committer and we are pleased to announce that he has
>> accepted.
>>>
>>> Being a committer enables easier contribution to the
>>> project since there is no need to go via the patch
>>> submission process. This should enable better productivity.
>>>
>>> Welcome and congratulations, Cong Zhao!
>>>
>>> Please join us in congratulating and welcoming Cong Zhao onboard!
>>>
>>> Best Regards,
>>> Haiting on behalf of the Pulsar PMC
>>>
>>



Re: [DIDSCUSS] Realease Pulsar 2.9.4 cherry-pick done

2022-11-21 Thread 丛搏
I have cherry-picked all pr labeled release/2.9.4, so I will start
releasing pulsar-2.9.4v.

Thanks,
Bo

Yunze Xu  于2022年11月18日周五 11:31写道:
>
> https://github.com/apache/pulsar/pull/18486 should be cherry-picked to
> 2.9.4 because it fixes a bug introduced in
> https://github.com/apache/pulsar/pull/18454, which has already been
> cherry-picked.
>
> Thanks,
> Yunze
>
> On Thu, Nov 17, 2022 at 8:26 PM 丛搏  wrote:
> >
> > Hello, Pulsar community:
> >
> > The cherry-pick of 2.9.4 is basically completed.
> > Contains about 300+ PRs.
> > link: 
> > https://github.com/apache/pulsar/pulls?q=is%3Apr+label%3Arelease%2F2.9.4
> >
> > If you still have a pr that must be released in pulsar-2.9.4, please
> > reply to me or ping me on GitHub.
> >
> > Thanks,
> > Bo


[DISCUSS] Modify MessageIdImpl and BatchMessageIdImpl compareTo(MessageId o) method

2022-11-21 Thread 丛搏
Hello, Pulsar community:

now when `BatchMessageIdImpl` and `MessageIdImpl` with the same
`ledgerId` and `EntryId`, one of it compare with the other, the
`BatchMessageIdImpl` will always be greater than MessageIdImpl.
see : 
https://github.com/apache/pulsar/blob/master/pulsar-client/src/main/java/org/apache/pulsar/client/impl/BatchMessageIdImpl.java#L71-L74

https://github.com/apache/pulsar/blob/master/pulsar-client/src/main/java/org/apache/pulsar/client/impl/MessageIdImpl.java#L219-L228

but when we use it, we may think `MessageIdImpl` is bigger than
`BatchMessageIdImpl` with the same `ledgerId` and `EntryId`. It causes
a lot of bugs. I think we need to change this `compareTo()` method,
although it is a public API, I think it is not a breaking change, it
is a bug that needs to be fixed.
eg. : https://github.com/apache/pulsar/pull/18486, need to add the
separate logic for compareTo().

Please leave your thoughts, thanks.

Thanks,
bo


[VOTE] PIP-211: Introduce offload throttling

2022-11-21 Thread Jiuming Tao
Dear Pulsar Community,

Please review and vote on this PIP.

PIP link: https://github.com/apache/pulsar/issues/18004 


Discuss thread: 
https://lists.apache.org/thread/3j8ldw93gyx1kblknygq35nq8g72plpx 


Thanks,
Tao Jiuming

[GitHub] [pulsar] crossoverJie added a comment to the discussion: Is it possible to manually acknowledge messages via msgId?

2022-11-21 Thread GitBox


GitHub user crossoverJie added a comment to the discussion: Is it possible to 
manually acknowledge messages via msgId?

> Query `individuallyDeletedMessages` again:
> `"individuallyDeletedMessages": "[(414:36..414:39]]",`
> The results did not change.

I'm sorry, that was my mistake.

I was testing in `JUnit` and the client exited before the background thread 
finished executing, resulting in the message not being committed.

Now the main function works fine instead.



> The background to my doing this is as follows:
> 
> I want to know if the backlog of message topics is caused by message holes.
> 
> If so, I would like to manually acknowledge these holes in our admin console 
> for the purpose of clearing them.
> 
> Have the broker automatically move the `MarkDeletedPosition` and clear the 
> backlog of messages.
> 
> Any other suggestions to make this work? thx.

By the way, do Any suggestions in this background? Thanks

GitHub link: 
https://github.com/apache/pulsar/discussions/18544#discussioncomment-4194853


This is an automatically sent email for dev@pulsar.apache.org.
To unsubscribe, please send an email to: dev-unsubscr...@pulsar.apache.org



[GitHub] [pulsar] crossoverJie edited a comment on the discussion: Is it possible to manually acknowledge messages via msgId?

2022-11-21 Thread GitBox


GitHub user crossoverJie edited a comment on the discussion: Is it possible to 
manually acknowledge messages via msgId?

Thanks for the answer,

~~Before this I thought that `individuallyDeletedMessages` stored 
unacknowledged messages.~~

---
~~Here is my testing process:~~

```java
"individuallyDeletedMessages": "[(414:36..414:39]]",
consumer.acknowledge(new MessageIdImpl(414, 35, 1));
consumer.acknowledge(new MessageIdImpl(414, 36, 1));
```
~~Query `individuallyDeletedMessages` again:
`"individuallyDeletedMessages": "[(414:36..414:39]]",`
The results did not change.~~

~~When I restart the consumer:~~
```java
consumer Message received: 414:35:1:0
consumer Message received: 414:36:1:0
```
~~The message that was just manually confirmed is still available, At the same 
time:
`"individuallyDeletedMessages": "[]"`~~

~~My expected results should be:~~
~~After I manually acknowledge the message, the restart consumer does not get 
the message again and at the same time, individuallyDeletedMessages should 
change.~~

~~Is my understanding correct?~~

thx.

GitHub link: 
https://github.com/apache/pulsar/discussions/18544#discussioncomment-4193283


This is an automatically sent email for dev@pulsar.apache.org.
To unsubscribe, please send an email to: dev-unsubscr...@pulsar.apache.org



[DISCUSS] The use of consumer redeliverUnacknowledgedMessages method

2022-11-21 Thread 丛搏
Hello, Pulsar community:

Now client consumer `void redeliverUnacknowledgedMessages();` is an
async interface, but it doesn't have the return value. only
`writeAndFlush` the redeliver command then finishes.

`ConsumerImpl`:
https://github.com/apache/pulsar/blob/master/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java#L1907-L1909

`MultiTopicsConsumerImpl`:
https://github.com/apache/pulsar/blob/master/pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java#L667-L677

in the shared subType, I think it doesn't need the response of the
`void redeliverUnacknowledgedMessages()`, and naming the
`redeliverUnacknowledgedMessages` is ok.

but in failover and exclusive subType, if we don't get the response,
the user will receive the message from the `incomingQueue` then the
order of the message will be broken.  If the
`redeliverUnacknowledgedMessages` timeout, we should try again. but
`redeliverUnacknowledgedMessages` doesn't throw any exception or
retry. and the `redeliverUnacknowledgedMessages` name is not accurate
for failover and exclusive subType. it is named `rewind` is more
suitable.

So I suggest `redeliverUnacknowledgedMessages` be deprecated under
failover and exclusive subType and add a new similar async and sync
method called `rewind` for failover and exclusive subType.

Please leave your comments or suggestions, thanks!

Thanks,
bo


Re: [DISCUSS] The use of consumer redeliverUnacknowledgedMessages method

2022-11-21 Thread Baodi Shi
Hi, Congbo.

The subscription type is an internal property of the consumer; If two APIs are 
provided: redeliverUnacknowledgedMessages(only work on shard) and rewind(only 
work exclusive and failover), This can be confusing for users.

Back to the issue, depending on the current usage scenario, the 
redeliverUnacknowledgedMessages method should be synchronous, maybe we can 
modify it to be synchronous and support retrying.



Thanks,
Baodi Shi

> 2022年11月21日 21:03,丛搏  写道:
> 
> Hello, Pulsar community:
> 
> Now client consumer `void redeliverUnacknowledgedMessages();` is an
> async interface, but it doesn't have the return value. only
> `writeAndFlush` the redeliver command then finishes.
> 
> `ConsumerImpl`:
> https://github.com/apache/pulsar/blob/master/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java#L1907-L1909
> 
> `MultiTopicsConsumerImpl`:
> https://github.com/apache/pulsar/blob/master/pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java#L667-L677
> 
> in the shared subType, I think it doesn't need the response of the
> `void redeliverUnacknowledgedMessages()`, and naming the
> `redeliverUnacknowledgedMessages` is ok.
> 
> but in failover and exclusive subType, if we don't get the response,
> the user will receive the message from the `incomingQueue` then the
> order of the message will be broken.  If the
> `redeliverUnacknowledgedMessages` timeout, we should try again. but
> `redeliverUnacknowledgedMessages` doesn't throw any exception or
> retry. and the `redeliverUnacknowledgedMessages` name is not accurate
> for failover and exclusive subType. it is named `rewind` is more
> suitable.
> 
> So I suggest `redeliverUnacknowledgedMessages` be deprecated under
> failover and exclusive subType and add a new similar async and sync
> method called `rewind` for failover and exclusive subType.
> 
> Please leave your comments or suggestions, thanks!
> 
> Thanks,
> bo



Re: [ANNOUNCE] New Committer: Cong Zhao

2022-11-21 Thread Baodi Shi
Congrats! Cong

> 2022年11月21日 17:56,Jun Ma  写道:
> 
> Congratulations, Cong @coderzc !
> 
> 
> From: PengHui Li 
> Sent: Monday, November 21, 2022 17:13
> To: dev@pulsar.apache.org 
> Subject: Re: [ANNOUNCE] New Committer: Cong Zhao
> 
> Congrats! Cong
> 
> Thanks,
> Penghui
> 
>> On Nov 21, 2022, at 13:57, Zixuan Liu  wrote:
>> 
>> Congrats! Cong
>> 
>> Best Regards,
>> Zixuan
>> 
>> houxiaoyu  于2022年11月21日周一 12:24写道:
>> 
>>> Congrats! Cong
>>> 
>>> Best,
>>> Xiaoyu Hou
>>> 
>>> Haiting Jiang  于2022年11月21日周一 12:10写道:
>>> 
 The Project Management Committee (PMC) for Apache Pulsar has invited
 Cong Zhao (https://github.com/coderzc)
 to become a committer and we are pleased to announce that he has
>>> accepted.
 
 Being a committer enables easier contribution to the
 project since there is no need to go via the patch
 submission process. This should enable better productivity.
 
 Welcome and congratulations, Cong Zhao!
 
 Please join us in congratulating and welcoming Cong Zhao onboard!
 
 Best Regards,
 Haiting on behalf of the Pulsar PMC
 
>>> 
> 



[GitHub] [pulsar] Raunak-Agrawal edited a comment on the discussion: Not able to run pulsar function locally

2022-11-21 Thread GitBox


GitHub user Raunak-Agrawal edited a comment on the discussion: Not able to run 
pulsar function locally

@Jason918 @michaeljmarshall can you please help with this? Basically I am 
trying to run pulsar function with python source code along with some of its 
external dependencies. I tried to build wheel file and use pulsar-admin create 
command to upload the function to the pulsar container, but it fails with some 
module not found error. 
I am using Mac os Monetory. Could you help me with the steps ?

GitHub link: 
https://github.com/apache/pulsar/discussions/18552#discussioncomment-4191516


This is an automatically sent email for dev@pulsar.apache.org.
To unsubscribe, please send an email to: dev-unsubscr...@pulsar.apache.org



[VOTE] Pulsar Release 2.11.0 Candidate 1

2022-11-21 Thread guo jiwei
This is the third release candidate for Apache Pulsar, version 2.11.0.

This release contains 1563 commits by 64 contributors.
https://github.com/apache/pulsar/compare/v2.10.2...v2.11.0-candidate-1

CI for this release candidate
https://github.com/Technoboy-/pulsar/pull/14

*** Please download, test and vote on this release. This vote will stay open
for at least 72 hours ***

Note that we are voting upon the source (tag), binaries are provided for
convenience.

Source and binary files:
https://dist.apache.org/repos/dist/dev/pulsar/pulsar-2.11.0-candidate-1

SHA-512 checksums:

90afcb2361f56d6ebba71cdd685847db36a34f5117abd506682dc19796d50a68202f3ee20f2d83459cbd99135cc25c21d75dcdacea4c59991bb4435f624b89f1

 ./apache-pulsar-2.11.0-bin.tar.gz

f046ae3b2f28b62a516306f29971dd73f237bf86e08b3c69c6f46ee83596d87eebf5615e4ef9823a6fd2fbf9b98fa9c0923c35db50faec2f79c0d1d117a45b0b

 ./apache-pulsar-2.11.0-src.tar.gz

Maven staging repo:
https://repository.apache.org/content/repositories/orgapachepulsar-1190/

The tag to be voted upon:
v2.11.0-candidate-1 (708012096eb781c645697a6f2b74bfc2574ff66e)
https://github.com/apache/pulsar/releases/tag/v2.11.0-candidate-1

Pulsar's KEYS file containing PGP keys we use to sign the release:
https://dist.apache.org/repos/dist/dev/pulsar/KEYS

Docker images:
https://hub.docker.com/layers/mattison/pulsar-all/2.11.0/images/sha256-cba4e27b3bcbc34508fb2eadcfd63dfab665fc6f7ae72e73288ad410ac93ad76
https://hub.docker.com/layers/mattison/pulsar/2.11.0/images/sha256-2c827263666caad16b27738ccdb9ed6bab8676552c2ae0148f764e87c3eebea7

Please download the source package, and follow the
release-candidate-validation doc to build
and run the Pulsar standalone service.
https://pulsar.apache.org/contribute/validate-release-candidate

Since the metadata store is changed from ZK to etcd, the verification of
the `stateful functions` needs to set the parameter "export
PULSAR_STANDALONE_USE_ZOOKEEPER=1"


Thanks
Jiwei Guo (Tboy)


Re: [DISCUSS] The use of consumer redeliverUnacknowledgedMessages method

2022-11-21 Thread 丛搏
Hi, Baodi:

I don't think it will confuse users, eg. individual ack and cumulative
ack, in the share subType cumulative ack have no use.
because we have individualAck and cumulativeAck, we should have
different redeliver methods for them.
I think adding new methods makes sense unless we separate cumulative
ack and individual ack into different consumer APIs like
ShareConsumer, and FailoverConsumer, it's just an example.

Thanks,
bo

Baodi Shi  于2022年11月21日周一 22:43写道:
>
> Hi, Congbo.
>
> The subscription type is an internal property of the consumer; If two APIs 
> are provided: redeliverUnacknowledgedMessages(only work on shard) and 
> rewind(only work exclusive and failover), This can be confusing for users.
>
> Back to the issue, depending on the current usage scenario, the 
> redeliverUnacknowledgedMessages method should be synchronous, maybe we can 
> modify it to be synchronous and support retrying.
>
>
>
> Thanks,
> Baodi Shi
>
> > 2022年11月21日 21:03,丛搏  写道:
> >
> > Hello, Pulsar community:
> >
> > Now client consumer `void redeliverUnacknowledgedMessages();` is an
> > async interface, but it doesn't have the return value. only
> > `writeAndFlush` the redeliver command then finishes.
> >
> > `ConsumerImpl`:
> > https://github.com/apache/pulsar/blob/master/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java#L1907-L1909
> >
> > `MultiTopicsConsumerImpl`:
> > https://github.com/apache/pulsar/blob/master/pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java#L667-L677
> >
> > in the shared subType, I think it doesn't need the response of the
> > `void redeliverUnacknowledgedMessages()`, and naming the
> > `redeliverUnacknowledgedMessages` is ok.
> >
> > but in failover and exclusive subType, if we don't get the response,
> > the user will receive the message from the `incomingQueue` then the
> > order of the message will be broken.  If the
> > `redeliverUnacknowledgedMessages` timeout, we should try again. but
> > `redeliverUnacknowledgedMessages` doesn't throw any exception or
> > retry. and the `redeliverUnacknowledgedMessages` name is not accurate
> > for failover and exclusive subType. it is named `rewind` is more
> > suitable.
> >
> > So I suggest `redeliverUnacknowledgedMessages` be deprecated under
> > failover and exclusive subType and add a new similar async and sync
> > method called `rewind` for failover and exclusive subType.
> >
> > Please leave your comments or suggestions, thanks!
> >
> > Thanks,
> > bo
>


[DISCUSS] PIP-223: Add metrics for all Rest Endpoints

2022-11-21 Thread Jiuming Tao
Hi pulsar community,

I’ve opened a PIP to discuss: PIP-223: Add metrics for all Rest Endpoints

The PIP link: https://github.com/apache/pulsar/issues/18560 


Thanks,
Tao Jiuming

[GitHub] [pulsar] comradekingu added a comment to the discussion: Archive Crowdin based translation initiative

2022-11-21 Thread GitBox


GitHub user comradekingu added a comment to the discussion: Archive Crowdin 
based translation initiative

Par for the course when using Crowdin. There are no (?) successful libre 
software translation efforts on Transifex, but there are plenty on Weblate.

GitHub link: 
https://github.com/apache/pulsar/discussions/17810#discussioncomment-4200151


This is an automatically sent email for dev@pulsar.apache.org.
To unsubscribe, please send an email to: dev-unsubscr...@pulsar.apache.org



Re: [Vote] PIP-215: Configurable TopicCompactionStrategy for StrategicTwoPhaseCompactor and TableView

2022-11-21 Thread Baodi Shi
+1 (non-binding)


Thanks,
Baodi Shi

> 2022年11月18日 17:00,Enrico Olivelli  写道:
> 
> +1 (binding)
> 
> Enrico
> 
> Il giorno mar 15 nov 2022 alle ore 02:41 PengHui Li
>  ha scritto:
>> 
>> +1
>> 
>> Thanks,
>> Penghui
>> 
>> On Wed, Nov 9, 2022 at 12:52 AM Heesung Sohn
>>  wrote:
>> 
>>> Dear Pulsar Community,
>>> 
>>> Please review and vote on this PIP.
>>> 
>>> PIP link: https://github.com/apache/pulsar/issues/18099
>>> 
>>> Thank you,
>>> -Heesung
>>> 



[GitHub] [pulsar] labuladong added a comment to the discussion: Is it possible to manually acknowledge messages via msgId?

2022-11-21 Thread GitBox


GitHub user labuladong added a comment to the discussion: Is it possible to 
manually acknowledge messages via msgId?

For this scenario, this PR https://github.com/apache/pulsar/pull/18263 may 
help, please take a look.

GitHub link: 
https://github.com/apache/pulsar/discussions/18544#discussioncomment-4200573


This is an automatically sent email for dev@pulsar.apache.org.
To unsubscribe, please send an email to: dev-unsubscr...@pulsar.apache.org



[GitHub] [pulsar] mattisonchao edited a discussion: Use vert.x-web as our web server

2022-11-21 Thread GitBox


GitHub user mattisonchao edited a discussion: Use vert.x-web as our web server

Apache Pulsar is a fully asynchronous system, in the best practice of 
asynchronous, we can not block any operations and support an excellent way to 
handle backpressure. 

Vert.x-web is a good component to be, it supports blocking call detection and 
backpressure handling.

I'm not sure if I missing something, it just suddenly happened in my mind, and 
I didn't do any research. 

Just share a small idea... :) 

Please fell free to left comments here.

GitHub link: https://github.com/apache/pulsar/discussions/18561


This is an automatically sent email for dev@pulsar.apache.org.
To unsubscribe, please send an email to: dev-unsubscr...@pulsar.apache.org



Re: Acknowledge contributors for each release

2022-11-21 Thread Yu
Hi tison,

Thanks for raising this up!

Expressing appreciation for contributors is a great way to improve health
and fitness in our community.

Here are just my two cents:



1. Except for the all-contributors list, does it make sense and is it
possible to show the top 10 contributors for each release?

Here comes another issue, how to evaluate the top 10?

The simplest way is based on the lines of code (the same as how GitHub
counts contributions, etc), but it does not make sense to some degree.

At the same time, other factors (e.g. how active a contributor is, how many
PR/issues he/she reviews/answers, etc) can be taken into consideration, but
this might make things a little complicated. If we do not find a quick and
easy way to do this, it might overwhelm release managers.



2. Does it make sense to show contributors for all Pulsar-related repos
(e.g. pulsar, pulsar-site, pulsar-client-cpp, pulsar-helm-chart) on the
Pulsar website?

SkyWalking follows this way, see "Contributors" at
https://skywalking.apache.org/team/.



Feel free to correct me if am wrong, thank you!

Yu

On Mon, Nov 21, 2022 at 2:35 PM tison  wrote:

> Hi,
>
> Dave's email about first-time contributions reminds me of the idea to
> acknowledge contributors for each release.
>
> Let's see how the Flink community does it:
>
> For each release blog, e.g. [1], in the last section "List of
> Contributors",
> explicitly list out contributors and acknowledge their contributions.
>
> When it went back to the first time I got listed, I was proud to share it
> on social media and it encouraged me a lot to make more contributions.
> Also, from the community perspective, releasing patches as well as
> acknowledging the authors are somewhat fundamental rewards we can offer.
>
> To generate the list, I adapt the scripts provided by Flink as:
>
> 1. For Pulsar v2.10.0 (minor version release):
>
>   git log --pretty="%an%n%cn" v2.9.0..v2.10.0 | sort | uniq | tr "\n" "," |
> sed 's/,/, /g'
>
> ... which gives:
>
> Addison Higham, Ali Ahmed, Aloys, Amar Prakash Pandey, Andras Beni, Andrey
> Yegorov, AnonHxy, Anonymitaet, Arnar, Baozi, Bharani Chadalavada, Bowen Li,
> Boyang Jerry Peng, Callum Duffy, Christophe Bornet, Da Xiang Huang, Dave
> Fisher, David Kjerrumgaard, Devin Bost, Dezhi LIiu, Dianjin Wang, Diego,
> Enrico Olivelli, Eric Shen, Eron Wright, Fangbin Sun, Frank J Kelly,
> Frederic Kneier, Gautier DI FOLCO, GitHub, Haaroon Y, Hang Chen,
> HuangQiang, Huanli Meng, Jagadesh Adireddi, Jason918, JiangHaiting, Jin,
> Jiwei Guo, Kai, Kai Wang, Koen Rutten, Lakshmi Balu, Lari Hotari, Lars
> Hvam, Lei Zhiyuan, Li Li, Lishen Yao, Marvin Cai, Masahiro Sakamoto,
> Massimiliano Mirelli, Matt Fleming, Matteo Merli, Md Mostafijur Rahman,
> Michael Marshall, Neng Lu, Nicklee007, Nicolò Boschi, Ofek Lev, Paul Gier,
> Peter Tinti, Qiang Huang, Qiang Zhao, Rajan Dhabalia, Roc Marshal, Ruguo
> Yu, Rui Fu, Saumitra Srivastav, Shen Liu, Sijie Guo, Smile, TakaHiro, Tao
> Jiuming, Thomas Leplus, Tong, Travis Sturzl, Vincent Royer, WangJialing,
> Xiangying Meng, Xiaobing Fang, Xiaoyu Hou, YANGLiiN, Yan, Yang Yang,
> Yannick Koechlin, Yong Zhang, Yunze Xu, Yuri Mizushima, Yuto Furuta, Zach
> Walsh, ZhangJian He, Zhanpeng Wu, Zhiwu Wang, Zike Yang, Zixuan Liu, Ziyao
> Wei, aarondonwilliams, baomingyu, bentonliang, billowqiu, chenlin,
> codertmy, congbo, entvex, fengtao1998, feynmanlin, fu-turer, gaozhangmin,
> goflutterjava, hanmz, hrsakai, imryao, junqingzh, kaushik-develop,
> kijanowski, kimula takesi, lightzhao, lin chen, lipenghui, litao,
> liuchangqing, liudezhi, madhavan-narayanan, ming, mingyifei, momo-jun,
> penghui, ran, sijia-w, suiyuzeng, wenbingshen, xiaolong ran, youzipi,
> zhaoyajun2009, 包子, 萧易客
>
> 2. For Pulsar v2.10.1 (patch version release):
>
>   git log --pretty="%an%n%cn" v2.10.0..v2.10.1 | sort | uniq | tr "\n" ","
> | sed 's/,/, /g'
>
> ... which gives:
>
> Adrian Paul, AlvaroStream, Andrey Yegorov, Baodi Shi, Baozi, Christophe
> Bornet, Cong Zhao, Dezhi LIiu, Enrico Olivelli, GitHub, JiangHaiting, Jim
> Baugh, Jiwei Guo, Kai Wang, Kay Johansen, Lari Hotari, LinChen, Lishen Yao,
> Matt-Esch, Matteo Merli, Michael Marshall, Neng Lu, Nicolò Boschi, Qiang
> Huang, Qiang Zhao, Ruguo Yu, Rui Fu, Shen Liu, Tao Jiuming, Tian Luo,
> WangJialing, Xiangying Meng, Xiaoyu Hou, Yan Zhao, Yang Yang, Yong Zhang,
> Yunze Xu, Yuri Mizushima, ZhangJian He, Zike Yang, Zixuan Liu, boatrainlsz,
> codertmy, congbo, dependabot[bot], fengyubiao, gaoran10, gaozhangmin,
> grayson, lin chen, lipenghui, lixinyang, llIlll, penghui, ran, wuxuanqicn,
> 赵延,
>
> I think we can integrate such a step into the release process[2] if we
> reach a consensus. But let me start this thread first to see your thoughts
> and suggestions.
>
> Looking forward to your feedback!
>
> Best,
> tison.
>
> [1] https://flink.apache.org/news/2022/10/28/1.16-announcement.html
> [2] https://pulsar.apache.org/contribute/release-process
>


[GitHub] [pulsar] labuladong edited a comment on the discussion: Is it possible to manually acknowledge messages via msgId?

2022-11-21 Thread GitBox


GitHub user labuladong edited a comment on the discussion: Is it possible to 
manually acknowledge messages via msgId?

For stats of ack holes, this PR https://github.com/apache/pulsar/pull/18263 may 
help, please take a look. And to handle ack holes, maybe [accumulative 
ack](https://pulsar.apache.org/docs/next/concepts-messaging/#acknowledgment) 
can help.

GitHub link: 
https://github.com/apache/pulsar/discussions/18544#discussioncomment-4200573


This is an automatically sent email for dev@pulsar.apache.org.
To unsubscribe, please send an email to: dev-unsubscr...@pulsar.apache.org



[GitHub] [pulsar] coderzc added a comment to the discussion: Use vert.x-web as our web server

2022-11-21 Thread GitBox


GitHub user coderzc added a comment to the discussion: Use vert.x-web as our 
web server

I think this is a good suggestion.

GitHub link: 
https://github.com/apache/pulsar/discussions/18561#discussioncomment-4200917


This is an automatically sent email for dev@pulsar.apache.org.
To unsubscribe, please send an email to: dev-unsubscr...@pulsar.apache.org



Re: [DISCUSS] Release Pulsar Client C++ 3.1.0

2022-11-21 Thread Yunze Xu
+1

Thanks,
Yunze

On Mon, Nov 21, 2022 at 5:32 PM Zike Yang  wrote:
>
> Hi everyone,
>
> I would like to propose releasing the Pulsar Client C++ 3.1.0
>
> There are several new features and bug fixes in the main branch[0].
> And it’s time to release a new version.
> Please remind me if you have any important fixes that need to be
> included in 3.1.0
>
> [0] https://github.com/apache/pulsar-client-cpp/compare/v3.0.0...main
>
> BR,
> Zike Yang


Re: [DISCUSS] The use of consumer redeliverUnacknowledgedMessages method

2022-11-21 Thread Baodi Shi
Hi, Congbo:

Thanks for your explanation. I agree to add a new interface for failover and 
exclusive subType.

>>> I suggest `redeliverUnacknowledgedMessages` be deprecated under
>>> failover and exclusive subType and add a new similar async and sync
>>> method called `rewind` for failover and exclusive subType.

After, when the user calls `redeliverUnacknowledgedMessages` under failover and 
exclusive subType, 
It gets a warning reminder that the messages may be out of order, right?

Thanks,
Baodi Shi

> 2022年11月22日 00:33,丛搏  写道:
> 
> Hi, Baodi:
> 
> I don't think it will confuse users, eg. individual ack and cumulative
> ack, in the share subType cumulative ack have no use.
> because we have individualAck and cumulativeAck, we should have
> different redeliver methods for them.
> I think adding new methods makes sense unless we separate cumulative
> ack and individual ack into different consumer APIs like
> ShareConsumer, and FailoverConsumer, it's just an example.
> 
> Thanks,
> bo
> 
> Baodi Shi  于2022年11月21日周一 22:43写道:
>> 
>> Hi, Congbo.
>> 
>> The subscription type is an internal property of the consumer; If two APIs 
>> are provided: redeliverUnacknowledgedMessages(only work on shard) and 
>> rewind(only work exclusive and failover), This can be confusing for users.
>> 
>> Back to the issue, depending on the current usage scenario, the 
>> redeliverUnacknowledgedMessages method should be synchronous, maybe we can 
>> modify it to be synchronous and support retrying.
>> 
>> 
>> 
>> Thanks,
>> Baodi Shi
>> 
>>> 2022年11月21日 21:03,丛搏  写道:
>>> 
>>> Hello, Pulsar community:
>>> 
>>> Now client consumer `void redeliverUnacknowledgedMessages();` is an
>>> async interface, but it doesn't have the return value. only
>>> `writeAndFlush` the redeliver command then finishes.
>>> 
>>> `ConsumerImpl`:
>>> https://github.com/apache/pulsar/blob/master/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java#L1907-L1909
>>> 
>>> `MultiTopicsConsumerImpl`:
>>> https://github.com/apache/pulsar/blob/master/pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java#L667-L677
>>> 
>>> in the shared subType, I think it doesn't need the response of the
>>> `void redeliverUnacknowledgedMessages()`, and naming the
>>> `redeliverUnacknowledgedMessages` is ok.
>>> 
>>> but in failover and exclusive subType, if we don't get the response,
>>> the user will receive the message from the `incomingQueue` then the
>>> order of the message will be broken.  If the
>>> `redeliverUnacknowledgedMessages` timeout, we should try again. but
>>> `redeliverUnacknowledgedMessages` doesn't throw any exception or
>>> retry. and the `redeliverUnacknowledgedMessages` name is not accurate
>>> for failover and exclusive subType. it is named `rewind` is more
>>> suitable.
>>> 
>>> So I suggest `redeliverUnacknowledgedMessages` be deprecated under
>>> failover and exclusive subType and add a new similar async and sync
>>> method called `rewind` for failover and exclusive subType.
>>> 
>>> Please leave your comments or suggestions, thanks!
>>> 
>>> Thanks,
>>> bo
>> 



Re: [DISCUSS] Release Pulsar Client C++ 3.1.0

2022-11-21 Thread Baodi Shi
+1 

Thanks,
Baodi Shi

> 2022年11月22日 11:07,Yunze Xu  写道:
> 
> +1
> 
> Thanks,
> Yunze
> 
> On Mon, Nov 21, 2022 at 5:32 PM Zike Yang  wrote:
>> 
>> Hi everyone,
>> 
>> I would like to propose releasing the Pulsar Client C++ 3.1.0
>> 
>> There are several new features and bug fixes in the main branch[0].
>> And it’s time to release a new version.
>> Please remind me if you have any important fixes that need to be
>> included in 3.1.0
>> 
>> [0] https://github.com/apache/pulsar-client-cpp/compare/v3.0.0...main
>> 
>> BR,
>> Zike Yang



Re: Acknowledge contributors for each release

2022-11-21 Thread Dave Fisher
To me a contributors list has three levels

1. New contributors whose first PR is included.
2. Contributors who are not yet committers.
3. Committers.

As a PMC member I want be on the look out for new committers to grow the Pulsar 
community.

We want the community to see the path to being a committer.

Best,
Dave

Sent from my iPhone

> On Nov 21, 2022, at 6:36 PM, Yu  wrote:
> 
> Hi tison,
> 
> Thanks for raising this up!
> 
> Expressing appreciation for contributors is a great way to improve health
> and fitness in our community.
> 
> Here are just my two cents:
> 
> 
> 
> 1. Except for the all-contributors list, does it make sense and is it
> possible to show the top 10 contributors for each release?
> 
> Here comes another issue, how to evaluate the top 10?
> 
> The simplest way is based on the lines of code (the same as how GitHub
> counts contributions, etc), but it does not make sense to some degree.
> 
> At the same time, other factors (e.g. how active a contributor is, how many
> PR/issues he/she reviews/answers, etc) can be taken into consideration, but
> this might make things a little complicated. If we do not find a quick and
> easy way to do this, it might overwhelm release managers.
> 
> 
> 
> 2. Does it make sense to show contributors for all Pulsar-related repos
> (e.g. pulsar, pulsar-site, pulsar-client-cpp, pulsar-helm-chart) on the
> Pulsar website?
> 
> SkyWalking follows this way, see "Contributors" at
> https://skywalking.apache.org/team/.
> 
> 
> 
> Feel free to correct me if am wrong, thank you!
> 
> Yu
> 
>> On Mon, Nov 21, 2022 at 2:35 PM tison  wrote:
>> 
>> Hi,
>> 
>> Dave's email about first-time contributions reminds me of the idea to
>> acknowledge contributors for each release.
>> 
>> Let's see how the Flink community does it:
>> 
>> For each release blog, e.g. [1], in the last section "List of
>> Contributors",
>> explicitly list out contributors and acknowledge their contributions.
>> 
>> When it went back to the first time I got listed, I was proud to share it
>> on social media and it encouraged me a lot to make more contributions.
>> Also, from the community perspective, releasing patches as well as
>> acknowledging the authors are somewhat fundamental rewards we can offer.
>> 
>> To generate the list, I adapt the scripts provided by Flink as:
>> 
>> 1. For Pulsar v2.10.0 (minor version release):
>> 
>>  git log --pretty="%an%n%cn" v2.9.0..v2.10.0 | sort | uniq | tr "\n" "," |
>> sed 's/,/, /g'
>> 
>> ... which gives:
>> 
>> Addison Higham, Ali Ahmed, Aloys, Amar Prakash Pandey, Andras Beni, Andrey
>> Yegorov, AnonHxy, Anonymitaet, Arnar, Baozi, Bharani Chadalavada, Bowen Li,
>> Boyang Jerry Peng, Callum Duffy, Christophe Bornet, Da Xiang Huang, Dave
>> Fisher, David Kjerrumgaard, Devin Bost, Dezhi LIiu, Dianjin Wang, Diego,
>> Enrico Olivelli, Eric Shen, Eron Wright, Fangbin Sun, Frank J Kelly,
>> Frederic Kneier, Gautier DI FOLCO, GitHub, Haaroon Y, Hang Chen,
>> HuangQiang, Huanli Meng, Jagadesh Adireddi, Jason918, JiangHaiting, Jin,
>> Jiwei Guo, Kai, Kai Wang, Koen Rutten, Lakshmi Balu, Lari Hotari, Lars
>> Hvam, Lei Zhiyuan, Li Li, Lishen Yao, Marvin Cai, Masahiro Sakamoto,
>> Massimiliano Mirelli, Matt Fleming, Matteo Merli, Md Mostafijur Rahman,
>> Michael Marshall, Neng Lu, Nicklee007, Nicolò Boschi, Ofek Lev, Paul Gier,
>> Peter Tinti, Qiang Huang, Qiang Zhao, Rajan Dhabalia, Roc Marshal, Ruguo
>> Yu, Rui Fu, Saumitra Srivastav, Shen Liu, Sijie Guo, Smile, TakaHiro, Tao
>> Jiuming, Thomas Leplus, Tong, Travis Sturzl, Vincent Royer, WangJialing,
>> Xiangying Meng, Xiaobing Fang, Xiaoyu Hou, YANGLiiN, Yan, Yang Yang,
>> Yannick Koechlin, Yong Zhang, Yunze Xu, Yuri Mizushima, Yuto Furuta, Zach
>> Walsh, ZhangJian He, Zhanpeng Wu, Zhiwu Wang, Zike Yang, Zixuan Liu, Ziyao
>> Wei, aarondonwilliams, baomingyu, bentonliang, billowqiu, chenlin,
>> codertmy, congbo, entvex, fengtao1998, feynmanlin, fu-turer, gaozhangmin,
>> goflutterjava, hanmz, hrsakai, imryao, junqingzh, kaushik-develop,
>> kijanowski, kimula takesi, lightzhao, lin chen, lipenghui, litao,
>> liuchangqing, liudezhi, madhavan-narayanan, ming, mingyifei, momo-jun,
>> penghui, ran, sijia-w, suiyuzeng, wenbingshen, xiaolong ran, youzipi,
>> zhaoyajun2009, 包子, 萧易客
>> 
>> 2. For Pulsar v2.10.1 (patch version release):
>> 
>>  git log --pretty="%an%n%cn" v2.10.0..v2.10.1 | sort | uniq | tr "\n" ","
>> | sed 's/,/, /g'
>> 
>> ... which gives:
>> 
>> Adrian Paul, AlvaroStream, Andrey Yegorov, Baodi Shi, Baozi, Christophe
>> Bornet, Cong Zhao, Dezhi LIiu, Enrico Olivelli, GitHub, JiangHaiting, Jim
>> Baugh, Jiwei Guo, Kai Wang, Kay Johansen, Lari Hotari, LinChen, Lishen Yao,
>> Matt-Esch, Matteo Merli, Michael Marshall, Neng Lu, Nicolò Boschi, Qiang
>> Huang, Qiang Zhao, Ruguo Yu, Rui Fu, Shen Liu, Tao Jiuming, Tian Luo,
>> WangJialing, Xiangying Meng, Xiaoyu Hou, Yan Zhao, Yang Yang, Yong Zhang,
>> Yunze Xu, Yuri Mizushima, ZhangJian He, Zike Yang, Zixuan Liu,

[GitHub] [pulsar] nodece added a comment to the discussion: Use vert.x-web as our web server

2022-11-21 Thread GitBox


GitHub user nodece added a comment to the discussion: Use vert.x-web as our web 
server

+1.

GitHub link: 
https://github.com/apache/pulsar/discussions/18561#discussioncomment-4201117


This is an automatically sent email for dev@pulsar.apache.org.
To unsubscribe, please send an email to: dev-unsubscr...@pulsar.apache.org



Re: [ANNOUNCE] New Committer: Cong Zhao

2022-11-21 Thread Max Xu
Congratulations! Cong

Best,
Max Xu


On Mon, Nov 21, 2022 at 12:10 PM Haiting Jiang 
wrote:

> The Project Management Committee (PMC) for Apache Pulsar has invited
> Cong Zhao (https://github.com/coderzc)
> to become a committer and we are pleased to announce that he has accepted.
>
> Being a committer enables easier contribution to the
> project since there is no need to go via the patch
> submission process. This should enable better productivity.
>
> Welcome and congratulations, Cong Zhao!
>
> Please join us in congratulating and welcoming Cong Zhao onboard!
>
> Best Regards,
> Haiting on behalf of the Pulsar PMC
>


Re: [ANNOUNCE] New Committer: Cong Zhao

2022-11-21 Thread tison
Congrats!

Best,
tison.


Max Xu  于2022年11月22日周二 13:14写道:

> Congratulations! Cong
>
> Best,
> Max Xu
>
>
> On Mon, Nov 21, 2022 at 12:10 PM Haiting Jiang 
> wrote:
>
> > The Project Management Committee (PMC) for Apache Pulsar has invited
> > Cong Zhao (https://github.com/coderzc)
> > to become a committer and we are pleased to announce that he has
> accepted.
> >
> > Being a committer enables easier contribution to the
> > project since there is no need to go via the patch
> > submission process. This should enable better productivity.
> >
> > Welcome and congratulations, Cong Zhao!
> >
> > Please join us in congratulating and welcoming Cong Zhao onboard!
> >
> > Best Regards,
> > Haiting on behalf of the Pulsar PMC
> >
>


Re: [ANNOUNCE] New Committer: Cong Zhao

2022-11-21 Thread Hang Chen
Congrats!

Best,
Hang

tison  于2022年11月22日周二 13:15写道:
>
> Congrats!
>
> Best,
> tison.
>
>
> Max Xu  于2022年11月22日周二 13:14写道:
>
> > Congratulations! Cong
> >
> > Best,
> > Max Xu
> >
> >
> > On Mon, Nov 21, 2022 at 12:10 PM Haiting Jiang 
> > wrote:
> >
> > > The Project Management Committee (PMC) for Apache Pulsar has invited
> > > Cong Zhao (https://github.com/coderzc)
> > > to become a committer and we are pleased to announce that he has
> > accepted.
> > >
> > > Being a committer enables easier contribution to the
> > > project since there is no need to go via the patch
> > > submission process. This should enable better productivity.
> > >
> > > Welcome and congratulations, Cong Zhao!
> > >
> > > Please join us in congratulating and welcoming Cong Zhao onboard!
> > >
> > > Best Regards,
> > > Haiting on behalf of the Pulsar PMC
> > >
> >


Re: [ANNOUNCE] New Committer: Cong Zhao

2022-11-21 Thread Nicolò Boschi
Congrats!
Nicolò Boschi


Il giorno mar 22 nov 2022 alle ore 06:23 Hang Chen  ha
scritto:

> Congrats!
>
> Best,
> Hang
>
> tison  于2022年11月22日周二 13:15写道:
> >
> > Congrats!
> >
> > Best,
> > tison.
> >
> >
> > Max Xu  于2022年11月22日周二 13:14写道:
> >
> > > Congratulations! Cong
> > >
> > > Best,
> > > Max Xu
> > >
> > >
> > > On Mon, Nov 21, 2022 at 12:10 PM Haiting Jiang <
> jianghait...@apache.org>
> > > wrote:
> > >
> > > > The Project Management Committee (PMC) for Apache Pulsar has invited
> > > > Cong Zhao (https://github.com/coderzc)
> > > > to become a committer and we are pleased to announce that he has
> > > accepted.
> > > >
> > > > Being a committer enables easier contribution to the
> > > > project since there is no need to go via the patch
> > > > submission process. This should enable better productivity.
> > > >
> > > > Welcome and congratulations, Cong Zhao!
> > > >
> > > > Please join us in congratulating and welcoming Cong Zhao onboard!
> > > >
> > > > Best Regards,
> > > > Haiting on behalf of the Pulsar PMC
> > > >
> > >
>