[GitHub] [pulsar-test-infra] nodece commented on issue #73: [pulsarbot] Bot should not comment on closed/merged PRs
nodece commented on issue #73: URL: https://github.com/apache/pulsar-test-infra/issues/73#issuecomment-1250325474 This is a good catch! Currently, the `docbot` adds a doc label based on the PR description, when the PR description is incorrect, we still add a comment. **Note:** For the doc label, we can only change the PR description, and then the `docbot` will check this and do the labeling. I have an idea, if the PR description is incorrect and the state is merged or closed, we will no longer add a comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-test-infra] tisonkun commented on issue #73: [pulsarbot] Bot should not comment on closed/merged PRs
tisonkun commented on issue #73: URL: https://github.com/apache/pulsar-test-infra/issues/73#issuecomment-1250326032 > I have an idea, if the PR description is incorrect and the state is merged or closed, we will no longer add a comment. Yes. Check the PR state in the bot or filter out in the workflow is OK. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-test-infra] tisonkun commented on issue #73: [pulsarbot] Bot should not comment on closed/merged PRs
tisonkun commented on issue #73: URL: https://github.com/apache/pulsar-test-infra/issues/73#issuecomment-1250462398 https://github.com/apache/pulsar/pull/17709 patch on the main repo. We can double-check in the bot logic, but filtering out in the workflow can reduce one runner scheduled for the check inside the bot. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] agrahul89 added a comment to the discussion: Healthcheck in pulsar-admin rest api
GitHub user agrahul89 added a comment to the discussion: Healthcheck in pulsar-admin rest api Thanks for sharing the swagger Michael. I could not find the latest doc for the list of rest endpoints so the link you shared helps a ton. GitHub link: https://github.com/apache/pulsar/discussions/17654#discussioncomment-3677453 This is an automatically sent email for dev@pulsar.apache.org. To unsubscribe, please send an email to: dev-unsubscr...@pulsar.apache.org
[GitHub] [pulsar] agrahul89 edited a comment on the discussion: Healthcheck in pulsar-admin rest api
GitHub user agrahul89 edited a comment on the discussion: Healthcheck in pulsar-admin rest api Thanks for sharing the swagger spec Michael. I could not find the latest doc for the list of rest endpoints so the link you shared helps a ton. GitHub link: https://github.com/apache/pulsar/discussions/17654#discussioncomment-3677453 This is an automatically sent email for dev@pulsar.apache.org. To unsubscribe, please send an email to: dev-unsubscr...@pulsar.apache.org
Re: [ANNOUNCE] New Committer: Zixuan Liu
Congrats, Zixuan ! Regards Jiwei Guo (Tboy) On Sat, Jul 9, 2022 at 9:21 AM Zike Yang wrote: > Congratulations! Zixuan > > Zike Yang > > On Fri, Jul 8, 2022 at 10:47 PM PengHui Li wrote: > > > Congratulations! Zixuan > > > > Penghui > > > > On Fri, Jul 8, 2022 at 9:56 PM Qiang Huang > > wrote: > > > > > Congratulations!!! Zixuan. > > > > > > Max Xu 于2022年7月8日周五 21:36写道： > > > > > > > Congratulations! Zixuan > > > > > > > > Best > > > > Max Xu > > > > > > > > > > > > > > > > On Thu, Jul 7, 2022 at 8:55 PM Nicolò Boschi > > > wrote: > > > > > > > > > Congrats! > > > > > > > > > > Nicolò Boschi > > > > > > > > > > > > > > > Il giorno gio 7 lug 2022 alle ore 13:28 Haiting Jiang < > > > > > jianghait...@apache.org> ha scritto: > > > > > > > > > > > Congratulates, Zixuan! > > > > > > > > > > > > BR, > > > > > > Haiting > > > > > > > > > > > > On 2022/07/07 10:03:36 Yu wrote: > > > > > > > Hi team, > > > > > > > > > > > > > > The Project Management Committee (PMC) for Apache Pulsar has > > > invited > > > > > > > Zixuan Liu (https://github.com/nodece) to become a committer > > > > > > > and we are pleased to announce that he has accepted. > > > > > > > > > > > > > > Being a committer enables easier contribution to the > > > > > > > project since there is no need to go via the patch > > > > > > > submission process. This should enable better productivity. > > > > > > > > > > > > > > Welcome and congratulations, Zixuan Liu! > > > > > > > > > > > > > > Please join us in congratulating and welcoming Zixuan Liu > > onboard! > > > > > > > > > > > > > > Best Regards, > > > > > > > Yu on behalf of the Pulsar PMC > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > BR, > > > Qiang Huang > > > > > >
Re: [ANNOUNCE] New Committer: Dezhi Liu
Congrats Dezhi ! Regards Jiwei Guo (Tboy) On Thu, Jun 9, 2022 at 11:31 AM Just do it wrote: > Thank you everyone! > Dezhi > > > > > -- 原始邮件 -- > 发件人: > "dev" > < > hua...@streamnative.io.INVALID>; > 发送时间: 2022年6月8日(星期三) 中午11:55 > 收件人: "Dev" > 主题: Re: [ANNOUNCE] New Committer: Dezhi Liu > > > > Congrats! > > BR//Huanli > > > On Jun 8, 2022, at 10:25 AM, Yu > > > Hi Dezhi, kudos to you! Well deserved! > > > > On Wed, Jun 8, 2022 at 9:52 AM Li Li wrote: > > > >> Congratulations Dezhi! > >> > >> Thanks, > >> Li Li > >> > >>> On Jun 7, 2022, at 9:13 PM, PengHui Li < > codelipeng...@gmail.com> wrote: > >>> > >>> Congratulations Dezhi! > >>> > >>> Penghui > >>> On Jun 7, 2022, 17:22 +0800, Enrico Olivelli < > eolive...@gmail.com>, > >> wrote: > Congratulations !! > > Enrico > > Il giorno mar 7 giu 2022 alle ore 10:57 Zike Yang < > z...@apache.org> ha > >> scritto: > > > > Congratulations! > > > > Best Regards, > > Zike Yang > > > > On Tue, Jun 7, 2022 at 3:52 PM ZhangJian He < > shoot...@gmail.com> > >> wrote: > > > >> Congratulations! > >> > >> Thanks > >> ZhangJian He > >> > >> Haiting Jiang 于2022年6月7日周二 15:46写道： > >> > >>> Congrats! > >>> > >>> BR, > >>> Haiting > >>> > >>> On 2022/06/07 06:46:00 Hang Chen wrote: > The Project Management Committee (PMC) > for Apache Pulsar has invited > Dezhi Liu ( > https://github.com/liudezhi2098) to become a committer > >> and > we are pleased to announce that he has > accepted. > > Dezhi Liu (with Github id liudezhi2098) > contributed many > >> improvements > and bug fixes to Pulsar. > > Being a committer enables easier > contribution to the project since > there is no need to go via the patch > submission process. This should > enable better productivity. > > Welcome and Congratulations, Dezhi Liu! > > Please join us in congratulating and > welcoming Dezhi Liu onboard! > > Best Regards, > Hang Chen on behalf of the Pulsar PMC > > >>> > >> > >> > >>
Re: [ANNOUNCE] New Committer: Dezhi Liu
Congratulations Dezhi! Sincerely, Xiangying On Mon, Sep 19, 2022 at 1:04 PM guo jiwei wrote: > Congrats Dezhi ! > > > Regards > Jiwei Guo (Tboy) > > > On Thu, Jun 9, 2022 at 11:31 AM Just do it > wrote: > > > Thank you everyone! > > Dezhi > > > > > > > > > > -- 原始邮件 -- > > 发件人: > > "dev" > > < > > hua...@streamnative.io.INVALID>; > > 发送时间: 2022年6月8日(星期三) 中午11:55 > > 收件人: "Dev" > > > 主题: Re: [ANNOUNCE] New Committer: Dezhi Liu > > > > > > > > Congrats! > > > > BR//Huanli > > > > > On Jun 8, 2022, at 10:25 AM, Yu > > > > > Hi Dezhi, kudos to you! Well deserved! > > > > > > On Wed, Jun 8, 2022 at 9:52 AM Li Li > > > wrote: > > > > > >> Congratulations Dezhi! > > >> > > >> Thanks, > > >> Li Li > > >> > > >>> On Jun 7, 2022, at 9:13 PM, PengHui Li < > > codelipeng...@gmail.com> wrote: > > >>> > > >>> Congratulations Dezhi! > > >>> > > >>> Penghui > > >>> On Jun 7, 2022, 17:22 +0800, Enrico Olivelli < > > eolive...@gmail.com>, > > >> wrote: > > Congratulations !! > > > > Enrico > > > > Il giorno mar 7 giu 2022 alle ore 10:57 Zike Yang < > > z...@apache.org> ha > > >> scritto: > > > > > > Congratulations! > > > > > > Best Regards, > > > Zike Yang > > > > > > On Tue, Jun 7, 2022 at 3:52 PM ZhangJian He < > > shoot...@gmail.com> > > >> wrote: > > > > > >> Congratulations! > > >> > > >> Thanks > > >> ZhangJian He > > >> > > >> Haiting Jiang > 于2022年6月7日周二 15:46写道： > > >> > > >>> Congrats! > > >>> > > >>> BR, > > >>> Haiting > > >>> > > >>> On 2022/06/07 06:46:00 Hang Chen wrote: > > The Project Management Committee (PMC) > > for Apache Pulsar has invited > > Dezhi Liu ( > > https://github.com/liudezhi2098) to become a committer > > >> and > > we are pleased to announce that he has > > accepted. > > > > Dezhi Liu (with Github id liudezhi2098) > > contributed many > > >> improvements > > and bug fixes to Pulsar. > > > > Being a committer enables easier > > contribution to the project since > > there is no need to go via the patch > > submission process. This should > > enable better productivity. > > > > Welcome and Congratulations, Dezhi Liu! > > > > Please join us in congratulating and > > welcoming Dezhi Liu onboard! > > > > Best Regards, > > Hang Chen on behalf of the Pulsar PMC > > > > >>> > > >> > > >> > > >> >
Re: [ANNOUNCE] New Committer: Dezhi Liu
Congratulations! Dezhi. Well deserved! Best, Max Xu On Tue, Jun 7, 2022 at 2:46 PM Hang Chen wrote: > The Project Management Committee (PMC) for Apache Pulsar has invited > Dezhi Liu (https://github.com/liudezhi2098) to become a committer and > we are pleased to announce that he has accepted. > > Dezhi Liu (with Github id liudezhi2098) contributed many improvements > and bug fixes to Pulsar. > > Being a committer enables easier contribution to the project since > there is no need to go via the patch submission process. This should > enable better productivity. > > Welcome and Congratulations, Dezhi Liu! > > Please join us in congratulating and welcoming Dezhi Liu onboard! > > Best Regards, > Hang Chen on behalf of the Pulsar PMC >
Re: [ANNOUNCE] New Committer: Zixuan Liu
Congratulations! Zixuan. Well deserved! Best, Max Xu On Thu, Jul 7, 2022 at 6:04 PM Yu wrote: > Hi team, > > The Project Management Committee (PMC) for Apache Pulsar has invited > Zixuan Liu (https://github.com/nodece) to become a committer > and we are pleased to announce that he has accepted. > > Being a committer enables easier contribution to the > project since there is no need to go via the patch > submission process. This should enable better productivity. > > Welcome and congratulations, Zixuan Liu! > > Please join us in congratulating and welcoming Zixuan Liu onboard! > > Best Regards, > Yu on behalf of the Pulsar PMC >
Re: [CI] Change to be made in Pulsar CI to mitigate CI resource consumption issues
I'll now merge the changes to master. The contributor docs will be updated in a separate pull request. Current in progress pull requests will get the changes when they are updated. -Lari On 2022/09/16 12:43:44 Lari Hotari wrote: > On 2022/09/16 10:09:51 PengHui Li wrote: > > After I go through all the comments here. > > Do we really need a new label? > > Good suggestion. It was also suggested yesterday by Matteo that a PR approval > should be sufficient. I have modified the solution in > https://github.com/apache/pulsar/pull/17693 so that either a PR approval or > the "ready-to-test" label is required for running tests in apache/pulsar. > > I have retained the ready-to-test label solution since there might be cases > where the reviewer might want to choose to run the tests in apache/pulsar > repository before approving the PR. This is to ensure that we don't change > the meaning of the PR approval to trigger tests to run. > > In the first phase, I won't be adding "/pulsarbot ready-to-test" at all. > Instead, we'd use use PR approval + "/pulsarbot rerun-failure-checks" to > trigger the build pipeline after an approval. The label can be added manually > in GitHub UI if that approach is used. > > I hope we are ready to merge https://github.com/apache/pulsar/pull/17693 on > Monday. I'm confident that everyone will be much happier with the revised CI > where it's possible to get almost instant CI feedback without hours of delays > that slows down PR processing and merging. > > -Lari > > On 2022/09/16 10:09:51 PengHui Li wrote: > > Thanks, Lari > > > > After I go through all the comments here. > > Do we really need a new label? > > > > It looks like if a committer thinks we should trigger the CI in the Pulsar > > repo > > > > - Passed in the fork repo > > - No request change for this PR. > > - ... > > > > Just run the "/pulsarbot ready-to-test" or "/pulsarbot trigger-ci". > > I think it makes sense that have a committer take a look at the PR first > > and then trigger the CI, approval is not required. > > > > During the PR review, the author could also push many commits to address > > the comment. > > After the comments have been addressed, we can trigger the CI again. > > > > Maybe I missed something about the label approach. > > > > Thanks, > > Penghui > > > > > > On Fri, Sep 16, 2022 at 5:45 PM Lari Hotari wrote: > > > > > I have created a draft PR for making the changes in Pulsar CI: > > > https://github.com/apache/pulsar/pull/17693 > > > > > > I'm looking forward to further practical improvements. I'd like to remind > > > everyone that we must make this change to address the CI slowness. After > > > this change, the experience of Pulsar CI will improve for everyone. > > > > > > In addition to the above PR, the contributor guide and Pulsarbot changes > > > will be needed. I expect that we would be able to complete the changes > > > during next week. > > > > > > -Lari > > > > > > On 2022/09/15 08:36:01 Lari Hotari wrote: > > > > Hi all, > > > > > > > > The GitHub Actions based Pulsar CI has been experiencing issues for > > > > multiple weeks. The condition is currently better, but the resource > > > > shortage issue remains. CI builds will take a long time to complete even > > > > after many optimizations have been made. > > > > > > > > There's a long email thread with some details about the past issues: > > > > https://lists.apache.org/thread/p7rb04vf1mt0kk3v2r7xl9dvb3zkhtxf > > > > > > > > I have filed an issue to GitHub support about the CI issues over a week > > > > ago, and I finally received an answer a few hours ago. However the > > > > GitHub support person didn't reply to my questions at all, but instead > > > > suggested that there's a beta program where it's possible to pay for > > > > more resources. That solution isn't suitable for our case, since it > > > > doesn't seem to be possible to assign GitHub Actions Runner VM resources > > > > only for a specific Apache project. I'll follow up with GitHub support, > > > but > > > > I don't expect that to resolve our problems in the near term. We need > > > > to make changes in our CI resource consumption. > > > > > > > > In a the-asf Slack thread [1] about Pulsar CI issues, Martin Grigorov > > > > suggested: "Apache Spark project requires that all PRs are executed in > > > > the contributor's GHA quota. Maybe Pulsar can do the same ?!" > > > > > > > > The Apache Spark contributing guide contains details about this in the > > > > "Pull request" section, https://spark.apache.org/contributing.html . > > > > > > > > "Before creating a pull request in Apache Spark, it is important to > > > > check if tests can pass on your branch because our GitHub Actions > > > > workflows automatically run tests for your pull request/following > > > > commits and every run burdens the limited resources of GitHub Actions in > > > > Apache Spark repository. " > > > > > > > > In Pulsar, we will need to do the same. As a solution to this, Tiso
