[GitHub] [pulsar-helm-chart] nodece commented on a diff in pull request #243: Update pulsarctl to v2.9.2.7
nodece commented on code in PR #243:
URL: https://github.com/apache/pulsar-helm-chart/pull/243#discussion_r906836366
##
scripts/pulsar/common_auth.sh:
##
@@ -25,7 +25,7 @@ fi
OUTPUT=${CHART_HOME}/output
OUTPUT_BIN=${OUTPUT}/bin
-PULSARCTL_VERSION=v0.4.0
+PULSARCTL_VERSION=v2.9.2.7
Review Comment:
Bump to 2.10.0.7.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [VOTE] Pulsar Release 2.10.1 Candidate 1
Hi all, Thanks for all your verification for 2.10.1 We currently have 2 (+1) bindings and 5 (+1) non-bindings. We need one more (+1) binding to unblock the 2.10.1 release. Please help validate. Thanks, Penghui On Thu, Jun 16, 2022 at 12:43 PM Shusuke Tsuda wrote: > +1 (non-binding) > > - verified checksums and signatures > - build from source > - verified pub/sub and java functions > - verified stateful functions > > Thanks, > Shusuke Tsuda > > -Original Message- > From: PengHui Li > Sent: Monday, June 13, 2022 8:43 PM > To: Dev > Subject: [VOTE] Pulsar Release 2.10.1 Candidate 1 > > This is the first release candidate for Apache Pulsar 2.10.1 > > It fixes the following issues: > > https://github.com/apache/pulsar/pulls?q=is%3Amerged+is%3Apr+label%3Arelease%2F2.10.1+ > > *** Please download, test and vote on this release. This vote will stay > open for at least 72 hours *** > > Note that we are voting upon the source (tag), binaries are provided for > convenience. > > Source and binary files: > > https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev%2Fpulsar%2Fpulsar-2.10.1-candidate-1%2F&data=05%7C01%7Cshustsud%40yahoo-corp.jp%7C5ddcaa29fc224b6f09e608da4d31e6a8%7Ca208d369cd4e4f87b11998eaf31df2c3%7C1%7C0%7C637907173959452192%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=MlMhzU4P7GzFXx%2BNQ9DYh09Z4%2BJWzqWe%2BXbhO5pOGBo%3D&reserved=0 > > SHA-512 checksums: > > > 87045067cf123574b2b7d578f020efd177b0d9ff12a75d9f738e135cde35a034000c03e21cc8a264a6ef9e2b1df2c4493ffa3b9170b0f368d7424f1160df38cb > ./apache-pulsar-2.10.1-bin.tar.gz > > > 19c078f65b9105728adda3926a9a1527d6498f0e2337d37497a6d965a38acf94e217e58939bc5b0a8b8166511ae9ee176ee3d0c764d4777e285b7bcaeb2731e1 > ./apache-pulsar-2.10.1-src.tar.gz > > Maven staging repo: > > https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Frepository.apache.org%2Fcontent%2Frepositories%2Forgapachepulsar-1156%2F&data=05%7C01%7Cshustsud%40yahoo-corp.jp%7C5ddcaa29fc224b6f09e608da4d31e6a8%7Ca208d369cd4e4f87b11998eaf31df2c3%7C1%7C0%7C637907173959452192%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=7881wtcvkkKTYpcJUDaaP1kD7L25hmJyWYnAsa7H1iw%3D&reserved=0 > > The tag to be voted upon: > v2.10.1-candidate-1 (0702b51ce09cc99044f4110e6bf98e82a0e86283) > https://github.com/apache/pulsar/releases/tag/v2.10.1-candidate-1 > > Pulsar's KEYS file containing PGP keys we use to sign the release: > > https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev%2Fpulsar%2FKEYS&data=05%7C01%7Cshustsud%40yahoo-corp.jp%7C5ddcaa29fc224b6f09e608da4d31e6a8%7Ca208d369cd4e4f87b11998eaf31df2c3%7C1%7C0%7C637907173959452192%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=PTTqkrOKzXpW9I14aQRcSHl1swE8tCua%2Bo%2BTIkP%2F8jM%3D&reserved=0 > > Docker images: > > > https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fhub.docker.com%2Flayers%2F233293315%2Flph890127%2Fpulsar%2F2.10.1-rc1%2Fimages%2Fsha256-4a952b3c662b94247ffc4ff17be16ef176c293baaf346db13a095970f43adfd6%3Fcontext%3Drepo&data=05%7C01%7Cshustsud%40yahoo-corp.jp%7C5ddcaa29fc224b6f09e608da4d31e6a8%7Ca208d369cd4e4f87b11998eaf31df2c3%7C1%7C0%7C637907173959452192%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=Td0nWB8YQIgPrC0252vtyyEqokUQLCTZ9MYJbIxuhQU%3D&reserved=0 > > > https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fhub.docker.com%2Flayers%2F233303469%2Flph890127%2Fpulsar-all%2F2.10.1-rc1%2Fimages%2Fsha256-ac8180f4ba796291e961581821a1318437e49b0fa684597f5b67265a502822ee%3Fcontext%3Drepo&data=05%7C01%7Cshustsud%40yahoo-corp.jp%7C5ddcaa29fc224b6f09e608da4d31e6a8%7Ca208d369cd4e4f87b11998eaf31df2c3%7C1%7C0%7C637907173959452192%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=7kiKT%2BK7T%2BkJSTSAER%2BF8aFyLTXHKrjEMa%2BP0AOxiSk%3D&reserved=0 > > Please download the source package, and follow the Release Candidate > Validation[1] to validate the release > > [1] https://github.com/apache/pulsar/wiki/Release-Candidate-Validation > > Thanks, > Penghui >
Re: [VOTE] Pulsar Release 2.9.3 Candidate 1
+1 (binding) - verify gpg signatures - run standalone - pub/sub with pulsar-perf - verify connector (Cassandra) - verify stateful function - build image and test internally for the integration tests (all the tests get passed) @mattison It's better to upload the image under your org first so that we can verify the image Thanks, Penghui On Tue, Jun 21, 2022 at 9:24 AM mattison chao wrote: > This is the first release candidate for Apache Pulsar, version 2.9.3. > > It fixes the following issues: > > https://github.com/apache/pulsar/pulls?q=is%3Amerged+is%3Apr+label%3Arelease%2F2.9.3+ > > *** Please download, test and vote on this release. This vote will stay > open > for at least 72 hours *** > > Note that we are voting upon the source (tag), binaries are provided for > convenience. > > Source and binary files: > https://dist.apache.org/repos/dist/dev/pulsar/pulsar-2.9.3-candidate-1/ > > SHA-512 checksums: > > > cbc9efbb6b25704e306442b1f45ab7e309fb7c0476c380997b4541b66e4709baeff7c67107a5c68faefe40a32a559755df54a732b21b5c689612307e688f1bcb > ./apache-pulsar-2.9.3-bin.tar.gz > > > 35795b824d0775ffcd426ff5b86858148fd55c3d465edc52f23aa938daefcc50dbffa962f26e03e6fa3a77a47c3b5f19f98e1a1fbd5a98f6fe6d800223a8ead8 > ./apache-pulsar-2.9.3-src.tar.gz > > Maven staging repo: > https://repository.apache.org/content/repositories/orgapachepulsar-1158/ > > The tag to be voted upon: > v2.9.3-candidate-1 (dd9a5f1f91651b634600f66c53dcc6ad855fb669) > https://github.com/apache/pulsar/releases/tag/v2.9.3-candidate-1 > > Pulsar's KEYS file containing PGP keys we use to sign the release: > https://dist.apache.org/repos/dist/dev/pulsar/KEYS > > Please download the source package, and follow the Release Candidate > Validation[1] > to validate the release > > [1] https://github.com/apache/pulsar/wiki/Release-Candidate-Validation >
Re: [VOTE] Pulsar Release 2.10.1 Candidate 1
Hi Penghui, Thanks for your great work! I found two problems with this candidate, I'm not sure whether it will block this release. - There are some CVEs in this candidate. Please refer to: https://github.com/apache/pulsar/runs/6854904384?check_suite_focus=true - When I import `pulsar-broker` and `managed-ledger` into my project, I found the project build failed with the following exceptions. ``` [ERROR] Failed to execute goal on project test_pulsar_lib: Could not resolve dependencies for project org.example:test_pulsar_lib:jar:1.0-SNAPSHOT: Failed to collect dependencies for org.example:test_pulsar_lib:jar:1.0-SNAPSHOT: Could not resolve version conflict among [org.apache.pulsar:pulsar-broker:jar:2.10.1 -> org.apache.pulsar:pulsar-zookeeper-utils:jar:2.10.1 -> org.apache.bookkeeper:stream-storage-server:jar:4.14.5 -> org.apache.bookkeeper:stream-storage-java-client:jar:4.14.5 -> io.grpc:grpc-core:jar:1.42.1, org.apache.pulsar:pulsar-broker:jar:2.10.1 -> org.apache.pulsar:pulsar-zookeeper-utils:jar:2.10.1 -> org.apache.bookkeeper:stream-storage-server:jar:4.14.5 -> org.apache.bookkeeper:stream-storage-java-client:jar:4.14.5 -> io.grpc:grpc-testing:jar:1.42.1 -> io.grpc:grpc-core:jar:[1.42.1,1.42.1], org.apache.pulsar:pulsar-broker:jar:2.10.1 -> org.apache.pulsar:pulsar-zookeeper-utils:jar:2.10.1 -> io.grpc:grpc-all:jar:1.45.1 -> io.grpc:grpc-core:jar:[1.45.1,1.45.1], org.apache.pulsar:pulsar-broker:jar:2.10.1 -> org.apache.pulsar:pulsar-zookeeper-utils:jar:2.10.1 -> io.grpc:grpc-all:jar:1.45.1 -> io.grpc:grpc-grpclb:jar:1.45.1 -> io.grpc:grpc-core:jar:[1.45.1,1.45.1], org.apache.pulsar:pulsar-broker:jar:2.10.1 -> org.apache.pulsar:pulsar-zookeeper-utils:jar:2.10.1 -> io.grpc:grpc-all:jar:1.45.1 -> io.grpc:grpc-netty:jar:1.45.1 -> io.grpc:grpc-core:jar:[1.45.1,1.45.1], org.apache.pulsar:pulsar-broker:jar:2.10.1 -> org.apache.pulsar:pulsar-zookeeper-utils:jar:2.10.1 -> io.grpc:grpc-all:jar:1.45.1 -> io.grpc:grpc-rls:jar:1.45.1 -> io.grpc:grpc-core:jar:[1.45.1,1.45.1], org.apache.pulsar:pulsar-broker:jar:2.10.1 -> org.apache.pulsar:pulsar-zookeeper-utils:jar:2.10.1 -> io.grpc:grpc-all:jar:1.45.1 -> io.grpc:grpc-services:jar:1.45.1 -> io.grpc:grpc-core:jar:[1.45.1,1.45.1], org.apache.pulsar:pulsar-broker:jar:2.10.1 -> org.apache.pulsar:pulsar-zookeeper-utils:jar:2.10.1 -> io.grpc:grpc-all:jar:1.45.1 -> io.grpc:grpc-xds:jar:1.45.1 -> io.grpc:grpc-core:jar:1.45.1, org.apache.pulsar:pulsar-broker:jar:2.10.1 -> org.apache.pulsar:pulsar-zookeeper-utils:jar:2.10.1 -> io.grpc:grpc-all:jar:1.45.1 -> io.grpc:grpc-xds:jar:1.45.1 -> io.grpc:grpc-netty-shaded:jar:[1.45.1,1.45.1] -> io.grpc:grpc-core:jar:[1.45.1,1.45.1], org.apache.pulsar:managed-ledger:jar:2.10.1 -> org.apache.pulsar:pulsar-metadata:jar:2.10.1 -> io.etcd:jetcd-core:jar:0.5.11 -> io.etcd:jetcd-common:jar:0.5.11 -> io.grpc:grpc-core:jar:1.41.0, org.apache.pulsar:managed-ledger:jar:2.10.1 -> org.apache.pulsar:pulsar-metadata:jar:2.10.1 -> io.etcd:jetcd-core:jar:0.5.11 -> io.grpc:grpc-core:jar:1.41.0] -> [Help 1] ``` Thanks, Hang PengHui Li 于2022年6月27日周一 08:51写道： > > Hi all, > > Thanks for all your verification for 2.10.1 > > We currently have 2 (+1) bindings and 5 (+1) non-bindings. > We need one more (+1) binding to unblock the 2.10.1 release. > Please help validate. > > Thanks, > Penghui > > On Thu, Jun 16, 2022 at 12:43 PM Shusuke Tsuda > wrote: > > > +1 (non-binding) > > > > - verified checksums and signatures > > - build from source > > - verified pub/sub and java functions > > - verified stateful functions > > > > Thanks, > > Shusuke Tsuda > > > > -Original Message- > > From: PengHui Li > > Sent: Monday, June 13, 2022 8:43 PM > > To: Dev > > Subject: [VOTE] Pulsar Release 2.10.1 Candidate 1 > > > > This is the first release candidate for Apache Pulsar 2.10.1 > > > > It fixes the following issues: > > > > https://github.com/apache/pulsar/pulls?q=is%3Amerged+is%3Apr+label%3Arelease%2F2.10.1+ > > > > *** Please download, test and vote on this release. This vote will stay > > open for at least 72 hours *** > > > > Note that we are voting upon the source (tag), binaries are provided for > > convenience. > > > > Source and binary files: > > > > https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev%2Fpulsar%2Fpulsar-2.10.1-candidate-1%2F&data=05%7C01%7Cshustsud%40yahoo-corp.jp%7C5ddcaa29fc224b6f09e608da4d31e6a8%7Ca208d369cd4e4f87b11998eaf31df2c3%7C1%7C0%7C637907173959452192%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=MlMhzU4P7GzFXx%2BNQ9DYh09Z4%2BJWzqWe%2BXbhO5pOGBo%3D&reserved=0 > > > > SHA-512 checksums: > > > > > > 87045067cf123574b2b7d578f020efd177b0d9ff12a75d9f738e135cde35a034000c03e21cc8a264a6ef9e2b1df2c4493ffa3b9170b0f368d7424f1160df38cb > > ./apache-pulsar-2.10.1-bin.tar.gz > > > > > > 19c078f65b9105728adda3926a9a1527d6498f0e2337d37497a6d965a38acf94e217e58939bc5b0a8b8166511ae9ee176ee3d0c764d4777e285b7b
Re: [VOTE] Pulsar Release 2.9.3 Candidate 1
Hi Mattison, Thanks for your great work! I found one problem with this candidate. - When I import `pulsar-broker` and `managed-ledger` into my project, I found the project build failed with the following exceptions. ``` [ERROR] Failed to execute goal on project test_pulsar_lib: Could not resolve dependencies for project org.example:test_pulsar_lib:jar:1.0-SNAPSHOT: Failed to collect dependencies for org.example:test_pulsar_lib:jar:1.0-SNAPSHOT: Could not resolve version conflict among [org.apache.pulsar:pulsar-broker:jar:2.9.3 -> org.apache.pulsar:pulsar-zookeeper-utils:jar:2.9.3 -> org.apache.bookkeeper:stream-storage-server:jar:4.14.5 -> org.apache.bookkeeper:stream-storage-java-client:jar:4.14.5 -> io.grpc:grpc-core:jar:1.42.1, org.apache.pulsar:pulsar-broker:jar:2.9.3 -> org.apache.pulsar:pulsar-zookeeper-utils:jar:2.9.3 -> org.apache.bookkeeper:stream-storage-server:jar:4.14.5 -> org.apache.bookkeeper:stream-storage-java-client:jar:4.14.5 -> io.grpc:grpc-testing:jar:1.42.1 -> io.grpc:grpc-core:jar:[1.42.1,1.42.1], org.apache.pulsar:pulsar-broker:jar:2.9.3 -> org.apache.pulsar:pulsar-zookeeper-utils:jar:2.9.3 -> io.grpc:grpc-all:jar:1.45.1 -> io.grpc:grpc-core:jar:[1.45.1,1.45.1], org.apache.pulsar:pulsar-broker:jar:2.9.3 -> org.apache.pulsar:pulsar-zookeeper-utils:jar:2.9.3 -> io.grpc:grpc-all:jar:1.45.1 -> io.grpc:grpc-grpclb:jar:1.45.1 -> io.grpc:grpc-core:jar:[1.45.1,1.45.1], org.apache.pulsar:pulsar-broker:jar:2.9.3 -> org.apache.pulsar:pulsar-zookeeper-utils:jar:2.9.3 -> io.grpc:grpc-all:jar:1.45.1 -> io.grpc:grpc-netty:jar:1.45.1 -> io.grpc:grpc-core:jar:[1.45.1,1.45.1], org.apache.pulsar:pulsar-broker:jar:2.9.3 -> org.apache.pulsar:pulsar-zookeeper-utils:jar:2.9.3 -> io.grpc:grpc-all:jar:1.45.1 -> io.grpc:grpc-rls:jar:1.45.1 -> io.grpc:grpc-core:jar:[1.45.1,1.45.1], org.apache.pulsar:pulsar-broker:jar:2.9.3 -> org.apache.pulsar:pulsar-zookeeper-utils:jar:2.9.3 -> io.grpc:grpc-all:jar:1.45.1 -> io.grpc:grpc-services:jar:1.45.1 -> io.grpc:grpc-core:jar:[1.45.1,1.45.1], org.apache.pulsar:pulsar-broker:jar:2.9.3 -> org.apache.pulsar:pulsar-zookeeper-utils:jar:2.9.3 -> io.grpc:grpc-all:jar:1.45.1 -> io.grpc:grpc-xds:jar:1.45.1 -> io.grpc:grpc-core:jar:1.45.1, org.apache.pulsar:pulsar-broker:jar:2.9.3 -> org.apache.pulsar:pulsar-zookeeper-utils:jar:2.9.3 -> io.grpc:grpc-all:jar:1.45.1 -> io.grpc:grpc-xds:jar:1.45.1 -> io.grpc:grpc-netty-shaded:jar:[1.45.1,1.45.1] -> io.grpc:grpc-core:jar:[1.45.1,1.45.1]] -> [Help 1] ``` There is a PR: https://github.com/apache/pulsar/pull/16109 removed pulsar-zookeeper-utils, which fixes this issue. But in branch 2.9, we still need this module, we can not cherry-pick this pr into branch-2.9. We can exclude the `io.grpc:grpc-core` in one dependency to fix this issue. Thanks, Hang PengHui Li 于2022年6月27日周一 09:51写道： > > +1 (binding) > > - verify gpg signatures > - run standalone > - pub/sub with pulsar-perf > - verify connector (Cassandra) > - verify stateful function > - build image and test internally for the integration tests (all the tests > get passed) > > @mattison It's better to upload the image under your org first so that we > can verify the image > > Thanks, > Penghui > > On Tue, Jun 21, 2022 at 9:24 AM mattison chao > wrote: > > > This is the first release candidate for Apache Pulsar, version 2.9.3. > > > > It fixes the following issues: > > > > https://github.com/apache/pulsar/pulls?q=is%3Amerged+is%3Apr+label%3Arelease%2F2.9.3+ > > > > *** Please download, test and vote on this release. This vote will stay > > open > > for at least 72 hours *** > > > > Note that we are voting upon the source (tag), binaries are provided for > > convenience. > > > > Source and binary files: > > https://dist.apache.org/repos/dist/dev/pulsar/pulsar-2.9.3-candidate-1/ > > > > SHA-512 checksums: > > > > > > cbc9efbb6b25704e306442b1f45ab7e309fb7c0476c380997b4541b66e4709baeff7c67107a5c68faefe40a32a559755df54a732b21b5c689612307e688f1bcb > > ./apache-pulsar-2.9.3-bin.tar.gz > > > > > > 35795b824d0775ffcd426ff5b86858148fd55c3d465edc52f23aa938daefcc50dbffa962f26e03e6fa3a77a47c3b5f19f98e1a1fbd5a98f6fe6d800223a8ead8 > > ./apache-pulsar-2.9.3-src.tar.gz > > > > Maven staging repo: > > https://repository.apache.org/content/repositories/orgapachepulsar-1158/ > > > > The tag to be voted upon: > > v2.9.3-candidate-1 (dd9a5f1f91651b634600f66c53dcc6ad855fb669) > > https://github.com/apache/pulsar/releases/tag/v2.9.3-candidate-1 > > > > Pulsar's KEYS file containing PGP keys we use to sign the release: > > https://dist.apache.org/repos/dist/dev/pulsar/KEYS > > > > Please download the source package, and follow the Release Candidate > > Validation[1] > > to validate the release > > > > [1] https://github.com/apache/pulsar/wiki/Release-Candidate-Validation > >
Re: [DISCUSS] Enable GitHub Discussions?
+1 for enabling the GitHub Discussion as I proposed before. At that time, the main concern was not able to sync info between GitHub Discussion and Mailing List. Since the concern can be resolved now, we can make the most of GitHub Discussion as it's a powerful supplementary to community collaboration.
[GitHub] [pulsar-client-node] massakam commented on pull request #81: Support seting topic schema when creating producers/consumers
massakam commented on PR #81: URL: https://github.com/apache/pulsar-client-node/pull/81#issuecomment-1166771346 I've resolved the conflict, but the current code fails to compile. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-client-node] massakam commented on a diff in pull request #81: Support seting topic schema when creating producers/consumers
massakam commented on code in PR #81:
URL: https://github.com/apache/pulsar-client-node/pull/81#discussion_r906928647
##
src/SchemaInfo.cc:
##
@@ -0,0 +1,78 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+#include "SchemaInfo.h"
+#include
+
+static const std::string CFG_SCHEMA_TYPE = "schemaType";
+static const std::string CFG_NAME = "name";
+static const std::string CFG_SCHEMA = "schema";
+static const std::string CFG_PROPS = "properties";
+
+static const std::map SCHEMA_TYPE = {{"None",
pulsar_None},
+
{"String", pulsar_String},
+ {"Json",
pulsar_Json},
+
{"Protobuf", pulsar_Protobuf},
+ {"Avro",
pulsar_Avro},
+
{"Boolean", pulsar_Boolean},
+ {"Int8",
pulsar_Int8},
+
{"Int16", pulsar_Int16},
+
{"Int32", pulsar_Int32},
+
{"Int64", pulsar_Int64},
+
{"Float32", pulsar_Float32},
+
{"Float64", pulsar_Float64},
+
{"KeyValue", pulsar_KeyValue},
+
{"Bytes", pulsar_Bytes},
+
{"AutoConsume", pulsar_AutoConsume},
+
{"AutoPublish", pulsar_AutoPublish}};
+
+SchemaInfo::SchemaInfo(const Napi::Object &schemaInfo) :
cSchemaType(pulsar_Bytes), name("BYTES"), schema() {
+ this->cProperties = pulsar_string_map_create();
+ if (schemaInfo.Has(CFG_SCHEMA_TYPE) &&
schemaInfo.Get(CFG_SCHEMA_TYPE).IsString()) {
+this->name = schemaInfo.Get(CFG_SCHEMA_TYPE).ToString().Utf8Value();
+this->cSchemaType =
SCHEMA_TYPE.at(schemaInfo.Get(CFG_SCHEMA_TYPE).ToString().Utf8Value());
+ }
+ if (schemaInfo.Has(CFG_NAME) && schemaInfo.Get(CFG_NAME).IsString()) {
+this->name = schemaInfo.Get(CFG_NAME).ToString().Utf8Value();
+ }
+ if (schemaInfo.Has(CFG_SCHEMA) && schemaInfo.Get(CFG_SCHEMA).IsString()) {
+this->schema = schemaInfo.Get(CFG_SCHEMA).ToString().Utf8Value();
+ }
+ if (schemaInfo.Has(CFG_PROPS) && schemaInfo.Get(CFG_PROPS).IsObject()) {
+Napi::Object propObj = schemaInfo.Get(CFG_PROPS).ToObject();
+Napi::Array arr = propObj.GetPropertyNames();
+int size = arr.Length();
+for (int i = 0; i < size; i++) {
+ Napi::String key = arr.Get(i).ToString();
+ Napi::String value = propObj.Get(key).ToString();
+ pulsar_string_map_put(this->cProperties, key.Utf8Value().c_str(),
value.Utf8Value().c_str());
+}
+ }
+}
+
+void SchemaInfo::SetProducerSchema(pulsar_producer_configuration_t
*cProducerConfiguration) {
+ pulsar_producer_configuration_set_schema_info(cProducerConfiguration,
this->cSchemaType, this->name.c_str(),
Review Comment:
```suggestion
void
SchemaInfo::SetProducerSchema(std::shared_ptr
cProducerConfiguration) {
pulsar_producer_configuration_set_schema_info(cProducerConfiguration.get(),
this->cSchemaType, this->name.c_str(),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar-client-node] massakam commented on a diff in pull request #81: Support seting topic schema when creating producers/consumers
massakam commented on code in PR #81:
URL: https://github.com/apache/pulsar-client-node/pull/81#discussion_r906928816
##
src/SchemaInfo.cc:
##
@@ -0,0 +1,78 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+#include "SchemaInfo.h"
+#include
+
+static const std::string CFG_SCHEMA_TYPE = "schemaType";
+static const std::string CFG_NAME = "name";
+static const std::string CFG_SCHEMA = "schema";
+static const std::string CFG_PROPS = "properties";
+
+static const std::map SCHEMA_TYPE = {{"None",
pulsar_None},
+
{"String", pulsar_String},
+ {"Json",
pulsar_Json},
+
{"Protobuf", pulsar_Protobuf},
+ {"Avro",
pulsar_Avro},
+
{"Boolean", pulsar_Boolean},
+ {"Int8",
pulsar_Int8},
+
{"Int16", pulsar_Int16},
+
{"Int32", pulsar_Int32},
+
{"Int64", pulsar_Int64},
+
{"Float32", pulsar_Float32},
+
{"Float64", pulsar_Float64},
+
{"KeyValue", pulsar_KeyValue},
+
{"Bytes", pulsar_Bytes},
+
{"AutoConsume", pulsar_AutoConsume},
+
{"AutoPublish", pulsar_AutoPublish}};
+
+SchemaInfo::SchemaInfo(const Napi::Object &schemaInfo) :
cSchemaType(pulsar_Bytes), name("BYTES"), schema() {
+ this->cProperties = pulsar_string_map_create();
+ if (schemaInfo.Has(CFG_SCHEMA_TYPE) &&
schemaInfo.Get(CFG_SCHEMA_TYPE).IsString()) {
+this->name = schemaInfo.Get(CFG_SCHEMA_TYPE).ToString().Utf8Value();
+this->cSchemaType =
SCHEMA_TYPE.at(schemaInfo.Get(CFG_SCHEMA_TYPE).ToString().Utf8Value());
+ }
+ if (schemaInfo.Has(CFG_NAME) && schemaInfo.Get(CFG_NAME).IsString()) {
+this->name = schemaInfo.Get(CFG_NAME).ToString().Utf8Value();
+ }
+ if (schemaInfo.Has(CFG_SCHEMA) && schemaInfo.Get(CFG_SCHEMA).IsString()) {
+this->schema = schemaInfo.Get(CFG_SCHEMA).ToString().Utf8Value();
+ }
+ if (schemaInfo.Has(CFG_PROPS) && schemaInfo.Get(CFG_PROPS).IsObject()) {
+Napi::Object propObj = schemaInfo.Get(CFG_PROPS).ToObject();
+Napi::Array arr = propObj.GetPropertyNames();
+int size = arr.Length();
+for (int i = 0; i < size; i++) {
+ Napi::String key = arr.Get(i).ToString();
+ Napi::String value = propObj.Get(key).ToString();
+ pulsar_string_map_put(this->cProperties, key.Utf8Value().c_str(),
value.Utf8Value().c_str());
+}
+ }
+}
+
+void SchemaInfo::SetProducerSchema(pulsar_producer_configuration_t
*cProducerConfiguration) {
+ pulsar_producer_configuration_set_schema_info(cProducerConfiguration,
this->cSchemaType, this->name.c_str(),
+this->schema.c_str(),
this->cProperties);
+}
+
+void SchemaInfo::SetConsumerSchema(pulsar_consumer_configuration_t
*cConsumerConfiguration) {
+ pulsar_consumer_configuration_set_schema_info(cConsumerConfiguration,
this->cSchemaType, this->name.c_str(),
Review Comment:
```suggestion
void
SchemaInfo::SetConsumerSchema(std::shared_ptr
cConsumerConfiguration) {
pulsar_consumer_configuration_set_schema_info(cConsumerConfiguration.get(),
this->cSchemaType, this->name.c_str(),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...
[GitHub] [pulsar-client-node] massakam commented on a diff in pull request #81: Support seting topic schema when creating producers/consumers
massakam commented on code in PR #81:
URL: https://github.com/apache/pulsar-client-node/pull/81#discussion_r906929063
##
src/SchemaInfo.h:
##
@@ -0,0 +1,41 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+#ifndef SCHEMA_INFO_H
+#define SCHEMA_INFO_H
+
+#include
+#include
+#include
+
+class SchemaInfo {
+ public:
+ SchemaInfo(const Napi::Object &schemaInfo);
+ ~SchemaInfo();
+ void SetProducerSchema(pulsar_producer_configuration_t
*cProducerConfiguration);
Review Comment:
```suggestion
void SetProducerSchema(std::shared_ptr
cProducerConfiguration);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar-client-node] massakam commented on a diff in pull request #81: Support seting topic schema when creating producers/consumers
massakam commented on code in PR #81:
URL: https://github.com/apache/pulsar-client-node/pull/81#discussion_r906929144
##
src/SchemaInfo.h:
##
@@ -0,0 +1,41 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+#ifndef SCHEMA_INFO_H
+#define SCHEMA_INFO_H
+
+#include
+#include
+#include
+
+class SchemaInfo {
+ public:
+ SchemaInfo(const Napi::Object &schemaInfo);
+ ~SchemaInfo();
+ void SetProducerSchema(pulsar_producer_configuration_t
*cProducerConfiguration);
+ void SetConsumerSchema(pulsar_consumer_configuration_t
*cConsumerConfiguration);
Review Comment:
```suggestion
void SetConsumerSchema(std::shared_ptr
cConsumerConfiguration);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [VOTE] Pulsar Release 2.10.1 Candidate 1
Hi - The Release Manager can vote. Shouldn’t you? Best Regards, Dave Sent from my iPhone > On Jun 26, 2022, at 5:51 PM, PengHui Li wrote: > > Hi all, > > Thanks for all your verification for 2.10.1 > > We currently have 2 (+1) bindings and 5 (+1) non-bindings. > We need one more (+1) binding to unblock the 2.10.1 release. > Please help validate. > > Thanks, > Penghui > >> On Thu, Jun 16, 2022 at 12:43 PM Shusuke Tsuda >> wrote: >> >> +1 (non-binding) >> >> - verified checksums and signatures >> - build from source >> - verified pub/sub and java functions >> - verified stateful functions >> >> Thanks, >> Shusuke Tsuda >> >> -Original Message- >> From: PengHui Li >> Sent: Monday, June 13, 2022 8:43 PM >> To: Dev >> Subject: [VOTE] Pulsar Release 2.10.1 Candidate 1 >> >> This is the first release candidate for Apache Pulsar 2.10.1 >> >> It fixes the following issues: >> >> https://github.com/apache/pulsar/pulls?q=is%3Amerged+is%3Apr+label%3Arelease%2F2.10.1+ >> >> *** Please download, test and vote on this release. This vote will stay >> open for at least 72 hours *** >> >> Note that we are voting upon the source (tag), binaries are provided for >> convenience. >> >> Source and binary files: >> >> https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev%2Fpulsar%2Fpulsar-2.10.1-candidate-1%2F&data=05%7C01%7Cshustsud%40yahoo-corp.jp%7C5ddcaa29fc224b6f09e608da4d31e6a8%7Ca208d369cd4e4f87b11998eaf31df2c3%7C1%7C0%7C637907173959452192%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=MlMhzU4P7GzFXx%2BNQ9DYh09Z4%2BJWzqWe%2BXbhO5pOGBo%3D&reserved=0 >> >> SHA-512 checksums: >> >> >> 87045067cf123574b2b7d578f020efd177b0d9ff12a75d9f738e135cde35a034000c03e21cc8a264a6ef9e2b1df2c4493ffa3b9170b0f368d7424f1160df38cb >> ./apache-pulsar-2.10.1-bin.tar.gz >> >> >> 19c078f65b9105728adda3926a9a1527d6498f0e2337d37497a6d965a38acf94e217e58939bc5b0a8b8166511ae9ee176ee3d0c764d4777e285b7bcaeb2731e1 >> ./apache-pulsar-2.10.1-src.tar.gz >> >> Maven staging repo: >> >> https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Frepository.apache.org%2Fcontent%2Frepositories%2Forgapachepulsar-1156%2F&data=05%7C01%7Cshustsud%40yahoo-corp.jp%7C5ddcaa29fc224b6f09e608da4d31e6a8%7Ca208d369cd4e4f87b11998eaf31df2c3%7C1%7C0%7C637907173959452192%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=7881wtcvkkKTYpcJUDaaP1kD7L25hmJyWYnAsa7H1iw%3D&reserved=0 >> >> The tag to be voted upon: >> v2.10.1-candidate-1 (0702b51ce09cc99044f4110e6bf98e82a0e86283) >> https://github.com/apache/pulsar/releases/tag/v2.10.1-candidate-1 >> >> Pulsar's KEYS file containing PGP keys we use to sign the release: >> >> https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev%2Fpulsar%2FKEYS&data=05%7C01%7Cshustsud%40yahoo-corp.jp%7C5ddcaa29fc224b6f09e608da4d31e6a8%7Ca208d369cd4e4f87b11998eaf31df2c3%7C1%7C0%7C637907173959452192%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=PTTqkrOKzXpW9I14aQRcSHl1swE8tCua%2Bo%2BTIkP%2F8jM%3D&reserved=0 >> >> Docker images: >> >> >> https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fhub.docker.com%2Flayers%2F233293315%2Flph890127%2Fpulsar%2F2.10.1-rc1%2Fimages%2Fsha256-4a952b3c662b94247ffc4ff17be16ef176c293baaf346db13a095970f43adfd6%3Fcontext%3Drepo&data=05%7C01%7Cshustsud%40yahoo-corp.jp%7C5ddcaa29fc224b6f09e608da4d31e6a8%7Ca208d369cd4e4f87b11998eaf31df2c3%7C1%7C0%7C637907173959452192%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=Td0nWB8YQIgPrC0252vtyyEqokUQLCTZ9MYJbIxuhQU%3D&reserved=0 >> >> >> https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fhub.docker.com%2Flayers%2F233303469%2Flph890127%2Fpulsar-all%2F2.10.1-rc1%2Fimages%2Fsha256-ac8180f4ba796291e961581821a1318437e49b0fa684597f5b67265a502822ee%3Fcontext%3Drepo&data=05%7C01%7Cshustsud%40yahoo-corp.jp%7C5ddcaa29fc224b6f09e608da4d31e6a8%7Ca208d369cd4e4f87b11998eaf31df2c3%7C1%7C0%7C637907173959452192%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=7kiKT%2BK7T%2BkJSTSAER%2BF8aFyLTXHKrjEMa%2BP0AOxiSk%3D&reserved=0 >> >> Please download the source package, and follow the Release Candidate >> Validation[1] to validate the release >> >> [1] https://github.com/apache/pulsar/wiki/Release-Candidate-Validation >> >> Thanks, >> Penghui >>
Re: [DISCUSS] [PIP-179] Support the admin API to check unknown request parameters
+1
Zike Yang
On Wed, Jun 22, 2022 at 11:26 AM PengHui Li wrote:
> +1
>
> Penghui
>
> On Wed, Jun 22, 2022 at 10:53 AM Yubiao Feng
> wrote:
>
> > Hi, Pulsar community:
> >
> > I open a pip to discuss "Support the admin API to check unknown request
> > parameters"
> >
> > Proposal Link: https://github.com/apache/pulsar/issues/16135
> >
> > ### Motivation
> >
> > The design of the Admin API is now such that if an incorrect parameter
> name
> > is submitted, this property (if not required) will be ignored, then
> > execution continues, and the response is “204 Success”. This will trick
> the
> > user into thinking the setup succeeded when it didn't correctly as
> expected
> > in some cases, as shown below:
> >
> > User POST request to /{tenant}/{namespace}/{topic}/retention" with
> > incorrect parameter:
> > ```json
> > {"retention_size_in_mb":-1,"retention_time_in_minutes":40320}
> > ```
> >
> > Which should have been this:
> >
> > ```json
> > {"retentionSizeInMB":-1,"retentionTimeInMinutes":40320}
> > ```
> >
> > Response:
> >
> > ```http
> > HTTP/1.1 204 No Content
> > Date: Mon, 20 Jun 2022 02:54:25 GMT
> > broker-address: 127.0.0.1
> > Server: Jetty(9.4.44.v20210927)
> > ```
> >
> > We can provide an optional mechanism: "fail (HTTP status 400 bad
> requests)
> > on unknown request parameters".
> >
> > ## Goal
> >
> > - scope:
> > - ~~Path variables~~(no need for change): This represents the domain.
> > The current API has been validated, so no additional modifications are
> > required.
> > - ~~Query params~~(no support on this proposal): I haven't found an
> > elegant way to do it yet, so this proposal does not include Query Param
> > validation.
> > - *Entity properties*: This proposal only handles requests whose
> > Content-type is "application/json" (in fact, this is the only type in our
> > project).
> > - Configurable(Support dynamic switching).
> >
> >
> > ## Approach
> >
> > When parsing the request body, any unknown property is considered a bad
> > request. The [Jackson unknown property rule](
> >
> >
> https://github.com/FasterXML/jackson-databind/blob/de3d0ecbc1fd0a1a6b061e62a198b3ba0d0d163e/src/main/java/com/fasterxml/jackson/databind/DeserializationFeature.java#L121
> > )
> > is adopted:
> >
> > - Case sensitive.
> > - Special characters are not ignored.
> > - Do not trim Spaces.
> >
> > If the check fails, return a text/plain response with 400 code. Like
> this:
> >
> > ```http
> > HTTP/1.1 400 Bad Request
> > Date: Mon, 20 Jun 2022 03:52:10 GMT
> > broker-address: 127.0.0.1
> > Content-Type: text/plain
> > Content-Length: 432
> > Server: Jetty(9.4.44.v20210927)
> >
> > Unrecognized field "retention_size_in_mb" (class
> > org.apache.pulsar.common.policies.data.RetentionPolicies known
> properties:
> > "retentionSizeInMB", "retentionTimeInMinutes"])
> > ```
> >
> > ## Configuration Changes
> >
> > broker.conf
> >
> > ```properties
> > # Admin API fail on unknown request parameter in request-body. see
> PIP-178.
> > Setting this to blank means that this feature is turned off.
> > httpRequestsFailOnUnknownPropertiesEnabled=false
> > ```
> >
> > ## Dynamic switching
> > Enabling this feature affects all of the broker's HTTP services,
> including
> > the following:
> >
> > - /status.html (no post-entity request)
> > - /admin [v2,v3]
> > - /lookup (no post-entity request)
> > - /topics (http client)
> > - /metrics (no post-entity request)
> >
> > Because of the number of apis involved, we provide dynamic configuration.
> > When a user discovers any problem, it can be turned on and off
> dynamically
> > using the Admin API(without restarting Broker), which can reduce impact.
> >
> > Note: Since admin api v1 is no longer maintained, this feature does not
> > affect this part of the functionality.
> >
> > ```shell
> > pulsar-admin brokers update-dynamic-config --config
> > httpRequestsFailOnUnknownPropertiesEnabled --value [boolean]
> > ```
> >
> > Thanks
> > Yubiao Feng
> >
>
[GitHub] [pulsar-helm-chart] nodece commented on a diff in pull request #243: Update pulsarctl to v2.9.2.7
nodece commented on code in PR #243:
URL: https://github.com/apache/pulsar-helm-chart/pull/243#discussion_r906987312
##
scripts/pulsar/common_auth.sh:
##
@@ -25,7 +25,7 @@ fi
OUTPUT=${CHART_HOME}/output
OUTPUT_BIN=${OUTPUT}/bin
-PULSARCTL_VERSION=v0.4.0
+PULSARCTL_VERSION=v2.9.2.7
Review Comment:
Update to the latest 2.9.x or 2.10.x release version as much as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar-helm-chart] nodece commented on a diff in pull request #243: Update pulsarctl to v2.9.2.7
nodece commented on code in PR #243:
URL: https://github.com/apache/pulsar-helm-chart/pull/243#discussion_r906987312
##
scripts/pulsar/common_auth.sh:
##
@@ -25,7 +25,7 @@ fi
OUTPUT=${CHART_HOME}/output
OUTPUT_BIN=${OUTPUT}/bin
-PULSARCTL_VERSION=v0.4.0
+PULSARCTL_VERSION=v2.9.2.7
Review Comment:
Update to the latest 2.9.x or 2.10.x release version as much as possible,
because recently we fixed some bugs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [VOTE] PIP-177: Add the classLoader field for SchemaDefinition
Thanks for your participation. I'm closing the vote. The proposal has been accepted with 5 binding +1, non-binding +2 votes. On 2022/06/17 01:21:14 Cong Zhao wrote: > Hi Pulsar Community, > > > I would like to start a VOTE on "Add the classLoader field for > SchemaDefinition" (PIP-177). > > > The proposal can be read at https://github.com/apache/pulsar/issues/16058 > > and the discussion thead is available at > > https://lists.apache.org/thread/3wjvmpzo3pq1ff62f4cops7ckyrcgfhf > > > Voting will stay open for at least 48h. > > > Thanks, > > Cong Zhao >
Re: [VOTE] PIP-168: Support zero-copy of NIC to NIC on Proxy
I forgot to close this vote. I'm closing the vote. The proposal has been accepted with 4 binding +1, non-binding +1 votes. Thanks, Cong Zhao On 2022/05/26 13:40:30 zhaocong wrote: > Hi Pulsar Community, > > > I would like to start a VOTE on "Support zero-copy of NIC to NIC on Proxy" > (PIP-168). > > > The proposal can be read at https://github.com/apache/pulsar/issues/15631 > > and the discussion thead is available at > > https://lists.apache.org/thread/gjys9tvbd5hy28mbkbcq7wkqfldycn7v > > > Voting will stay open for at least 48h. > > > Thanks, > > Cong Zhao >
[GitHub] [pulsar-helm-chart] rdhabalia commented on a diff in pull request #269: Support mechanism to provide external zookeeper-server list to build global/configuration zookeeper
rdhabalia commented on code in PR #269:
URL: https://github.com/apache/pulsar-helm-chart/pull/269#discussion_r907003823
##
charts/pulsar/templates/zookeeper-statefulset.yaml:
##
@@ -134,10 +134,19 @@ spec:
containerPort: {{ .Values.zookeeper.ports.clientTls }}
{{- end }}
env:
-- name: ZOOKEEPER_SERVERS
- value:
-{{- $global := . }}
-{{ range $i, $e := until (.Values.zookeeper.replicaCount | int)
}}{{ if ne $i 0 }},{{ end }}{{ template "pulsar.fullname" $global }}-{{
$global.Values.zookeeper.component }}-{{ printf "%d" $i }}{{ end }}
+ - name: ZOOKEEPER_SERVERS
+{{- if .Values.zookeeper.configData.ZOOKEEPER_SERVERS }}
Review Comment:
yes, I have added sample-example values in
`examples/values-zookeeper-aws.yaml`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
