[GitHub] [pulsar-site] Anonymitaet merged pull request #108: [improve][website] add download links for previous versions

[GitBox]

Anonymitaet merged PR #108:
URL: https://github.com/apache/pulsar-site/pull/108


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [pulsar-site] urfreespace merged pull request #110: fix: upgrade build node versions

[GitBox]

urfreespace merged PR #110:
URL: https://github.com/apache/pulsar-site/pull/110


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [pulsar-test-infra] maxsxu opened a new pull request, #44: [docbot] fix relative working directory

[GitBox]

maxsxu opened a new pull request, #44:
URL: https://github.com/apache/pulsar-test-infra/pull/44

   The `working-directory` should be set as `docbot`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [pulsar-helm-chart] Syphixs commented on issue #267: helm chart for pulsar version 2.10.0

[GitBox]

Syphixs commented on issue #267:
URL: 
https://github.com/apache/pulsar-helm-chart/issues/267#issuecomment-1153776712

   bump , new version would be gladly appreciated! 
   Seems though its not a simple image version upgrade alone


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[VOTE] Pulsar Release 2.10.1 Candidate 1

[PengHui Li]

This is the first release candidate for Apache Pulsar 2.10.1

It fixes the following issues:
https://github.com/apache/pulsar/pulls?q=is%3Amerged+is%3Apr+label%3Arelease%2F2.10.1+

*** Please download, test and vote on this release. This vote will stay open
for at least 72 hours ***

Note that we are voting upon the source (tag), binaries are provided for
convenience.

Source and binary files:
https://dist.apache.org/repos/dist/dev/pulsar/pulsar-2.10.1-candidate-1/

SHA-512 checksums:

87045067cf123574b2b7d578f020efd177b0d9ff12a75d9f738e135cde35a034000c03e21cc8a264a6ef9e2b1df2c4493ffa3b9170b0f368d7424f1160df38cb
 ./apache-pulsar-2.10.1-bin.tar.gz

19c078f65b9105728adda3926a9a1527d6498f0e2337d37497a6d965a38acf94e217e58939bc5b0a8b8166511ae9ee176ee3d0c764d4777e285b7bcaeb2731e1
 ./apache-pulsar-2.10.1-src.tar.gz

Maven staging repo:
https://repository.apache.org/content/repositories/orgapachepulsar-1156/

The tag to be voted upon:
v2.10.1-candidate-1 (0702b51ce09cc99044f4110e6bf98e82a0e86283)
https://github.com/apache/pulsar/releases/tag/v2.10.1-candidate-1

Pulsar's KEYS file containing PGP keys we use to sign the release:
https://dist.apache.org/repos/dist/dev/pulsar/KEYS

Docker images:

https://hub.docker.com/layers/233293315/lph890127/pulsar/2.10.1-rc1/images/sha256-4a952b3c662b94247ffc4ff17be16ef176c293baaf346db13a095970f43adfd6?context=repo

https://hub.docker.com/layers/233303469/lph890127/pulsar-all/2.10.1-rc1/images/sha256-ac8180f4ba796291e961581821a1318437e49b0fa684597f5b67265a502822ee?context=repo

Please download the source package, and follow the Release Candidate
Validation[1]
to validate the release

[1] https://github.com/apache/pulsar/wiki/Release-Candidate-Validation

Thanks,
Penghui

[GitHub] [pulsar-test-infra] lhotari commented on pull request #43: Implement a new documentation bot

[GitBox]

lhotari commented on PR #43:
URL: https://github.com/apache/pulsar-test-infra/pull/43#issuecomment-1153936978

   > @maxsxu thanks for your great contribution! We've tested and it works 
well. Approve from the non-technical side.
   
   @Anonymitaet how was this tested? all jobs fail in apache/pulsar currently 
after merging https://github.com/apache/pulsar/pull/16027


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Pulsar Documentation Guides

[Yu]

Hi team,

This is a soft reminder:

If you make contributions to Pulsar documentation, please follow these
guides to improve your PR quality and get your PR merged quickly.

- Pulsar Documentation Writing Style Guide [1]
- Pulsar Documentation Writing Syntax Guide [2]
- Pulsar Documentation Preview Guide [3]
- Pulsar Documentation Label Guide [4]
- Pulsar Pull Request Naming Convention Guide [5]
- Pulsar Design Style Guide [6]

I'm continuously updating these guides and working on the documentation
contribution guide. Stay tuned!

Feel free to comment, thank you!

[1]
https://docs.google.com/document/d/1lc5j4RtuLIzlEYCBo97AC8-U_3Erzs_lxpkDuseU0n4/edit#
[2]
https://docs.google.com/document/d/12De2btkDHQVaqUlHjTqERmroMLKGhHdiC7rEttFTyqc/edit#
[3]
https://docs.google.com/document/d/1wszdtMRo6MhKbVaggPK7_bnKaC4TewuT--GWZZxJNGg/edit#heading=h.tng8x5vsxlpi
[4]
https://docs.google.com/document/d/1Qw7LHQdXWBW9t2-r-A7QdFDBwmZh6ytB4guwMoXHqc0/edit#
[5]
https://docs.google.com/document/d/1d8Pw6ZbWk-_pCKdOmdvx9rnhPiyuxwq60_TrD68d7BA/edit#heading=h.wu6ygjne8e35
[6]
https://docs.google.com/document/d/16Hp7Sc86MQtL0m8fc2w_TrcKXAuglwRwHmdmwfk00mI/edit#heading=h.b8ogodj5sj0

Yu

[GitHub] [pulsar-test-infra] lhotari merged pull request #44: [docbot] fix relative working directory

[GitBox]

lhotari merged PR #44:
URL: https://github.com/apache/pulsar-test-infra/pull/44


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [VOTE] Pulsar Release 2.10.1 Candidate 1

[Ran Gao]

+1 (non-binding)

Verification list:
1. Build source code. (MacOS 12.2.1, Chip Apple M1 Pro)
2. Start standalone.
3. Producing and consuming tests based on perf tool.
4. Query bytes data by Pulsar SQL.
5. Using the binary package execute same operations.

On 2022/06/13 11:42:59 PengHui Li wrote:
> This is the first release candidate for Apache Pulsar 2.10.1
> 
> It fixes the following issues:
> https://github.com/apache/pulsar/pulls?q=is%3Amerged+is%3Apr+label%3Arelease%2F2.10.1+
> 
> *** Please download, test and vote on this release. This vote will stay open
> for at least 72 hours ***
> 
> Note that we are voting upon the source (tag), binaries are provided for
> convenience.
> 
> Source and binary files:
> https://dist.apache.org/repos/dist/dev/pulsar/pulsar-2.10.1-candidate-1/
> 
> SHA-512 checksums:
> 
> 87045067cf123574b2b7d578f020efd177b0d9ff12a75d9f738e135cde35a034000c03e21cc8a264a6ef9e2b1df2c4493ffa3b9170b0f368d7424f1160df38cb
>  ./apache-pulsar-2.10.1-bin.tar.gz
> 
> 19c078f65b9105728adda3926a9a1527d6498f0e2337d37497a6d965a38acf94e217e58939bc5b0a8b8166511ae9ee176ee3d0c764d4777e285b7bcaeb2731e1
>  ./apache-pulsar-2.10.1-src.tar.gz
> 
> Maven staging repo:
> https://repository.apache.org/content/repositories/orgapachepulsar-1156/
> 
> The tag to be voted upon:
> v2.10.1-candidate-1 (0702b51ce09cc99044f4110e6bf98e82a0e86283)
> https://github.com/apache/pulsar/releases/tag/v2.10.1-candidate-1
> 
> Pulsar's KEYS file containing PGP keys we use to sign the release:
> https://dist.apache.org/repos/dist/dev/pulsar/KEYS
> 
> Docker images:
> 
> https://hub.docker.com/layers/233293315/lph890127/pulsar/2.10.1-rc1/images/sha256-4a952b3c662b94247ffc4ff17be16ef176c293baaf346db13a095970f43adfd6?context=repo
> 
> https://hub.docker.com/layers/233303469/lph890127/pulsar-all/2.10.1-rc1/images/sha256-ac8180f4ba796291e961581821a1318437e49b0fa684597f5b67265a502822ee?context=repo
> 
> Please download the source package, and follow the Release Candidate
> Validation[1]
> to validate the release
> 
> [1] https://github.com/apache/pulsar/wiki/Release-Candidate-Validation
> 
> Thanks,
> Penghui
> 

Re: Pulsar Documentation Guides

[Ran Gao]

Great work!

On 2022/06/13 16:00:00 Yu wrote:
> Hi team,
> 
> This is a soft reminder:
> 
> If you make contributions to Pulsar documentation, please follow these
> guides to improve your PR quality and get your PR merged quickly.
> 
> - Pulsar Documentation Writing Style Guide [1]
> - Pulsar Documentation Writing Syntax Guide [2]
> - Pulsar Documentation Preview Guide [3]
> - Pulsar Documentation Label Guide [4]
> - Pulsar Pull Request Naming Convention Guide [5]
> - Pulsar Design Style Guide [6]
> 
> I'm continuously updating these guides and working on the documentation
> contribution guide. Stay tuned!
> 
> Feel free to comment, thank you!
> 
> [1]
> https://docs.google.com/document/d/1lc5j4RtuLIzlEYCBo97AC8-U_3Erzs_lxpkDuseU0n4/edit#
> [2]
> https://docs.google.com/document/d/12De2btkDHQVaqUlHjTqERmroMLKGhHdiC7rEttFTyqc/edit#
> [3]
> https://docs.google.com/document/d/1wszdtMRo6MhKbVaggPK7_bnKaC4TewuT--GWZZxJNGg/edit#heading=h.tng8x5vsxlpi
> [4]
> https://docs.google.com/document/d/1Qw7LHQdXWBW9t2-r-A7QdFDBwmZh6ytB4guwMoXHqc0/edit#
> [5]
> https://docs.google.com/document/d/1d8Pw6ZbWk-_pCKdOmdvx9rnhPiyuxwq60_TrD68d7BA/edit#heading=h.wu6ygjne8e35
> [6]
> https://docs.google.com/document/d/16Hp7Sc86MQtL0m8fc2w_TrcKXAuglwRwHmdmwfk00mI/edit#heading=h.b8ogodj5sj0
> 
> Yu
> 

Re: Pulsar Documentation Guides

[Dave Fisher]

Hi Yu,

I have a request. Please make these guides part of the website and on project 
managed resources.

Thank you,
Dave

Sent from my iPhone

> On Jun 13, 2022, at 9:04 AM, Yu  wrote:
> 
> 
> Hi team,
> 
> This is a soft reminder:
> 
> If you make contributions to Pulsar documentation, please follow these guides 
> to improve your PR quality and get your PR merged quickly.
> 
> - Pulsar Documentation Writing Style Guide [1]
> - Pulsar Documentation Writing Syntax Guide [2]
> - Pulsar Documentation Preview Guide [3]
> - Pulsar Documentation Label Guide [4]
> - Pulsar Pull Request Naming Convention Guide [5]
> - Pulsar Design Style Guide [6]
> 
> I'm continuously updating these guides and working on the documentation 
> contribution guide. Stay tuned!
> 
> Feel free to comment, thank you!
> 
> [1] 
> https://docs.google.com/document/d/1lc5j4RtuLIzlEYCBo97AC8-U_3Erzs_lxpkDuseU0n4/edit#
> [2] 
> https://docs.google.com/document/d/12De2btkDHQVaqUlHjTqERmroMLKGhHdiC7rEttFTyqc/edit#
> [3] 
> https://docs.google.com/document/d/1wszdtMRo6MhKbVaggPK7_bnKaC4TewuT--GWZZxJNGg/edit#heading=h.tng8x5vsxlpi
> [4] 
> https://docs.google.com/document/d/1Qw7LHQdXWBW9t2-r-A7QdFDBwmZh6ytB4guwMoXHqc0/edit#
> [5] 
> https://docs.google.com/document/d/1d8Pw6ZbWk-_pCKdOmdvx9rnhPiyuxwq60_TrD68d7BA/edit#heading=h.wu6ygjne8e35
> [6] 
> https://docs.google.com/document/d/16Hp7Sc86MQtL0m8fc2w_TrcKXAuglwRwHmdmwfk00mI/edit#heading=h.b8ogodj5sj0
> 
> Yu

[GitHub] [pulsar-site] heesung-sn opened a new pull request, #111: Recommitted the dropped instruction, CI Testing in your Fork

[GitBox]

heesung-sn opened a new pull request, #111:
URL: https://github.com/apache/pulsar-site/pull/111

   This was originally approved by https://github.com/apache/pulsar/pull/15535.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [pulsar-site] aarondonwilliams opened a new pull request, #112: Update community.js

[GitBox]

aarondonwilliams opened a new pull request, #112:
URL: https://github.com/apache/pulsar-site/pull/112

   Currently there isn't a simple what to sign up for the Pulsar Slack.  The 
link to the heroku app seems to have been lost in the move to the new site.  
   I used this page as the model for the text: 
https://pulsar.apache.org/contact/
   
   approx line 249- Added text to explain the new button
   approx line 253- Add button for the heroku app and the text explaining the 
button
   approx line 233- correcting the url
   approx line 200- removed unnecessary prepositional phrase "which includes 
Pulsar committers".. yes a minor change but since I was adding in the button...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [pulsar-helm-chart] michaeljmarshall commented on issue #267: helm chart for pulsar version 2.10.0

[GitBox]

michaeljmarshall commented on issue #267:
URL: 
https://github.com/apache/pulsar-helm-chart/issues/267#issuecomment-1154506431

   This PR https://github.com/apache/pulsar-helm-chart/pull/266 should fix it 
to make it a simple version upgrade. I will try to get it merged this week.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [pulsar-test-infra] michaeljmarshall commented on a diff in pull request #43: Implement a new documentation bot

[GitBox]

michaeljmarshall commented on code in PR #43:
URL: https://github.com/apache/pulsar-test-infra/pull/43#discussion_r896211686


##
docbot/README.md:
##
@@ -0,0 +1,54 @@
+# Documentation Bot 
+
+Automatically label pull requests based on the checked task list.
+
+## Usage
+
+Create a workflow `.github/workflows/ci-docbot.yml` with below content:
+
+```yaml
+name: Documentation Bot
+
+on:
+  pull_request_target:
+types:
+  - opened
+  - edited
+  - labeled
+  - unlabeled
+
+jobs:
+  label:
+permissions:
+  pull-requests: write
+runs-on: ubuntu-latest
+steps:
+  - name: Checkout action
+uses: actions/checkout@v3
+with:
+  repository: maxsxu/action-labeler

Review Comment:
   Did you meant to leave this reference to your personal github repo?



##
docbot/README.md:
##
@@ -0,0 +1,54 @@
+# Documentation Bot 
+
+Automatically label pull requests based on the checked task list.
+
+## Usage
+
+Create a workflow `.github/workflows/ci-docbot.yml` with below content:
+
+```yaml
+name: Documentation Bot
+
+on:
+  pull_request_target:
+types:
+  - opened
+  - edited
+  - labeled
+  - unlabeled
+
+jobs:
+  label:
+permissions:
+  pull-requests: write
+runs-on: ubuntu-latest
+steps:
+  - name: Checkout action
+uses: actions/checkout@v3
+with:
+  repository: maxsxu/action-labeler
+  ref: master
+
+  - name: Set up Go
+uses: actions/setup-go@v3
+with:
+  go-version: 1.18
+
+  - name: Labeling
+uses: maxsxu/action-labeler@master

Review Comment:
   Same comment.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [pulsar-test-infra] michaeljmarshall opened a new issue, #45: Add LICENSE file to root of project directory

[GitBox]

michaeljmarshall opened a new issue, #45:
URL: https://github.com/apache/pulsar-test-infra/issues/45

   We need to add the Apache LICENSE in the root of this project directory. I 
plan to do this later tonight.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [pulsar-site] urfreespace commented on pull request #112: Update community.js

[GitBox]

urfreespace commented on PR #112:
URL: https://github.com/apache/pulsar-site/pull/112#issuecomment-1154602917

   @Anonymitaet PTAL, thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [pulsar-site] urfreespace commented on pull request #111: Recommitted the dropped instruction, CI Testing in your Fork

[GitBox]

urfreespace commented on PR #111:
URL: https://github.com/apache/pulsar-site/pull/111#issuecomment-1154603295

   @Anonymitaet PTAL, thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [pulsar-site] urfreespace opened a new pull request, #113: feat: upgrade docusaurus version and upgrade docker image with node 16

[GitBox]

urfreespace opened a new pull request, #113:
URL: https://github.com/apache/pulsar-site/pull/113

   docusaurus (>=2.0.0-beta.21) required the node >= 16.14


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [pulsar-site] urfreespace merged pull request #113: feat: upgrade docusaurus version and upgrade docker image with node 16

[GitBox]

urfreespace merged PR #113:
URL: https://github.com/apache/pulsar-site/pull/113


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [pulsar-helm-chart] zymap opened a new pull request, #270: Enable the pulsar manager in the minikube values

[GitBox]

zymap opened a new pull request, #270:
URL: https://github.com/apache/pulsar-helm-chart/pull/270

   ---
   
   Fixes: https://github.com/apache/pulsar/issues/15927
   
   ### Motivation
   
   We have documented the using pulsar manager in the Getting started
   with helm on the pulsar website. We should enable the pulsar manager
   by default in the minikube values.
   
   ### Modifications
   
   - enable the pulsar manager by default in the minikube values.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [pulsar-test-infra] michaeljmarshall opened a new pull request, #46: Add LICENSE to project's root directory

[GitBox]

michaeljmarshall opened a new pull request, #46:
URL: https://github.com/apache/pulsar-test-infra/pull/46

   Fix #45. In talking with @dave2wave, he mentioned that we should have a 
LICENSE file in this project. Adding that file now. I copied the contents of 
the file straight from the apache/pulsar project.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [pulsar-helm-chart] michaeljmarshall merged pull request #266: Add bk, zk securityContext to support upgrade to non-root docker image

[GitBox]

michaeljmarshall merged PR #266:
URL: https://github.com/apache/pulsar-helm-chart/pull/266


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [Discuss] Update Helm Chart to Support 2.10 Docker Image

[Michael Marshall]

I just merged https://github.com/apache/pulsar-helm-chart/pull/266.
I'll follow up with a proposal that we release a new version of the
helm chart.

Thanks,
Michael

On Thu, May 19, 2022 at 2:13 PM Michael Marshall  wrote:
>
> Hello Pulsar Community,
>
> With the 2.10.0 release, our Pulsar Docker images default to run as a
> non-root user. In order to use the 2.10.0 Docker image with the Apache
> Pulsar Helm Chart, we need to merge this PR [0]. If you're able,
> please review it. Once merged, I propose that we follow up with a
> release so that users wanting to upgrade to 2.10.0 have an upgrade
> path.
>
> Thanks,
> Michael
>
> [0] https://github.com/apache/pulsar-helm-chart/pull/266

[DISCUSS] Release Next Pulsar Helm Chart Version

[Michael Marshall]

Hello Pulsar Community,

I propose that we release a new version of the Pulsar Helm Chart since
it now supports the 2.10.0 docker image. It looks like the version
should be 2.9.4, but I'm not entirely sure how we version the chart.
Does anyone have guidance on what the version ought to be?

Note that recently we have not been voting on these releases. Since
this is an ASF requirement for releases [0], I think we should start
voting on these releases.

Also, is it important that we sign the release? It looks like the
`helm package` command provides a signing feature here [1]. We will
need to modify our release procedure to sign artifacts.

Let me know what you think.

Thanks,
Michael

[0] https://www.apache.org/foundation/voting.html#ReleaseVotes
[1] https://helm.sh/docs/topics/provenance/

[GitHub] [pulsar-site] michaeljmarshall commented on pull request #109: fix: replace scripts fix

[GitBox]

michaeljmarshall commented on PR #109:
URL: https://github.com/apache/pulsar-site/pull/109#issuecomment-1154668750

   @urfreespace - does this PR fix 
https://github.com/apache/pulsar/issues/15984?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[DISCUSS][PIP-176] PIP176:Multiple snapshots for transaction buffer snapshot

[Xiangying Meng]

Hi Pulsar Community,
I have opened a proposal to implement multiple snapshots for the
transaction buffer.
The details can be found here
.

Thanks,
Xiangying Meng

Re: Pulsar Documentation Guides

[Michael Marshall]

Hi Yu,

Thank you for your efforts to improve our documentation. I agree with
Dave that these should be added to our Pulsar website instead of being
managed in Google Docs.

For example, our docs bot is configured to link to one of the google
docs. I think it'd be more appropriate to link it to our website [0]

Thanks,
Michael

[0] https://github.com/apache/pulsar/pull/16045#issuecomment-1154724788



On Mon, Jun 13, 2022 at 1:13 PM Dave Fisher  wrote:
>
> Hi Yu,
>
> I have a request. Please make these guides part of the website and on project 
> managed resources.
>
> Thank you,
> Dave
>
> Sent from my iPhone
>
> On Jun 13, 2022, at 9:04 AM, Yu  wrote:
>
> 
> Hi team,
>
> This is a soft reminder:
>
> If you make contributions to Pulsar documentation, please follow these guides 
> to improve your PR quality and get your PR merged quickly.
>
> - Pulsar Documentation Writing Style Guide [1]
> - Pulsar Documentation Writing Syntax Guide [2]
> - Pulsar Documentation Preview Guide [3]
> - Pulsar Documentation Label Guide [4]
> - Pulsar Pull Request Naming Convention Guide [5]
> - Pulsar Design Style Guide [6]
>
> I'm continuously updating these guides and working on the documentation 
> contribution guide. Stay tuned!
>
> Feel free to comment, thank you!
>
> [1] 
> https://docs.google.com/document/d/1lc5j4RtuLIzlEYCBo97AC8-U_3Erzs_lxpkDuseU0n4/edit#
> [2] 
> https://docs.google.com/document/d/12De2btkDHQVaqUlHjTqERmroMLKGhHdiC7rEttFTyqc/edit#
> [3] 
> https://docs.google.com/document/d/1wszdtMRo6MhKbVaggPK7_bnKaC4TewuT--GWZZxJNGg/edit#heading=h.tng8x5vsxlpi
> [4] 
> https://docs.google.com/document/d/1Qw7LHQdXWBW9t2-r-A7QdFDBwmZh6ytB4guwMoXHqc0/edit#
> [5] 
> https://docs.google.com/document/d/1d8Pw6ZbWk-_pCKdOmdvx9rnhPiyuxwq60_TrD68d7BA/edit#heading=h.wu6ygjne8e35
> [6] 
> https://docs.google.com/document/d/16Hp7Sc86MQtL0m8fc2w_TrcKXAuglwRwHmdmwfk00mI/edit#heading=h.b8ogodj5sj0
>
> Yu

[GitHub] [pulsar-client-node] BewareMyPower opened a new pull request, #219: Add null check for consumer in MessageListenerProxy

[GitBox]

BewareMyPower opened a new pull request, #219:
URL: https://github.com/apache/pulsar-client-node/pull/219

   There is a segmentation fault reported by the user.
   
   > So, I recompiled the extension with `node-gyp rebuild --debug` then 
attached a debugger and it crashed because of this
   >
   > ```
   > (gdb) l
   > 60  void MessageListenerProxy(Napi::Env env, Napi::Function 
jsCallback, MessageListenerProxyData *data) {
   > 61Napi::Object msg = Message::NewInstance({}, data->cMessage);
   > 62Consumer *consumer = data->consumer;
   > 63delete data;
   > 64
   > 65jsCallback.Call({msg, consumer->Value()});
   > 66  }
   > 67
   > 68  void MessageListener(pulsar_consumer_t *cConsumer, 
pulsar_message_t *cMessage, void *ctx) {
   > 69ListenerCallback *listenerCallback = (ListenerCallback *)ctx;
   > (gdb)
   > ```
   
   The `consumer` field is assigned from `MessageListenerCallback` and the 
initial value is `nullptr`. This field could only be modified in 
`Consumer::SetListenerCallback`. I didn't look deeper into where it's invoked, 
but I think it's better to add the null check here for safety.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [pulsar-site] Anonymitaet commented on a diff in pull request #111: Recommitted the dropped instruction, CI Testing in your Fork

[GitBox]

Anonymitaet commented on code in PR #111:
URL: https://github.com/apache/pulsar-site/pull/111#discussion_r896440054


##
site2/website-next/src/pages/contributing.md:
##
@@ -156,6 +156,97 @@ Then you can push your local, committed changes to your 
(forked) repository on G
 
 All code should have appropriate unit testing coverage. New code should have 
new tests in the same contribution. Bug fixes should include a regression test 
to prevent the issue from reoccurring.
 
+### CI Testing in your Fork
+
+The following is copied from the
+[thread](https://lists.apache.org/thread/1ofdbd9j1hhj4c0rw3o7vv8y6rbsxrp0) and 
[#15385](https://github.com/apache/pulsar/pull/15385).
+
+
+ Each PR triggers many CI Jobs
+Since we cannot add more resources to Pulsar CI, we need to find other ways
+to reduce the load on Pulsar CI.
+Every developer can help reduce the load on Pulsar CI.
+Please don't open a PR to apache/pulsar when the work is in very initial
+stages.
+Every push to the pull request branch will trigger a lot of concurrent
+builds (about 25).
+By reducing the amount of PR pushes you can reduce the load on Pulsar CI.
+
+ Run CI from Fork
+You don't have to stop developing and using CI for getting feedback. There
+is a better way to get CI feedback for early stages of development. The
+secret is that everyone has their personal CI on GitHub!

Review Comment:
   @maxsxu FYI



##
site2/website-next/src/pages/contributing.md:
##
@@ -156,6 +156,97 @@ Then you can push your local, committed changes to your 
(forked) repository on G
 
 All code should have appropriate unit testing coverage. New code should have 
new tests in the same contribution. Bug fixes should include a regression test 
to prevent the issue from reoccurring.
 
+### CI Testing in your Fork
+
+The following is copied from the
+[thread](https://lists.apache.org/thread/1ofdbd9j1hhj4c0rw3o7vv8y6rbsxrp0) and 
[#15385](https://github.com/apache/pulsar/pull/15385).
+
+
+ Each PR triggers many CI Jobs
+Since we cannot add more resources to Pulsar CI, we need to find other ways

Review Comment:
   @maxsxu FYI



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org