date:20220313

[GitHub] [pulsar-helm-chart] mkoertgen closed pull request #227: Remove breaking labelmap actions, #226, #100

2022-03-13 Thread GitBox



mkoertgen closed pull request #227:
URL: https://github.com/apache/pulsar-helm-chart/pull/227


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [pulsar-helm-chart] rrva opened a new pull request #243: Update pulsarctl to v2.9.2.7

2022-03-13 Thread GitBox



rrva opened a new pull request #243:
URL: https://github.com/apache/pulsar-helm-chart/pull/243


   Failure to run prepare_helm_release.sh on darwin arm64
   
   ### Motivation
   
   Tried to run 
   
   ```bash
   ./scripts/pulsar/prepare_helm_release.sh -n mynamespace -k pulsar
   ```
   
   Fails because scripts gets a 404 when downloading a pulsarctl release for 
v0.4.0 on arm64/darwin
   
   
   ### Modifications
   
   Bumped the pulsarctl versions to latest
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [ANNOUNCE] New Committer: Andrey Yegorov

2022-03-13 Thread Li Li

Congrats Andrey!

-Li Li

> On Mar 11, 2022, at 5:54 PM, PengHui Li  wrote:
> 
> Congrats Andrey!
> 
> -Penghui
> 
> On Wed, Mar 9, 2022 at 9:33 PM Lari Hotari  wrote:
> 
>> Congrats Andrey!
>> 
>> -Lari
>> 
>> On 2022/03/07 19:25:44 Dave Fisher wrote:
>>> The Apache Pulsar Project Management Committee (PMC) has invited Andrey
>> Yegorov
>>> https://github.com/dlg99 to become a committer and we are pleased to
>>> announce that he has accepted.
>>> 
>>> Andrey has made great contributions to Pulsar including Connector and
>> Adaptor work along with updating dependencies for CVEs
>>> Welcome and Congratulations, Li Li!
>>> 
>>> Please join us in congratulating and welcoming Andrey onboard!
>>> 
>>> Best Regards,
>>> Dave Fisher on behalf of the Pulsar PMC
>>

Re: [ANNOUNCE] New Committer: Andrey Yegorov

2022-03-13 Thread Hang Chen

Congratulations Andrey!

Best,
Hang

Li Li  于2022年3月14日周一 08:41写道：
>
> Congrats Andrey!
>
> -Li Li
>
> > On Mar 11, 2022, at 5:54 PM, PengHui Li  wrote:
> >
> > Congrats Andrey!
> >
> > -Penghui
> >
> > On Wed, Mar 9, 2022 at 9:33 PM Lari Hotari  wrote:
> >
> >> Congrats Andrey!
> >>
> >> -Lari
> >>
> >> On 2022/03/07 19:25:44 Dave Fisher wrote:
> >>> The Apache Pulsar Project Management Committee (PMC) has invited Andrey
> >> Yegorov
> >>> https://github.com/dlg99 to become a committer and we are pleased to
> >>> announce that he has accepted.
> >>>
> >>> Andrey has made great contributions to Pulsar including Connector and
> >> Adaptor work along with updating dependencies for CVEs
> >>> Welcome and Congratulations, Li Li!
> >>>
> >>> Please join us in congratulating and welcoming Andrey onboard!
> >>>
> >>> Best Regards,
> >>> Dave Fisher on behalf of the Pulsar PMC
> >>
>

Re: [VOTE] [PIP-144] Making SchemaRegistry implementation configurable

2022-03-13 Thread Hang Chen

+1

Thanks,
Hang

Aparajita Singh  于2022年3月11日周五 10:41写道：
>
> *bump*
>
>
> On Wed, 9 Mar 2022, 18:30 PengHui Li,  wrote:
>
> > +1
> >
> > Penghui
> >
> > On Wed, Mar 9, 2022 at 5:27 PM Enrico Olivelli 
> > wrote:
> >
> > > +1 (binding)
> > >
> > > Enrico
> > >
> > > Il giorno mer 9 mar 2022 alle ore 06:39 Aparajita Singh
> > >  ha scritto:
> > > >
> > > > Hi,
> > > >
> > > > I would like to start a vote for PIP-144:
> > > > https://github.com/apache/pulsar/issues/14395
> > > > Discussion thread:
> > > > https://lists.apache.org/thread/z97cvs8mvhlydv8rbnqk4d0c7mp8rwt3
> > > >
> > > > --
> > > > Thanks,
> > > > Aparajita
> > >
> >

Re: [ANNOUNCE] New Committer: Andrey Yegorov

2022-03-13 Thread Yu

Congrats Andrey!

On Mon, Mar 14, 2022 at 9:15 AM Hang Chen  wrote:

> Congratulations Andrey!
>
> Best,
> Hang
>
> Li Li  于2022年3月14日周一 08:41写道：
> >
> > Congrats Andrey!
> >
> > -Li Li
> >
> > > On Mar 11, 2022, at 5:54 PM, PengHui Li  wrote:
> > >
> > > Congrats Andrey!
> > >
> > > -Penghui
> > >
> > > On Wed, Mar 9, 2022 at 9:33 PM Lari Hotari  wrote:
> > >
> > >> Congrats Andrey!
> > >>
> > >> -Lari
> > >>
> > >> On 2022/03/07 19:25:44 Dave Fisher wrote:
> > >>> The Apache Pulsar Project Management Committee (PMC) has invited
> Andrey
> > >> Yegorov
> > >>> https://github.com/dlg99 to become a committer and we are pleased to
> > >>> announce that he has accepted.
> > >>>
> > >>> Andrey has made great contributions to Pulsar including Connector and
> > >> Adaptor work along with updating dependencies for CVEs
> > >>> Welcome and Congratulations, Li Li!
> > >>>
> > >>> Please join us in congratulating and welcoming Andrey onboard!
> > >>>
> > >>> Best Regards,
> > >>> Dave Fisher on behalf of the Pulsar PMC
> > >>
> >
>

Re: [ANNOUNCE] New Committer: Andrey Yegorov

2022-03-13 Thread ZhangJian He

Congrats Andrey!


Yu  于2022年3月14日周一 09:33写道：

> Congrats Andrey!
>
> On Mon, Mar 14, 2022 at 9:15 AM Hang Chen  wrote:
>
> > Congratulations Andrey!
> >
> > Best,
> > Hang
> >
> > Li Li  于2022年3月14日周一 08:41写道：
> > >
> > > Congrats Andrey!
> > >
> > > -Li Li
> > >
> > > > On Mar 11, 2022, at 5:54 PM, PengHui Li  wrote:
> > > >
> > > > Congrats Andrey!
> > > >
> > > > -Penghui
> > > >
> > > > On Wed, Mar 9, 2022 at 9:33 PM Lari Hotari 
> wrote:
> > > >
> > > >> Congrats Andrey!
> > > >>
> > > >> -Lari
> > > >>
> > > >> On 2022/03/07 19:25:44 Dave Fisher wrote:
> > > >>> The Apache Pulsar Project Management Committee (PMC) has invited
> > Andrey
> > > >> Yegorov
> > > >>> https://github.com/dlg99 to become a committer and we are pleased
> to
> > > >>> announce that he has accepted.
> > > >>>
> > > >>> Andrey has made great contributions to Pulsar including Connector
> and
> > > >> Adaptor work along with updating dependencies for CVEs
> > > >>> Welcome and Congratulations, Li Li!
> > > >>>
> > > >>> Please join us in congratulating and welcoming Andrey onboard!
> > > >>>
> > > >>> Best Regards,
> > > >>> Dave Fisher on behalf of the Pulsar PMC
> > > >>
> > >
> >
>

Re: [VOTE][PIP-146] ManagedCursorInfo compression

2022-03-13 Thread Hang Chen

+1

Thanks,
Hang

Haiting Jiang  于2022年3月10日周四 16:21写道：
>
> +1
>
> Thanks,
> Haiting
>
> On 2022/03/09 09:18:04 Zixuan Liu wrote:
> > Hi Pulsar community,
> >
> > I want to start this PIP - https://github.com/apache/pulsar/issues/14529
> >
> > Thanks,
> > Zixuan
> >

[GitHub] [pulsar-site] urfreespace merged pull request #18: Nav updates and removing duplicative relase notes page

2022-03-13 Thread GitBox



urfreespace merged pull request #18:
URL: https://github.com/apache/pulsar-site/pull/18


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [pulsar-site] urfreespace merged pull request #19: [doc] add new file for Pulsar REST API

2022-03-13 Thread GitBox



urfreespace merged pull request #19:
URL: https://github.com/apache/pulsar-site/pull/19


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: Re: [DISCUSS] Releasing pulsar-client-go 0.8.1

2022-03-13 Thread r...@apache.org

Hello Shubham Sharma:

Thanks for your email, which Lib the Go SDK depends on is caused by this?
The release version of 0.8.1 was just launched recently, which is also
mainly to solve the problem of license compatibility.

-- 
Thanks
Xiaolong Ran

Shubham Sharma (DEVDIV)  于2022年3月9日周三
22:47写道：

> Hi,
>
> We discovered the GPL dependency at Dapr using https://fossa.com/, you
> can also try the same. It can be added in the CI step to prevent
> introducing any such dependencies further.
>
> Thanks,
> Shubham
>
> On 2022/03/08 19:44:29 Michael Marshall wrote:
> > +1 for releasing 0.8.1. Thanks for starting this discussion, Rui.
> >
> > Is there any official ASF protocol for dealing with this situation? I
> > think we should warn users about the unintended GPL dependency
> > included in 0.8.0. Perhaps we can do that by adding a warning to the
> > GitHub Release page for 0.8.0 [0] and sending a note to the users
> > mailing list?
> >
> > Also, does Go have any tooling we can add to our release process to
> > help prevent this kind of error in future releases?
> >
> > Thanks,
> > Michael
> >
> > [0] https://github.com/apache/pulsar-client-go/releases/tag/v0.8.0
> >
> > On Mon, Mar 7, 2022 at 7:59 PM Rui Fu rf...@apache.org rf...@apache.org> wrote:
> > >
> > > Thanks for all your votings, I will start working on the release.
> > >
> > > On 2022/03/07 19:14:00 Sijie Guo wrote:
> > > > +1
> > > >
> > > > On Sun, Mar 6, 2022 at 6:46 PM r...@apache.org
> ra...@gmail.com
> > > > wrote:
> > > >
> > > > > +1
> > > > >
> > > > > --
> > > > > Thanks
> > > > > Xiaolong Ran
> > > > >
> > > > > PengHui Li pe...@apache.org 于2022年3月5日周六
> 18:10写道：
> > > > >
> > > > > > +1
> > > > > >
> > > > > > Penghui
> > > > > >
> > > > > > On Sat, Mar 5, 2022 at 4:58 AM Matteo Merli ma...@gmail.com
> 
> > > > > > wrote:
> > > > > >
> > > > > > > +1 Thanks Rui, we should eliminate the GPL dependency ASAP.
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > --
> > > > > > > Matteo Merli
> > > > > > > ma...@gmail.com
> > > > > > >
> > > > > > > On Thu, Mar 3, 2022 at 2:08 AM Rui Fu rf...@apache.org rf...@apache.org> wrote:
> > > > > > > >
> > > > > > > > Hi everyone,
> > > > > > > >
> > > > > > > > I would like to start a discussion here about starting a new
> release
> > > > > of
> > > > > > > > pulsar-client-go v0.8.1. Recently we have some of
> dependencies
> > > > > updated
> > > > > > > PRs
> > > > > > > > from the community, [1] is bumping `
> github.com/beefsack/go-rate` 
> > > > > http://github.com/beefsack/go-rate
> > > > > > http://github.com/beefsack/go-rate
> > > > > > > http://github.com/beefsack/go-rate to the
> > > > > > > > latest version, which migrates the license from GPL to MIT.
> [2] is
> > > > > > > bumping `
> > > > > > > > github.com/prometheus/client_golang`
> 
> > > > > http://github.com/prometheus/client_golang
> > > > > > http://github.com/prometheus/client_golang
> > > > > > > http://github.com/prometheus/client_golang to address the
> > > > > > > CVE-2022-21698. For
> > > > > > > > more details, please check the links below.
> > > > > > > >
> > > > > > > > As the v0.8.0 was just released weeks ago and the next
> release will
> > > > > > start
> > > > > > > > about 2 month later, I think we should start the release of
> v0.8.1.
> > > > > > > >
> > > > > > > > [1]: https://github.com/apache/pulsar-client-go/pull/735
> > > > > > > > [2]: https://github.com/apache/pulsar-client-go/pull/738
> > > > > > > >
> > > > > > > > --
> > > > > > > >
> > > > > > > > Best Regards,
> > > > > > > >
> > > > > > > > Rui Fu
> > > > > > >
> > > > > >
> > > > >
> > > >
> >
>

Re: [ANNOUNCE] Apache Pulsar Node.js client 1.6.2 released

2022-03-13 Thread r...@apache.org

Thanks E teacher work for this

--
Thanks
Xiaolong Ran

Guangning E  于2022年3月11日周五 11:56写道：

> The Apache Pulsar team is proud to announce Apache Pulsar Node.js client
> version 1.6.2.
>
> Pulsar is a highly scalable, low latency messaging platform running on
> commodity hardware. It provides simple pub-sub semantics over topics,
> guaranteed at-least-once delivery of messages, automatic cursor management
> for
> subscribers, and cross-datacenter replication.
>
> For Pulsar Node.js client release details and downloads, visit:
> https://www.npmjs.com/package/pulsar-client
>
> Release Notes are at:
> https://github.com/apache/pulsar-client-node/releases
>
> We would like to thank the contributors that made the release possible.
>
> Regards,
>
> The Pulsar Team
>

Re: [ANNOUNCE] New Committer: Andrey Yegorov

2022-03-13 Thread r...@apache.org

Congrats Andrey!

ZhangJian He  于2022年3月14日周一 09:51写道：

> Congrats Andrey!
>
>
> Yu  于2022年3月14日周一 09:33写道：
>
> > Congrats Andrey!
> >
> > On Mon, Mar 14, 2022 at 9:15 AM Hang Chen  wrote:
> >
> > > Congratulations Andrey!
> > >
> > > Best,
> > > Hang
> > >
> > > Li Li  于2022年3月14日周一 08:41写道：
> > > >
> > > > Congrats Andrey!
> > > >
> > > > -Li Li
> > > >
> > > > > On Mar 11, 2022, at 5:54 PM, PengHui Li 
> wrote:
> > > > >
> > > > > Congrats Andrey!
> > > > >
> > > > > -Penghui
> > > > >
> > > > > On Wed, Mar 9, 2022 at 9:33 PM Lari Hotari 
> > wrote:
> > > > >
> > > > >> Congrats Andrey!
> > > > >>
> > > > >> -Lari
> > > > >>
> > > > >> On 2022/03/07 19:25:44 Dave Fisher wrote:
> > > > >>> The Apache Pulsar Project Management Committee (PMC) has invited
> > > Andrey
> > > > >> Yegorov
> > > > >>> https://github.com/dlg99 to become a committer and we are
> pleased
> > to
> > > > >>> announce that he has accepted.
> > > > >>>
> > > > >>> Andrey has made great contributions to Pulsar including Connector
> > and
> > > > >> Adaptor work along with updating dependencies for CVEs
> > > > >>> Welcome and Congratulations, Li Li!
> > > > >>>
> > > > >>> Please join us in congratulating and welcoming Andrey onboard!
> > > > >>>
> > > > >>> Best Regards,
> > > > >>> Dave Fisher on behalf of the Pulsar PMC
> > > > >>
> > > >
> > >
> >
>

Re: [VOTE][PIP-146] ManagedCursorInfo compression

2022-03-13 Thread r...@apache.org

+1

--
Thanks
Xiaolong Ran

Hang Chen  于2022年3月14日周一 09:55写道：

> +1
>
> Thanks,
> Hang
>
> Haiting Jiang  于2022年3月10日周四 16:21写道：
> >
> > +1
> >
> > Thanks,
> > Haiting
> >
> > On 2022/03/09 09:18:04 Zixuan Liu wrote:
> > > Hi Pulsar community,
> > >
> > > I want to start this PIP -
> https://github.com/apache/pulsar/issues/14529
> > >
> > > Thanks,
> > > Zixuan
> > >
>

Re: [VOTE] Pulsar Client Go Release 0.8.1 Candidate 1

2022-03-13 Thread r...@apache.org

+1 (non-bindig)

- Verify the checksum
- Run Action CI for all test case

--
Thanks
Xiaolong Ran

Hiroyuki Sakai  于2022年3月11日周五 14:24写道：

> +1(binding)
>
> - Verify the checksum / signature
> - Run producer and consumer
>
> Regards,
> Hiroyuki
>
> 
> From: r...@apache.org 
> Sent: Wednesday, March 9, 2022 16:39
> To: dev@pulsar.apache.org 
> Subject: [VOTE] Pulsar Client Go Release 0.8.1 Candidate 1
>
> Hi everyone,
>
> Please review and vote on the release candidate #1 for the version 0.8.1,
> as follows:
> [ ] +1, Approve the release
> [ ] -1, Do not approve the release (please provide specific comments)
>
> This is the first release candidate for Apache Pulsar Go client, version
> 0.8.1.
>
> It fixes the following issues:
> https://github.com/apache/pulsar-client-go/milestone/11?closed=1
>
> Pulsar Client Go's KEYS file contains PGP keys we used to sign this
> release:
>
> https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev%2Fpulsar%2FKEYS&data=04%7C01%7Chsakai%40yahoo-corp.jp%7Cb1d8d9e6bb7a4f8ddf6408da019ffce0%7Ca208d369cd4e4f87b11998eaf31df2c3%7C1%7C0%7C637824084773383529%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=%2B0wHIBnrXtqDoSx2h%2BkrG7YqaQaGX1f4mZdxqfSkFTo%3D&reserved=0
>
> Please download these packages and review this release candidate:
> - Review release notes
> - Download the source package (verify shasum, and asc) and follow the
> README.md to build and run the pulsar-client-go.
>
> The vote will be open for at least 72 hours. It is adopted by majority
> approval, with at least 3 PMC affirmative votes.
>
> Source file:
>
> https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev%2Fpulsar%2Fpulsar-client-go-0.8.1-candidate-1%2F&data=04%7C01%7Chsakai%40yahoo-corp.jp%7Cb1d8d9e6bb7a4f8ddf6408da019ffce0%7Ca208d369cd4e4f87b11998eaf31df2c3%7C1%7C0%7C637824084773383529%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=tBpR7gVRlH92tF35WEHZDJYHkUEGZ39gjhCSuFYWtPA%3D&reserved=0
>
> The tag to be voted upon:
> v0.8.1
> https://github.com/apache/pulsar-client-go/releases/tag/v0.8.1-candidate-1
>
> SHA-512 checksums:
> 55c397d050e457bf22b4d20a52c8b081c6bce2b875ed93ae6369d9da92ea6434495f7e94853e80cdcc34b238bbc0986a3e875773a56d66b1b1c8c4f5175fa55c
> apache-pulsar-client-go-0.8.1-src.tar.gz
>
> Best,
>
> Rui Fu
>

[GitHub] [pulsar-client-node] massakam commented on pull request #200: convert worker threads to async functions

2022-03-13 Thread GitBox



massakam commented on pull request #200:
URL: 
https://github.com/apache/pulsar-client-node/pull/200#issuecomment-1066336745


   Is this line no longer needed?
   
https://github.com/apache/pulsar-client-node/blob/571aa7a5b9598b317400e5a2bfc797cd9120342d/src/Client.h#L40


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

RE: [EXTERNAL] Re: Re: [DISCUSS] Releasing pulsar-client-go 0.8.1

2022-03-13 Thread Shubham Sharma (DEVDIV)

Hi Xiaolong,

The go SDK had this dependency 
github.com/beefsack/go-rate which had GPL 
license. With this pull request, 
it was changed to MIT. The v0.8.1 version contains my 
PR which upgrades the 
version of beefsack/go-rate that uses MIT, and is compliant.

Thanks,
Shubham

From: r...@apache.org 
Sent: Monday, March 14, 2022 8:47 AM
To: Dev ; Shubham Sharma (DEVDIV) 
; 
canrml2pntoayqvysslvgbigbkgmyausf1v3anmljxdytsmb...@mail.gmail.com
Subject: [EXTERNAL] Re: Re: [DISCUSS] Releasing pulsar-client-go 0.8.1

You don't often get email from 
ranxiaolong...@gmail.com. Learn why this is 
important
Hello Shubham Sharma:

Thanks for your email, which Lib the Go SDK depends on is caused by this? The 
release version of 0.8.1 was just launched recently, which is also mainly to 
solve the problem of license compatibility.

--
Thanks
Xiaolong Ran

Shubham Sharma (DEVDIV) 
mailto:shubh...@microsoft.com.invalid>> 
于2022年3月9日周三 22:47写道：
Hi,

We discovered the GPL dependency at Dapr using 
https://fossa.com/,
 you can also try the same. It can be added in the CI step to prevent 
introducing any such dependencies further.

Thanks,
Shubham

On 2022/03/08 19:44:29 Michael Marshall wrote:
> +1 for releasing 0.8.1. Thanks for starting this discussion, Rui.
>
> Is there any official ASF protocol for dealing with this situation? I
> think we should warn users about the unintended GPL dependency
> included in 0.8.0. Perhaps we can do that by adding a warning to the
> GitHub Release page for 0.8.0 [0] and sending a note to the users
> mailing list?
>
> Also, does Go have any tooling we can add to our release process to
> help prevent this kind of error in future releases?
>
> Thanks,
> Michael
>
> [0] 
> https://github.com/apache/pulsar-client-go/releases/tag/v0.8.0
>
> On Mon, Mar 7, 2022 at 7:59 PM Rui Fu 
> rf...@apache.org>
>  wrote:
> >
> > Thanks for all your votings, I will start working on the release.
> >
> > On 2022/03/07 19:14:00 Sijie Guo wrote:
> > > +1
> > >
> > > On Sun, Mar 6, 2022 at 6:46 PM 
> > > r...@apache.org>
> > >  
> > > ra...@gmail.com>
> > > wrote:
> > >
> > > > +1
> > > >
> > > > --
> > > > Thanks
> > > > Xiaolong Ran
> > > >
> > > > PengHui Li 
> > > > pe...@apache.org>
> > > >  于2022年3月5日周六 18:10写道：
> > > >
> > > > > +1
> > > > >
> > > > > Penghui
> > > > >
> > > > > On Sat, Mar 5, 2022 at 4:58 AM Matteo Merli 
> > > > > ma...@gmail.com>
> > > > > wrote:
> > > > >
> > > > > > +1 Thanks Rui, we should eliminate the GPL dependency ASAP.
> > > > > >
> > > > > >
> > > > > >
> > > > > > --
> > > > > > Matteo Merli
> > > > > > ma...@gmail.com>
> > > > > >
> > > > > > On Thu, Mar 3, 2022 at 2:08 AM Rui Fu 
> > > > > > rf...@apache.org>
> > > > > >  wrote:
> > > > > > >
> > > > > > > Hi everyone,
> > > > > > >
> > > > > > > I would like to start a discussion here about starting a new 
> > > > > > > release
> > > > of
> > > > > > > pulsar-client-go v0.8.1. Recently we have some of dependencies
> > > > updated
> > > > > > PRs
> > > > > > > from the community, [1] is bumping 
> > > > > > > `github.com/beefsack/go-rate`

[GitHub] [pulsar-client-node] massakam commented on a change in pull request #200: convert worker threads to async functions

2022-03-13 Thread GitBox



massakam commented on a change in pull request #200:
URL: https://github.com/apache/pulsar-client-node/pull/200#discussion_r825615311



##
File path: src/Consumer.cc
##
@@ -79,144 +81,131 @@ void MessageListener(pulsar_consumer_t *cConsumer, 
pulsar_message_t *cMessage, v
   listenerCallback->callback.Release();
 }
 
-void Consumer::SetCConsumer(std::shared_ptr cConsumer) { 
this->wrapper = cConsumer; }
-void Consumer::SetListenerCallback(ListenerCallback *listener) {
+void Consumer::SetCConsumer(std::shared_ptr cConsumer) { 
this->cConsumer = cConsumer; }
+void Consumer::SetListenerCallback(MessageListenerCallback *listener) {
   if (listener) {
+// Pass consumer as argument
+listener->consumer = this;
+  }
+
+  if (this->listener == nullptr) {
 // Maintain reference to consumer, so it won't get garbage collected
 // since, when we have a listener, we don't have to maintain reference to 
consumer (in js code)
 this->Ref();

Review comment:
   Why increase the reference count when `listener` is `nullptr`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [pulsar-client-node] massakam commented on a change in pull request #200: convert worker threads to async functions

2022-03-13 Thread GitBox



massakam commented on a change in pull request #200:
URL: https://github.com/apache/pulsar-client-node/pull/200#discussion_r825615679



##
File path: src/Consumer.cc
##
@@ -79,144 +81,131 @@ void MessageListener(pulsar_consumer_t *cConsumer, 
pulsar_message_t *cMessage, v
   listenerCallback->callback.Release();
 }
 
-void Consumer::SetCConsumer(std::shared_ptr cConsumer) { 
this->wrapper = cConsumer; }
-void Consumer::SetListenerCallback(ListenerCallback *listener) {
+void Consumer::SetCConsumer(std::shared_ptr cConsumer) { 
this->cConsumer = cConsumer; }
+void Consumer::SetListenerCallback(MessageListenerCallback *listener) {
   if (listener) {
+// Pass consumer as argument
+listener->consumer = this;
+  }
+
+  if (this->listener == nullptr) {

Review comment:
   ```suggestion
 } else {
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [pulsar-client-node] massakam commented on a change in pull request #200: convert worker threads to async functions

2022-03-13 Thread GitBox



massakam commented on a change in pull request #200:
URL: https://github.com/apache/pulsar-client-node/pull/200#discussion_r825622206



##
File path: src/Consumer.cc
##
@@ -79,144 +81,131 @@ void MessageListener(pulsar_consumer_t *cConsumer, 
pulsar_message_t *cMessage, v
   listenerCallback->callback.Release();
 }
 
-void Consumer::SetCConsumer(std::shared_ptr cConsumer) { 
this->wrapper = cConsumer; }
-void Consumer::SetListenerCallback(ListenerCallback *listener) {
+void Consumer::SetCConsumer(std::shared_ptr cConsumer) { 
this->cConsumer = cConsumer; }
+void Consumer::SetListenerCallback(MessageListenerCallback *listener) {
   if (listener) {
+// Pass consumer as argument
+listener->consumer = this;
+  }
+
+  if (this->listener == nullptr) {
 // Maintain reference to consumer, so it won't get garbage collected
 // since, when we have a listener, we don't have to maintain reference to 
consumer (in js code)
 this->Ref();

Review comment:
   FYI: https://github.com/apache/pulsar-client-node/pull/83




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [VOTE][PIP-146] ManagedCursorInfo compression

2022-03-13 Thread Zike Yang

+1

Thanks,
Zike Yang

On Mon, Mar 14, 2022 at 11:27 AM r...@apache.org
 wrote:
>
> +1
>
> --
> Thanks
> Xiaolong Ran
>
> Hang Chen  于2022年3月14日周一 09:55写道：
>
> > +1
> >
> > Thanks,
> > Hang
> >
> > Haiting Jiang  于2022年3月10日周四 16:21写道：
> > >
> > > +1
> > >
> > > Thanks,
> > > Haiting
> > >
> > > On 2022/03/09 09:18:04 Zixuan Liu wrote:
> > > > Hi Pulsar community,
> > > >
> > > > I want to start this PIP -
> > https://github.com/apache/pulsar/issues/14529
> > > >
> > > > Thanks,
> > > > Zixuan
> > > >
> >



-- 
Zike Yang

[GitHub] [pulsar-client-node] Matt-Esch commented on a change in pull request #200: convert worker threads to async functions

2022-03-13 Thread GitBox



Matt-Esch commented on a change in pull request #200:
URL: https://github.com/apache/pulsar-client-node/pull/200#discussion_r825628138



##
File path: src/Consumer.cc
##
@@ -79,144 +81,131 @@ void MessageListener(pulsar_consumer_t *cConsumer, 
pulsar_message_t *cMessage, v
   listenerCallback->callback.Release();
 }
 
-void Consumer::SetCConsumer(std::shared_ptr cConsumer) { 
this->wrapper = cConsumer; }
-void Consumer::SetListenerCallback(ListenerCallback *listener) {
+void Consumer::SetCConsumer(std::shared_ptr cConsumer) { 
this->cConsumer = cConsumer; }
+void Consumer::SetListenerCallback(MessageListenerCallback *listener) {
   if (listener) {
+// Pass consumer as argument
+listener->consumer = this;
+  }
+
+  if (this->listener == nullptr) {
 // Maintain reference to consumer, so it won't get garbage collected
 // since, when we have a listener, we don't have to maintain reference to 
consumer (in js code)
 this->Ref();

Review comment:
   I think this was purely to make sure that the ref count is balanced. So 
if we set the listener 10 times, we don't Ref the Consumer more than once, as 
there is only one corresponding Unref in `Consumer::Cleanup()`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [pulsar-helm-chart] mkoertgen closed pull request #227: Remove breaking labelmap actions, #226, #100

[GitHub] [pulsar-helm-chart] rrva opened a new pull request #243: Update pulsarctl to v2.9.2.7

Re: [ANNOUNCE] New Committer: Andrey Yegorov

Re: [ANNOUNCE] New Committer: Andrey Yegorov

Re: [VOTE] [PIP-144] Making SchemaRegistry implementation configurable

Re: [ANNOUNCE] New Committer: Andrey Yegorov

Re: [ANNOUNCE] New Committer: Andrey Yegorov

Re: [VOTE][PIP-146] ManagedCursorInfo compression

[GitHub] [pulsar-site] urfreespace merged pull request #18: Nav updates and removing duplicative relase notes page

[GitHub] [pulsar-site] urfreespace merged pull request #19: [doc] add new file for Pulsar REST API

Re: Re: [DISCUSS] Releasing pulsar-client-go 0.8.1

Re: [ANNOUNCE] Apache Pulsar Node.js client 1.6.2 released

Re: [ANNOUNCE] New Committer: Andrey Yegorov

Re: [VOTE][PIP-146] ManagedCursorInfo compression

Re: [VOTE] Pulsar Client Go Release 0.8.1 Candidate 1

[GitHub] [pulsar-client-node] massakam commented on pull request #200: convert worker threads to async functions

RE: [EXTERNAL] Re: Re: [DISCUSS] Releasing pulsar-client-go 0.8.1

[GitHub] [pulsar-client-node] massakam commented on a change in pull request #200: convert worker threads to async functions

[GitHub] [pulsar-client-node] massakam commented on a change in pull request #200: convert worker threads to async functions

[GitHub] [pulsar-client-node] massakam commented on a change in pull request #200: convert worker threads to async functions

Re: [VOTE][PIP-146] ManagedCursorInfo compression

[GitHub] [pulsar-client-node] Matt-Esch commented on a change in pull request #200: convert worker threads to async functions

22 matches

Site Navigation

Mail list logo

Footer information