[GitHub] [pulsar-helm-chart] lhotari opened a new pull request #218: Add timeouts for cluster metadata initialization and for init containers
lhotari opened a new pull request #218: URL: https://github.com/apache/pulsar-helm-chart/pull/218 ### Motivation - Sometimes the Pulsar deployment doesn't complete, and the broker services don't become available. When investigating the problem, it seems that cluster metadata initialization might get stuck and that blocks starting the pods. - This problem seems to happen with Pulsar 2.8.x+ and Zookeeper, when TLS is enabled for Zookeeper. #190 is the PR to switch to use Pulsar 2.8.x . ### Modifications - Add timeouts for waiting for zk and bk to become available. - timeouts will help failures recover eventually - Add timeout to cluster metadata initialization jobs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-helm-chart] lhotari commented on pull request #190: Bump to Pulsar 2.8.2
lhotari commented on pull request #190: URL: https://github.com/apache/pulsar-helm-chart/pull/190#issuecomment-1022967091 I finally got some logs from CI. It looks like the metadata initialization job is stuck. I'm adding timeouts in #218 to see if that could help mitigate the issue. I'm aware of a Zookeeper fix in the works for https://issues.apache.org/jira/browse/ZOOKEEPER-3988 . However, I haven't been able to find signs of ZOOKEEPER-3988 issue in the logs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-helm-chart] lhotari edited a comment on pull request #190: Bump to Pulsar 2.8.2
lhotari edited a comment on pull request #190: URL: https://github.com/apache/pulsar-helm-chart/pull/190#issuecomment-1022967091 I finally got some logs from CI. It looks like the metadata initialization job is stuck. I'm adding timeouts in #218 to see if that could help mitigate the issue. I'm aware of a Zookeeper fix in the works for https://issues.apache.org/jira/browse/ZOOKEEPER-3988 . I haven't been able to find signs of ZOOKEEPER-3988 issue in the logs that were collected from the failing CI jobs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-helm-chart] lhotari edited a comment on pull request #190: Bump to Pulsar 2.8.2
lhotari edited a comment on pull request #190: URL: https://github.com/apache/pulsar-helm-chart/pull/190#issuecomment-1022967091 I finally got some logs from CI. It looks like the metadata initialization job is stuck. I'm adding timeouts in #218 to see if that could help mitigate the issue. I'm aware of a Zookeeper fix in the works for https://issues.apache.org/jira/browse/ZOOKEEPER-3988 . I haven't been able to find signs of ZOOKEEPER-3988 issue in the logs that were collected from the failing CI jobs. I uploaded the relevant log files to a gist, https://gist.github.com/lhotari/d1bf977cfbd5f1fdbd942df9fef3c952 @eolivelli Could you check if the logs match ZOOKEEPER-3988? To me it looks like another issue. I found https://issues.apache.org/jira/browse/ZOOKEEPER-3466 , https://issues.apache.org/jira/browse/ZOOKEEPER-3828 and https://issues.apache.org/jira/browse/ZOOKEEPER-3706 . I wonder if ZOOKEEPER-3706 / https://github.com/apache/zookeeper/pull/1235 . @eolivelli Would it be possible to get this fix to the next Zookeeper release that we could use for Pulsar 2.8.x and above? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-helm-chart] lhotari edited a comment on pull request #190: Bump to Pulsar 2.8.2
lhotari edited a comment on pull request #190: URL: https://github.com/apache/pulsar-helm-chart/pull/190#issuecomment-1022967091 I finally got some logs from CI. It looks like the metadata initialization job is stuck. I'm adding timeouts in #218 to see if that could help mitigate the issue. I'm aware of a Zookeeper fix in the works for https://issues.apache.org/jira/browse/ZOOKEEPER-3988 . I haven't been able to find signs of ZOOKEEPER-3988 issue in the logs that were collected from the failing CI jobs. I uploaded the relevant log files to a gist, https://gist.github.com/lhotari/d1bf977cfbd5f1fdbd942df9fef3c952 @eolivelli Could you check if the logs match ZOOKEEPER-3988? To me it looks like another issue. I found https://issues.apache.org/jira/browse/ZOOKEEPER-3466 , https://issues.apache.org/jira/browse/ZOOKEEPER-3828 and https://issues.apache.org/jira/browse/ZOOKEEPER-3706 . I wonder if it is ZOOKEEPER-3706, fixed by https://github.com/apache/zookeeper/pull/1235 . @eolivelli Would it be possible to get this fix to the next Zookeeper release that we could use for Pulsar 2.8.x and above? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[DISCUSS] PIP-138: Use NarClassLoaderManager to manage all NarClassLoader.
Hello everyone, I want to start a discussion about PIP-138: Use NarClassLoaderManager to manage all NarClassLoader. This is the PIP document https://github.com/apache/pulsar/issues/13979 Please check it out and feel free to share your thoughts. Best, Mattison
Re: [VOTE] PIP-124: Create init subscription before sending message to DLQ
Hi all, Since there are no objections on this PIP and this vote has been staying open for 48 hours. Close the vote with 3 (+1) bindings and 2 (+1) non-bindings. Thanks for your participation. Thanks, Zike On Thu, Jan 27, 2022 at 10:09 AM Zike Yang wrote: > > Hi Michael, > > Sorry, I forgot about it. Sorry for my mistake. > Thanks for your correction. I will stay this vote open. > > Thanks, > Zike > > > > > > On Thu, Jan 27, 2022 at 12:31 AM Michael Marshall > wrote: > > > > Hi Zike, > > > > Based on our current voting rules, I believe we need to leave the vote > > open for at least 17 more hours. > > > > There has been discussion on the dev list about changing this rule, > > but I don't believe we have reached any conclusions yet. > > > > Thanks, > > Michael > > > > On Wed, Jan 26, 2022 at 6:04 AM Zike Yang > > wrote: > > > > > > Thanks for your participation and your great efforts to move this forward! > > > Close the vote with 3 (+1) bindings and 2 (+1) non-bindings. > > > > > > Thanks, > > > Zike > > > > > > On Wed, Jan 26, 2022 at 3:54 PM PengHui Li wrote: > > > > > > > > +1 (binding) > > > > > > > > Regards, > > > > Penghui > > > > > > > > On Wed, Jan 26, 2022 at 12:17 PM Michael Marshall > > > > wrote: > > > > > > > > > +1 (non binding) - this proposal looks great! Thank you for a good > > > > > discussion of this feature! > > > > > > > > > > Thanks, > > > > > Michael > > > > > > > > > > On Tue, Jan 25, 2022 at 8:20 PM Hang Chen wrote: > > > > > > > > > > > > +1 (binding) > > > > > > > > > > > > Thanks, > > > > > > Hang > > > > > > > > > > > > Jia Zhai 于2022年1月26日周三 10:17写道： > > > > > > > > > > > > > > +1 > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Tue, Jan 25, 2022 at 8:28 PM mattison chao > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > +1 (non-binding) > > > > > > > > > > > > > > > > > On Jan 25, 2022, at 5:34 PM, Zike Yang > > > > .INVALID> > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > Hi Pulsar Community, > > > > > > > > > > > > > > > > > > This is the voting thread for PIP-124. It will stay open for > > > > > > > > > at > > > > > least > > > > > > > > > 48 hours. Pasted below for quoting convenience. > > > > > > > > > > > > > > > > > > Here is the issue for this PIP: > > > > > > > > https://github.com/apache/pulsar/issues/13408 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ## Motivation > > > > > > > > > > > > > > > > > > If we enable the DLQ when consuming messages. For some > > > > > > > > > messages > > > > > that > > > > > > > > > can't be processed successfully, the messages will be moved > > > > > > > > > to the > > > > > > > > > DLQ, but if we do not specify the data retention for the > > > > > > > > > namespace > > > > > or > > > > > > > > > create a subscription for the DLQ to retain the data, the > > > > > > > > > data of > > > > > the > > > > > > > > > DLQ will be removed automatically. Therefore, we need to > > > > > > > > > create the > > > > > > > > > initial subscription before sending messages to the DLQ. > > > > > > > > > > > > > > > > > > ## Goal > > > > > > > > > > > > > > > > > > Users can set the initial subscription name in the > > > > > DeadLetterPolicy. > > > > > > > > > The consumer will create the initial subscription before > > > > > > > > > sending > > > > > > > > > messages to the DLQ. At this point, subsequent messages > > > > > > > > > produced to > > > > > > > > > the DLQ are not automatically deleted unexpectedly. If > > > > > > > > > `allowAutoSubscriptionCreation` in `broker.conf` is false, the > > > > > initial > > > > > > > > > subscription won't be created automatically. Otherwise, it > > > > > > > > > will > > > > > > > > > confuse the user. Users can explicitly create that > > > > > > > > > subscription to > > > > > > > > > handle this case. > > > > > > > > > > > > > > > > > > This PIP needs to be compatible with the previous behavior. > > > > > > > > > The > > > > > > > > > initial subscription name in the DeadLetterPolicy is > > > > > > > > > optional. The > > > > > > > > > default behavior is not to create the initial subscription > > > > > > > > > which is > > > > > > > > > consistent with the original behavior. > > > > > > > > > > > > > > > > > > ## API Changes > > > > > > > > > > > > > > > > > > * Add `initSubscriptionName` to the `DeadLetterPolicy` > > > > > > > > > > > > > > > > > > ```java > > > > > > > > > /** > > > > > > > > > * Name of the initial subscription name of the dead letter > > > > > > > > > topic. > > > > > > > > > * If this field is not set, the initial subscription will not > > > > > > > > > be > > > > > created. > > > > > > > > > */ > > > > > > > > > private String initSubscriptionName; > > > > > > > > > ``` > > > > > > > > > > > > > > > > > > * Add a new field to the `CommandProducer`. The broker will > > > > > > > > > use > > > > > this > > > > > > > > > field to create the initial subscription. > > > > > > > > > > > > > >
Re: [VOTE] PIP-119: Enable consistent hashing by default on KeyShared dispatcher
HEADS up I have found this problem: https://github.com/apache/pulsar/issues/10750 We should fix it before changing the default value Enrico Il giorno gio 23 dic 2021 alle ore 06:37 Michael Marshall ha scritto: > > +1 > > - Michael > > On Wed, Dec 22, 2021 at 6:17 PM Sijie Guo wrote: > > > > +1 > > > > On Tue, Dec 21, 2021 at 3:23 PM Matteo Merli wrote: > > > > > This is the voting thread for PIP-119. It will stay open for at least 48h. > > > > > > https://github.com/apache/pulsar/issues/13305 > > > > > > --- > > > > > > ## Motivation > > > > > > The consistent hashing implementation to uniformly assign keys to > > > consumers > > > in the context of a KeyShared subscription, was introduced in > > > https://github.com/apache/pulsar/pull/6791, which was released in Pulsar > > > 2.6.0. > > > > > > While consistent hashing can use slightly more memory in certain cases, it > > > is > > > more suitable as a general default implementation, as it leads to a fairer > > > distribution of keys across consumers, and avoiding corner cases that > > > depend > > > on the sequence of addition/removal of consumers. > > > > > > ## Proposed changes > > > > > > In 2.10 release, for the setting: > > > > > > ```properties > > > # On KeyShared subscriptions, with default AUTO_SPLIT mode, use > > > splitting ranges or > > > # consistent hashing to reassign keys to new consumers > > > subscriptionKeySharedUseConsistentHashing=false > > > ``` > > > > > > Change its default value to `true`. > > > > > > The `AUTO_SPLIT` mode will not be removed nor deprecated. Users will still > > > be > > > able to use the old implementation. > > > > > > -- > > > Matteo Merli > > > > > >
[GitHub] [pulsar-helm-chart] pellicano commented on pull request #205: Tiered Storage config
pellicano commented on pull request #205: URL: https://github.com/apache/pulsar-helm-chart/pull/205#issuecomment-1023289512 @sijie if you may take a look, I appreciate. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Improve quality and efficiency of image creation
Hi Pulsarers, As you may notice, the images in Pulsar documentation are in inconsistent styles, which affect user experience. This issue may be caused by: 1) Pulsar community does not have design style guides. 2) Original images are not shared, so that contributors can not be able to re-use the exiting images, and then they create their own. Solving this issue brings many benefits, such as: - Build a trusting relationship with Pulsar users. - Save image contributors' efforts and time in the design process. - Help design work communicates clearly and looks professional. And for 2), are there any good solutions? Hosting original images on GitHub repo may not be a pretty good idea since: - Collaborating synchronously online is impossible. You need to download the original file, re-use/edit it, and upload it back. Few contributors would like to do it. - Occupy much space. Can we choose a professional tool to create/edit/host images and collaborate online synchronously? Just my two cents: for example, can ASF give the community an email address and register an account on LucidChart? PMC can manage the LucidChart Pulsar account and all image assets and grant different access to contributors. So that contributors can re-use/collaborate in an efficient manner. Please correct me if my understanding is incorrect, I'd love your feedback, thanks!
[GitHub] [pulsar-helm-chart] csthomas1 opened a new pull request #219: Feature/pulsar manager v0.2.0 with jwt setup admin account creation
csthomas1 opened a new pull request #219: URL: https://github.com/apache/pulsar-helm-chart/pull/219 Fixes #133 #108 #86 #31 ### Motivation The docker image for Pulsar Manager v0.2.0 includes support for JWT-based configurations, so long as the appropriate environment variables are specified: - JWT_TOKEN - PRIVATE_KEY/PUBLIC_KEY -or- SECRET_KEY The k8s secrets that can populate each of the above environment variables are created by the 'prepare_helm_release.sh' script when it is run prior to installation of the helm chart. Unfortunately, the helm chart doesn't current provide a way to directly expose these secrets to the Pulsar Manager deployment. Instead, it requires that these values be separately set in the "configData" map of the "pulsar_manager" section, which creates the opportunity for them to go out of sync. Further, it exposes in clear text potentially sensitive values (the superuser token and the key material) alongside in the ConfigMap of other environment settings. Pulsar Manager v0.2.0 has also introduced a user management capability that is enabled by default, and requires that the initial admin/superuser account be created via web service call (see https://github.com/apache/pulsar-manager/blob/master/README.md). Finally, the current helm chart mistakenly conflates the Pulsar Manager admin user's credentials with those of the Postgres user account used to establish a connection to the Pulsar Manager's internal database -- it mounts the admin user's credentials secret to the "USERNAME" and "PASSWORD" environment variables, despite the fact that these control only the datasource connection parameters as described above. Further, with the current secret mounting approach, changing the admin credentials actually breaks the Pulsar Manager deployment because the pulsar database credentials are hardcoded in the postgres db initialization script. The changes included in this PR do the following: 1. Enable mounting of the appropriate JWT and key secrets to the appropriate environment variables when JWT authentication is enabled; 2. Automatically (when requested) creates the initial admin account via web service call on container startup. This initial account will be configured with the credentials contained in the manager's admin secret. 3. The manager's admin secret will no longer be used to set the USERNAME and PASSWORD environment variables for reasons described above; hence, changing the admin secret will now correctly only affect the credentials recognized as the default login to the Pulsar Manager and will no longer break the connection to Pulsar Manager's internal database. ### Modifications 1. In charts/pulsar/values.yaml: - Added auth.superUsers type "manager," which defaults to blank. Setting a value here determines the JWT secret (generated by the prepare_helm_release.sh script) that will be used by the Pulsar Manager to communicate with the Pulsar brokers when JWT authentication is enabled. - Added pulsar_manager.autoCreateAdminAccount, which defaults to true. When this value is set to true, a sidecar will be added to the Pulsar Manager pod that will create the admin's account from the configured credentials when the container launches. - Added 'USERNAME' and 'PASSWORD' with values of pulsar/pulsar to pulsar_manager.configData, since these values currently must agree with the hardcoded values in the database initialization script 2. In charts/pulsar/templates/pulsar-manager-deployment.yaml: - REMOVED the mounts of the pulsar admin secret to the USERNAME and PASSWORD environment variables. - ADDED env secretKeyRefs for JWT_TOKEN to the "manager" superUser token when jwt authentication is enabled - ADDED env file path value for SECRET_KEY when jwt authentication is enabled and jwt.usingSecretKey is true - ADDED env file path value for PRIVATE_KEY and PUBLIC_KEY when jwt authentication is enabled and jwt.usingSecretKey is false - ADDED volume mount for pulsar-manager-keys when jwt authentication is enabled - ADDED volume for the symmetric token signing key when jwt authentication is enabled and jwt.usingSecretKey is true - ADDED volume for the asymmetric token signing key when jwt authentication is enabled and jwt.usingSecretKey is false - ADDED sidecar container to initialize admin user account when pulsar_manager.autoCreateAdminAccount is true. Upon launch, the sidecar will attempt to curl the pulsar-manager's main page every 3 seconds until it receives a successful status. At that point, it will perform the procedure described in the pulsar manager README.md (get a CSRF token, then make another service call to create the admin account). It will then sleep forever. ### Verifying this change - [ ] Make sure that the change passes the CI checks. -- This is an automated message from the Apache Git Service. To res
[GitHub] [pulsar-helm-chart] csthomas1 commented on pull request #219: Feature/pulsar manager v0.2.0 with jwt setup admin account creation
csthomas1 commented on pull request #219: URL: https://github.com/apache/pulsar-helm-chart/pull/219#issuecomment-1023671164 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
PulsarIO connector for Apache Beam - looking for feedback on PR
Hi Everyone, I was just informed that the first version of the Apache Beam PulsarIO connector has been completed, and the contributor is looking for feedback. This is a good opportunity for any feedback from the Pulsar community prior to it getting merged into Beam master. Apache Beam is used for Google Dataflow, as well as other tools, so having a stable Pulsar connector for Apache Beam will be very beneficial to the community. https://github.com/apache/beam/pull/16634 Devin G. Bost
[GitHub] [pulsar-helm-chart] csthomas1 removed a comment on pull request #219: Feature/pulsar manager v0.2.0 with jwt setup admin account creation
csthomas1 removed a comment on pull request #219: URL: https://github.com/apache/pulsar-helm-chart/pull/219#issuecomment-1023671164 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-helm-chart] csthomas1 commented on pull request #219: Feature/pulsar manager v0.2.0 with jwt setup admin account creation
csthomas1 commented on pull request #219: URL: https://github.com/apache/pulsar-helm-chart/pull/219#issuecomment-1023729553 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-client-node] zhaoyajun2009 commented on issue #188: When installing the Pulsar Node.js client, the operation steps need to be optimized
zhaoyajun2009 commented on issue #188: URL: https://github.com/apache/pulsar-client-node/issues/188#issuecomment-1023876000 fix it as follow: https://github.com/apache/pulsar/pull/13999 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
