Re: [VOTE] Pulsar Release 2.7.3 Candidate 2

2021-07-29 Thread 丛搏
Hi,
I test again on my mac.
environment: macOS.
command: mvn clean install -am -pl pulsar-broker
Most of the tests fail because the test has not been modified, only
`org.apache.pulsar.broker.admin.TopicPoliciesTest.testRestart` run fail
because ` https://github.com/apache/pulsar/pull/11294`
 don't have cherry-pick to
branch-2.7. I suggest moving it to 2.7.4 to fix. Because it is not a newly
introduced problem, but an existing problem.

Thanks!
Bo


Enrico Olivelli  于2021年7月28日周三 下午2:03写道:

> Il giorno mer 28 lug 2021 alle ore 06:36 丛搏  ha
> scritto:
>
> > Hi
> > Is it a blocker of 2.7.3 release? If not, we can release first, and then
> > solve this problem later.
> >
>
> If tests are not passing then maybe something is broken.
> I am not talking about a "flaky test" but something that is blocking the
> machine.
>
> for instance recently (a couple of weeks ago), while running the tests on
> branch-2.7 I found that delayed delivery was totally broken
> https://github.com/apache/pulsar/pull/11374
>
> unfortunately we are cherry-picking commits to branch-2.7 without
> validating the patch against CI so every cherry-pick, especially the ones
> which do not apply cleanly
> may break the stability of the system
>
> I suggest to investigate the problem, and hopefully qualify it as "not a
> problem", before closing the VOTE
>
> Pulsar is becoming more and more popular, we must not release something
> that we are not sure that cannot be validated.
> Unfortunately on 2.7 there are still many flaky tests, but AFAIK the test
> suite used to eventually pass
>
> Enrico
>
>
> >
> > Thanks,
> > Bo
> >
> > Enrico Olivelli  于2021年7月26日周一 下午10:55写道:
> >
> > > Hi,
> > > are you able to run the tests from the source packages ?
> > > If I run the pulsar-broker test at a certain point (I am still not able
> > to
> > > see where) my machines starts to use 100% CPU and it is blocked and I
> > need
> > > to reboot
> > >
> > >
> > > Enrico
> > >
> > > Il giorno lun 26 lug 2021 alle ore 09:37 Nozomi Kurihara <
> > > nkuri...@apache.org> ha scritto:
> > >
> > > > +1 (binding)
> > > >
> > > > - check signatures/checksums
> > > > - compile the source
> > > > - standalone/producer/consumer worked
> > > > - function/cassandra-connector worked
> > > >
> > > > Best Regards,
> > > > Nozomi
> > > >
> > > > 2021年7月26日(月) 16:07 Masahiro Sakamoto :
> > > >
> > > > > +1 (binding)
> > > > >
> > > > > - Checked checksums and signatures
> > > > > - Compiled the source
> > > > > - Ran the standalone server
> > > > > - Confirmed that producer and consumer work properly
> > > > > - Confirmed that the sample function works properly
> > > > >
> > > > > Regards,
> > > > >
> > > > > Masahiro Sakamoto
> > > > > Yahoo Japan Corp.
> > > > > E-mail: massa...@yahoo-corp.jp
> > > > >
> > > > > -Original Message-
> > > > > From: 丛搏 
> > > > > Sent: Wednesday, July 21, 2021 9:00 PM
> > > > > To: dev@pulsar.apache.org
> > > > > Subject: [VOTE] Pulsar Release 2.7.3 Candidate 2
> > > > >
> > > > > This is the second release candidate for Apache Pulsar, version
> > 2.7.3.
> > > > >
> > > > > It fixes the following issues:
> > > > >
> > > > >
> > > >
> > >
> >
> https://github.com/apache/pulsar/pulls?q=is%3Apr+is%3Aopen+label%3Arelease%2F2.7.3+is%3Apr+
> > > > >
> > > > > *** Please download, test and vote on this release. This vote will
> > stay
> > > > > open
> > > > > for at least 72 hours ***
> > > > >
> > > > > Note that we are voting upon the source (tag), binaries are
> provided
> > > for
> > > > > convenience.
> > > > >
> > > > > Source and binary files:
> > > > >
> > >
> https://dist.apache.org/repos/dist/dev/pulsar/pulsar-2.7.3-candidate-2/
> > > > >
> > > > > SHA-512 checksums:
> > > > >
> > > > >
> > > > >
> > > >
> > >
> >
> 323e896bebb2981cc99178e9584273908d5fd9427fa8e907027e8b7c59946cb04a3821af0e70b1a29b0ba166120c493a432fd4d5920e71ccef11e4095f5f30c6
> > > > >  apache-pulsar-2.7.3-bin.tar.gz
> > > > >
> > > > >
> > > > >
> > > >
> > >
> >
> 4eb2ff4a058fc5f0c0f1352aff926e6125c833c509901a16f93a118540a79a1fc575225b224f1f8ab7ff77c5aeea2a20fe8fedea1717ea249c27c9bbfbb4aae8
> > > > >  apache-pulsar-2.7.3-src.tar.gz
> > > > >
> > > > > Maven staging repo:
> > > > >
> > >
> https://repository.apache.org/content/repositories/orgapachepulsar-1093/
> > > > >
> > > > > The tag to be voted upon:
> > > > > v2.7.3-candidate-2 (d6c2667ea05339efd8aabf56fe667835b4fe76e9)
> > > > > https://github.com/apache/pulsar/releases/tag/v2.7.3-candidate-2
> > > > >
> > > > > Pulsar's KEYS file containing PGP keys we use to sign the release:
> > > > > https://dist.apache.org/repos/dist/dev/pulsar/KEYS
> > > > >
> > > > > Please download the the source package, and follow the README to
> > build
> > > > > and run the Pulsar standalone service.
> > > > >
> > > >
> > >
> >
>


[GitHub] [pulsar-adapters] afedulov opened a new issue #27: PulsarKafkaProducer/Consumer do not set required configuration properties.

2021-07-29 Thread GitBox


afedulov opened a new issue #27:
URL: https://github.com/apache/pulsar-adapters/issues/27


   **Describe the bug**
   ```
new PulsarKafkaProducer<>(
   props, new StringSerializer(), new StringSerializer<>());
   ```
   fails with
   ```
   org.apache.kafka.common.config.ConfigException: Missing required 
configuration "key.serializer" which has no default value.
   ```
   Similarly, PulsarKafkaConsumer fails with missing 
`key.deserializer/value.serializer`.
   
   **To Reproduce**
   ```
   import java.util.Properties;
   import org.apache.kafka.clients.producer.PulsarKafkaProducer;
   import org.apache.kafka.common.serialization.StringSerializer;
   
   public class ReproducePulsarBug {
   
 public static void main(String[] args) {
   Properties props = new Properties();
   props.put("bootstrap.servers", "pulsar://localhost:49377");
   //  Only works if below two lines are commented in:
   //props.put("key.serializer", StringSerializer.class.getName());
   //props.put("value.serializer", StringSerializer.class.getName());
   new PulsarKafkaProducer<>(
   props, new StringSerializer(), new StringSerializer());
 }
   }
   ```
   
   **Additional context**
   ```
   
   org.apache.pulsar
   pulsar-client-kafka-original
   2.8.0
   
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




Pulsar Summit Europe: Save the Date

2021-07-29 Thread Jinfeng Huang
Dear Pulsar and BookKeeper community members,

We're excited to announce the first-ever Pulsar Virtual Summit Europe on
October 6th! Save the date and hear from top companies and Pulsar thought
leaders at this one day virtual event.

The Pulsar Summit North America and Asia events featured 80+ speakers and
1500+ Pulsar community members. Now, we're bringing the Pulsar Summit to
Europe for more engaging and insightful sessions. Speakers and schedules
are coming soon, save your spot today.



Event Details


   - Date: October 6th, 2021
   - Time: 9:30 AM - 2:00 PM GMT

Sign up now  and
contact us regarding group discounts.

More summit details to come, see you soon!

Best Regards,
Jennifer


Re: [VOTE] Pulsar Release 2.7.3 Candidate 2

2021-07-29 Thread Enrico Olivelli
I am performing again my tests, sorry for so late reply.

If you see that some tests are consistently failing and we already have a
fix,  in my humble opinion it is better to apply the fix and roll a new
release.

There is no hurry to approve a release.

In Apache we are primarily releasing the sources and the binaries are
provided only 'for convenience'.

So users are expected to be able to run the tests and see them passing.

I will give my final feedback tomorrow

Enrico

Il Gio 29 Lug 2021, 17:14 丛搏  ha scritto:

> Hi,
> I test again on my mac.
> environment: macOS.
> command: mvn clean install -am -pl pulsar-broker
> Most of the tests fail because the test has not been modified, only
> `org.apache.pulsar.broker.admin.TopicPoliciesTest.testRestart` run fail
> because ` https://github.com/apache/pulsar/pull/11294`
> 
>  don't have cherry-pick to
> branch-2.7. I suggest moving it to 2.7.4 to fix. Because it is not a newly
> introduced problem, but an existing problem.
>
> Thanks!
> Bo
>
>
> Enrico Olivelli  于2021年7月28日周三 下午2:03写道:
>
> > Il giorno mer 28 lug 2021 alle ore 06:36 丛搏  ha
> > scritto:
> >
> > > Hi
> > > Is it a blocker of 2.7.3 release? If not, we can release first, and
> then
> > > solve this problem later.
> > >
> >
> > If tests are not passing then maybe something is broken.
> > I am not talking about a "flaky test" but something that is blocking the
> > machine.
> >
> > for instance recently (a couple of weeks ago), while running the tests on
> > branch-2.7 I found that delayed delivery was totally broken
> > https://github.com/apache/pulsar/pull/11374
> >
> > unfortunately we are cherry-picking commits to branch-2.7 without
> > validating the patch against CI so every cherry-pick, especially the ones
> > which do not apply cleanly
> > may break the stability of the system
> >
> > I suggest to investigate the problem, and hopefully qualify it as "not a
> > problem", before closing the VOTE
> >
> > Pulsar is becoming more and more popular, we must not release something
> > that we are not sure that cannot be validated.
> > Unfortunately on 2.7 there are still many flaky tests, but AFAIK the test
> > suite used to eventually pass
> >
> > Enrico
> >
> >
> > >
> > > Thanks,
> > > Bo
> > >
> > > Enrico Olivelli  于2021年7月26日周一 下午10:55写道:
> > >
> > > > Hi,
> > > > are you able to run the tests from the source packages ?
> > > > If I run the pulsar-broker test at a certain point (I am still not
> able
> > > to
> > > > see where) my machines starts to use 100% CPU and it is blocked and I
> > > need
> > > > to reboot
> > > >
> > > >
> > > > Enrico
> > > >
> > > > Il giorno lun 26 lug 2021 alle ore 09:37 Nozomi Kurihara <
> > > > nkuri...@apache.org> ha scritto:
> > > >
> > > > > +1 (binding)
> > > > >
> > > > > - check signatures/checksums
> > > > > - compile the source
> > > > > - standalone/producer/consumer worked
> > > > > - function/cassandra-connector worked
> > > > >
> > > > > Best Regards,
> > > > > Nozomi
> > > > >
> > > > > 2021年7月26日(月) 16:07 Masahiro Sakamoto :
> > > > >
> > > > > > +1 (binding)
> > > > > >
> > > > > > - Checked checksums and signatures
> > > > > > - Compiled the source
> > > > > > - Ran the standalone server
> > > > > > - Confirmed that producer and consumer work properly
> > > > > > - Confirmed that the sample function works properly
> > > > > >
> > > > > > Regards,
> > > > > >
> > > > > > Masahiro Sakamoto
> > > > > > Yahoo Japan Corp.
> > > > > > E-mail: massa...@yahoo-corp.jp
> > > > > >
> > > > > > -Original Message-
> > > > > > From: 丛搏 
> > > > > > Sent: Wednesday, July 21, 2021 9:00 PM
> > > > > > To: dev@pulsar.apache.org
> > > > > > Subject: [VOTE] Pulsar Release 2.7.3 Candidate 2
> > > > > >
> > > > > > This is the second release candidate for Apache Pulsar, version
> > > 2.7.3.
> > > > > >
> > > > > > It fixes the following issues:
> > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://github.com/apache/pulsar/pulls?q=is%3Apr+is%3Aopen+label%3Arelease%2F2.7.3+is%3Apr+
> > > > > >
> > > > > > *** Please download, test and vote on this release. This vote
> will
> > > stay
> > > > > > open
> > > > > > for at least 72 hours ***
> > > > > >
> > > > > > Note that we are voting upon the source (tag), binaries are
> > provided
> > > > for
> > > > > > convenience.
> > > > > >
> > > > > > Source and binary files:
> > > > > >
> > > >
> > https://dist.apache.org/repos/dist/dev/pulsar/pulsar-2.7.3-candidate-2/
> > > > > >
> > > > > > SHA-512 checksums:
> > > > > >
> > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> 323e896bebb2981cc99178e9584273908d5fd9427fa8e907027e8b7c59946cb04a3821af0e70b1a29b0ba166120c493a432fd4d5920e71ccef11e4095f5f30c6
> > > > > >  apache-pulsar-2.7.3-bin.tar.gz
> > > > > >
> > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> 4eb2ff4a058fc5f0c0f1352aff926e6125c833c509901a16f93a118540a79a1fc575225b224f1f8ab7ff77c5aeea2a20fe8fedea1717ea249c27c

[Discuss] Optimize the performance of creating Topic

2021-07-29 Thread linlin
Creating a topic will first check whether the topic already exists.
The verification will read all topics under the namespace, and then
traverse these topics to see if the topic already exists.
When there are a large number of topics under the namespace(about 300,000
topics),
less than 10 topics can be created in one second.

Without a distributed lock, this check is unreliable and costly.
I tried to delete this check and write to ZooKeeper directly. If the znode
already exists, it means the topic already exists.

Then, I found this scenario in the unit test:
The user already has a non-partitioned topic like `topic-name-partition-123`
Then, he wants to create a partitioned topic like `topic-name`.
It cannot be created successfully now.
When traversing all topics, prefix matching is also performed.

In order to solve this problem, I want to add a check for reserved words on
the topic creation interface,and the topic name is not allowed to contain
-partition-, but this may cause some compatibility problems.

I want to hear your opinions. Is there a better way?


[GitHub] [pulsar-helm-chart] toneill818 opened a new pull request #140: Add Support for imagePullSecrets

2021-07-29 Thread GitBox


toneill818 opened a new pull request #140:
URL: https://github.com/apache/pulsar-helm-chart/pull/140


   Fixes #125
   
   ### Motivation
   
   The default images in the values.yaml are in docker hub. This PR allows us 
to provide image pull secrets for the containers which will allow us to get 
around Docker Hub's rate limiting if the nodes are not logged into Docker Hub.
   
   ### Modifications
   
   Added a new template to generate `imagePullSecrets`, and included them in 
the deployments and statefulsets. This will only add them if they are specified 
under `images.imagePullSecrets`
   
   ### Verifying this change
   
   - [] Make sure that the change passes the CI checks.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [pulsar-helm-chart] volgorean opened a new pull request #141: Updates CA name generation to be configurable

2021-07-29 Thread GitBox


volgorean opened a new pull request #141:
URL: https://github.com/apache/pulsar-helm-chart/pull/141


   Updates CA name generation to be configurable allowing the swapping in of a 
CA.
   
   ### Motivation
   
   We recently swapped out cert issuers and found that with the current helm 
chart we were unable to do a hot swap without downtime (via helm) because the 
CA cert name is not configurable. Being able to change the name of the CA 
allows us to create a new CA first -> Validate -> then swap over in follow up 
apply/release.
   
   ### Modifications
   
   Adds the ability to specify the suffix used to generate the CA name (not the 
whole name in order to preserve back compatibility regardless of the release 
name.)
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org