[GitHub] [pulsar-client-node] rkaw92 commented on issue #22: Convert project to typescript.

2020-12-08 Thread GitBox


rkaw92 commented on issue #22:
URL: 
https://github.com/apache/pulsar-client-node/issues/22#issuecomment-741076507


   Hi! I'm running into some issues due to the typings in DefinitelyTyped being 
out of date (namely, `log` missing, and `listener`-based consumer unrecognized 
in TS). Wouldn't it be easier to maintain the type definitions inside this 
source repository, and always ship them together? It seems like this would make 
keeping things in sync easier.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




Re: why not process bk error code LedgerFencedException

2020-12-08 Thread Sijie Guo
Yang - Can you clarify a bit more about the question and what are you
looking for?

- Sijie

On Mon, Dec 7, 2020 at 7:20 PM yang chen  wrote:

> hello, I have a question about ledger fence, why not fence the ledger
> in ManagedLedgerImpl
> and change the state to fenced when bk return LedgerFencedException after
> adding an entry.
>


Re: Apache Pulsar PIP - advertisedListener enhancement - Invitation to comment

2020-12-08 Thread Sijie Guo
Hi Abhilash,

I took a look at the issue you described. I don't think this is the right
approach to solve the problem. Because the HTTP and HTTPS ports are only
used for admin rest calls and topic lookups. You don't really need to
advertise those addresses. When we introduced multiple advertised
listeners, we already have that consideration in mind as we only need to
advertise the addresses and ports used for binary protocols.

I think to solve the problem, we can just fix the name used in health check
topics. E.g. switching from using HTTP port to Binary port.

Thanks,
Sijie

On Sat, Dec 5, 2020 at 12:13 AM Abhilash Mandaliya <
abhilashmandal...@gmail.com> wrote:

> Replied on the doc :)
>
> On Fri, Dec 4, 2020 at 6:39 PM Enrico Olivelli 
> wrote:
>
> > Hi,
> > I left a few comments on the documenations.
> >
> > Thanks for your efforts, I hope we can get this new feature in soon
> >
> > Regards
> > Enrico
> >
> > Il giorno gio 3 dic 2020 alle ore 16:39 Abhilash Mandaliya (via Google
> > Docs)  ha scritto:
> >
> >> I've shared an item with you:
> >>
> >> Apache Pulsar PIP - advertisedListener enhancement
> >>
> >>
> https://docs.google.com/document/d/1YelHBuFAAYkmRNWzhVg4j39-VovGb9Ng2_Vg6zbCqGM/edit?usp=sharing&invite=CJTD-8sC&ts=5fc8a168
> >>
> >> It's not an attachment -- it's stored online. To open this item, just
> >> click
> >> the link above.
> >>
> >> Let me know if you need an edit access of this doc
> >>
> >
>
> --
> Regards,
> Abhilash Mandaliya
>


[GitHub] [pulsar-adapters] hailin0 opened a new issue #4: Not found pulsar-client-kafka 2.7.0 in maven central repository

2020-12-08 Thread GitBox


hailin0 opened a new issue #4:
URL: https://github.com/apache/pulsar-adapters/issues/4


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




PIP for making dispatcher pluggable

2020-12-08 Thread Zhengxin Cai
Hi Pulsar community,

Recently there was discussion about adding consumer filtering logic at
broker side, and the community has choose not to add that to core
components but still would like to find a way for uses to do their own
customization.
Here I'm proposing we can make the message dispatcher pluggable and add
factory for creating all kinds fo dispatchers. Users can create their own
dispatchers and factory and can use customized dispatcher with business
logic like filtering there.
A more detailed proposal in this google doc:
https://docs.google.com/document/d/1RxgK833SgbEWvso-9xJuSsT4he5Yqw3E0AIGp3GmoNI
Any comments are welcome.

Best,
Marvin,