Re: [ovs-dev] [PATCH v2] Introducing support for P4 in OVS
Hi Ben, I have done some initial testing using the l2_switch.p4 program, and it builds and works correctly. I can now match using the generated fields and can route traffic based on these fields. Also, I think, we can now remove the include/p4/src folder, as it's no longer needed. At the moment, we are running both the legacy parser and the new parser, generated using P4, in miniflow_extract. It seems like the next step is to remove this legacy parser and fields from 'flow' struct and replace them with the P4 generated fields. It requires replacing explicit references to these legacy fields at different places in the code, i.e., in bfd.c, cfm.c, and more, with the P4 fields. I'm working on a patch for this and will share on the dev-list, soon. Thanks, Shahbaz On Fri, Oct 14, 2016 at 8:56 PM Muhammad Shahbaz wrote: > Hi Ben, > > That's great! Thanks for the new set of changes to the new approach. > > I have looked at the changes and, I agree, it makes more sense to have > template files inline with theOVS source code rather than having them > under a separate folder. I like the new approach for P4, much cleaner. > > I will build and test it myself and let you know if I see any issues. > > Cheers, > Shahbaz > > > On Fri, Oct 14, 2016 at 8:00 PM Ben Pfaff wrote: > > I finished changing the build system to use the new approach. It's on > the same branch as before (force-pushed over the previous version). > > It builds, I haven't tried running it yet. > > On Thu, Oct 13, 2016 at 05:05:17PM -0700, Ben Pfaff wrote: > > Thanks for sending v2. > > > > I think that the changes to extract-ofp-actions are white-space only and > > can be dropped. > > > > I spent a lot of time this afternoon playing with the build system. > > Running p4c-behavioral once at configure time is not a great way to > > go. Furthermore, it's a pain to have all these files in a separate > > directory that's walled off from the main code. I think that we can do > > better. So I pushed this branch: > > https://github.com/blp/ovs-reviews/tree/p4-2 > > which adds a commit to demonstrate a different approach. The basic idea > > is to teach the build system to run any file whose name ends in .p4c > > through p4c-behavioral regardless of where it occurs in the tree. > > p4c-behavioral isn't well suited for this so I had to write a script > > (preprocess-p4) to make it possible. I included a demo use of the idea > > for just include/openvswitch/flow.h. You can probably see how this is > > easier to follow than the indirection through a separate directory plus > > an extra nested #include. > > > > I'll certainly have other comments, but I spent all afternoon on this > > and I'm out of time for the day. > > > > What do you think of this approach? It's an incomplete conversion for > > now, of course, so the tree doesn't build. > > > > On Sat, Oct 08, 2016 at 02:12:11AM -0500, Muhammad Shahbaz wrote: > > > This is a follow-up patch with changes proposed by Ben Pfaff in an > earlier thread, > > > "[PATCH 1/2] adding P4 support." This patch doesn't contain changes > for the > > > microflow cache; those will be posted later. > > > > > > Following changes have been addressed: > > > > > > 1. All ovs-related code is now in under the include/p4/plugin > directory. > > > p4c-behavioral reads this code using the --plugin-path flag. Also, no > changes > > > are needed in the p4c-behvaioral repository now. > > > 2. Identifier names no longer begin with a leading "_." > > > 3. Dropping macro definitions for headers for better readability. > > > 4. Unified code for repetitive 8/16/32/64 bit cases. > > > 5. Replaced OXM_OF_* with NXOXM_ET_*. > > > 6. Only fields with valid headers are now masked. > > > 7. Code refactoring to remove repetition and to improve readability. > > > > > > Remaining changes, from the earlier thread, that still need to be > addressed are: > > > > > > 1. Removing duplicate parsing and integrating resets into > dp_packet_reset_offsets(). > > > 2. Inlining packet_set__*() functions. > > > 3. Come up with a compact representation of valid bits for the headers. > > > > > > Signed-off-by: Muhammad Shahbaz > > > --- > > > acinclude.m4 | 14 + > > > build-aux/extract-ofp-actions | 4 +- > > > build-aux/extract-ofp-fields | 99 +++-- > > > configure.ac | 1 + > > > datapath/linux/compat/include/linux/openvswitch.h | 7 + > > > include/automake.mk| 1 + > > > include/openvswitch/flow.h | 8 + > > > include/openvswitch/meta-flow.h| 5 + > > > include/openvswitch/packets.h | 3 + > > > include/openvswitch/types.h| 3 + > > > include/p4/automake.mk | 20 + > > > include/p4/examples/l2-switch.p4 | 89 > > > include/p4/examples/s
[ovs-dev] Liebe Sieger,
Liebe Sieger, Sie sind einer der glücklichen Gewinner des internationalen Lotto in Madrid Spanien gefeiert. öffnen Sie das beigefügte Dokument Ihr Mitteilungsschreiben anzuzeigen. Herzliche Glückwünsche. DON Caballero Guardiola DIRECTOR GENERAL ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
Re: [ovs-dev] [PATCH 1/9] dist-docs: Add support for rST
On Sat, Oct 8, 2016 at 12:30 PM, Stephen Finucane wrote:
> This will eventually go away once Sphinx starts doing all this work for
> us. For now, however, let's make sure we don't break the OVS website.
>
> This introduces a new dependency for the dist-docs script - 'rst2html'.
> This tool is packaged on Ubuntu, Fedora (via 'python-docutils'), etc.
> and can be installed from pip using the 'docsutils' package.
>
> Signed-off-by: Stephen Finucane
>
I'm working through this patch series now. I had one small addition to
this one to run by you.
> ---
> Makefile.am | 4 ++--
> build-aux/dist-docs | 22 +++---
> 2 files changed, 21 insertions(+), 5 deletions(-)
>
> diff --git a/Makefile.am b/Makefile.am
> index 49010b3..4b01766 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -63,8 +63,8 @@ CLEAN_LOCAL =
> DISTCLEANFILES =
> PYCOV_CLEAN_FILES = build-aux/check-structs,cover
>
> -# A list of Markdown-formatted documentation that will automatically be
> -# included in the "make dist-docs" output.
> +# A list of Markdown- or reStructuredText-formatted documentation that
> will
> +# automatically be included in the "make dist-docs" output.
> docs = \
> CONTRIBUTING.md \
> CodingStyle.md \
> diff --git a/build-aux/dist-docs b/build-aux/dist-docs
> index a81e4b2..677ceeb 100755
> --- a/build-aux/dist-docs
> +++ b/build-aux/dist-docs
> @@ -35,6 +35,7 @@ search_path () {
> }
> search_path man
> search_path markdown
> +search_path rst2html
> search_path ps2pdf
>
> # Create dist-docs directory.
> @@ -61,9 +62,9 @@ cat >&3 <
> EOF
>
> -# Add top-level documentation to index.html, giving it .txt extensions so
> -# that the webserver doesn't serve it as Markdown and make your web
> browser
> -# try to invoke some kind of external helper you don't have installed.
> +# Add top-level documentation to index.html, giving it .txt extensions so
> that
> +# the webserver doesn't serve it as Markdown/rST and make your web
> browser try
> +# to invoke some kind of external helper you don't have installed.
> #
> # Also translate documentation to HTML.
> for file
> @@ -92,6 +93,21 @@ EOF
> EOF
> ;;
>
> +*.rst)
>
I added this line here:
+title=`grep -A 1 -e "^=" $srcdir/$file | sed -n 2p`
To get a proper title for each rst doc in index.html. Previously it was
just using the first line, which was ".." for the rst files. Let me know
if you have an idea for something better.
+cp "$srcdir/$file" "$distdir/$file.txt"
> +ln -s $(basename "$file.txt") "$distdir/$file"
> +rst2html "$distdir/$file.txt" --stylesheet-path="style.css" \
> +--link-stylesheet --title="$file (Open vSwitch $VERSION)"
> \
> +> "$distdir/$file.html"
> +cat < +
> + $file
> + $title
> + HTML, plain
> text
> +
> +EOF
> +;;
> +
> *)
> cp "$srcdir/$file" "$distdir/$file"
> cat < --
> 2.7.4
>
> ___
> dev mailing list
> dev@openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
>
--
Russell Bryant
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Re: [ovs-dev] [PATCH 2/9] doc: Convert INSTALL to rST
On Sat, Oct 8, 2016 at 12:30 PM, Stephen Finucane wrote: > Signed-off-by: Stephen Finucane > --- > CONTRIBUTING.md | 6 +- > FAQ.md | 10 +- > INSTALL.DPDK-ADVANCED.md | 2 +- > INSTALL.DPDK.md | 6 +- > INSTALL.Debian.md| 4 +- > INSTALL.Docker.md| 6 +- > INSTALL.Fedora.md| 6 +- > INSTALL.KVM.md | 8 +- > INSTALL.Libvirt.md | 4 +- > INSTALL.NetBSD.md| 4 +- > INSTALL.RHEL.md | 6 +- > INSTALL.SELinux.md | 2 +- > INSTALL.SSL.md | 4 +- > INSTALL.XenServer.md | 6 +- > INSTALL.md | 823 -- > -- > INSTALL.rst | 867 ++ > + > INSTALL.userspace.md | 4 +- > Makefile.am | 2 +- > README.md| 6 +- > tutorial/Tutorial.md | 4 +- > 20 files changed, 912 insertions(+), 868 deletions(-) > delete mode 100644 INSTALL.md > create mode 100644 INSTALL.rst > I made a couple of minor changes to this patch. I renamed the new "Profiling" section header to "Valgrind", since I don't think the use of valgrind here is for profiling, it's primarily for catching certain types of errors. I also re-added the bug reporting section at the end of the document. diff --git a/INSTALL.rst b/INSTALL.rst index a159b00..2b7f9b1 100644 --- a/INSTALL.rst +++ b/INSTALL.rst @@ -599,8 +599,8 @@ All the same options are avaiable via TESTSUITEFLAGS. For example:: $ make check-lcov TESTSUITEFLAGS=-j8 -k ovn -Profiling -+ +Valgrind + If you have ``valgrind`` installed, you can run the testsuite under valgrind by using the ``check-valgrind`` target:: @@ -865,3 +865,8 @@ Open vSwitch includes a Makefile target to trigger static code analysis:: You should invoke scan-view to view analysis results. The last line of output from ``clang-analyze`` will list the command (containing results directory) that you should invoke to view the results on a browser. + +Bug Reporting +- + +Please report problems to b...@openvswitch.org. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
Re: [ovs-dev] [PATCH 2/9] doc: Convert INSTALL to rST
On Sat, Oct 15, 2016 at 9:57 PM, Russell Bryant wrote: > > On Sat, Oct 8, 2016 at 12:30 PM, Stephen Finucane > wrote: > >> Signed-off-by: Stephen Finucane >> --- >> CONTRIBUTING.md | 6 +- >> FAQ.md | 10 +- >> INSTALL.DPDK-ADVANCED.md | 2 +- >> INSTALL.DPDK.md | 6 +- >> INSTALL.Debian.md| 4 +- >> INSTALL.Docker.md| 6 +- >> INSTALL.Fedora.md| 6 +- >> INSTALL.KVM.md | 8 +- >> INSTALL.Libvirt.md | 4 +- >> INSTALL.NetBSD.md| 4 +- >> INSTALL.RHEL.md | 6 +- >> INSTALL.SELinux.md | 2 +- >> INSTALL.SSL.md | 4 +- >> INSTALL.XenServer.md | 6 +- >> INSTALL.md | 823 -- >> -- >> INSTALL.rst | 867 ++ >> + >> INSTALL.userspace.md | 4 +- >> Makefile.am | 2 +- >> README.md| 6 +- >> tutorial/Tutorial.md | 4 +- >> 20 files changed, 912 insertions(+), 868 deletions(-) >> delete mode 100644 INSTALL.md >> create mode 100644 INSTALL.rst >> > > I made a couple of minor changes to this patch. I renamed the new > "Profiling" section header to "Valgrind", since I don't think the use of > valgrind here is for profiling, it's primarily for catching certain types > of errors. > > I also re-added the bug reporting section at the end of the document. > > diff --git a/INSTALL.rst b/INSTALL.rst > index a159b00..2b7f9b1 100644 > --- a/INSTALL.rst > +++ b/INSTALL.rst > @@ -599,8 +599,8 @@ All the same options are avaiable via TESTSUITEFLAGS. > For example:: > > $ make check-lcov TESTSUITEFLAGS=-j8 -k ovn > > -Profiling > -+ > +Valgrind > + > > If you have ``valgrind`` installed, you can run the testsuite under > valgrind by using the ``check-valgrind`` target:: > @@ -865,3 +865,8 @@ Open vSwitch includes a Makefile target to trigger > static code analysis:: > You should invoke scan-view to view analysis results. The last line of > output > from ``clang-analyze`` will list the command (containing results > directory) > that you should invoke to view the results on a browser. > + > +Bug Reporting > +- > + > +Please report problems to b...@openvswitch.org. > > Very minor nit ... I think I would find it easier to review these if content changes were separate from the md to rst conversion. I also understand that it's much easier to do the cleanups as you go during the conversion. I certainly don't want you to re-do these patches, but it's something to keep in mind for future patches if separating formatting from content is easy enough to do. Thanks, -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
Re: [ovs-dev] $2M To You
From: Hakkebo, Ragnhild Størseth Sent: Saturday, October 15, 2016 10:54 PM To: Hakkebo, Ragnhild Størseth Subject: $2M To You Een speciale donatie van $ 2M is gemaakt om u en uw gezin. Neem contact op voor meer informatie A Special Donation of $2M was màde to you and your family. Contact for details ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
