[ovs-dev] hi
Hi! How are you? My name is Anzu. I am 25 years old. I am from Chongqing. I like your page. How often do you visit the site? I really want to communicate with you. I am good at Thai massage and really like to eat fish. What about you? I guess that we will have many topics to talk about. Do you have some social networks? I will be waiting for your letter. Best wishes. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
[ovs-dev] [PATCH] ovn-northd: Recalculate db mappings if the txn returns TXN_ERROR
Fixes the issue
Reported-at: http://openvswitch.org/pipermail/discuss/2015-November/019443.html
Signed-off-by: Numan Siddique
---
lib/ovsdb-idl.c | 1 +
lib/ovsdb-idl.h | 1 +
ovn/northd/ovn-northd.c | 21 -
3 files changed, 22 insertions(+), 1 deletion(-)
diff --git a/lib/ovsdb-idl.c b/lib/ovsdb-idl.c
index 0d02ae8..2e536c9 100644
--- a/lib/ovsdb-idl.c
+++ b/lib/ovsdb-idl.c
@@ -3209,6 +3209,7 @@ ovsdb_idl_loop_commit_and_wait(struct ovsdb_idl_loop
*loop)
ovsdb_idl_txn_destroy(txn);
loop->committing_txn = NULL;
}
+loop->last_commit_status = status;
}
ovsdb_idl_wait(loop->idl);
diff --git a/lib/ovsdb-idl.h b/lib/ovsdb-idl.h
index 4c66ae0..5f7f2fc 100644
--- a/lib/ovsdb-idl.h
+++ b/lib/ovsdb-idl.h
@@ -266,6 +266,7 @@ struct ovsdb_idl_loop {
unsigned int precommit_seqno;
struct ovsdb_idl_txn *open_txn;
+enum ovsdb_idl_txn_status last_commit_status;
};
#define OVSDB_IDL_LOOP_INITIALIZER(IDL) { .idl = (IDL) }
diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c
index 270b116..be4d6a8 100644
--- a/ovn/northd/ovn-northd.c
+++ b/ovn/northd/ovn-northd.c
@@ -1912,6 +1912,8 @@ main(int argc, char *argv[])
/* Main loop. */
exiting = false;
+bool ovnnb_changes_pending = false;
+bool ovnsb_changes_pending = false;
while (!exiting) {
struct northd_context ctx = {
.ovnnb_idl = ovnnb_idl_loop.idl,
@@ -1922,11 +1924,28 @@ main(int argc, char *argv[])
if (ovnnb_seqno != ovsdb_idl_get_seqno(ctx.ovnnb_idl)) {
ovnnb_seqno = ovsdb_idl_get_seqno(ctx.ovnnb_idl);
-ovnnb_db_run(&ctx);
+ovnnb_changes_pending = true;
}
if (ovnsb_seqno != ovsdb_idl_get_seqno(ctx.ovnsb_idl)) {
ovnsb_seqno = ovsdb_idl_get_seqno(ctx.ovnsb_idl);
+ovnsb_changes_pending = true;
+}
+
+/*
+ * We need to recalculate the mappings to the OVN-sb db
+ * - If the OVN-nb db has changed or
+ * - If the previous update to the OVN-sb is not yet completed.
+ */
+if (ovnnb_changes_pending ||
+ovnsb_idl_loop.last_commit_status == TXN_ERROR) {
+ovnnb_db_run(&ctx);
+ovnnb_changes_pending = false;
+}
+
+if (ovnsb_changes_pending ||
+ovnnb_idl_loop.last_commit_status == TXN_ERROR) {
ovnsb_db_run(&ctx);
+ovnsb_changes_pending = false;
}
unixctl_server_run(unixctl);
--
2.5.0
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
[ovs-dev] hi
Hello! How are you? My name is Katashi and you? I am from Tokyo. It was really interesting for me to read you profile. I want to keep company with you. I read your profile and I like that you wrote about yourself. As for me I am a sushi chef and I am interested in reading. I hope that you will write to me on my email or hotmail ID, do you have such one? Please write back! ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
[ovs-dev] hi
Hi! How is your day? What is your name? My name is Michi. My native town is Shanghai. I am interested in chatting with you, what do you think about it? I suppose that you are very smart and consider person. I like your interests. My hobby is yoga. Do you have yahoo or Skype? Write to me, well? ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
[ovs-dev] Mail System Error - Returned Mail
The original message was included as attachment ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
[ovs-dev] missing Hyper-V and OVN meetings this week
I'm going to have to miss the Hyper-V and OVN meetings in #openvswitch this week. I'm in Pune, India this week, and they're at inconvenient times for the time zone there. I should be able to make the Hyper-V meeting next week, after I'm back. (The OVN meeting that week is on Christmas Eve; we might want to cancel it.) ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
Re: [ovs-dev] [monitor2 v2 7/9] ovsdb-client: support monitor2
Andy Zhou wrote on 12/12/2015 12:37:32 AM:
> On Tue, Dec 1, 2015 at 6:20 AM, Liran Schour wrote:
> "dev" wrote on 25/11/2015 12:16:01 AM:
>
> > From: Andy Zhou
> > @@ -617,6 +621,101 @@ monitor_print(struct json *table_updates,
> > }
> >
> > static void
> > +monitor2_print_row(struct json *row, const char *type, const char
> *uuid,
> > + const struct ovsdb_column_set *columns, struct
table
> *t)
> > +{
> > +if (!strcmp(type, "delete")) {
> > +if (row->type != JSON_NULL) {
> > +ovs_error(0, "delete method does not expect ");
> > +return;
> > +}
> > +
> > +table_add_row(t);
> > +table_add_cell(t)->text = xstrdup(uuid);
> > +table_add_cell(t)->text = xstrdup(type);
> > +} else {
> > +if (!row || row->type != JSON_OBJECT) {
> > +ovs_error(0, " is not object");
> > +return;
> > +}
> > +monitor_print_row(row, type, uuid, columns, t);
> > +}
> > +}
>
> Update2 does not send default values, therefore we will miss these
values
> on ovsdb-client.
> I can fix it on monitor_cond or you can send an updated patch.
>
> What changes do you have in mind?
> The goal of "monitor" command is to show what's being transmitted
> per ovsdb remote protocol. Since
> the default values are not being transmitted, I'd think it is O.K.
> not to show them. No?
>
OK. I thought the user expects to see the real outcome of the updates. If
not and "monitor" command should show only what is being transmitted it is
OK like it is now.
Thanks
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
