[ovs-dev] [PATCH] flow: Fix MSVC compile errors.
MSVC doesn't like the change in 'const' between function declaration and
definition: it reports "formal parameter 2 different from declaration" for
each of the functions in flow.h corrected by this (commit. I think it's
technically wrong about that, standards-wise.)
MSVC doesn't like an empty-brace initializer. (I think it's technically
right about that, standards-wise.)
This commit attempts to fix both problems, but I have not tested it with
MSVC.
CC: Jarno Rajahalme
Signed-off-by: Ben Pfaff
---
lib/flow.c | 2 +-
lib/flow.h | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/lib/flow.c b/lib/flow.c
index 4236e87..84048e8 100644
--- a/lib/flow.c
+++ b/lib/flow.c
@@ -742,7 +742,7 @@ miniflow_extract(struct dp_packet *packet, struct miniflow
*dst)
} else if (OVS_LIKELY(nw_proto == IPPROTO_ICMPV6)) {
if (OVS_LIKELY(size >= sizeof(struct icmp6_hdr))) {
const struct in6_addr *nd_target = NULL;
-struct eth_addr arp_buf[2] = { };
+struct eth_addr arp_buf[2] = { { { { 0 } } } };
const struct icmp6_hdr *icmp = data_pull(&data, &size,
sizeof *icmp);
parse_icmpv6(&data, &size, icmp, &nd_target, arp_buf);
diff --git a/lib/flow.h b/lib/flow.h
index 6ed7de3..d8632ff 100644
--- a/lib/flow.h
+++ b/lib/flow.h
@@ -529,7 +529,7 @@ flowmap_clear(struct flowmap *fm, size_t idx, unsigned int
n_bits)
/* OR the bits in the flowmaps. */
static inline struct flowmap
-flowmap_or(struct flowmap a, const struct flowmap b)
+flowmap_or(struct flowmap a, struct flowmap b)
{
struct flowmap map;
size_t unit;
@@ -542,7 +542,7 @@ flowmap_or(struct flowmap a, const struct flowmap b)
/* AND the bits in the flowmaps. */
static inline struct flowmap
-flowmap_and(struct flowmap a, const struct flowmap b)
+flowmap_and(struct flowmap a, struct flowmap b)
{
struct flowmap map;
size_t unit;
@@ -554,7 +554,7 @@ flowmap_and(struct flowmap a, const struct flowmap b)
}
static inline bool
-flowmap_is_empty(const struct flowmap fm)
+flowmap_is_empty(struct flowmap fm)
{
map_t map;
--
2.1.3
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Re: [ovs-dev] [PATCH] tunnel: Support matching on the presence of Geneve options.
On Fri, Aug 28, 2015 at 04:22:15PM -0700, Jesse Gross wrote: > On Fri, Aug 28, 2015 at 2:50 PM, Jarno Rajahalme > wrote: > > Jesse, > > > > Some comments and a possible bug below, otherwise looks good. > > > > Acked-by: Jarno Rajahalme > > > > I recall Ben has reviewed the earlier patches in this domain, so maybe it > > would be good to get his Ack as well. > > Thanks for the review. I fixed up the issues below but I'll wait a bit > to see if Ben feels like reviewing it. I skimmed the patch and I think you should just take Jarno's ack. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
Re: [ovs-dev] [PATCH] tunnel: Support matching on the presence of Geneve options.
On Sun, Aug 30, 2015 at 7:41 AM, Ben Pfaff wrote: > On Fri, Aug 28, 2015 at 04:22:15PM -0700, Jesse Gross wrote: >> On Fri, Aug 28, 2015 at 2:50 PM, Jarno Rajahalme >> wrote: >> > Jesse, >> > >> > Some comments and a possible bug below, otherwise looks good. >> > >> > Acked-by: Jarno Rajahalme >> > >> > I recall Ben has reviewed the earlier patches in this domain, so maybe it >> > would be good to get his Ack as well. >> >> Thanks for the review. I fixed up the issues below but I'll wait a bit >> to see if Ben feels like reviewing it. > > I skimmed the patch and I think you should just take Jarno's ack. Thanks. I applied this to master with the changes I mentioned in my response to Jarno. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
Re: [ovs-dev] [ovs-discuss] openvswitch 2.4.0 Fedora packages
> > Both. Open the link below and click on the icon in the right side of the > 'Builds' > line. > fbl > Great. Thanks. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
[ovs-dev] MAIL SYSTEM ERROR - RETURNED MAIL
___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
[ovs-dev] Query with respect to OVSDB and vswitchd
Hi , I have been very recently using the OVSDB for one of our projects . I am able to create my own schema and operate on it . However to better understand things , I was also looking at the behavior of vswitchd on the default schema. I am confused with the events of things that happened - 1) I am monitoring the "Bridge" table through ovsdb-client 2) Using ovs-vsctl , whenever I add a bridge ( say br0 ) , on the monitor console I see that there are 2 activities - one of which is the initial "insert" and the next is an update for the "datapath id " that gets allocated by the vswitchd. This is understandable. In the update the _version field and the datapath id field gets mutated to new values. 3) However, if I add a second bridge ( say br1 ) , in the monitor console , apart from the above operations pertaining to the new bridge being added ( br1 ) , I am also seeing that the entry for the previously added bridge br0 also gets mutated and the only change is the _version field. My understanding of the _uuid and _version fields is that these are maintained by the DB for internal purposes and the ovsdb-client cannot mutate these. So I wanted to understand , why ( or what is the need ) the change of *_version* for all of the existing bridges are required , whenever we are adding a new bridge. Thanks and regards, Rishi Raj ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
[ovs-dev] Message could not be delivered
This Message was undeliverable due to the following reason: Your message was not delivered because the destination computer was not reachable within the allowed queue period. The amount of time a message is queued before it is returned depends on local configura- tion parameters. Most likely there is a network problem that prevented delivery, but it is also possible that the computer is turned off, or does not have a mail system running right now. Your message was not delivered within 1 days: Host 131.149.99.92 is not responding. The following recipients did not receive this message: Please reply to postmas...@openvswitch.org if you feel this message to be in error. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
