Re: [ovs-dev] [PATCH] stp: Fix bpdu tx problem in listening state

2014-03-16 Thread Kmindg G
On Sun, Mar 16, 2014 at 12:50 AM, Ben Pfaff  wrote:
> On Wed, Mar 12, 2014 at 03:31:26PM +0800, Kmindg G wrote:
>> On Wed, Mar 12, 2014 at 1:41 PM, Ben Pfaff  wrote:
>> > On Sun, Mar 09, 2014 at 05:48:52PM +0800, kmindg wrote:
>> >> The restriction only allows to send bpdu in forwarding state in
>> >> compose_output_action__. But a port could send bpdu in listening
>> >> and learning state according to comments in lib/stp.h(State of
>> >> an STP port).
>> >>
>> >> Signed-off-by: kmindg 
>> >
>> > This appears to fix a bug, but I'm not sure exactly how bad that bug is,
>> > or what the symptoms of it are.  Does this patch mean that currently OVS
>> > isn't sending out BPDUs in certain STP states?  (In other words, that
>> > STP is currently broken?)
>>
>> Yes, currently OVS isn't sending out BPDUs in listening and learning states.
>> But those two states are temporary, the stp port will be in forwarding state
>> and send out BPDUs eventually (In the default configuration listening and
>> learning states last 15+15 second).
>>
>> So this minor problem may only increase the convergence time, in my opinion.
>
> Thanks for the extra explanation.  I added that to the commit message
> and applied this to master, branch-2.1, and branch-2.0.

Thanks for applying.   :)
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev


Re: [ovs-dev] [ovs-discuss] How to Search in Archives?

2014-03-16 Thread Kmindg G
On Fri, Mar 14, 2014 at 7:13 PM, Rizwan Jamil  wrote:
> Hi!
>
> Search is provided in mininet-discuss and openflow-discuss mailing archives.
> But why it has not been provided in ovs-dev and ovs-discuss archives? How
> can I search my question in ovs-dev and ovs-discuss?

google always is your friend.
Search this "Rizwan site:openvswitch.org" in google

>
> Regards,
> Rizwan Jamil
>
> ___
> discuss mailing list
> disc...@openvswitch.org
> http://openvswitch.org/mailman/listinfo/discuss
>
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev


Re: [ovs-dev] [PATCH 2/5] ofproto: Allow the use of the OpenFlow 1.4 protocol

2014-03-16 Thread Ben Pfaff
On Mon, Mar 03, 2014 at 03:22:32PM +0200, Alexandru Copot wrote:
> This defines the version number for OpenFlow 1.4 so that the switch
> can actually use it. The ovsdb schema is also modified.
> 
> Signed-off-by: Alexandru Copot 
> Cc: Daniel Baluta 

I'm pretty happy with this.

The one bit that I'm concerned about is that it allows OpenFlow 1.4 to
be enabled even though there are unimplemented messages that will cause
Open vSwitch to abort if ovs-vswitchd receives one (or tries to send
one).  We need to avoid that somehow; one way would be to not allow
OpenFlow 1.4 to be enabled as long as any of those messages exist.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev