Re: SHA1/MD5 in sal/rtl/source/digest.c patch license able for OO
OT: Welcome back Rafael! On 25.07.19 22:57, Raphael Bircher wrote: > If the code is released from the original author under Apache License > v2.0 then we can include it, else we have to write our own solution > > On Thu, Jul 25, 2019 at 9:54 PM Keith N. McKenna > wrote: >> On 7/25/2019 1:26 PM, Peter Kovacs wrote: >>> Call me naive. I wanted to have the question asked. No one should say that >>> we did not try it this way. >>> >>> Am 25. Juli 2019 09:38:28 MESZ schrieb Bidouille : - Mail original - > I believe that unless the LO developer agrees to license it also > under the ALv2 we cannot commit it to our code base. +1 The author is Michael Stahl, employed at CIB GmbH. This company is copyleft addicted and LibO side only. - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org >> Peter; >> >> For other questions around handling other licenses see the 3rd Party >> License Policy at https://www.apache.org/legal/resolved.html >> > - > To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org > For additional commands, e-mail: dev-h...@openoffice.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: SHA1/MD5 in sal/rtl/source/digest.c patch license able for OO
Hi Brane, This is a very nice Idea. Maybe even beyond the immediate idea on fixing the SHA implementation. Thanks a lot for this Idea. All the Best Peter On 26.07.19 12:36, Branko Čibej wrote: > On 25.07.2019 00:43, Peter Kovacs wrote: >> Hello all, >> >> >> I would like to ask if I or any other from OpenOffice Development team >> can port the patch from LibreOffice to OpenOffice to fix this Issue >> under the APL2 License, so the Issue can be fixed in OpenOffice without >> more work then necessary. > > Would it be appropriate to use the hash code from APR > (https://apr.apacha.org)? The license fits, and that code has been > stable and well tested for ages. But I'm not sure if it fits your FIPS > compliance requirements. > > -- Brane > > - > To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org > For additional commands, e-mail: dev-h...@openoffice.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: SHA1/MD5 in sal/rtl/source/digest.c patch license able for OO
If you read through the LO bug report, you'll see that there are many patches for this bug, affecting multiple modules. Why? The historical files that are valid but have the wrong checksum due to having been written by the broken [OO.org-derivative] implementations when they were created, will still be accepted as valid by future versions of LO. I think they have quite an involved bug fix, with new UI dialogs for those cases, etc. On Sat, Jul 27, 2019 at 9:50 AM Peter Kovacs wrote: > Hi Brane, > > This is a very nice Idea. Maybe even beyond the immediate idea on fixing > the SHA implementation. > > Thanks a lot for this Idea. > > > All the Best > > Peter > > On 26.07.19 12:36, Branko Čibej wrote: > > On 25.07.2019 00:43, Peter Kovacs wrote: > >> Hello all, > >> > >> > >> I would like to ask if I or any other from OpenOffice Development team > >> can port the patch from LibreOffice to OpenOffice to fix this Issue > >> under the APL2 License, so the Issue can be fixed in OpenOffice without > >> more work then necessary. > > > > Would it be appropriate to use the hash code from APR > > (https://apr.apacha.org)? The license fits, and that code has been > > stable and well tested for ages. But I'm not sure if it fits your FIPS > > compliance requirements. > > > > -- Brane > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org > > For additional commands, e-mail: dev-h...@openoffice.apache.org > > > > - > To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org > For additional commands, e-mail: dev-h...@openoffice.apache.org > >
Re: [discussion] svn migration plan
Hi all, Am 23.07.19 um 11:08 schrieb Matthias Seidel: > Hi Peter, > > Am 21.07.19 um 12:27 schrieb Peter Kovacs: >> back to the initial discussion. > Obviously you didn't read my mail until the end... >> I have created the request. Simply requesting that trunc, branch and >> tags are moved. All other folders should remain as is. >> >> I hope this suits everyone. > Do we have the necessary code changes ready? > > We use the SVN revision in our About dialog, and for creating the source > builds. This has to be adapted when we switch to git. > Using the git hash (short or long) instead? This should have been > discussed... Given the lack of response, this has yet to be investigated... Meanwhile my builds on Windows are now done from git. Additionally I did checkout from git on ArcaOS (OS/2) without problems. @Marcus: The switch to git hash (instead of SVN revision) would require some changes in the logic of our download page. Can you evaluate? Regards, Matthias > > Regards, > > Matthias > > BTW: My latest builds are based on a checkout from git, no problems so far. > >> >> Please review: >> >> https://issues.apache.org/jira/browse/INFRA-18773 >> >> >> On 21.07.19 01:42, Peter Kovacs wrote: >>> Hi brane, >>> >>> The threads are linked in my first post. >>> >>> It is for me a workflow thing. >>> I need a decentral versioning system instead of a central one. >>> And I want github as public patch interface. >>> Both do not work with svn. >>> >>> I add a reason that I heard at work. Young people do not know svn. They >>> expect to work with git. >>> IMHO it is a dumb argument but in my country the fresh people from >>> university are dictating a little their working environment. >>> >>> Ahh and git has major pains reading OpenOffice svn repo. So I can't even >>> use git as a client. >>> >>> All the best. >>> Peter >>> >>> Am 21. Juli 2019 01:17:32 MESZ schrieb "Branko Čibej" : Hi AOO devs, I just stumbled onto this thread. Coming from subversion.a.o, I'm saddened to see you've decided to switch to Git. Could someone please summarise the reasons for this decision, or give me a link to the discussion in the mail archives? I'd very much like to know if it was caused by some specific problem or missing feature in Subversion that we may be able to address. -- Brane >> - >> To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org >> For additional commands, e-mail: dev-h...@openoffice.apache.org >> >> smime.p7s Description: S/MIME Cryptographic Signature
Re: Java 12 not recognized by AOO
Hello, @ Damjan I see your fix to Issue #128157. Does ist also works with Openjdk 11? Is it possible to extend it to OpenJKD because this is standard in the Linux distributions Kind regards Mechtide Am 10.05.19 um 08:42 schrieb Damjan Jovanovic: > On Fri, May 10, 2019 at 8:35 AM FR web forum wrote: > >> @Larry, >> Strange, the xml has kept many path locations. >> Could you rename this file (quit AOO before)? >> Run AOO that re-create a new javasettings file. >> Go back in Tools > Options > AOO > Java to see if jre 12 is here. >> >>> >>> >> file:///Library/Java/JavaVirtualMachines/jdk1.8.0_101.jdk/Contents/Home/jre >>> >> file:///Library/Java/JavaVirtualMachines/jdk1.8.0_144.jdk/Contents/Home/jre >>> >> file:///Library/Java/JavaVirtualMachines/jdk-11.0.1.jdk/Contents/Home >>> >> file:///Library/Java/JavaVirtualMachines/jdk-11.0.2.jdk/Contents/Home >>> >> >> > The only way I solved a Java detection issue before is to step through the > code with a debugger, and carefully check values at every step. > > See commit 1829211 for an example. > > We really need to beef up Java detection urgently, as Oracle has started to > limit its Java to non-commercial use, and people are migrating to > AdoptOpenJDK which we don't detect properly, even for Java 8. > -- Mechtilde Stehmann ## Apache OpenOffice ## Freie Office Suite für Linux, MacOSX, Windows ## Debian Developer ## PGP encryption welcome ## F0E3 7F3D C87A 4998 2899 39E7 F287 7BBA 141A AD7F signature.asc Description: OpenPGP digital signature
Re: Java 12 not recognized by AOO
Hi Mechtilde No idea. I'll try AdoptOpenJDK 11 now. Regards Damjan On Sat, Jul 27, 2019 at 7:22 PM Mechtilde wrote: > Hello, > > @ Damjan > > I see your fix to Issue #128157. > > Does ist also works with Openjdk 11? > > Is it possible to extend it to OpenJKD because this is standard in the > Linux distributions > > Kind regards > > Mechtide > > Am 10.05.19 um 08:42 schrieb Damjan Jovanovic: > > On Fri, May 10, 2019 at 8:35 AM FR web forum wrote: > > > >> @Larry, > >> Strange, the xml has kept many path locations. > >> Could you rename this file (quit AOO before)? > >> Run AOO that re-create a new javasettings file. > >> Go back in Tools > Options > AOO > Java to see if jre 12 is here. > >> > >>> > >>> > >> > file:///Library/Java/JavaVirtualMachines/jdk1.8.0_101.jdk/Contents/Home/jre > >>> > >> > file:///Library/Java/JavaVirtualMachines/jdk1.8.0_144.jdk/Contents/Home/jre > >>> > >> > file:///Library/Java/JavaVirtualMachines/jdk-11.0.1.jdk/Contents/Home > >>> > >> > file:///Library/Java/JavaVirtualMachines/jdk-11.0.2.jdk/Contents/Home > >>> > >> > >> > > The only way I solved a Java detection issue before is to step through > the > > code with a debugger, and carefully check values at every step. > > > > See commit 1829211 for an example. > > > > We really need to beef up Java detection urgently, as Oracle has started > to > > limit its Java to non-commercial use, and people are migrating to > > AdoptOpenJDK which we don't detect properly, even for Java 8. > > > > -- > Mechtilde Stehmann > ## Apache OpenOffice > ## Freie Office Suite für Linux, MacOSX, Windows > ## Debian Developer > ## PGP encryption welcome > ## F0E3 7F3D C87A 4998 2899 39E7 F287 7BBA 141A AD7F > >
Re: Java 12 not recognized by AOO
AdoptOpenJDK 11 isn't detected. I am investigating. On Sat, Jul 27, 2019 at 7:41 PM Damjan Jovanovic wrote: > Hi Mechtilde > > No idea. I'll try AdoptOpenJDK 11 now. > > Regards > Damjan > > > On Sat, Jul 27, 2019 at 7:22 PM Mechtilde wrote: > >> Hello, >> >> @ Damjan >> >> I see your fix to Issue #128157. >> >> Does ist also works with Openjdk 11? >> >> Is it possible to extend it to OpenJKD because this is standard in the >> Linux distributions >> >> Kind regards >> >> Mechtide >> >> Am 10.05.19 um 08:42 schrieb Damjan Jovanovic: >> > On Fri, May 10, 2019 at 8:35 AM FR web forum wrote: >> > >> >> @Larry, >> >> Strange, the xml has kept many path locations. >> >> Could you rename this file (quit AOO before)? >> >> Run AOO that re-create a new javasettings file. >> >> Go back in Tools > Options > AOO > Java to see if jre 12 is here. >> >> >> >>> >> >>> >> >> >> file:///Library/Java/JavaVirtualMachines/jdk1.8.0_101.jdk/Contents/Home/jre >> >>> >> >> >> file:///Library/Java/JavaVirtualMachines/jdk1.8.0_144.jdk/Contents/Home/jre >> >>> >> >> >> file:///Library/Java/JavaVirtualMachines/jdk-11.0.1.jdk/Contents/Home >> >>> >> >> >> file:///Library/Java/JavaVirtualMachines/jdk-11.0.2.jdk/Contents/Home >> >>> >> >> >> >> >> > The only way I solved a Java detection issue before is to step through >> the >> > code with a debugger, and carefully check values at every step. >> > >> > See commit 1829211 for an example. >> > >> > We really need to beef up Java detection urgently, as Oracle has >> started to >> > limit its Java to non-commercial use, and people are migrating to >> > AdoptOpenJDK which we don't detect properly, even for Java 8. >> > >> >> -- >> Mechtilde Stehmann >> ## Apache OpenOffice >> ## Freie Office Suite für Linux, MacOSX, Windows >> ## Debian Developer >> ## PGP encryption welcome >> ## F0E3 7F3D C87A 4998 2899 39E7 F287 7BBA 141A AD7F >> >>
Re: Java 12 not recognized by AOO
The problem with AdoptOpenJDK 11 is that it has a: lib/server/libjvm.so instead of the expected: lib/amd64/server/libjvm.so Patching AOO to search the new path fixes the detection problem. Does OpenJDK 11 / Oracle JDK 11 have the same change in path? Those require a different patch. Regards Damjan On Sat, Jul 27, 2019 at 7:48 PM Damjan Jovanovic wrote: > AdoptOpenJDK 11 isn't detected. > > I am investigating. > > > > On Sat, Jul 27, 2019 at 7:41 PM Damjan Jovanovic > wrote: > >> Hi Mechtilde >> >> No idea. I'll try AdoptOpenJDK 11 now. >> >> Regards >> Damjan >> >> >> On Sat, Jul 27, 2019 at 7:22 PM Mechtilde wrote: >> >>> Hello, >>> >>> @ Damjan >>> >>> I see your fix to Issue #128157. >>> >>> Does ist also works with Openjdk 11? >>> >>> Is it possible to extend it to OpenJKD because this is standard in the >>> Linux distributions >>> >>> Kind regards >>> >>> Mechtide >>> >>> Am 10.05.19 um 08:42 schrieb Damjan Jovanovic: >>> > On Fri, May 10, 2019 at 8:35 AM FR web forum wrote: >>> > >>> >> @Larry, >>> >> Strange, the xml has kept many path locations. >>> >> Could you rename this file (quit AOO before)? >>> >> Run AOO that re-create a new javasettings file. >>> >> Go back in Tools > Options > AOO > Java to see if jre 12 is here. >>> >> >>> >>> >>> >>> >>> >> >>> file:///Library/Java/JavaVirtualMachines/jdk1.8.0_101.jdk/Contents/Home/jre >>> >>> >>> >> >>> file:///Library/Java/JavaVirtualMachines/jdk1.8.0_144.jdk/Contents/Home/jre >>> >>> >>> >> >>> file:///Library/Java/JavaVirtualMachines/jdk-11.0.1.jdk/Contents/Home >>> >>> >>> >> >>> file:///Library/Java/JavaVirtualMachines/jdk-11.0.2.jdk/Contents/Home >>> >>> >>> >> >>> >> >>> > The only way I solved a Java detection issue before is to step through >>> the >>> > code with a debugger, and carefully check values at every step. >>> > >>> > See commit 1829211 for an example. >>> > >>> > We really need to beef up Java detection urgently, as Oracle has >>> started to >>> > limit its Java to non-commercial use, and people are migrating to >>> > AdoptOpenJDK which we don't detect properly, even for Java 8. >>> > >>> >>> -- >>> Mechtilde Stehmann >>> ## Apache OpenOffice >>> ## Freie Office Suite für Linux, MacOSX, Windows >>> ## Debian Developer >>> ## PGP encryption welcome >>> ## F0E3 7F3D C87A 4998 2899 39E7 F287 7BBA 141A AD7F >>> >>>
Re: Java 12 not recognized by AOO
Hello Damjan, here you can see the paths of the different Java versions fpr libjvm.so under Debian: /usr/lib/jvm/java-11-openjdk-amd64/lib/server/libjvm.so /usr/lib/jvm/java-12-openjdk-amd64/lib/server/libjvm.so /usr/lib/jvm/java-8-openjdk-amd64/jre/lib/amd64/server/libjvm.so Kind regards Am 27.07.19 um 20:18 schrieb Damjan Jovanovic: > The problem with AdoptOpenJDK 11 is that it has a: > lib/server/libjvm.so > instead of the expected: > lib/amd64/server/libjvm.so > > Patching AOO to search the new path fixes the detection problem. > > Does OpenJDK 11 / Oracle JDK 11 have the same change in path? Those require > a different patch. > > Regards > Damjan > -- Mechtilde Stehmann ## Apache OpenOffice ## Freie Office Suite für Linux, MacOSX, Windows ## Debian Developer ## PGP encryption welcome ## F0E3 7F3D C87A 4998 2899 39E7 F287 7BBA 141A AD7F signature.asc Description: OpenPGP digital signature
Re: Java 12 not recognized by AOO
Thank you. I've added the new paths in commit 1863883. Regards Damjan On Sat, Jul 27, 2019 at 8:39 PM Mechtilde wrote: > Hello Damjan, > > here you can see the paths of the different Java versions fpr libjvm.so > under Debian: > > /usr/lib/jvm/java-11-openjdk-amd64/lib/server/libjvm.so > /usr/lib/jvm/java-12-openjdk-amd64/lib/server/libjvm.so > /usr/lib/jvm/java-8-openjdk-amd64/jre/lib/amd64/server/libjvm.so > > Kind regards > > > Am 27.07.19 um 20:18 schrieb Damjan Jovanovic: > > The problem with AdoptOpenJDK 11 is that it has a: > > lib/server/libjvm.so > > instead of the expected: > > lib/amd64/server/libjvm.so > > > > Patching AOO to search the new path fixes the detection problem. > > > > Does OpenJDK 11 / Oracle JDK 11 have the same change in path? Those > require > > a different patch. > > > > Regards > > Damjan > > > > -- > Mechtilde Stehmann > ## Apache OpenOffice > ## Freie Office Suite für Linux, MacOSX, Windows > ## Debian Developer > ## PGP encryption welcome > ## F0E3 7F3D C87A 4998 2899 39E7 F287 7BBA 141A AD7F > >
Re: Java 12 not recognized by AOO
Should we not move this stuff in some sort of config file?Is the information in the config file you edited? On 27.07.19 21:52, Damjan Jovanovic wrote: > Thank you. > > I've added the new paths in commit 1863883. > > Regards > Damjan > > > On Sat, Jul 27, 2019 at 8:39 PM Mechtilde wrote: > >> Hello Damjan, >> >> here you can see the paths of the different Java versions fpr libjvm.so >> under Debian: >> >> /usr/lib/jvm/java-11-openjdk-amd64/lib/server/libjvm.so >> /usr/lib/jvm/java-12-openjdk-amd64/lib/server/libjvm.so >> /usr/lib/jvm/java-8-openjdk-amd64/jre/lib/amd64/server/libjvm.so >> >> Kind regards >> >> >> Am 27.07.19 um 20:18 schrieb Damjan Jovanovic: >>> The problem with AdoptOpenJDK 11 is that it has a: >>> lib/server/libjvm.so >>> instead of the expected: >>> lib/amd64/server/libjvm.so >>> >>> Patching AOO to search the new path fixes the detection problem. >>> >>> Does OpenJDK 11 / Oracle JDK 11 have the same change in path? Those >> require >>> a different patch. >>> >>> Regards >>> Damjan >>> >> -- >> Mechtilde Stehmann >> ## Apache OpenOffice >> ## Freie Office Suite für Linux, MacOSX, Windows >> ## Debian Developer >> ## PGP encryption welcome >> ## F0E3 7F3D C87A 4998 2899 39E7 F287 7BBA 141A AD7F >> >> - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Building AOO
Hello, I started to build AOO like the release. I use all the options of configure as in https://svn.apache.org/viewvc/openoffice/devtools/build-scripts/4.2.0-Dev1/?sortby=date The build breaks with /home/mechtilde/aoo42x/main/cui/Library_cui.mk:37: *** missing separator. Stop. dmake: Error code 2, while making 'all' 1 module(s): cui need(s) to be rebuilt Reason(s): ERROR: error 65280 occurred while making /home/mechtilde/aoo42x/main/cui/prj When you have fixed the errors in that module you can resume the build by running: build --all:cui I did a dmake clean Kind regards -- Mechtilde Stehmann ## Apache OpenOffice ## Freie Office Suite für Linux, MacOSX, Windows ## Debian Developer ## PGP encryption welcome ## F0E3 7F3D C87A 4998 2899 39E7 F287 7BBA 141A AD7F signature.asc Description: OpenPGP digital signature
Re: Java 12 not recognized by AOO
For AdoptOpenJDK it was config files and several .cxx files that register Java implementations (we really should extract that from config files instead). For Java 11/12 it was .cxx files that specify search paths for libjvm.so on *nix. Yes, there may still be issues on Windows/Mac/etc. On Sun, Jul 28, 2019 at 5:31 AM Peter Kovacs wrote: > Should we not move this stuff in some sort of config file?Is the > information in the config file you edited? > > On 27.07.19 21:52, Damjan Jovanovic wrote: > > Thank you. > > > > I've added the new paths in commit 1863883. > > > > Regards > > Damjan > > > > > > On Sat, Jul 27, 2019 at 8:39 PM Mechtilde wrote: > > > >> Hello Damjan, > >> > >> here you can see the paths of the different Java versions fpr libjvm.so > >> under Debian: > >> > >> /usr/lib/jvm/java-11-openjdk-amd64/lib/server/libjvm.so > >> /usr/lib/jvm/java-12-openjdk-amd64/lib/server/libjvm.so > >> /usr/lib/jvm/java-8-openjdk-amd64/jre/lib/amd64/server/libjvm.so > >> > >> Kind regards > >> > >> > >> Am 27.07.19 um 20:18 schrieb Damjan Jovanovic: > >>> The problem with AdoptOpenJDK 11 is that it has a: > >>> lib/server/libjvm.so > >>> instead of the expected: > >>> lib/amd64/server/libjvm.so > >>> > >>> Patching AOO to search the new path fixes the detection problem. > >>> > >>> Does OpenJDK 11 / Oracle JDK 11 have the same change in path? Those > >> require > >>> a different patch. > >>> > >>> Regards > >>> Damjan > >>> > >> -- > >> Mechtilde Stehmann > >> ## Apache OpenOffice > >> ## Freie Office Suite für Linux, MacOSX, Windows > >> ## Debian Developer > >> ## PGP encryption welcome > >> ## F0E3 7F3D C87A 4998 2899 39E7 F287 7BBA 141A AD7F > >> > >> > > > - > To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org > For additional commands, e-mail: dev-h...@openoffice.apache.org > >
Re: Building AOO
ifneq ($(BUILD_VER_STRING),)
$(eval $(call
gb_Library_add_defs,cui,-DBUILD_VER_STRING="$(BUILD_VER_STRING)"))
endif
Please try fiddle with that middle line. Maybe you need $$ instead of $
and/or {} instead of (), for the BUILD_VER_STRING variable.
Regards
Damjan
On Sun, Jul 28, 2019 at 6:24 AM Mechtilde wrote:
> Hello,
>
> I started to build AOO like the release. I use all the options of
> configure as in
>
>
> https://svn.apache.org/viewvc/openoffice/devtools/build-scripts/4.2.0-Dev1/?sortby=date
>
> The build breaks with
>
> /home/mechtilde/aoo42x/main/cui/Library_cui.mk:37: *** missing
> separator. Stop.
> dmake: Error code 2, while making 'all'
>
> 1 module(s):
> cui
> need(s) to be rebuilt
>
> Reason(s):
>
> ERROR: error 65280 occurred while making
> /home/mechtilde/aoo42x/main/cui/prj
>
> When you have fixed the errors in that module you can resume the build
> by running:
>
> build --all:cui
>
> I did a dmake clean
>
> Kind regards
>
> --
> Mechtilde Stehmann
> ## Apache OpenOffice
> ## Freie Office Suite für Linux, MacOSX, Windows
> ## Debian Developer
> ## PGP encryption welcome
> ## F0E3 7F3D C87A 4998 2899 39E7 F287 7BBA 141A AD7F
>
>
