Bug? in stm32_sdio.c
Hi, Sorry I haven't time to made a pull request for a little possible bug. in boards/arm/stm32/stm32_sdio.c line 1792 there is a return so value is not apply in register.
Re: RNDIS
> On 28/01/2023, 14:11, "Alan C. Assis" wrote: > If there are inconsistencies, they are not specify of RNDIS driver by > itself, but could be in the USB implementation of other architectures. Just for completeness, there was indeed a fix needed in the SAMA5 sam_udphs.c code. This is now done and merged to master. RNDIS is now working for this processor with Linux and Win11.
Re: RNDIS
Hi Tim, Thank you for confirming! I noticed that Mr. Xiang Xiao already closed the issue as well. BR, Alan On 2/11/23, Tim Hardisty wrote: >> On 28/01/2023, 14:11, "Alan C. Assis" wrote: > >> If there are inconsistencies, they are not specify of RNDIS driver by >> itself, but could be in the USB implementation of other architectures. > > Just for completeness, there was indeed a fix needed in the SAMA5 > sam_udphs.c code. > > This is now done and merged to master. > > RNDIS is now working for this processor with Linux and Win11. > >
Re: Bug? in stm32_sdio.c
Hi Pierre-Noel, Good catch! Although the right file is arch/arm/src/stm32/stm32_sdio.c, not boards/... This file has this possible BUG since when it was added into NuttX and it works as you can see here: https://www.youtube.com/watch?v=H28t4RbOXqI Probably someone using SDIO for other applications (like to use with WiFi chips) could face some issue when trying to disable the SDIO. Please send the PR or case you don't have time to do it, I could submit it and put you as author. BR, Alan On 2/11/23, Pierre-Noel Bouteville wrote: > Hi, > > Sorry I haven't time to made a pull request for a little possible bug. > > in boards/arm/stm32/stm32_sdio.c line 1792 there is a return so value is > not apply in register. >
Re: Bug? in stm32_sdio.c
Hello, A fix has already been merged. https://github.com/apache/nuttx/pull/8502 On Sat, Feb 11, 2023 at 9:48 PM Alan C. Assis wrote: > Hi Pierre-Noel, > > Good catch! Although the right file is > arch/arm/src/stm32/stm32_sdio.c, not boards/... > > This file has this possible BUG since when it was added into NuttX and > it works as you can see here: > > https://www.youtube.com/watch?v=H28t4RbOXqI > > Probably someone using SDIO for other applications (like to use with > WiFi chips) could face some issue when trying to disable the SDIO. > > Please send the PR or case you don't have time to do it, I could > submit it and put you as author. > > BR, > > Alan > > On 2/11/23, Pierre-Noel Bouteville wrote: > > Hi, > > > > Sorry I haven't time to made a pull request for a little possible bug. > > > > in boards/arm/stm32/stm32_sdio.c line 1792 there is a return so value is > > not apply in register. > > >
Re: Bug? in stm32_sdio.c
Thanks i will test as soon as possible. I’m on other project with SD CARD but without os so I found it with review of code ;) Envoyé de mon iPhone > Le 11 févr. 2023 à 21:28, Fotis Panagiotopoulos a écrit > : > > Hello, > > A fix has already been merged. > > https://github.com/apache/nuttx/pull/8502 > >> On Sat, Feb 11, 2023 at 9:48 PM Alan C. Assis wrote: >> >> Hi Pierre-Noel, >> >> Good catch! Although the right file is >> arch/arm/src/stm32/stm32_sdio.c, not boards/... >> >> This file has this possible BUG since when it was added into NuttX and >> it works as you can see here: >> >> https://www.youtube.com/watch?v=H28t4RbOXqI >> >> Probably someone using SDIO for other applications (like to use with >> WiFi chips) could face some issue when trying to disable the SDIO. >> >> Please send the PR or case you don't have time to do it, I could >> submit it and put you as author. >> >> BR, >> >> Alan >> >>> On 2/11/23, Pierre-Noel Bouteville wrote: >>> Hi, >>> >>> Sorry I haven't time to made a pull request for a little possible bug. >>> >>> in boards/arm/stm32/stm32_sdio.c line 1792 there is a return so value is >>> not apply in register. >>> >>
