Re: Error with stm32f4discovery:usbnsh

2021-04-20 Thread Max Kriegleder
Strange.. I have sent two mails prior to this one and apparently they 
did not make it to the list. Trying again:


Were you able to fix this problem? I am running nuttx-10.0.1 on a 
stm32f4discovery board and I have the same issue.


Thanks!


On 2021/04/17 22:56:48, Alan Carvalho de Assis  wrote:
> I just received it!>
>
> Try to submit a new email>
>
> On 4/17/21, Max Kriegleder  wrote:>
> > Is anybody reading this? I am not sure why my messages get lost.. how>
> > can I post to the message list?>
> >>
> > On 2020/12/13 22:19:01, Brennan Ashton  
wrote:>
> > > Yeah 100% agree which is why I need to look when I have a little 
more>>

> > > time to understand what is going on.>>
> > >>
> > > On Sun, Dec 13, 2020 at 2:12 PM Gregory Nutt  
wrote:>>

> > > >>>
> > > > See>>
> > > >>
> > 
https://mail-archives.apache.org/mod_mbox/nuttx-dev/202012.mbox/%3CCAKFLXYwes3pcDA2zXsL2FcwgCS4PecdmiP9srkGEtTaOoLEhMg%40mail.gmail.com%3E>> 


> >>
> >>
> > > >>>
> > > > I don't think this is the correct solution since with Xiao 
Xiang's>>
> > > > recent changes, stdin should never be closed. But it does give 
some>>
> > > > clues about the nature of the problem: stdin is no valid; 
stdout is>

> > okay>>
> > > >>>
> > > > On 12/13/2020 4:07 PM, Brennan Ashton wrote:>>
> > > > > This is impacting all the usbnsh configurations. I can take 
another>>

> > > > > look later this evening>>
> > > > > https://github.com/apache/incubator-nuttx/pull/2526>>
> > > > >>>
> > > > > --Brennan>>
> > > > >>>
> > > > > On Fri, Dec 11, 2020 at 5:05 AM Gregory Nutt >
> > wrote:>>
> > > > >> Several other PRs specifically removed support for fclose>
> > (stdin). Are>>
> > > > >> you certain you want to restore it? I think this needs more>
> > analysis>>
> > > > >> and resolution with the previous changes that removed the>
> > fclose() of>>
> > > > >> stdin, stdout, and stderr.>>
> > > > 
> > > > >> On 12/10/2020 5:37 PM, Masayuki Ishikawa wrote:>>
> > > > >>> Suzuki-san,>>
> > > > >
> > > > >>> Please send a PR (Pull Request) to>>
> > > > >>> https://github.com/apache/incubator-nuttx-apps/>>
> > > > >
> > > > >>> On Thu, Dec 10, 2020 at 5:24 PM SUZUKI Keiji 
>

> > wrote:>>
> > > > >
> > > >  Hi,>>
> > > > >>
> > > >  I use STM32F407G-DISC1 (MB997D) and build nuttx on macOS>
> > Mojave (10.14.6).>>
> > > > >>
> > > >  The following error occurs with the default configuration 
of>>

> > > >  stm32f4discovery:usbnsh.>>
> > > > >>
> > > >  NuttShell (NSH) NuttX-10.0.0>>
> > > >  nsh> nsh: nsh_session: readline failed: 9>>
> > > > >>
> > > >  The reason seems that instream->fs_fd is -1 instead of 0 in>
> > the readline()>>
> > > >  function called by>>
> > > >  nsh_session().>>
> > > > >>
> > > >  This error occurs in version 10.0-RC0 and after (I checked>
> > 10.0-RC0, 10.0>>
> > > >  and current master)>>
> > > >  but does not occur in 9.1 and before (I checked 9.1, 8.2 and>
> > 7.31).>>
> > > > >>
> > > >  The following patch fixed it in my environment but I don't>
> > know this is a>>
> > > >  correct fix.>>
> > > > >>
> > > >  === from here ===>>
> > > > >>
> > > >  diff --git a/nshlib/nsh_usbconsole.c 
b/nshlib/nsh_usbconsole.c>>

> > > >  index 28f63bcc..768a621b 100644>>
> > > >  --- a/nshlib/nsh_usbconsole.c>>
> > > >  +++ b/nshlib/nsh_usbconsole.c>>
> > > >  @@ -77,8 +77,8 @@>>
> > > > >>
> > > >  static void nsh_configstdio(int fd, FAR struct 
console_stdio_s>

> > *pstate)>>
> > > >  {>>
> > > >  - /* Make sure the stdout, and stderr are flushed */>>
> > > >  ->>
> > > >  + /* Make sure the stdin is closed and the stdout, and 
stderr>

> > are flushed>>
> > > >  */>>
> > > >  + fclose(stdin);>>
> > > >  fflush(stdout);>>
> > > >  fflush(stderr);>>
> > > > >>
> > > >  @@ -88,6 +88,9 @@ static void nsh_configstdio(int fd, FAR 
struct>>

> > > >  console_stdio_s *pstate)>>
> > > >  dup2(fd, 1);>>
> > > >  dup2(fd, 2);>>
> > > > >>
> > > >  + /* fdopen stdin */>>
> > > >  + fdopen(0, "r");>>
> > > >  +>>
> > > >  /* Setup the stdout */>>
> > > > >>
> > > >  pstate->cn_outfd = 1;>>
> > > > >>
> > > >  =>>
> > > > >>
> > > >  Thanks,>>
> > > >  SUZUKI Keiji>>
> > > > >>
> > >>
> >>
>


Re: Error with stm32f4discovery:usbnsh

2021-04-20 Thread Alan Carvalho de Assis
Are you getting this error:

"nsh> nsh: nsh_session: readline failed: 9"

Could you please share your .config file?

BR,

Alan

On 4/20/21, Max Kriegleder  wrote:
> Strange.. I have sent two mails prior to this one and apparently they
> did not make it to the list. Trying again:
>
> Were you able to fix this problem? I am running nuttx-10.0.1 on a
> stm32f4discovery board and I have the same issue.
>
> Thanks!
>
>
> On 2021/04/17 22:56:48, Alan Carvalho de Assis  wrote:
>  > I just received it!>
>  >
>  > Try to submit a new email>
>  >
>  > On 4/17/21, Max Kriegleder  wrote:>
>  > > Is anybody reading this? I am not sure why my messages get lost.. how>
>  > > can I post to the message list?>
>  > >>
>  > > On 2020/12/13 22:19:01, Brennan Ashton 
> wrote:>
>  > > > Yeah 100% agree which is why I need to look when I have a little
> more>>
>  > > > time to understand what is going on.>>
>  > > >>
>  > > > On Sun, Dec 13, 2020 at 2:12 PM Gregory Nutt 
> wrote:>>
>  > > > >>>
>  > > > > See>>
>  > > > >>
>  > >
> https://mail-archives.apache.org/mod_mbox/nuttx-dev/202012.mbox/%3CCAKFLXYwes3pcDA2zXsL2FcwgCS4PecdmiP9srkGEtTaOoLEhMg%40mail.gmail.com%3E>>
>
>
>  > >>
>  > >>
>  > > > >>>
>  > > > > I don't think this is the correct solution since with Xiao
> Xiang's>>
>  > > > > recent changes, stdin should never be closed. But it does give
> some>>
>  > > > > clues about the nature of the problem: stdin is no valid;
> stdout is>
>  > > okay>>
>  > > > >>>
>  > > > > On 12/13/2020 4:07 PM, Brennan Ashton wrote:>>
>  > > > > > This is impacting all the usbnsh configurations. I can take
> another>>
>  > > > > > look later this evening>>
>  > > > > > https://github.com/apache/incubator-nuttx/pull/2526>>
>  > > > > >>>
>  > > > > > --Brennan>>
>  > > > > >>>
>  > > > > > On Fri, Dec 11, 2020 at 5:05 AM Gregory Nutt >
>  > > wrote:>>
>  > > > > >> Several other PRs specifically removed support for fclose>
>  > > (stdin). Are>>
>  > > > > >> you certain you want to restore it? I think this needs more>
>  > > analysis>>
>  > > > > >> and resolution with the previous changes that removed the>
>  > > fclose() of>>
>  > > > > >> stdin, stdout, and stderr.>>
>  > > > > 
>  > > > > >> On 12/10/2020 5:37 PM, Masayuki Ishikawa wrote:>>
>  > > > > >>> Suzuki-san,>>
>  > > > > >
>  > > > > >>> Please send a PR (Pull Request) to>>
>  > > > > >>> https://github.com/apache/incubator-nuttx-apps/>>
>  > > > > >
>  > > > > >>> On Thu, Dec 10, 2020 at 5:24 PM SUZUKI Keiji
> >
>  > > wrote:>>
>  > > > > >
>  > > > >  Hi,>>
>  > > > > >>
>  > > > >  I use STM32F407G-DISC1 (MB997D) and build nuttx on macOS>
>  > > Mojave (10.14.6).>>
>  > > > > >>
>  > > > >  The following error occurs with the default configuration
> of>>
>  > > > >  stm32f4discovery:usbnsh.>>
>  > > > > >>
>  > > > >  NuttShell (NSH) NuttX-10.0.0>>
>  > > > >  nsh> nsh: nsh_session: readline failed: 9>>
>  > > > > >>
>  > > > >  The reason seems that instream->fs_fd is -1 instead of 0 in>
>  > > the readline()>>
>  > > > >  function called by>>
>  > > > >  nsh_session().>>
>  > > > > >>
>  > > > >  This error occurs in version 10.0-RC0 and after (I checked>
>  > > 10.0-RC0, 10.0>>
>  > > > >  and current master)>>
>  > > > >  but does not occur in 9.1 and before (I checked 9.1, 8.2 and>
>  > > 7.31).>>
>  > > > > >>
>  > > > >  The following patch fixed it in my environment but I don't>
>  > > know this is a>>
>  > > > >  correct fix.>>
>  > > > > >>
>  > > > >  === from here ===>>
>  > > > > >>
>  > > > >  diff --git a/nshlib/nsh_usbconsole.c
> b/nshlib/nsh_usbconsole.c>>
>  > > > >  index 28f63bcc..768a621b 100644>>
>  > > > >  --- a/nshlib/nsh_usbconsole.c>>
>  > > > >  +++ b/nshlib/nsh_usbconsole.c>>
>  > > > >  @@ -77,8 +77,8 @@>>
>  > > > > >>
>  > > > >  static void nsh_configstdio(int fd, FAR struct
> console_stdio_s>
>  > > *pstate)>>
>  > > > >  {>>
>  > > > >  - /* Make sure the stdout, and stderr are flushed */>>
>  > > > >  ->>
>  > > > >  + /* Make sure the stdin is closed and the stdout, and
> stderr>
>  > > are flushed>>
>  > > > >  */>>
>  > > > >  + fclose(stdin);>>
>  > > > >  fflush(stdout);>>
>  > > > >  fflush(stderr);>>
>  > > > > >>
>  > > > >  @@ -88,6 +88,9 @@ static void nsh_configstdio(int fd, FAR
> struct>>
>  > > > >  console_stdio_s *pstate)>>
>  > > > >  dup2(fd, 1);>>
>  > > > >  dup2(fd, 2);>>
>  > > > > >>
>  > > > >  + /* fdopen stdin */>>
>  > > > >  + fdopen(0, "r");>>
>  > > > >  +>>
>  > > > >  /* Setup the stdout */>>
>  > > > > >>
>  > > > >  pstate->cn_outfd = 1;>>
>  > > > > >>
>  > > > >  =>>
>  > > > > >>
>  > > > >  Thanks,>>
>  > > > >  SUZUKI Keiji>>
>  > > > > >>
>  > > >>
>  > >>
>  >
>


Re: [VOTE] Apache NuttX 10.1.0 (incubating) RC0 release

2021-04-20 Thread Alan Carvalho de Assis
Hi Everyone,

It is important to list the binary size increment for future reference
and to make it easy to track this information:

---

Default esp32-devkitc:nsh

$ ls -l nuttx*
-rwxrwxr-x 1 alan alan  219272 Apr 20 21:17 nuttx
-rwxrwxr-x 1 alan alan  123856 Apr 20 21:17 nuttx.bin

$ xtensa-esp32-elf-size nuttx
   textdata bss dec hex filename
  70572  924976   75640   12778 nuttx

---

Default stm32f4discovery:nsh

$ ls -l nuttx*
-rwxrwxr-x 1 alan alan 173164 Apr 20 21:19 nuttx
-rwxrwxr-x 1 alan alan  68620 Apr 20 21:19 nuttx.bin

$ arm-none-eabi-size nuttx
   textdata bss dec hex filename
  68524  961732   70352   112d0 nuttx

---

Default stm32f103-minimum:nsh

$ ls -l nuttx*
-rwxrwxr-x 1 alan alan 98860 Apr 20 21:21 nuttx
-rwxrwxr-x 1 alan alan 42588 Apr 20 21:21 nuttx.bin

$ arm-none-eabi-size nuttx
   textdata bss dec hex filename
  42480 1081728   44316ad1c nuttx

---

$ arm-none-eabi-gcc -v
gcc version 9.2.1 20191025 (release) [ARM/arm-9-branch revision
277599] (15:9-2019-q4-0ubuntu1)

---

$ xtensa-esp32-elf-gcc -v
gcc version 8.2.0 (crosstool-NG esp-2020r2)


BTW, everything fine!

My vote: +1

BR,

Alan

On 4/18/21, Alin Jerpelea  wrote:
> Hello all,
> Apache NuttX (Incubating) 10.1.0 RC0 has been staged under [1] and it's
> time to vote on accepting it for release. If approved we will seek
> final release approval from the IPMC. Voting will be open for 72hr.
>
> A minimum of 3 binding +1 votes and more binding +1 than binding -1 are
> required to pass.
>
> The Apache requirements for approving a release can be found here [3]
> "Before voting +1 [P]PMC members are required to download the signed
> source code package, compile it as provided, and test the resulting
> executable on their own platform, along with also verifying that the
> package meets the requirements of the ASF policy on releases."
>
> A document to walk through some of this process has been published on
> our project wiki and can be found here [4].
>
> [ ] +1 accept (indicate what you validated - e.g. performed the non-RM
> items in [4])
> [ ] -1 reject (explanation required)
>
> Thank you all,
> Alin Jerpelea
>
> SCM Information:
>   Release tag: nuttx-10.1.0-RC0
>   Hash for the release incubating-nuttx tag:
> f380c919f04d5ee88e0a83f5632cc83af503664f
>   Hash for the release incubating-nuttx-apps tag:
> 4348d91d1356335483089c3865282d80f13bedcd
>
> [1] https://dist.apache.org/repos/dist/dev/incubator/nuttx/10.1.0-RC0/
> [2]https://raw.githubusercontent.com/apache/incubator-nuttx/nuttx-10.1.0-RC0/ReleaseNotes
> [3] https://www.apache.org/dev/release.html#approving-a-release
> [4]https://cwiki.apache.org/confluence/display/NUTTX/Validating+a+staged+Release
>


RE: [VOTE] Apache NuttX 10.1.0 (incubating) RC0 release

2021-04-20 Thread Alin.Jerpelea
Thanks for sharing @Alan Carvalho de Assis

Best regards
Alin

-Original Message-
From: Alan Carvalho de Assis  
Sent: den 21 april 2021 02:27
To: dev@nuttx.apache.org
Subject: Re: [VOTE] Apache NuttX 10.1.0 (incubating) RC0 release

Hi Everyone,

It is important to list the binary size increment for future reference and to 
make it easy to track this information:

---

Default esp32-devkitc:nsh

$ ls -l nuttx*
-rwxrwxr-x 1 alan alan  219272 Apr 20 21:17 nuttx -rwxrwxr-x 1 alan alan  
123856 Apr 20 21:17 nuttx.bin

$ xtensa-esp32-elf-size nuttx
   textdata bss dec hex filename
  70572  924976   75640   12778 nuttx

---

Default stm32f4discovery:nsh

$ ls -l nuttx*
-rwxrwxr-x 1 alan alan 173164 Apr 20 21:19 nuttx -rwxrwxr-x 1 alan alan  68620 
Apr 20 21:19 nuttx.bin

$ arm-none-eabi-size nuttx
   textdata bss dec hex filename
  68524  961732   70352   112d0 nuttx

---

Default stm32f103-minimum:nsh

$ ls -l nuttx*
-rwxrwxr-x 1 alan alan 98860 Apr 20 21:21 nuttx -rwxrwxr-x 1 alan alan 42588 
Apr 20 21:21 nuttx.bin

$ arm-none-eabi-size nuttx
   textdata bss dec hex filename
  42480 1081728   44316ad1c nuttx

---

$ arm-none-eabi-gcc -v
gcc version 9.2.1 20191025 (release) [ARM/arm-9-branch revision 277599] 
(15:9-2019-q4-0ubuntu1)

---

$ xtensa-esp32-elf-gcc -v
gcc version 8.2.0 (crosstool-NG esp-2020r2)


BTW, everything fine!

My vote: +1

BR,

Alan

On 4/18/21, Alin Jerpelea  wrote:
> Hello all,
> Apache NuttX (Incubating) 10.1.0 RC0 has been staged under [1] and 
> it's time to vote on accepting it for release. If approved we will 
> seek final release approval from the IPMC. Voting will be open for 72hr.
>
> A minimum of 3 binding +1 votes and more binding +1 than binding -1 
> are required to pass.
>
> The Apache requirements for approving a release can be found here [3] 
> "Before voting +1 [P]PMC members are required to download the signed 
> source code package, compile it as provided, and test the resulting 
> executable on their own platform, along with also verifying that the 
> package meets the requirements of the ASF policy on releases."
>
> A document to walk through some of this process has been published on 
> our project wiki and can be found here [4].
>
> [ ] +1 accept (indicate what you validated - e.g. performed the non-RM 
> items in [4]) [ ] -1 reject (explanation required)
>
> Thank you all,
> Alin Jerpelea
>
> SCM Information:
>   Release tag: nuttx-10.1.0-RC0
>   Hash for the release incubating-nuttx tag:
> f380c919f04d5ee88e0a83f5632cc83af503664f
>   Hash for the release incubating-nuttx-apps tag:
> 4348d91d1356335483089c3865282d80f13bedcd
>
> [1] 
> https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/inc
> ubator/nuttx/10.1.0-RC0/__;!!JmoZiZGBv3RvKRSx!oRlm_Yz8nkx5UCWqoXWLYVfy
> TMU7M4IvH-o5EoMO2TM4LLPuvAHBvCA2pSuMCYJh0g$
> [2]https://urldefense.com/v3/__https://raw.githubusercontent.com/apach
> e/incubator-nuttx/nuttx-10.1.0-RC0/ReleaseNotes__;!!JmoZiZGBv3RvKRSx!o
> Rlm_Yz8nkx5UCWqoXWLYVfyTMU7M4IvH-o5EoMO2TM4LLPuvAHBvCA2pSsGR_ISXg$
> [3] 
> https://urldefense.com/v3/__https://www.apache.org/dev/release.html*ap
> proving-a-release__;Iw!!JmoZiZGBv3RvKRSx!oRlm_Yz8nkx5UCWqoXWLYVfyTMU7M
> 4IvH-o5EoMO2TM4LLPuvAHBvCA2pSu_x7G6FA$
> [4]https://urldefense.com/v3/__https://cwiki.apache.org/confluence/dis
> play/NUTTX/Validating*a*staged*Release__;Kysr!!JmoZiZGBv3RvKRSx!oRlm_Y
> z8nkx5UCWqoXWLYVfyTMU7M4IvH-o5EoMO2TM4LLPuvAHBvCA2pSuxeoP51Q$
>