CI Broken due to change from Apache Infra
Hey just wanted to give people a heads up. Apache Intra has broken our CI with a change that just landed blocking almost all external Actions which we use in multiple places... You will see an error like this: """ nick-invision/retry@v1 is not allowed to be used in apache/incubator-nuttx. Actions in this workflow must be: created by GitHub, verified in the GitHub Marketplace, within a repository owned by apache or match the following: adoptopenjdk/*, apache/*, gradle/wrapper-validation-action. """ I am looking into what we can do. --Brennan
Re: Move Unity from apps/testing to libs/libtesting?
We can only do so much from the application, we want to have some unit tests for the hardware drivers, that we will also hook to our internal CI. The driver can be instantiated and instead of binding it with an upper layer we use it as part of our testing. We can then have boards' entry points that run the unit tests. At least this is the idea so far. On Mon, Dec 28, 2020 at 8:22 PM Brennan Ashton wrote: > > You would need to explain more. It would be very difficult to separate the > drivers from the underlying hardware interface. What exactly are you > wanting to test? You can always violate the kernel boundary for testing > much like is done with some of the other tests in apps. > > On Mon, Dec 28, 2020, 11:13 AM Abdelatif Guettouche < > abdelatif.guettou...@gmail.com> wrote: > > > The interface is actually configurable. > > > > We want to use that for some unit testing for the drivers, any > > alternatives? > > > > On Mon, Dec 28, 2020, 20:05 Gregory Nutt wrote: > > > > > Unity also uses application only interfaces such as printf() that would > > > be inappropriate for use within the OS. > > > > > > On 12/28/2020 1:00 PM, Brennan Ashton wrote: > > > > I don't think so any testing will be part of an application. There is > > > > nothing in the OS that would ever make use of it directly. Even if you > > > > were to make something like ostest use it the right place would still > > be > > > as > > > > an application. > > > > > > > > --Brennan > > > > > > > > On Mon, Dec 28, 2020, 10:40 AM Abdelatif Guettouche < > > > > abdelatif.guettou...@gmail.com> wrote: > > > > > > > >> Unity (https://github.com/ThrowTheSwitch/Unity) is a test harness > > that > > > >> we can use both for applications and OS code. Isn't it better to have > > > >> it in libs/libtesting instead of apps/testing? > > > >> > > > > > > > >
Re: CI Broken due to change from Apache Infra
Hmm... and I was blaming it on Github... Thanks for the heads up! On Tue, Dec 29, 2020 at 7:23 PM Brennan Ashton wrote: > > Hey just wanted to give people a heads up. Apache Intra has broken > our CI with a change that just landed blocking almost all external > Actions which we use in multiple places... > > You will see an error like this: > """ > nick-invision/retry@v1 is not allowed to be used in > apache/incubator-nuttx. Actions in this workflow must be: created by > GitHub, verified in the GitHub Marketplace, within a repository owned > by apache or match the following: adoptopenjdk/*, apache/*, > gradle/wrapper-validation-action. > """ > > I am looking into what we can do. > > --Brennan
Re: CANFD on ST32H7
Those are both good ideas; thanks for the pointer. My driver is currently based on NuttX 8.2, so I need to rebase and clean some stuff up, but once I do that I will get a PR started. - John On 12/28/20 11:05 AM, Nathan Hartman wrote: On Mon, Dec 28, 2020 at 10:40 AM John Rippetoe wrote: I have actually implemented the FDCAN driver for the H7, but have yet to submit a pull request because of a lingering bug I haven't had the time to sort out. I could clean up my code and push it to personal repo if you wanted to play around with it. Maybe put a REVISIT comment that describes the bug, place it in the code as near to where you believe the bug is as possible, and go ahead and submit a PR and mark it as a draft. Perhaps as part of the review process the cause of the bug will be discovered. As an additional possibility, require EXPERIMENTAL to build the code until the bug is solved. Cheers, Nathan CONFIDENTIALITY NOTICE: This communication may contain private, confidential and privileged material for the sole use of the intended recipient. If you are not the intended recipient, please delete this e-mail and any attachments permanently.
Re: Move Unity from apps/testing to libs/libtesting?
I hope that you assure that this works in the PROTECTED mode. In that mode, tow libraries are built: A kernel library and a user library. On 12/29/2020 2:50 PM, Abdelatif Guettouche wrote: We can only do so much from the application, we want to have some unit tests for the hardware drivers, that we will also hook to our internal CI. The driver can be instantiated and instead of binding it with an upper layer we use it as part of our testing. We can then have boards' entry points that run the unit tests. At least this is the idea so far. On Mon, Dec 28, 2020 at 8:22 PM Brennan Ashton wrote: You would need to explain more. It would be very difficult to separate the drivers from the underlying hardware interface. What exactly are you wanting to test? You can always violate the kernel boundary for testing much like is done with some of the other tests in apps. On Mon, Dec 28, 2020, 11:13 AM Abdelatif Guettouche < abdelatif.guettou...@gmail.com> wrote: The interface is actually configurable. We want to use that for some unit testing for the drivers, any alternatives? On Mon, Dec 28, 2020, 20:05 Gregory Nutt wrote: Unity also uses application only interfaces such as printf() that would be inappropriate for use within the OS. On 12/28/2020 1:00 PM, Brennan Ashton wrote: I don't think so any testing will be part of an application. There is nothing in the OS that would ever make use of it directly. Even if you were to make something like ostest use it the right place would still be as an application. --Brennan On Mon, Dec 28, 2020, 10:40 AM Abdelatif Guettouche < abdelatif.guettou...@gmail.com> wrote: Unity (https://github.com/ThrowTheSwitch/Unity) is a test harness that we can use both for applications and OS code. Isn't it better to have it in libs/libtesting instead of apps/testing?
Re: CI Broken due to change from Apache Infra
The CI should be restored now. You may need to rebase to grab the new configuration if you do not see the build stages running. On Tue, Dec 29, 2020 at 11:56 AM Abdelatif Guettouche wrote: > > Hmm... and I was blaming it on Github... Thanks for the heads up! > > On Tue, Dec 29, 2020 at 7:23 PM Brennan Ashton > wrote: > > > > Hey just wanted to give people a heads up. Apache Intra has broken > > our CI with a change that just landed blocking almost all external > > Actions which we use in multiple places... > > > > You will see an error like this: > > """ > > nick-invision/retry@v1 is not allowed to be used in > > apache/incubator-nuttx. Actions in this workflow must be: created by > > GitHub, verified in the GitHub Marketplace, within a repository owned > > by apache or match the following: adoptopenjdk/*, apache/*, > > gradle/wrapper-validation-action. > > """ > > > > I am looking into what we can do. > > > > --Brennan
