[DISCUSS] Wrapping up the Workflow document

2020-01-24 Thread Nathan Hartman
Hi all,

The proposed Workflow document (see [1]) has a substantial amount of
good information in it.

It is not yet 100% percent complete:
(1) There are several "REVISIT" notes throughout.
(2) A few sections toward the end aren't written yet.

However, by the 80-20 rule, I think the most important parts have been
written, even if some things are rough around the edges.

I have had a LOT of overtime at my $dayjob lately, which has kept me
from working much on NuttX. However, I don't want to let the workflow
fall by the wayside. I would like to get it wrapped up so we can vote
on it soon.

Please, could we have some willing volunteers proofread the document,
fix some of the "REVISIT" parts, and help push this document that last
little bit to get it into a "shippable" state?

[1]
https://cwiki.apache.org/confluence/display/NUTTX/Code+Contribution+Workflow+--+Brennan+Ashton)

Thanks,
Nathan


[GitHub] [incubator-nuttx-testing] maht opened a new pull request #1: Topic dummy 1

2020-01-24 Thread GitBox
maht opened a new pull request #1: Topic dummy 1
URL: https://github.com/apache/incubator-nuttx-testing/pull/1
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-nuttx-testing] maht closed pull request #1: Topic dummy 1

2020-01-24 Thread GitBox
maht closed pull request #1: Topic dummy 1
URL: https://github.com/apache/incubator-nuttx-testing/pull/1
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


CONFIG_NFILE_DESCRIPTORS considerations and limitations

2020-01-24 Thread Florian Wehmeyer



Hi all,

guess this is kind of newbie topic, sorry about that.

I am using current Nuttx 8.x, master branch.

Using a stm32f0l0g0 config (arm cortex-m0), my own custom board with
ARCH_CHIP_STM32F030CC,
means 256KB flash and 32KB RAM, same as the cpu used with the
nucleo-f091rc config (for which appears the same problem, tried this as
I got a nucleo-f091rc board here also..).

Using CONFIG_NFILE_DESCRIPTORS=6, same as all of the stm32f0l0g0 board
configs.

I created a task as builtin app in the nsh. The task needs to open more
than 4 device files,
but when trying to open the 4.th device file, calling
fs/vfs/fs_open.c : open() -> nx_vopen() -> files_allocate(),
the struct filelist will already be full with device inodes
(>CONFIG_NFILE_DESCRIPTORS),
returning EMFILE error
because the first 3 inodes are already set with stdin, stdout, sterr
(correct?), and then the 3 of my first device nodes.


I am using 4 buttons, and another device, and for each button a device
node, this is why I need that "much" file descriptors for that single task.

So, now my questions are:
1) am I doing bad practice, opening that much file descriptors per task?
if yes, I could open and close them on each access, which is actually
each 100ms, if that would be less overhead (guess not).

2)Of course I tried to set CONFIG_NFILE_DESCRIPTORS=8, but when I do that,
the system jumps into  arch/arm/src/armv6-m/up_assert.c :_up_assert(),
before even finishing
nx_start().
Is there anything else that must be considered when increasing the
CONFIG_NFILE_DESCRIPTORS?
Seems that it happens something like stack corruption..
Increased also
CONFIG_USERMAIN_STACKSIZE=2048
and the stacksize of my task,
no success..

I am really not using a lot of resources:
nsh> free
             total       used       free    largest
Umem:        26144      10088      16056      14120

flow@flowI3:~/work/nuttx/nx8.2git/nuttx$ arm-none-eabi-size nuttx
   text   data    bss    dec    hex filename
  67539    156   4340  72035  11963 nuttx

Thanks a lot for any help or suggestions.


--
Florian Wehmeyer
TFW Tech Solutions



Re: CONFIG_NFILE_DESCRIPTORS considerations and limitations

2020-01-24 Thread Gregory Nutt




1) am I doing bad practice, opening that much file descriptors per task?
if yes, I could open and close them on each access, which is actually
each 100ms, if that would be less overhead (guess not).
No, it is perfectly fine to change the number of descriptors, provided 
that you have at least 3.


2)Of course I tried to set CONFIG_NFILE_DESCRIPTORS=8, but when I do 
that,

the system jumps into  arch/arm/src/armv6-m/up_assert.c :_up_assert(),
before even finishing
nx_start().
Is there anything else that must be considered when increasing the
CONFIG_NFILE_DESCRIPTORS?


No, other than it will greatly increase memory usage.  That is a big 
deal on that platform.


Check CONFIG_STDIO_BUFFER_SIZE, the increased memory usage will go into 
(1) file descriptor structures, and (2) buffers for C-buffered I/O. You 
can set CONFIG_STDIO_BUFFER_SIZE as low as zero, but then you will have 
no buffering that that will affect realtime preformance.


Greg