[GitHub] [incubator-nuttx-website] huahang commented on issue #8: Update contributors information and alphabetize

2020-01-05 Thread GitBox
huahang commented on issue #8: Update contributors information and alphabetize
URL: 
https://github.com/apache/incubator-nuttx-website/pull/8#issuecomment-570901800
 
 
   LGTM


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-nuttx-website] huahang commented on issue #7: Add publisher script

2020-01-05 Thread GitBox
huahang commented on issue #7: Add publisher script
URL: 
https://github.com/apache/incubator-nuttx-website/pull/7#issuecomment-570901797
 
 
   LGTM


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-nuttx-website] huahang commented on issue #6: publish the website

2020-01-05 Thread GitBox
huahang commented on issue #6: publish the website
URL: 
https://github.com/apache/incubator-nuttx-website/pull/6#issuecomment-570903011
 
 
   @btashton The `publish.sh` script looks cool! :-) I think the orphan branch 
makes sense. But it seems that Github won't allow a PR from an orphan branch 
against the current `asf-site` branch since they don't have a common ancestor. 
Is it possible to do a git push -f? I don't know. I don't have write access to 
this repo. >_<


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-nuttx-website] huahang closed pull request #6: publish the website

2020-01-05 Thread GitBox
huahang closed pull request #6: publish the website
URL: https://github.com/apache/incubator-nuttx-website/pull/6
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-nuttx-website] huahang commented on issue #7: Add publisher script

2020-01-05 Thread GitBox
huahang commented on issue #7: Add publisher script
URL: 
https://github.com/apache/incubator-nuttx-website/pull/7#issuecomment-570908074
 
 
   @btashton Hi Brennan, I tried the `publish.sh` script. I think the link to 
the original version is very nice~
   :-)
   
   One thing I've noticed is that this script will put the generated files 
inside a `content` folder like the Apache Daffodil project [1]. This is 
different from the Apache brpc project which places the files in `asf-site`'s 
root folder. Maybe both are supported. We may want to have a try after your 
other 2 PRs are merged.
   :-P
   
   [1]. https://github.com/apache/incubator-daffodil-site/tree/asf-site
   [2]. https://github.com/apache/incubator-brpc-website/tree/asf-site
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-nuttx-website] huahang edited a comment on issue #7: Add publisher script

2020-01-05 Thread GitBox
huahang edited a comment on issue #7: Add publisher script
URL: 
https://github.com/apache/incubator-nuttx-website/pull/7#issuecomment-570908074
 
 
   @btashton Hi Brennan, I tried the `publish.sh` script. I think the link to 
the original version is very nice~
   :-)
   
   One thing I've noticed is that this script will put the generated files 
inside a `content` folder like the Apache Daffodil project [1]. This is 
different from the Apache brpc project which places the files in `asf-site`'s 
root folder [2]. Maybe both are supported. We may want to have a try after your 
other 2 PRs are merged.
   :-P
   
   [1]. https://github.com/apache/incubator-daffodil-site/tree/asf-site
   [2]. https://github.com/apache/incubator-brpc-website/tree/asf-site
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-nuttx-website] huahang edited a comment on issue #7: Add publisher script

2020-01-05 Thread GitBox
huahang edited a comment on issue #7: Add publisher script
URL: 
https://github.com/apache/incubator-nuttx-website/pull/7#issuecomment-570908074
 
 
   @btashton Hi Brennan, I tried the `publish.sh` script. I think the link to 
the original version is very nice~
   :-)
   
   One thing I've noticed is that this script will put the generated files 
inside a `content` folder like the Apache Daffodil project [1]. This is 
different from the Apache brpc project which places the files in `asf-site`'s 
root folder [2]. Maybe both are supported. We may want to have a try after your 
other 2 PRs are merged.
   :-P
   
   [1](https://github.com/apache/incubator-daffodil-site/tree/asf-site)
   [2](https://github.com/apache/incubator-brpc-website/tree/asf-site)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-nuttx-website] huahang edited a comment on issue #7: Add publisher script

2020-01-05 Thread GitBox
huahang edited a comment on issue #7: Add publisher script
URL: 
https://github.com/apache/incubator-nuttx-website/pull/7#issuecomment-570908074
 
 
   @btashton Hi Brennan, I tried the `publish.sh` script. I think the link to 
the original version is very nice~
   :-)
   
   One thing I've noticed is that this script will put the generated files 
inside a `content` folder like the Apache Daffodil project [1]. This is 
different from the Apache brpc project which places the files in `asf-site`'s 
root folder [2]. Maybe both are supported. We may want to have a try after your 
other 2 PRs are merged.
   :-P
   
   [1] https://github.com/apache/incubator-daffodil-site/tree/asf-site
   [2] https://github.com/apache/incubator-brpc-website/tree/asf-site
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-nuttx-website] huahang edited a comment on issue #7: Add publisher script

2020-01-05 Thread GitBox
huahang edited a comment on issue #7: Add publisher script
URL: 
https://github.com/apache/incubator-nuttx-website/pull/7#issuecomment-570908074
 
 
   @btashton Hi Brennan, I tried the `publish.sh` script. I think the link to 
the original version is very nice~
   :-)
   
   One thing I've noticed is that this script will put the generated files 
inside a `content` folder like the Apache Daffodil project [1]. This is 
different from the Apache brpc project which places the files in `asf-site`'s 
root folder [2]. Maybe both are supported. We may want to have a try after your 
other 2 PRs are merged.
   :-P
   
   [1]: https://github.com/apache/incubator-daffodil-site/tree/asf-site
   [2]: https://github.com/apache/incubator-brpc-website/tree/asf-site
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-nuttx-website] huahang edited a comment on issue #7: Add publisher script

2020-01-05 Thread GitBox
huahang edited a comment on issue #7: Add publisher script
URL: 
https://github.com/apache/incubator-nuttx-website/pull/7#issuecomment-570908074
 
 
   @btashton Hi Brennan, I tried the `publish.sh` script. I think the link to 
the original version is very nice~
   :-)
   
   One thing I've noticed is that this script will put the generated files 
inside a `content` folder like the Apache Daffodil project [1]. This is 
different from the Apache brpc project which places the files in `asf-site`'s 
root folder [2]. Maybe both are supported. We may want to have a try after your 
other 2 PRs are merged.
   :-P
   
   [1] https://github.com/apache/incubator-daffodil-site/tree/asf-site
   [2] https://github.com/apache/incubator-brpc-website/tree/asf-site
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-nuttx-website] xiaoxiang781216 commented on a change in pull request #8: Update contributors information and alphabetize

2020-01-05 Thread GitBox
xiaoxiang781216 commented on a change in pull request #8: Update contributors 
information and alphabetize
URL: 
https://github.com/apache/incubator-nuttx-website/pull/8#discussion_r363093639
 
 

 ##
 File path: _data/contributors.yml
 ##
 @@ -18,82 +18,88 @@
 # Please keep the list in alphabetical order.
 #
 
+- name: Abdelatif Guettouche
+  apacheId: aguettouche
+  githubId: Ouss4
+  role: PPMC, Committer
+  org:
+
 - name: Alan Carvalho de Assis
   apacheId: acassis
   githubId: acassis
-  role: Committer
+  role: PPMC, Committer
   org:
 
-- name: Abdelatif Guettouche
-  apacheId: aguettouche
-  githubId: Ouss4
-  role: Committer
+- name:Alin Jerpelea
 
 Review comment:
   remove the extra space?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-nuttx-website] xiaoxiang781216 commented on a change in pull request #8: Update contributors information and alphabetize

2020-01-05 Thread GitBox
xiaoxiang781216 commented on a change in pull request #8: Update contributors 
information and alphabetize
URL: 
https://github.com/apache/incubator-nuttx-website/pull/8#discussion_r363093568
 
 

 ##
 File path: _data/contributors.yml
 ##
 @@ -18,82 +18,88 @@
 # Please keep the list in alphabetical order.
 #
 
+- name: Abdelatif Guettouche
+  apacheId: aguettouche
+  githubId: Ouss4
+  role: PPMC, Committer
+  org:
+
 - name: Alan Carvalho de Assis
   apacheId: acassis
   githubId: acassis
-  role: Committer
+  role: PPMC, Committer
   org:
 
-- name: Abdelatif Guettouche
-  apacheId: aguettouche
-  githubId: Ouss4
-  role: Committer
+- name:Alin Jerpelea
+  apacheId: jerpelea
+  githubId: jerpelea
+  role: PPMC, Committer
   org:
 
 - name: Anthony Merlino
   apacheId: antmerlino
   githubId: antmerlino
-  role: Committer
+  role: PPMC, Committer
   org:
 
-- name: Mohammad Asif Siddiqui
-  apacheId: asifdxtreme
-  githubId: asifdxtreme
-  role: Mentor
+- name: Brennan Ashton
+  apacheId: btashton
+  githubId: btashton
+  role: Committer
   org:
 
 - name: David Sidrane
   apacheId: davids5
   githubId: davids5
-  role: Committer
+  role: PPMC, Committer
   org:
 
 - name:Flavio Paiva Junqueira
 
 Review comment:
   remove the extra space?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-nuttx] patacongo merged pull request #39: Implement QSPI for STM32H7

2020-01-05 Thread GitBox
patacongo merged pull request #39: Implement QSPI for STM32H7
URL: https://github.com/apache/incubator-nuttx/pull/39
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-nuttx-website] xiaoxiang781216 commented on issue #6: publish the website

2020-01-05 Thread GitBox
xiaoxiang781216 commented on issue #6: publish the website
URL: 
https://github.com/apache/incubator-nuttx-website/pull/6#issuecomment-570913628
 
 
   Let's me delete and recreate asf-site as an empty branch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


RE: NX Graphics

2020-01-05 Thread disruptivesolutionsnl
Oke I think I am getting somewhere

Priv has (during lcd_framebuffer):
fblen -> 153600
xres -> 320
yres -> 240
stride -> 640
display -> 0 '\0'

fbmem = 0x0
*fbmem -> 72 'H'

But it stil runs into this error:
priv->fbmem  = (FAR uint8_t *)kmm_zalloc(priv->fblen);
  if (priv->fbmem == NULL)
{
--?>  lcderr("ERROR: Failed to allocate frame buffer memory\n");

What am I overlooking here? Yes fbmem is 0... .

Total;  used; free; largest;
  
Umem:   191920   7568 184352 124192

Ben

-Oorspronkelijk bericht-
Van: Gregory Nutt  
Verzonden: zaterdag 4 januari 2020 22:39
Aan: dev@nuttx.apache.org
Onderwerp: Re: NX Graphics


> Priv->fblen = 0

Trying to allocate a buffer of zero length will return  the value NULL too.





Re: NX Graphics

2020-01-05 Thread Gregory Nutt
You need to allocate **contiguous** memory for the framebuffer.  The 
largest contiguous region in the heap has size 124,192 bytes.  You can 
allocate nothing larger than that.


The size of the framebuffer you are tying to allocate is 153,600 bytes.  
So any attempt to allocate that framebuffer from that heap will fail.


On 1/5/2020 7:49 AM, disruptivesolution...@gmail.com wrote:

Oke I think I am getting somewhere

Priv has (during lcd_framebuffer):
fblen -> 153600
xres -> 320
yres -> 240
stride -> 640
display -> 0 '\0'

fbmem = 0x0
*fbmem -> 72 'H'

But it stil runs into this error:
priv->fbmem  = (FAR uint8_t *)kmm_zalloc(priv->fblen);
   if (priv->fbmem == NULL)
 {
--?>  lcderr("ERROR: Failed to allocate frame buffer memory\n");

What am I overlooking here? Yes fbmem is 0... .

 Total;  used; free; largest;
Umem:   191920   7568 184352 124192

Ben

-Oorspronkelijk bericht-
Van: Gregory Nutt 
Verzonden: zaterdag 4 januari 2020 22:39
Aan: dev@nuttx.apache.org
Onderwerp: Re: NX Graphics



Priv->fblen = 0

Trying to allocate a buffer of zero length will return  the value NULL too.







Re: NX Graphics

2020-01-05 Thread Disruptive Solutions
Ahhh so say FSMC with say a DS3231 I2C Precision Clock with AT24C32 Memory???

The resources onboard are insufficient...?

Ben

Verstuurd vanaf mijn iPhone

> Op 5 jan. 2020 om 14:53 heeft Gregory Nutt  het volgende 
> geschreven:
> 
> You need to allocate **contiguous** memory for the framebuffer.  The largest 
> contiguous region in the heap has size 124,192 bytes.  You can allocate 
> nothing larger than that.
> 
> The size of the framebuffer you are tying to allocate is 153,600 bytes.  So 
> any attempt to allocate that framebuffer from that heap will fail.
> 
>> On 1/5/2020 7:49 AM, disruptivesolution...@gmail.com wrote:
>> Oke I think I am getting somewhere
>> 
>> Priv has (during lcd_framebuffer):
>> fblen -> 153600
>> xres -> 320
>> yres -> 240
>> stride -> 640
>> display -> 0 '\0'
>> 
>> fbmem = 0x0
>> *fbmem -> 72 'H'
>> 
>> But it stil runs into this error:
>> priv->fbmem  = (FAR uint8_t *)kmm_zalloc(priv->fblen);
>>   if (priv->fbmem == NULL)
>> {
>> --?>  lcderr("ERROR: Failed to allocate frame buffer memory\n");
>> 
>> What am I overlooking here? Yes fbmem is 0... .
>> 
>> Total;  used; free; largest;
>> Umem:   191920   7568 184352 124192
>> 
>> Ben
>> 
>> -Oorspronkelijk bericht-
>> Van: Gregory Nutt 
>> Verzonden: zaterdag 4 januari 2020 22:39
>> Aan: dev@nuttx.apache.org
>> Onderwerp: Re: NX Graphics
>> 
>> 
>>> Priv->fblen = 0
>> Trying to allocate a buffer of zero length will return  the value NULL too.
>> 
>> 
>> 
> 


[GitHub] [incubator-nuttx-website] xiaoxiang781216 commented on issue #7: Add publisher script

2020-01-05 Thread GitBox
xiaoxiang781216 commented on issue #7: Add publisher script
URL: 
https://github.com/apache/incubator-nuttx-website/pull/7#issuecomment-570918462
 
 
   > I have an example of a orphaned asf-site branch as well that I would 
recommend we use as a starting branch. Someone would need to force it over the 
existing asf-site branch that is based on master.
   > 
   
   @btashton I just recreate a ampty asf-site branch, please try it.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


Re: Bug tracking

2020-01-05 Thread Xiang Xiao
But, I think that the user who hasn't an apache account can't create
an issue in JIRA.

On Sun, Jan 5, 2020 at 10:51 AM Gregory Nutt  wrote:
>
>
> >>> Maybe people should not file a bug for hardware-specific issues that
> >>> affect only their specific configuration. As you point out, it is
> >>> unlikely that anyone else will be able to fix or test such an issue.
> >>> So, for those cases, maybe we should encourage people not to file an
> >>> issue but rather to fix it right away, and help in any way possible.
> >>>
> >>> In contrast, for things that affect the RTOS itself, build system,
> >>> etc., we would let people file issues.
> >> I think that keeping track of issues, prioritized and categorized by
> >> sub-system and platform would be of benefit to many users. Attempt to
> >> fix every bug on every hardware configuration is not humanly possible.
> >> I think fixing bugs would have to be like committers responding to PRs:
> >> People will have have "scratch what itches" (or something like that).
> >> But just knowing that something has a bug is useful information to users.
> > I dont know how github issues work but I know that in Jira, issues can be
> > tagged with any number of "tags". Then you can filter by tags and see all
> > issues with that tag.
> >
> > Utilizing this feature, we could have a tag for each supported MCU, and a
> > tag for each supported board.
> >
> > When someone is thinking of using NuttX for their project with a particular
> > board, they could look up the known issues and then make an informed
> > decision if those issues might affect their project and, if so, if they are
> > willing to scratch that itch and fix that issue.
> >
> > Then obviously what I said before no longer applies and we would encourage
> > people to file issues provided they tag them correctly.
>
> I like that idea of tagging issues.  That could prove very useful.
> Doesn't github support user-defined tags?  I have never used them, but
> they seem a little primitive from what I have read.  The issues in the
> top-level TODO list are not tagged, but grouped by functional areas and
> would be unusable if they were not so grouped.  A long list of old
> ungrouped, untagged github issues would be similarly useless.
>
> I am not a big fan of selecting a tools then defining your management
> processes to match the tool.  I prefer to think the other way around.  I
> spent decades as as system engineer and system architect and I have
> top-down thinking in my bones.
>
> I really don't know anything of significance about Jira so it would be
> irresponsible for me to advocate anything either way. Github issues are
> great places for discussing current topics.  I am more familiar with
> Bitbucket issues, and I assume they are similar.  My experience is that
> if no one takes immediate action on an issue, it lingers, people lose
> interest, and the issue fades from group memory.  Then years later they
> are there in the issue list, out of context, possibly inactionable.
>
> Issues are good for the immediate reactions to and dialog about an
> issue.  But that doesn't it really constitutes management of issues.
>
> At one point Brennan demonstrated that you can link a Jira issue to a
> PR.  I wonder... can you also link a Jira issue to a github issue.  If
> so, then why not use both?  Users could enter issues into Github, email,
> or Jirah.  Github issues could support some dialog.  Jira might then
> provide the missing project management component.
>
> And what do we do with the old issues still in the Bitbucket Issues?  Or
> the issues in the TODO list.  There are usually issues raised in emails
> on  daily basis.  Most of the time, these are worked out through through
> email exchanges, others are not and are just forgotten.
>
> Greg
>
>


[GitHub] [incubator-nuttx-website] btashton commented on issue #7: Add publisher script

2020-01-05 Thread GitBox
btashton commented on issue #7: Add publisher script
URL: 
https://github.com/apache/incubator-nuttx-website/pull/7#issuecomment-570921968
 
 
   I just tweaked it to include the asf.yaml
   @huahang can you use the publish script to create a PR against it now? 
(Probably need to hard reset your local asf-site branch)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


Re: Bug tracking

2020-01-05 Thread Gregory Nutt




But, I think that the user who hasn't an apache account can't create
an issue in JIRA.

I don't think that is true, is it?  I think it is role-based: 
https://cwiki.apache.org/confluence/display/INFRA/Role+Based+JIRA+Authorization


It looks like any registered user (even non-committers) can create and 
link issues, add comments to issues, add attachments to issues.  Looks 
like it would work fine.


If Jira is linked to github issues, then users could create issues via 
github and the PPMC could track everything in Jira.




Re: Bug tracking

2020-01-05 Thread Gregory Nutt






But, I think that the user who hasn't an apache account can't create
an issue in JIRA.

I don't think that is true, is it?  I think it is role-based: 
https://cwiki.apache.org/confluence/display/INFRA/Role+Based+JIRA+Authorization


It looks like any registered user (even non-committers) can create and 
link issues, add comments to issues, add attachments to issues.  Looks 
like it would work fine.


If Jira is linked to github issues, then users could create issues via 
github and the PPMC could track everything in Jira.


In that reference web page, there is also something called the 
Contributor's role that has almost as many privileges as a committer 
does.  I am not exactly sure what a Contributor role is.  I suppose it 
is a role that we could assign to any trusted contributor?






[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #40: Format all shell scripts in tools folder

2020-01-05 Thread GitBox
xiaoxiang781216 opened a new pull request #40: Format all shell scripts in 
tools folder
URL: https://github.com/apache/incubator-nuttx/pull/40
 
 
   Change-Id: Ieef2eb93d56c03972b4dc63a1c55aabf1fb0d169
   Signed-off-by: Xiang Xiao 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-nuttx] patacongo merged pull request #40: Format all shell scripts in tools folder

2020-01-05 Thread GitBox
patacongo merged pull request #40: Format all shell scripts in tools folder
URL: https://github.com/apache/incubator-nuttx/pull/40
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-nuttx] patacongo commented on issue #40: Format all shell scripts in tools folder

2020-01-05 Thread GitBox
patacongo commented on issue #40: Format all shell scripts in tools folder
URL: https://github.com/apache/incubator-nuttx/pull/40#issuecomment-570928984
 
 
   If there is a coding standard for shell scripts, we should document it.
   Or was this done using a tool?  If a tools was used, we should document the 
tool.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-nuttx-website] xiaoxiang781216 merged pull request #8: Update contributors information and alphabetize

2020-01-05 Thread GitBox
xiaoxiang781216 merged pull request #8: Update contributors information and 
alphabetize
URL: https://github.com/apache/incubator-nuttx-website/pull/8
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-nuttx-website] xiaoxiang781216 merged pull request #9: Update community page issue and repo references

2020-01-05 Thread GitBox
xiaoxiang781216 merged pull request #9: Update community page issue and repo 
references
URL: https://github.com/apache/incubator-nuttx-website/pull/9
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #40: Format all shell scripts in tools folder

2020-01-05 Thread GitBox
xiaoxiang781216 commented on issue #40: Format all shell scripts in tools folder
URL: https://github.com/apache/incubator-nuttx/pull/40#issuecomment-570938662
 
 
   > If there is a coding standard for shell scripts, we should document it.
   > Or was this done using a tool? If a tools was used, we should document the 
tool.
   
   The script has the different style:
   1.Some use tab, other use space for indent
   2.Some indent use two spaces, other use three/four spaces
   My change unify all to 2 spaces like C style.
   It's better to follow the C style with the addition for the special syntax 
constructure.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


netlink_crypo Branch

2020-01-05 Thread Gregory Nutt

Hi, Xiao Xiand and Guiding Li,

I created the netlink_crypto branch several months back to help you 
integrate some crypto logic.  Do you still need that branch. I am trying 
to keep it up to date with master, but that is getting more difficult as 
time goes by.


If you don't plan to use this branch in the near future, I propose that 
I archive the changes and delete the branch.  I will be able to 
re-create a fresh, clean, up-to-date netlink_crypto branch for you in 
the future when you are ready to use it.


Please let me know,

Greg




[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #37: Improvements for NRF52

2020-01-05 Thread GitBox
xiaoxiang781216 commented on issue #37: Improvements for NRF52
URL: https://github.com/apache/incubator-nuttx/pull/37#issuecomment-570942572
 
 
   I don't have the magic script either:(: only single line functions are 
replaced by the command automatically, other functions spread the multiple 
lines are done manually. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


Re: netlink_crypo Branch

2020-01-05 Thread Xiang Xiao
Guiding doesn't have the free time to finish netlink crypto in the
near future. It's fine to delete the branch now.

Thanks
Xiang

On Mon, Jan 6, 2020 at 3:11 AM Gregory Nutt  wrote:
>
> Hi, Xiao Xiand and Guiding Li,
>
> I created the netlink_crypto branch several months back to help you
> integrate some crypto logic.  Do you still need that branch. I am trying
> to keep it up to date with master, but that is getting more difficult as
> time goes by.
>
> If you don't plan to use this branch in the near future, I propose that
> I archive the changes and delete the branch.  I will be able to
> re-create a fresh, clean, up-to-date netlink_crypto branch for you in
> the future when you are ready to use it.
>
> Please let me know,
>
> Greg
>
>


Re: netlink_crypo Branch

2020-01-05 Thread Gregory Nutt




Guiding doesn't have the free time to finish netlink crypto in the
near future. It's fine to delete the branch now.


Okay.. it has been deleted.

Greg



Strange things in git repositories?

2020-01-05 Thread Nathan Hartman
Something strange is happening with the git repositories.

Several times recently, I have seen things inexplicably disappear and reappear.

For example:

Commit # 9e091d2027a42fbec14555ae98c76e7579cd8b8e,
"Improvements for NRF52 (#37)"

Adds these files:
* arch/arm/src/nrf52/hardware/nrf52_gpiote.h
* arch/arm/src/nrf52/hardware/nrf52_saadc.h
* arch/arm/src/nrf52/nrf52_i2c.c
* arch/arm/src/nrf52/nrf52_i2c.h

And modifies these files:
* arch/arm/src/nrf52/hardware/nrf52_gpio.h
* arch/arm/src/nrf52/hardware/nrf52_spi.h
* arch/arm/src/nrf52/hardware/nrf52_twi.h
* arch/arm/src/nrf52/hardware/nrf52_uarte.h
* arch/arm/src/nrf52/nrf52_gpio.c
* arch/arm/src/nrf52/nrf52_gpio.h
* arch/arm/src/nrf52/nrf52_lowputc.c
* arch/arm/src/nrf52/nrf52_lowputc.h
* arch/arm/src/nrf52/nrf52_serial.c

Now see the commit after it, 7da409f3b53b4d2607b4551b059abb69ad3ad33b,
"tools/nxstyle.c: Add -r option to check specified range lines"

According to 'git show', it modifies these files:
* tools/README.txt
* tools/nxstyle.c

There is no mention of any other files.

No files are supposed to be added.

No files are supposed to be deleted.

However, try this:

$ git checkout 9e091d2027a42fbec14555ae98c76e7579cd8b8e

$ ls arch/arm/src/nrf52/hardware/nrf52_gpiote.h
arch/arm/src/nrf52/hardware/nrf52_gpiote.h

The file is there. Now checkout the next commit:

$ git checkout 7da409f3b53b4d2607b4551b059abb69ad3ad33b

$ ls arch/arm/src/nrf52/hardware/nrf52_gpiote.h
ls: cannot access 'arch/arm/src/nrf52/hardware/nrf52_gpiote.h': No
such file or directory

The file is gone!

Now checkout the next commit, 3951c4de5af427b204b77ae484fbd8175ed07842:

$ git checkout 3951c4de5af427b204b77ae484fbd8175ed07842
$ ls arch/arm/src/nrf52/hardware/nrf52_gpiote.h
arch/arm/src/nrf52/hardware/nrf52_gpiote.h

The file is back.

Why are files (and modifications) disappearing and reappearing from
one commit to the next?

Nathan


Re: Bug tracking

2020-01-05 Thread Justin Mclean
Hi,

You don’t need an apache account to raise either a GitHub issue or a JIRA 
issues.

> In that reference web page, there is also something called the Contributor's 
> role that has almost as many privileges as a committer does.  I am not 
> exactly sure what a Contributor role is.  I suppose it is a role that we 
> could assign to any trusted contributor?

Correct.

Thanks,
Justin

Re: netlink_crypo Branch

2020-01-05 Thread Justin Mclean
Hi,

What if someone else in the community decided they could work on this? 
Generally you would want to wait 72 hours before making decision list this as 
that gives people (in different time zones or who don’t work full time on the 
project) to respond. Having unfinished tasks is OK and someone in the future 
may decide to work on them.

Thanks,
Justin

Re: Strange things in git repositories?

2020-01-05 Thread Justin Mclean
HI,

I not looked into it in detail, but if may be due to the use of —force, from 
one of the GitHub messages:

"This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version.  This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:”

Thanks,
Justin



Re: Strange things in git repositories?

2020-01-05 Thread Nathan Hartman
On Sun, Jan 5, 2020 at 3:49 PM Justin Mclean 
wrote:

> HI,
>
> I not looked into it in detail, but if may be due to the use of —force,
> from one of the GitHub messages:
>
> "This update added new revisions after undoing existing revisions.
> That is to say, some revisions that were in the old version of the
> branch are not in the new version.  This situation occurs
> when a user --force pushes a change and generates a repository
> containing something like this:”


And this is on the MASTER branch!

And I wonder, why isn't 'git show' showing this. You think you'll get one
thing when you checkout a commit, then you get other side effects.

Nathan


[GitHub] [incubator-nuttx-website] justinmclean commented on issue #7: Add publisher script

2020-01-05 Thread GitBox
justinmclean commented on issue #7: Add publisher script
URL: 
https://github.com/apache/incubator-nuttx-website/pull/7#issuecomment-570947320
 
 
   Hi,
   > One thing I've noticed is that this script will put the generated files 
inside a content folder like the Apache Daffodil project [1]. This is different 
from the Apache brpc project which places the files in asf-site's root folder. 
Maybe both are supported. We may want to have a try after your other 2 PRs are 
merged.
   > :-P
   > 
   
   Both are supported, but the content folder being special may go away at some 
point in the future. (In fact if you make a directory anywhere called content 
it will replace your web site, I found that out the hard way a few months back.)
   
   Thanks,
   Justin


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


Re: Strange things in git repositories?

2020-01-05 Thread Gregory Nutt



Something strange is happening with the git repositories.

Several times recently, I have seen things inexplicably disappear and reappear.


You had me going with that.  The answer is that the order of the commits 
is not in date order.  Look:


   commit 3951c4de5af427b204b77ae484fbd8175ed07842
   Merge: 7da409f3b5 9e091d2027
   Author: Gregory Nutt 
   Date:   Sat Jan 4 07:58:30 2020 -0600

    Merge branch 'master' of github.com:apache/incubator-nuttx

   commit 7da409f3b53b4d2607b4551b059abb69ad3ad33b
   Author: liuhaitao 
   Date:   Thu Jan 2 17:22:08 2020 +0800

   commit 9e091d2027a42fbec14555ae98c76e7579cd8b8e
   Author: Mateusz Szafoni 
   Date:   Sat Jan 4 09:44:00 2020 -0300

Is it possible that the local clone was unclean when commit 
7da409f3b53b4d2607b4551b059abb69ad3ad33b was made?  I did that one, I 
don't think that was ever the case.


Again 'git show 7da409f3b53b4d2607b4551b059abb69ad3ad33b' shows no problem.

7da409f3b53b4d2607b4551b059abb69ad3ad33b was committed on Jan 2, 
9e091d2027a42fbec14555ae98c76e7579cd8b8e was committed on Jan 2. So the 
order of the commits in 'git log' does not reflect the date order.


Also lock at the github.com/apache/incubator-nuttx.  Look at the last 
commit.  It has two parents (because it was merged) follow the left 
parent back to 3951c4d: 
https://github.com/apache/incubator-nuttx/commit/3951c4de5af427b204b77ae484fbd8175ed07842


Notice that it has two parents: 7da409f 
 
+ 9e091d2 



That is where the merge occurred and the two commits from different 
times were merge into commit order.  Try this:


   git log --date-order.

That will be clearly and will behave as you expect, 7da409f 
 
and 9e091d2 
swap 
positions and if you follow that you will see that nothing disappeared.. 
You were jumpting backwared in time


Greg






Re: Strange things in git repositories?

2020-01-05 Thread Gregory Nutt




I not looked into it in detail, but if may be due to the use of —force, from 
one of the GitHub messages:

No, --force was never used.  There is nothing wrong with the 
repositories.  Nathan is expecting date-order, not commit-order


Re: Strange things in git repositories?

2020-01-05 Thread Gregory Nutt




And this is on the MASTER branch!

The master branch is perfect!  No problems.

And I wonder, why isn't 'git show' showing this. You think you'll get one
thing when you checkout a commit, then you get other side effects.


Get show is working correctly.  But you are making the wrong assumption 
about the ordering of commits in the repository.


Greg



Re: Strange things in git repositories?

2020-01-05 Thread Nathan Hartman
On Sun, Jan 5, 2020 at 4:04 PM Gregory Nutt  wrote:
> > And this is on the MASTER branch!
> The master branch is perfect!  No problems.
> > And I wonder, why isn't 'git show' showing this. You think you'll get one
> > thing when you checkout a commit, then you get other side effects.
>
> Get show is working correctly.  But you are making the wrong assumption
> about the ordering of commits in the repository.

Ok, thank you for clearing that up!

I'll use 'git log --date-order' from now on...

I suppose this was never necessary in the past because you were the
only one making commits...

Thanks again,
Nathan


Re: Strange things in git repositories?

2020-01-05 Thread Nathan Hartman
On Sun, Jan 5, 2020 at 4:11 PM Nathan Hartman  wrote:
>
> On Sun, Jan 5, 2020 at 4:04 PM Gregory Nutt  wrote:
> > > And this is on the MASTER branch!
> > The master branch is perfect!  No problems.
> > > And I wonder, why isn't 'git show' showing this. You think you'll get one
> > > thing when you checkout a commit, then you get other side effects.
> >
> > Get show is working correctly.  But you are making the wrong assumption
> > about the ordering of commits in the repository.
>
> Ok, thank you for clearing that up!
>
> I'll use 'git log --date-order' from now on...

Nope. That gives the same results, almost.

$ git log master --oneline --date-order > date-order.txt
$ git log master --oneline  > commit-order.txt
$ diff date-order.txt commit-order.txt

Everything identical for the first 8696 commits listed.

Only at commit c3d76d56bc there is one change of ordering, and then
some others much farther down the list.

But the recent commits that I was referring to are shown the same
whether --date-order or not.

Hmmm

Nathan


Re: Strange things in git repositories?

2020-01-05 Thread Gregory Nutt




But the recent commits that I was referring to are shown the same
whether --date-order or not.


Sorry, --date-order is the default, commit timestamp order.  I meant 
--author-date-order, author timestamp order.  Summarized:


$ git log

commit 3951c4de5af427b204b77ae484fbd8175ed07842
Merge: 7da409f3b5 9e091d2027
Date:   Sat Jan 4 07:58:30 2020 -0600

commit 7da409f3b53b4d2607b4551b059abb69ad3ad33b
Date:   Thu Jan 2 17:22:08 2020 +0800

commit 9e091d2027a42fbec14555ae98c76e7579cd8b8e
Author: Mateusz Szafoni 
Date:   Sat Jan 4 09:44:00 2020 -0300

$ git log --author-date-order

commit 3951c4de5af427b204b77ae484fbd8175ed07842
Merge: 7da409f3b5 9e091d2027
Date:   Sat Jan 4 07:58:30 2020 -0600

commit 9e091d2027a42fbec14555ae98c76e7579cd8b8e
Date:   Sat Jan 4 09:44:00 2020 -0300

commit 7da409f3b53b4d2607b4551b059abb69ad3ad33b
Date:   Thu Jan 2 17:22:08 2020 +0800





stm32_extmem.c and FSMC SDRAM solution in Nuttx?

2020-01-05 Thread disruptivesolutionsnl
All,

 

I want to set up some generic SDRAM as a component (board) to support the
ILI9341 LCD screens. I tried a few boards now (L476RG, F407VE, etc.), but
all seem to come short in (SD)RAM fort he framebuffer.

 

What do you advise? And is there already a solution in Nuttx for it?

 

In this article/sheet, they also write about NOR Flash, etc..

https://www.st.com/content/ccc/resource/technical/document/application_note/
85/ad/ef/0f/a3/a6/49/9a/CD00201397.pdf/files/CD00201397.pdf/jcr:content/tran
slations/en.CD00201397.pdf

 

Thanks again.

 

Ben



[GitHub] [incubator-nuttx] wingunder opened a new pull request #41: Fixed a compilation error, with irq debugging for stm32f7 and stm32h7 archs.

2020-01-05 Thread GitBox
wingunder opened a new pull request #41: Fixed a compilation error, with irq 
debugging for stm32f7 and stm32h7 archs.
URL: https://github.com/apache/incubator-nuttx/pull/41
 
 
   This commit fixes a compilation error that occurs when enabling the
   following configuration items for stm32f7 and stm32h7 architectures:
   ```
  CONFIG_DEBUG_FEATURES=y
  CONFIG_DEBUG_ERROR=y
  CONFIG_DEBUG_WARN=y
  CONFIG_DEBUG_INFO=y
  CONFIG_DEBUG_IRQ=y
  CONFIG_DEBUG_IRQ_ERROR=y
  CONFIG_DEBUG_IRQ_WARN=y
  CONFIG_DEBUG_IRQ_INFO=y
   ```
   The compiler error for stm32f7:
   ```
   make[1]: Entering directory '/home/pdupreez/dev/wingunder/nuttx/arch/arm/src'
   CC:  chip/stm32_irq.c
   chip/stm32_irq.c: In function 'up_irqinitialize':
   chip/stm32_irq.c:497:29: error: 'STM32_IRQ_NIRQS' undeclared (first use in 
this function); did you mean 'STM32_IRQ_FIRST'?
  stm32_dumpnvic("initial", STM32_IRQ_NIRQS);
   ^~~
STM32_IRQ_FIRST
   chip/stm32_irq.c:497:29: note: each undeclared identifier is reported only 
once for each function it appears in
   make[1]: *** [Makefile:172: stm32_irq.o] Error 1
   make[1]: Leaving directory '/home/pdupreez/dev/wingunder/nuttx/arch/arm/src'
   ```
   And the compiler error for stm32h7:
   ```
   make[1]: Entering directory '/home/pdupreez/dev/wingunder/nuttx/arch/arm/src'
   CC:  chip/stm32_irq.c
   chip/stm32_irq.c: In function 'stm32_dumpnvic':
   chip/stm32_irq.c:164:4: warning: #warning Missing logic [-Wcpp]
#  warning Missing logic
^~~
chip/stm32_irq.c: In function 'up_irqinitialize':
chip/stm32_irq.c:522:29: error: 'STM32_IRQ_NIRQS' undeclared (first use 
in this function); did you mean 'STM32_IRQ_CRS'?
   stm32_dumpnvic("initial", STM32_IRQ_NIRQS);
^~~
 STM32_IRQ_CRS
   chip/stm32_irq.c:522:29: note: each undeclared identifier is reported only 
once for each function it appears in
   make[1]: *** [Makefile:172: stm32_irq.o] Error 1
   make[1]: Leaving directory '/home/pdupreez/dev/wingunder/nuttx/arch/arm/src'
   ```
   This commit replaces all STM32_IRQ_NIRQS defines with the NR_IRQS
   define, which seems to be consistent with the rest of the code in
   Nuttx.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


Re: stm32_extmem.c and FSMC SDRAM solution in Nuttx?

2020-01-05 Thread Alexander Oryshchenko
If I remember right stm32f407 doesn't support sdram.

-Alexander

вс, 5 янв. 2020 г., 23:45 :

> All,
>
>
>
> I want to set up some generic SDRAM as a component (board) to support the
> ILI9341 LCD screens. I tried a few boards now (L476RG, F407VE, etc.), but
> all seem to come short in (SD)RAM fort he framebuffer.
>
>
>
> What do you advise? And is there already a solution in Nuttx for it?
>
>
>
> In this article/sheet, they also write about NOR Flash, etc..
>
>
> https://www.st.com/content/ccc/resource/technical/document/application_note/
>
> 85/ad/ef/0f/a3/a6/49/9a/CD00201397.pdf/files/CD00201397.pdf/jcr:content/tran
> slations/en.CD00201397.pdf
> 
>
>
>
> Thanks again.
>
>
>
> Ben
>
>


Re: stm32_extmem.c and FSMC SDRAM solution in Nuttx?

2020-01-05 Thread Gregory Nutt



I want to set up some generic SDRAM as a component (board) to support the
ILI9341 LCD screens. I tried a few boards now (L476RG, F407VE, etc.), but
all seem to come short in (SD)RAM fort he framebuffer.

What do you advise? And is there already a solution in Nuttx for it?


There are dozens of them.  For the STM32 family that you seem to prefer, 
there are only a few boards:


 * stm32f429i-disco- 64-Mbit SDRAM
 * stm3240g-eval - 16 Mbit SRAM
 * stm3220g-eval - 16 Mbit SRAM
 * stm3210e-eval -  8-Mbit SRAM
 * axloti -  8 MiB of SDRAM (Alliance Memory AS4C4M16SA)

I prefer the NXP LPC54 to any of those, however.

Actually, my recommendation (as if I were doing the job on an STM32) 
would not be to use any ILI9341 LCD but something based on the SSD1963 
which as a 1,215Kb framebuffer built into the LCD controller.  I love 
that part and it has been on my list for a long time to buy an LCD with 
an SSD1963.  The are cheap.  There are some around $45 on eBay.


Greg




Re: stm32_extmem.c and FSMC SDRAM solution in Nuttx?

2020-01-05 Thread Gregory Nutt




If I remember right stm32f407 doesn't support sdram.


A large external SRAM could be used, however.


[GitHub] [incubator-nuttx] patacongo merged pull request #41: Fixed a compilation error, with irq debugging for stm32f7 and stm32h7 archs.

2020-01-05 Thread GitBox
patacongo merged pull request #41: Fixed a compilation error, with irq 
debugging for stm32f7 and stm32h7 archs.
URL: https://github.com/apache/incubator-nuttx/pull/41
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


Re: Strange things in git repositories?

2020-01-05 Thread Nathan Hartman
On Sun, Jan 5, 2020 at 4:38 PM Gregory Nutt  wrote:
> > But the recent commits that I was referring to are shown the same
> > whether --date-order or not.
>
> Sorry, --date-order is the default, commit timestamp order.  I meant
> --author-date-order, author timestamp order.  Summarized:
>
> $ git log
>
> commit 3951c4de5af427b204b77ae484fbd8175ed07842
> Merge: 7da409f3b5 9e091d2027
> Date:   Sat Jan 4 07:58:30 2020 -0600
>
> commit 7da409f3b53b4d2607b4551b059abb69ad3ad33b
> Date:   Thu Jan 2 17:22:08 2020 +0800
>
> commit 9e091d2027a42fbec14555ae98c76e7579cd8b8e
> Author: Mateusz Szafoni 
> Date:   Sat Jan 4 09:44:00 2020 -0300
>
> $ git log --author-date-order
>
> commit 3951c4de5af427b204b77ae484fbd8175ed07842
> Merge: 7da409f3b5 9e091d2027
> Date:   Sat Jan 4 07:58:30 2020 -0600
>
> commit 9e091d2027a42fbec14555ae98c76e7579cd8b8e
> Date:   Sat Jan 4 09:44:00 2020 -0300
>
> commit 7da409f3b53b4d2607b4551b059abb69ad3ad33b
> Date:   Thu Jan 2 17:22:08 2020 +0800

Yes, now I see it. --date-order vs --author-date-order.

Yet another example of git's horrendous user interface.
Bottom-up design at its worst.

Thanks for your help,
Nathan


Re: Strange things in git repositories?

2020-01-05 Thread Gregory Nutt




Yet another example of git's horrendous user interface.
Bottom-up design at its worst.


This is really  problem that in endemic in open source software. Open 
source software is developed by people like us -- engineering nerds who 
only care about interesting implementations and are much less skilled in 
understanding or valuing the end-users point of view.  As a result, 
there is a lot of really, really cool open source software that is just 
difficult to use.


If we really wanted our open source software to compete with commercial 
software, we should focus a lot more attention in understanding what 
users want and do a better job of human factors engineering.


It is informative to look at the marketing materials and support tools 
offered by commercial vendors of RTOSs like VxWorks and Integrity.  We 
could learn a lot.




Re: stm32_extmem.c and FSMC SDRAM solution in Nuttx?

2020-01-05 Thread Disruptive Solutions
Thanks all! I will look into all options!

Verstuurd vanaf mijn iPhone

> Op 5 jan. 2020 om 23:05 heeft Gregory Nutt  het volgende 
> geschreven:
> 
> 
>> If I remember right stm32f407 doesn't support sdram.
>> 
> A large external SRAM could be used, however.


Re: Strange things in git repositories?

2020-01-05 Thread Xiang Xiao
On Mon, Jan 6, 2020 at 5:02 AM Gregory Nutt  wrote:
>
>
> > Something strange is happening with the git repositories.
> >
> > Several times recently, I have seen things inexplicably disappear and 
> > reappear.
>
> You had me going with that.  The answer is that the order of the commits
> is not in date order.  Look:
>
> commit 3951c4de5af427b204b77ae484fbd8175ed07842
> Merge: 7da409f3b5 9e091d2027
> Author: Gregory Nutt 
> Date:   Sat Jan 4 07:58:30 2020 -0600
>
>  Merge branch 'master' of github.com:apache/incubator-nuttx
>
> commit 7da409f3b53b4d2607b4551b059abb69ad3ad33b
> Author: liuhaitao 
> Date:   Thu Jan 2 17:22:08 2020 +0800
>
> commit 9e091d2027a42fbec14555ae98c76e7579cd8b8e
> Author: Mateusz Szafoni 
> Date:   Sat Jan 4 09:44:00 2020 -0300
>
> Is it possible that the local clone was unclean when commit
> 7da409f3b53b4d2607b4551b059abb69ad3ad33b was made?  I did that one, I
> don't think that was ever the case.
>
> Again 'git show 7da409f3b53b4d2607b4551b059abb69ad3ad33b' shows no problem.
>
> 7da409f3b53b4d2607b4551b059abb69ad3ad33b was committed on Jan 2,
> 9e091d2027a42fbec14555ae98c76e7579cd8b8e was committed on Jan 2. So the
> order of the commits in 'git log' does not reflect the date order.
>
> Also lock at the github.com/apache/incubator-nuttx.  Look at the last
> commit.  It has two parents (because it was merged) follow the left
> parent back to 3951c4d:
> https://github.com/apache/incubator-nuttx/commit/3951c4de5af427b204b77ae484fbd8175ed07842
>
> Notice that it has two parents: 7da409f
> 
> + 9e091d2
> 
>

Can we always use "Rebase and merge" here? The "Create a merge
commit"(default option) generate many empty merge commits which make
the history hard to read.

> That is where the merge occurred and the two commits from different
> times were merge into commit order.  Try this:
>
> git log --date-order.
>
> That will be clearly and will behave as you expect, 7da409f
> 
> and 9e091d2
> swap
> positions and if you follow that you will see that nothing disappeared..
> You were jumpting backwared in time
>
> Greg
>
>
>
>


Re: Strange things in git repositories?

2020-01-05 Thread Brennan Ashton
> Can we always use "Rebase and merge" here? The "Create a merge
> commit"(default option) generate many empty merge commits which make
> the history hard to read.
>

I would be in favor of this.  I was looking at this earlier and we can
control this with the .asf.yaml file in the repo if we want
See the Merge Buttons sections here
https://cwiki.apache.org/confluence/display/INFRA/.asf.yaml+features+for+git+repositories

The downside is that I frequently GPG sign my commits and this breaks that
if the rebase is needed.  I usually just rebase myself in edit
mode so that I can sign them.

As for the question that was raised earlier in this thread I think there
are some misconceptions about what dates mean in git,
commit or author date are not really going to solve seeing this in a linear
fashion. You need to look at the graph resolution,
especially if you are allowing merge commits (hence why rebase is much
better).  I have an alias that I use for generating the log output

lg1 = log --graph --abbrev-commit --decorate --format=format:'%C(bold
blue)%h%C(reset) - %C(bold green)(%ar)%C(reset) %C(white)%s%C(reset)
%C(dim white)- %an%C(reset)%C(bold yellow)%d%C(reset)' --all


Running this you see what is going on, and why you cannot just look at it
in a linear fashion.  This is also visible in the github graph view btw.
Hope this is helpful.

*   5d5897c309 - (4 hours ago) Merge pull request #41 from
wingunder/wingunder_fix_compilation_bug_irq_f7_h7 - patacongo (HEAD ->
master, origin/master, origin/HEAD)
|\
| * 00df2f0fe2 - (5 hours ago) Fixed a compilation error, with irq
debugging for stm32f7 and stm32h7 archs. - Pieter du Preez
* |   7179f2940d - (9 hours ago) Merge pull request #40 from
xiaoxiang781216/fix-shell-script-format - patacongo
|\ \
| * | 3b9efc95a2 - (10 hours ago) Format all shell scripts in tools folder
- Xiang Xiao
|/ /
* | 390ebd504f - (12 hours ago) arch/arm/src/stm32h7:  Port QSPI driver
from STM32F7 to STM32H7 - Minamiya_Natsuki
|/
* 7136215930 - (33 hours ago) sched_mergepending.c:  Correct some errors in
comments. (#38) - patacongo
*   3951c4de5a - (2 days ago) Merge branch 'master' of
github.com:apache/incubator-nuttx
- Gregory Nutt
|\
| * 9e091d2027 - (2 days ago) Improvements for NRF52 (#37) - Mateusz Szafoni
| * d644567dff - (2 days ago) sx127x: fix some coding standard problems
(#36) - Mateusz Szafoni
| * ebce5fb7ca - (2 days ago) Squashed commit of the following: - Gregory
Nutt
| * d612fd3dc5 - (3 days ago) Squashed commit of the following: - Xiang Xiao
* | 7da409f3b5 - (4 days ago) tools/nxstyle.c: Add -r option to check
specified range lines - liuhaitao
|/
* 9b2fa8152c - (3 days ago) drivers/sensors/lsm6dsl.c: fix various compiler
warnings - raiden00pl
* 06c2e86d98 - (3 days ago) Documentation/NuttXCCodingStandard.html:
 Remove requirement to decorate ignored returned values with (void). (#31)
- Gregory Nutt
* 91d483591d - (3 days ago) drivers/modem/altair/altmdm_sys.c:  Fix
modem/altair semaphore related compiler warning - Xiang Xiao
* 0ee8241606 - (3 days ago) Author: Gregory Nutt  - jjlange
* f9f8c6a79b - (3 days ago) net/icmp/icmp_netpoll.c: Fix return of
uninitialized 'ret' when no error occurs.  That is, on what should be a
successful return from this function, an uninitialized value was returned,
which may indicate an undeserved error. - Nathan Hartman
*   dfe74fc4cf - (3 days ago) Merge branch 'master' of
github.com:apache/incubator-nuttx
- Gregory Nutt


--Brennan


[GitHub] [incubator-nuttx-website] btashton commented on issue #7: Add publisher script

2020-01-05 Thread GitBox
btashton commented on issue #7: Add publisher script
URL: 
https://github.com/apache/incubator-nuttx-website/pull/7#issuecomment-570978830
 
 
   Its much more convenient to have a specific folder to add during the git 
commit to avoid committing build artifacts (.sass-cache and vendor are 
created), so until that changes I would prefer to keep it as-is.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-nuttx-website] huahang opened a new pull request #10: Try to publish the website

2020-01-05 Thread GitBox
huahang opened a new pull request #10: Try to publish the website
URL: https://github.com/apache/incubator-nuttx-website/pull/10
 
 
   Try to publish the website using the script in #7.
   
   Signed-off-by: hans 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-nuttx-website] btashton merged pull request #10: Try to publish the website

2020-01-05 Thread GitBox
btashton merged pull request #10: Try to publish the website
URL: https://github.com/apache/incubator-nuttx-website/pull/10
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


Re: Apache NuttX website

2020-01-05 Thread Brennan Ashton
Hans, thanks for pushing this through.

Website is now live at:
https://nuttx.apache.org/

It's still rough in many ways, but I think we have a good starting point.
One thing I wanted to get feedback from Justin on is can we link to the old
releases before Apache.  If so what kind of disclaimer do we need to
provide?

Thanks,
Brennan



On Sat, Jan 4, 2020 at 2:14 AM Alan Carvalho de Assis 
wrote:

> Hi Abdelatif,
>
> On Saturday, January 4, 2020, Abdelatif Guettouche <
> abdelatif.guettou...@gmail.com> wrote:
> > Hi Alan,
> >
> > There is a pull request in the website repo that will redirect the
> > website from github.io to apache.
> > Brennan wants to review it.
> > When it's merged the website will be accessible at
> https://nuttx.apache.org
> >
>
> Thank you! This idea was to point to some place until Brennan finish the
> jerkill revision.
>
> BTW, let's wait Brennan to finish it.
>
> BR,
>
> Alan
>
>
> > On Sat, Jan 4, 2020 at 10:06 AM Alan Carvalho de Assis
> >  wrote:
> >>
> >> Hi Justin,
> >>
> >> I Will ask Infra to redirect it to NUTTX Confluence wiki page, ok?
> >>
> >> BR,
> >>
> >> Alan
> >>
> >> On Saturday, January 4, 2020, Justin Mclean 
> >> wrote:
> >> > Hi,
> >> >
> >> > This seems to have slipped between the cracks.
> >> >
> >> > Currently https://nuttx.apache.org is returning a 404 which is not a
> good
> >> look.
> >> >
> >> > You might want to look at this with a little more urgency as it's the
> way
> >> new user and committers will find out about your project.
> >> >
> >> > Thanks,
> >> > Justin
> >
>


Re: Apache NuttX website

2020-01-05 Thread Nathan Hartman
On Sun, Jan 5, 2020 at 9:42 PM Brennan Ashton 
wrote:

> Hans, thanks for pushing this through.
>
> Website is now live at:
> https://nuttx.apache.org/


It's beautiful. Thank you to everyone for getting this live!

Nathan


Need NuttX Logo Submitted to Apache

2020-01-05 Thread Brennan Ashton
Greg,
Do you have an SVG of the NuttX logo? Looks like we need to submit it as
instructed here:
https://www.apache.org/logos/about.html

I am trying to check off the remaining items here and I think the logo
requirement will be the last one.  I have a PR for the other website issues.

Thanks,
Brennan


[GitHub] [incubator-nuttx-website] btashton opened a new pull request #11: Add and fix links required by Apache Podling Website Check

2020-01-05 Thread GitBox
btashton opened a new pull request #11: Add and fix links required by Apache 
Podling Website Check
URL: https://github.com/apache/incubator-nuttx-website/pull/11
 
 
   The check results for the current content are here:
   https://whimsy.apache.org/pods/project/nuttx
   
   We had license, but it seems we had the wrong link text.
   
   Signed-off-by: Brennan Ashton 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


Re: Need NuttX Logo Submitted to Apache

2020-01-05 Thread Gregory Nutt




Do you have an SVG of the NuttX logo? Looks like we need to submit it as
instructed here:
https://www.apache.org/logos/about.html

I am trying to check off the remaining items here and I think the logo
requirement will be the last one.  I have a PR for the other website issues.t


Not really.  Alan made an SVG of the logo a few years back, but it 
doesn't look very much like the original and I cannot recommend it.


I think we should celebrate the new Apache NuttX with a new, more 
contemporary logo.  I have some nostalgic feelings for my old, rustic. 
hand drawn logo; I drew that when I first released the project in 2007.  
However, a graphics artist at Xiaomi, Nan Dier, has offered to create 
some new ideas.


I suggest we wait awhile to see what kind of newer, more contemporary, 
more professional logo we can come up with.  This will probably need to 
be color coordinated with the website color scheme as well.


Greg



Re: stm32_extmem.c and FSMC SDRAM solution in Nuttx?

2020-01-05 Thread Gregory Nutt




Thanks all! I will look into all options!


I like this board: https://www.mikroe.com/mikromedia-4-for-stm32-capacitive

STM32F407 (like the STM32F4Discovery) with a nice large SSD1963-based 
LCD and a capacitive touch screen.


Mikroe has a lot of nice boards for graphics development



[GitHub] [incubator-nuttx-website] xiaoxiang781216 merged pull request #11: Add and fix links required by Apache Podling Website Check

2020-01-05 Thread GitBox
xiaoxiang781216 merged pull request #11: Add and fix links required by Apache 
Podling Website Check
URL: https://github.com/apache/incubator-nuttx-website/pull/11
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-nuttx-website] xiaoxiang781216 merged pull request #7: Add publisher script

2020-01-05 Thread GitBox
xiaoxiang781216 merged pull request #7: Add publisher script
URL: https://github.com/apache/incubator-nuttx-website/pull/7
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-nuttx-website] xiaoxiang781216 commented on issue #11: Add and fix links required by Apache Podling Website Check

2020-01-05 Thread GitBox
xiaoxiang781216 commented on issue #11: Add and fix links required by Apache 
Podling Website Check
URL: 
https://github.com/apache/incubator-nuttx-website/pull/11#issuecomment-570993052
 
 
   @btashton @huahang should we generate the content again?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-nuttx-website] btashton commented on issue #11: Add and fix links required by Apache Podling Website Check

2020-01-05 Thread GitBox
btashton commented on issue #11: Add and fix links required by Apache Podling 
Website Check
URL: 
https://github.com/apache/incubator-nuttx-website/pull/11#issuecomment-570994719
 
 
   Ideally when this goes into master a CI would pick it up and run the publish 
script.  Personally I think the commiter who merges to master should publish 
directly or ask another commiter to do it if they don't know how/can't.   The 
extra PR of the static content seems redundant.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-nuttx-website] xiaoxiang781216 commented on issue #11: Add and fix links required by Apache Podling Website Check

2020-01-05 Thread GitBox
xiaoxiang781216 commented on issue #11: Add and fix links required by Apache 
Podling Website Check
URL: 
https://github.com/apache/incubator-nuttx-website/pull/11#issuecomment-570995364
 
 
   @liuguo09, please help add a jenkins job to run pushlish.sh script and push 
the result to asf-site automatically.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-nuttx-website] btashton commented on issue #11: Add and fix links required by Apache Podling Website Check

2020-01-05 Thread GitBox
btashton commented on issue #11: Add and fix links required by Apache Podling 
Website Check
URL: 
https://github.com/apache/incubator-nuttx-website/pull/11#issuecomment-570996976
 
 
   @xiaoxiang781216 in the meantime I don't mind being the CI bot only running 
the publish.sh script. (did it for this one)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


Re: Strange things in git repositories?

2020-01-05 Thread Justin Mclean
Hi,

> This is really  problem that in endemic in open source software. Open source 
> software is developed by people like us 

Git was made for use by repository maintainers, not for developers and 
certainly not for users. It shows :-)

Thanks,
Justin




Re: Apache NuttX website

2020-01-05 Thread Justin Mclean
Hi,

> One thing I wanted to get feedback from Justin on is can we link to the old
> releases before Apache.  If so what kind of disclaimer do we need to
> provide?

As long as they are very clearly marked as not being Apache releases that fine.

Thanks,
Justin

Re: Need NuttX Logo Submitted to Apache

2020-01-05 Thread Justin Mclean
Hi,

> I think we should celebrate the new Apache NuttX with a new, more 
> contemporary logo.  I have some nostalgic feelings for my old, rustic. hand 
> drawn logo; I drew that when I first released the project in 2007.  However, 
> a graphics artist at Xiaomi, Nan Dier, has offered to create some new ideas.

Apache central services can also able to help with a new logo. 

It also a good idea to put your logo here, so you can get stickers for 
ApacheCons and other events. [1]

Thanks,
Justin

1. https://www.apache.org/logos/