[GitHub] kafka pull request #2706: MINOR: fixed memory pollution by removing unnecess...
Github user wlsc closed the pull request at: https://github.com/apache/kafka/pull/2706 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #2697: MINOR: fixed memory pollution in KafkaConsumer
GitHub user wlsc opened a pull request: https://github.com/apache/kafka/pull/2697 MINOR: fixed memory pollution in KafkaConsumer This PL fixes memory pollution in KafkaConsumer by removing creation of the unnecessary HashSet each time we need to create unmodifiableSet and using unmodifiableMap when we just need to commit offsets. You can merge this pull request into a Git repository by running: $ git pull https://github.com/wlsc/kafka trunk Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/2697.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2697 commit 2d71b1f4b90680ad4eeac7b13c85373a19127c98 Author: Wladimir Schmidt Date: 2017-03-16T20:35:44Z * exchanged HashMap with unmodifiableMap in KafkaConsumer (commitSync and commitAsync functions) commit 0cdd0d691fd67800674833a5809b357ee6dc4afa Author: Wladimir Schmidt Date: 2017-03-16T20:45:54Z * fixed memory pollution due to unnecessary creation of additional HashMap --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #2697: MINOR: fixed memory pollution in KafkaConsumer
Github user wlsc closed the pull request at: https://github.com/apache/kafka/pull/2697 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #2706: MINOR: fixed memory pollution by removing unnecess...
GitHub user wlsc opened a pull request: https://github.com/apache/kafka/pull/2706 MINOR: fixed memory pollution by removing unnecessary creation of HashSet MINOR: fixed memory pollution by removing unnecessary creation of HashSet (assignment and subscription functions), changed modifiable to non-modifiable state while committing offsets (commitSync and commitAsync functions). You can merge this pull request into a Git repository by running: $ git pull https://github.com/wlsc/kafka minor/memory-pollution-kafka-consumer Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/2706.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2706 commit 9e2272fbfc3ce830f016833183a873a6124d2c3a Author: Wladimir Schmidt Date: 2017-03-19T10:03:48Z MINOR: fixed memory pollution by removing unnecessary creation of HashSet (assignment and subscription functions), changed modifiable to non-modifiable state while committing offsets (commitSync and commitAsync functions) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #2707: MINOR: exchanged addAll/putAll with parametrized c...
GitHub user wlsc opened a pull request: https://github.com/apache/kafka/pull/2707 MINOR: exchanged addAll/putAll with parametrized constructor Basic static analysis was done here. I've exchanged all addAll/putAll methods that were stand right after creation of each particular HashSet/HashMap with parametric constructor of HashSet/HashMap. You can merge this pull request into a Git repository by running: $ git pull https://github.com/wlsc/kafka minor/add-all-values-replaced-with-param-constructor Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/2707.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2707 commit b38a031798ccef733ded808d1b4d26906dd34f6a Author: Wladimir Schmidt Date: 2017-03-19T10:50:10Z MINOR: exchanged addAll/putAll methods right after creation of each particular HashSet/HashMap with parametrized constructor of HashSet/HashMap --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3049: MINOR: removed code duplicates from several files ...
GitHub user wlsc opened a pull request: https://github.com/apache/kafka/pull/3049 MINOR: removed code duplicates from several files (KafkaStreams) This PR offers following to KafkaStreams project: * removed code duplication from **TopologyBuilder**'s function **makeNodeGroups** (extract function) * removed code duplication from **GlobalProcessorContextImpl** and from **ProcessorContextImpl** to parent class **AbstractProcessorContext** (move method to parent) You can merge this pull request into a Git repository by running: $ git pull https://github.com/wlsc/kafka refactoring/remove-duplicates Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3049.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3049 commit fa90d68f7d547f54ae48a8254acac4759ddd4580 Author: Wladimir Schmidt Date: 2017-05-14T08:33:28Z removed code duplicate from GlobalProcessorContextImpl and from ProcessorContextImpl to parent AbstractProcessorContext commit 6c70019a2d8f6b98b29366576f3b9f531ec0aea4 Author: Wladimir Schmidt Date: 2017-05-14T08:48:37Z removed code duplicate from TopologyBuilder's function "makeNodeGroups" --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
