[GitHub] kafka pull request #3955: KAFKA-5969: Use correct error message when the JSO...
GitHub user scholzj opened a pull request: https://github.com/apache/kafka/pull/3955 KAFKA-5969: Use correct error message when the JSON file is invalid When invalid JSON file is passed to the bin/kafka-preferred-replica-election.sh / PreferredReplicaLeaderElectionCommand tool it gives a misleading error `Preferred replica election data is empty`. This PR replaces it with the correct error message. You can merge this pull request into a Git repository by running: $ git pull https://github.com/scholzj/kafka KAFKA-5969 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3955.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3955 commit 45bd0251c02b0d960e015b6f626323ba2eeb413c Author: Jakub Scholz Date: 2017-09-25T09:11:57Z Use correct error message when the JSON file is invalid ---
[GitHub] kafka pull request #3920: KAFKA-5940: Throw exception if the JSON file is in...
Github user scholzj closed the pull request at: https://github.com/apache/kafka/pull/3920 ---
[GitHub] kafka pull request #4012: KAFKA-6008: Sanitize the Kafka Connect workerId be...
GitHub user scholzj opened a pull request: https://github.com/apache/kafka/pull/4012 KAFKA-6008: Sanitize the Kafka Connect workerId before passing it to AppInfoParser You can merge this pull request into a Git repository by running: $ git pull https://github.com/scholzj/kafka KAFKA-6008 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/4012.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4012 commit 8aac02d76ca9bc723a58bd54965977c7a2a6dfec Author: Jakub Scholz Date: 2017-10-04T11:26:21Z Sanitize the workerId before passing it to AppInfoParser ---
[GitHub] kafka-site pull request #99: Rephrase mailing lists section to avoid incorre...
GitHub user scholzj opened a pull request: https://github.com/apache/kafka-site/pull/99 Rephrase mailing lists section to avoid incorrect subscribe emails The user@ and dev@ mailing lists seem to receive lot of emails from users who are not subscribed but are trying to subscribe. I wonder it is has something to do with the UX of the website and if the change in this PR can help to make it more clear to the users that they subscribe on a different email. You can merge this pull request into a Git repository by running: $ git pull https://github.com/scholzj/kafka-site mailing-lists Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka-site/pull/99.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #99 commit 3216f194a676238b42bc653925428d6de57ddfe2 Author: Jakub Scholz Date: 2017-10-18T07:27:09Z Rephrase mailing lists section to avoid incorrect subscribe emails commit ef812699426e13cf0eeb4ddb1b7756dc42cb Author: Jakub Scholz Date: 2017-10-18T07:30:37Z Remove you can and add are to the "archives are ..." ---
[GitHub] kafka-site issue #81: MINOR: Fix typo in the gradle command for code style c...
Github user scholzj commented on the issue: https://github.com/apache/kafka-site/pull/81 Can someone have a look at this? It is just a simple typo, so it should be very easy to review and merge. ---
[GitHub] kafka-site pull request #99: Rephrase mailing lists section to avoid incorre...
Github user scholzj commented on a diff in the pull request: https://github.com/apache/kafka-site/pull/99#discussion_r145345710 --- Diff: contact.html --- @@ -11,16 +11,16 @@ - us...@kafka.apache.org: A list for general user questions about Kafka®. To subscribe, send an email to users-subscr...@kafka.apache.org. Archives are available http://mail-archives.apache.org/mod_mbox/kafka-users";>here. + User maling list: A list for general user questions about Kafka®. To subscribe, send an email to users-subscr...@kafka.apache.org. Once subscribed, send your emails to us...@kafka.apache.org. Archives are available http://mail-archives.apache.org/mod_mbox/kafka-users";>here. --- End diff -- Fixed, thanks for noticing. ---
[GitHub] kafka-site pull request #99: Rephrase mailing lists section to avoid incorre...
Github user scholzj commented on a diff in the pull request: https://github.com/apache/kafka-site/pull/99#discussion_r145347106 --- Diff: contact.html --- @@ -11,16 +11,16 @@ - us...@kafka.apache.org: A list for general user questions about Kafka®. To subscribe, send an email to users-subscr...@kafka.apache.org. Archives are available http://mail-archives.apache.org/mod_mbox/kafka-users";>here. + User mailing list: A list for general user questions about Kafka®. To subscribe, send an email to users-subscr...@kafka.apache.org. Once subscribed, send your emails to us...@kafka.apache.org. Archives are available http://mail-archives.apache.org/mod_mbox/kafka-users";>here. - dev@kafka.apache.org: A list for discussion on Kafka development. To subscribe, send an email to dev-subscr...@kafka.apache.org. Archives available http://mail-archives.apache.org/mod_mbox/kafka-dev";>here. + Developer mailing list: A list for discussion on Kafka® development. To subscribe, send an email to dev-subscr...@kafka.apache.org. Once subscribed, send your emails to dev@kafka.apache.org. Archives are available http://mail-archives.apache.org/mod_mbox/kafka-dev";>here. - j...@kafka.apache.org: A list to track Kafka https://issues.apache.org/jira/projects/KAFKA";>JIRA notifications. To subscribe, send an email to jira-subscr...@kafka.apache.org. Archives available http://mail-archives.apache.org/mod_mbox/kafka-jira";>here. + JIRA mailing list: A list to track Kafka® https://issues.apache.org/jira/projects/KAFKA";>JIRA notifications. To subscribe, send an email to jira-subscr...@kafka.apache.org. Once subscribed, send your emails to j...@kafka.apache.org. Archives are available http://mail-archives.apache.org/mod_mbox/kafka-jira";>here. --- End diff -- Fixed. ---
[GitHub] kafka pull request #4310: DOCU: Add authorizer.class.name to the security se...
GitHub user scholzj opened a pull request: https://github.com/apache/kafka/pull/4310 DOCU: Add authorizer.class.name to the security section in documentation The section _7.4 Authorization and ACLs_ in Kafka documentation describes how to use ACLs. But it doesn't seem to contain the most important part - configuring the Authorizer. That might be a bit confusing for the users. This PR adds this to the documentation. You can merge this pull request into a Git repository by running: $ git pull https://github.com/scholzj/kafka acl-docu Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/4310.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4310 commit a5f4b643c739bbc47e026cea7a7cd64d5d7f9e36 Author: Jakub Scholz Date: 2017-12-10T19:42:21Z MINOR: Add authorizer.class.name to the security section in documentation ---
[GitHub] kafka pull request #3883: KAFKA-5918: Fix minor typos and errors in the Kafk...
GitHub user scholzj opened a pull request:
https://github.com/apache/kafka/pull/3883
KAFKA-5918: Fix minor typos and errors in the Kafka Streams turotial
I found several minor issues with the Kafka Streams tutorial:
* Some typos
* "As shown above, it illustrate that the constructed ..." instead of "As
shown above, it illustrate_s_ that the constructed ..."
* "same as Pipe.java below" instead of "same as Pipe.java _above_"
* Wrong class name in the `LineSplit` example
* Incorrect imports for the code examples
* Missing `import org.apache.kafka.streams.kstream.KStream;` in
`LineSplit` and `WordCount` example
* Unnecessary (and potentially confusing) split by whitespaces in the
`WorkCount` class (the split into words happened already in `LineSplit`)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scholzj/kafka stream-tutorial-typos
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/3883.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3883
commit 8facfd30948a4c866131c7554ded54bf4213293a
Author: Jakub Scholz
Date: 2017-09-17T21:11:17Z
Fix some typos in the Kafka Streams tutorial
---
[GitHub] kafka pull request #3899: KAFKA-4320: Log cleaner is enabled by default
GitHub user scholzj opened a pull request: https://github.com/apache/kafka/pull/3899 KAFKA-4320: Log cleaner is enabled by default The log cleaner is enabled by default since 0.9.0.1. But the 0.10.0 docs are not updated. This PR updates the docs to say that it is enabled by default. You can merge this pull request into a Git repository by running: $ git pull https://github.com/scholzj/kafka 0.10.0-log-compaction-docu Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3899.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3899 ---
[GitHub] kafka pull request #3900: KAFKA-4320: Clarify the log compaction config prop...
GitHub user scholzj opened a pull request: https://github.com/apache/kafka/pull/3900 KAFKA-4320: Clarify the log compaction config property per-topic and per-broker The per-topic config property is different from the per-broker. This PR makes it a bit more clear. You can merge this pull request into a Git repository by running: $ git pull https://github.com/scholzj/kafka log-compaction-docu Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3900.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3900 commit dba96145f94752da9ea44f41f75658acf20f8a90 Author: Jakub Scholz Date: 2017-09-19T09:28:20Z Clarify the log compaction config property per-topic and per-broker ---
[GitHub] kafka pull request #3898: KAFKA-4320: Log cleaner is enabled by default
GitHub user scholzj opened a pull request: https://github.com/apache/kafka/pull/3898 KAFKA-4320: Log cleaner is enabled by default The log cleaner is enabled by default since 0.9.0.1. But the 0.9.0 docs are not updated. This PR updates the docs to say that it is enabled by default. You can merge this pull request into a Git repository by running: $ git pull https://github.com/scholzj/kafka 0.9.0-log-compaction-docu Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3898.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3898 commit cef74f230cdf4abc1180362a82b501f8e0154a5e Author: Jakub Scholz Date: 2017-09-19T09:04:58Z Log cleaner is enabled by default ---
[GitHub] kafka pull request #3908: KAFKA-5933: Move timeout and validate_only protoco...
GitHub user scholzj opened a pull request: https://github.com/apache/kafka/pull/3908 KAFKA-5933: Move timeout and validate_only protocol fields into CommonFields class Most of the fields which are shared by multiple protocol messages (requests ad responses) are in the CommonFields class. However there are still some fields used multiple times which are not there yet: * `timeout` * `validate_only` It would be good to move also these two fields into the CommonFields class so that they can be easily shared by different messages. You can merge this pull request into a Git repository by running: $ git pull https://github.com/scholzj/kafka common-fields Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3908.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3908 commit 2772267e213e17bc04032d7305db3099ad0d573d Author: Jakub Scholz Date: 2017-09-19T19:04:45Z Move timeout and validate_only to CommonFields ---
[GitHub] kafka-site pull request #81: MINOR: Fix typo in the gradle command for code ...
GitHub user scholzj opened a pull request: https://github.com/apache/kafka-site/pull/81 MINOR: Fix typo in the gradle command for code style check Fix typo in the gradle command for code style check: chec**k**styleMain instead of chec**h**styleMain You can merge this pull request into a Git repository by running: $ git pull https://github.com/scholzj/kafka-site coding-guide-typo Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka-site/pull/81.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #81 commit 644a677161800cbc384e196bda40188c26f7351e Author: Jakub Scholz Date: 2017-09-20T10:01:42Z Fix typo in the gradle command for code style check ---
[GitHub] kafka pull request #3920: KAFKA5940: Throw exception if the JSON file is inv...
GitHub user scholzj opened a pull request: https://github.com/apache/kafka/pull/3920 KAFKA5940: Throw exception if the JSON file is invalid Throw an exception when the JSON file with topics/partitions and offsets is incorrect (= when Json.parseFull(...) returns None). You can merge this pull request into a Git repository by running: $ git pull https://github.com/scholzj/kafka KAFKA-5940 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3920.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3920 commit 870167e1d33710e129506621578e019634510bc9 Author: Jakub Scholz Date: 2017-09-20T11:00:45Z Throw exception if the JSON file is invalid ---
