[GitHub] kafka pull request #1652: KAFKA-2394: move to RollingFileAppender by default...
Github user cotedm closed the pull request at: https://github.com/apache/kafka/pull/1652 ---
[GitHub] kafka pull request: KAFKA-2394: move to RollingFileAppender by def...
GitHub user cotedm opened a pull request: https://github.com/apache/kafka/pull/1434 KAFKA-2394: move to RollingFileAppender by default for log4j This PR sets up the default max log size to be about 1GB. That default should probably be vetted. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cotedm/kafka trunk Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/1434.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1434 commit 6eab7890db19cf0d873530278b8cd43877063f69 Author: Dustin Cote Date: 2016-05-26T13:52:35Z move to RollingFileAppender by default for log4j --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #1434: KAFKA-2394: move to RollingFileAppender by default...
Github user cotedm closed the pull request at: https://github.com/apache/kafka/pull/1434 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #1652: KAFKA-2394: move to RollingFileAppender by default...
GitHub user cotedm opened a pull request: https://github.com/apache/kafka/pull/1652 KAFKA-2394: move to RollingFileAppender by default for log4j You can merge this pull request into a Git repository by running: $ git pull https://github.com/cotedm/kafka KAFKA-2394 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/1652.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1652 commit 31a565b31a99567327b774045fbf726f5a2d1812 Author: Dustin Cote Date: 2016-07-22T14:37:53Z update log4j.properties to use RollingFileAppender --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #1653: KAFKA-2932: Adjust importance level of Kafka Conne...
GitHub user cotedm opened a pull request: https://github.com/apache/kafka/pull/1653 KAFKA-2932: Adjust importance level of Kafka Connect configs @ewencp I went down the list of connect configs and it looks like only the internal converter configs are mismarked. It looks like the `cluster` config that is present in the current docs is already gone. The only other values I can see arguing to change importance on are the ssl configs (marked high) but they are consistent with the producer/consumer config docs so that's at least consistent. Everything else marked high looks either mandatory or requires consideration in a production deployment to me. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cotedm/kafka KAFKA-2932 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/1653.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1653 commit c3e076a75e1e714c2585e9b976f5b746d804eaa5 Author: Dustin Cote Date: 2016-07-22T18:01:39Z lower importance rating for internal converter settings --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #1681: KAFKA-3590: KafkaConsumer fails with "Messages are...
GitHub user cotedm opened a pull request: https://github.com/apache/kafka/pull/1681 KAFKA-3590: KafkaConsumer fails with "Messages are rejected since there are fewer in-sync replicas than required." when polling This just improves the error message since it's confusing that a consumer throws a message you'd normally see for a producer. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cotedm/kafka KAFKA-3590 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/1681.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1681 commit 9873e9fa94c8781dccb390cde890c48f9aa5ffc5 Author: Dustin Cote Date: 2016-07-29T14:59:10Z Handle error case for under replicated __consumer_offsets by logging a better message commit 45c0d6cd9e4192fae6f44a308812679f8fdb3fd3 Author: Dustin Cote Date: 2016-07-29T15:02:28Z updated comment --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #1691: MINOR: lower logging severity for offset reset
GitHub user cotedm opened a pull request: https://github.com/apache/kafka/pull/1691 MINOR: lower logging severity for offset reset When resetting the first dirty offset to the log start offset, we currently log an ERROR which makes users think the log cleaner has a problem and maybe has exited. We should log a WARN instead to avoid alarming the users. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cotedm/kafka minorlogcleanerlogging Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/1691.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1691 commit 54d611ce10ec28946a439e41bd28eaf9996f292f Author: Dustin Cote Date: 2016-08-01T15:11:59Z MINOR: lower logging severity for offset reset When resetting the first dirty offset to the log start offset, we currently log an ERROR which makes users think the log cleaner has a problem and maybe has exited. We should log a WARN instead to avoid alarming the users. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #2534: Update SimpleAclAuthorizer.scala
GitHub user cotedm opened a pull request: https://github.com/apache/kafka/pull/2534 Update SimpleAclAuthorizer.scala Comments had the wrong name for the Group znode, updating ConsumerGroup-->Group in the comments to match what's actually coded. @ijuma if you can review, it's a trivial change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cotedm/kafka acl-znode-correction Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/2534.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2534 commit 3825673b20ce15c94a5efd32d1163ff7dbc60b59 Author: Dustin Cote Date: 2017-02-10T15:34:15Z Update SimpleAclAuthorizer.scala Comments had the wrong name for the Group znode, updating ConsumerGroup-->Group in the comments to match what's actually coded. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #2537: MINOR: Improve LogCleaner buffer size change loggi...
GitHub user cotedm opened a pull request: https://github.com/apache/kafka/pull/2537 MINOR: Improve LogCleaner buffer size change logging Right now it looks like the buffer size only grows if you are watching the cleaner logs. It would be nice if we also logged when the buffer size was restored to avoid confusion when the log just keeps saying the buffer has grown repeatedly to and from the same values. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cotedm/kafka restorecleanerbufferlog Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/2537.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2537 commit fa46f021e3d11377edf03938a1eb84cd7b2e8ad5 Author: Dustin Cote Date: 2017-02-10T19:38:34Z Update LogCleaner.scala --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request: Update links for new consumer API
GitHub user cotedm opened a pull request: https://github.com/apache/kafka/pull/1331 Update links for new consumer API Pull request to update the consumer API links in the docs. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cotedm/kafka KAFKA-3666 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/1331.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1331 commit 4dcffc14b2dd7bb462afe818f785ea1e5ffcffd8 Author: Dustin Cote Date: 2016-05-06T14:28:45Z Update links for new consumer API --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request: KAFKA-3683: Add file descriptor recommendation...
GitHub user cotedm opened a pull request: https://github.com/apache/kafka/pull/1353 KAFKA-3683: Add file descriptor recommendation to ops guide Adding sizing recommendations for file descriptors to the ops guide. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cotedm/kafka KAFKA-3683 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/1353.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1353 commit 4dcffc14b2dd7bb462afe818f785ea1e5ffcffd8 Author: Dustin Cote Date: 2016-05-06T14:28:45Z Update links for new consumer API commit 13309ed77c92a926053b1dffde13bb776c4703db Author: Dustin Cote Date: 2016-05-06T15:37:51Z Update links for new consumer API commit 32315e437febf8b694109d954c096d3767e0151d Author: Dustin Cote Date: 2016-05-06T15:38:10Z Merge branch 'trunk' of https://github.com/cotedm/kafka into trunk commit 0908aa98e0d2c254a6558a482aedc2441d519501 Author: Dustin Cote Date: 2016-05-09T16:41:18Z Merge https://github.com/apache/kafka into trunk commit 8120318b007b972363fce4bc778e1112c104ba65 Author: Dustin Cote Date: 2016-05-09T17:11:31Z Adding file descriptor sizing recommendations --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #1795: KAFKA-3129: Console producer issue when request-re...
GitHub user cotedm opened a pull request: https://github.com/apache/kafka/pull/1795 KAFKA-3129: Console producer issue when request-required-acks=0 change console producer default acks to 1, update acks docs. Also added the -1 config to the acks docs since that question comes up often. @ijuma and @vahidhashemian, does this look reasonable to you? You can merge this pull request into a Git repository by running: $ git pull https://github.com/cotedm/kafka KAFKA-3129 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/1795.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1795 commit bec755ffc4e4b779a6c6d45b144a7e3a87dc64d7 Author: Dustin Cote Date: 2016-08-29T12:44:37Z change console producer default acks to 1, update acks docs --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #1796: KAFKA-4092: retention.bytes should not be allowed ...
GitHub user cotedm opened a pull request: https://github.com/apache/kafka/pull/1796 KAFKA-4092: retention.bytes should not be allowed to be less than segment.bytes adding a LogConfig value validator. @gwenshap or @junrao would you mind taking a look? You can merge this pull request into a Git repository by running: $ git pull https://github.com/cotedm/kafka retentionbytesvalidation Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/1796.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1796 commit 9312611cb6b92bf17984bf6a499206634526db38 Author: Dustin Cote Date: 2016-08-29T18:01:01Z add a LogConfig value validator --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #1797: KAFKA-4062: Require --print-data-log if --offsets-...
GitHub user cotedm opened a pull request: https://github.com/apache/kafka/pull/1797 KAFKA-4062: Require --print-data-log if --offsets-decoder is enabled for DumpLogOffsets set print-data-log option when offset-decoder is set. @hachikuji we had talked about this one before, does this change look ok to you? You can merge this pull request into a Git repository by running: $ git pull https://github.com/cotedm/kafka KAFKA-4062 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/1797.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1797 commit beb9735c6a3bdcf9bb50a229caf05314fca11ffc Author: Dustin Cote Date: 2016-08-29T18:09:59Z set print-data-log option when offset-decoder is set --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #1829: KAFKA-4134: log ConnectException at WARN
GitHub user cotedm opened a pull request: https://github.com/apache/kafka/pull/1829 KAFKA-4134: log ConnectException at WARN Simply log the connection refused instance. If we're worried about spamming users, I can add a flag to make sure we only log this exception once, but the initial change is to simply log what we're given. @ijuma looks like you were last to touch this code, would you mind having a look? You can merge this pull request into a Git repository by running: $ git pull https://github.com/cotedm/kafka connectexceptiondebug Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/1829.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1829 commit 4ad69909b71db6b8f28b8879bfc508e86b124af8 Author: Dustin Cote Date: 2016-09-06T19:15:53Z log ConnectException at WARN --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #1681: KAFKA-3590: KafkaConsumer fails with "Messages are...
Github user cotedm closed the pull request at: https://github.com/apache/kafka/pull/1681 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3153: MINOR: clarify partition option behavior for conso...
GitHub user cotedm opened a pull request: https://github.com/apache/kafka/pull/3153 MINOR: clarify partition option behavior for console consumer Console Consumer help doesn't say that ``--partition`` option needs ``--offset`` otherwise will consume from the end of the partition. This minor fix makes that happen. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cotedm/kafka console_consumer_help_fix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3153.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3153 commit f7188f8dad72e41da876a6bd4b5be0e83dbec664 Author: Dustin Cote Date: 2017-05-26T12:34:24Z clarify partition option behavior --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
