[GitHub] kafka pull request #2152: MINOR: make serializer classes final

2016-11-20 Thread MatthiasBechtold
GitHub user MatthiasBechtold opened a pull request:

https://github.com/apache/kafka/pull/2152

MINOR: make serializer classes final

implementations of simple serializers / deserializers should be final to 
prevent JVM method call overhead.
See also:
https://wiki.openjdk.java.net/display/HotSpot/VirtualCalls


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MatthiasBechtold/kafka trunk

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/2152.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2152


commit 07276db1b7dc5fc9a9350e6b4a55dc3cd23aa22b
Author: Matthias 
Date:   2016-11-20T12:44:18Z

MINOR: implementations of simple serializers / deserializers should be
final to prevent JVM method call overhead.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] kafka pull request #2152: KAFKA-4424: make serializer classes final

2016-11-23 Thread MatthiasBechtold
Github user MatthiasBechtold closed the pull request at:

https://github.com/apache/kafka/pull/2152


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---