Re: [VOTE] 3.7.0 RC4

2024-02-25 Thread Mickael Maison 
Hi,

Thanks for sorting out the docs issues.
+1 (binding)

Mickael

On Fri, Feb 23, 2024 at 11:50 AM Stanislav Kozlovski
 wrote:
>
> Some quick updates:
>
> There were some inconsistencies between the documentation in the
> apache/kafka repo and the one in kafka-site. The process is such that the
> apache/kafka docs are the source of truth, but we had a few divergences in
> the other repo. I have worked on correcting those with:
> - MINOR: Reconcile upgrade.html with kafka-site/36's version
>  and cherry-picked it into the
> 3.6 and 3.7 branches too
>
> Additionally, the 3.7 upgrade notes have been merged in apache/kafka - MINOR:
> Add 3.7 upgrade notes .
>
> With that, I have opened a PR to move them to the kafka-site repository -
> https://github.com/apache/kafka-site/pull/587. That is awaiting review.
>
> Similarly, the 3.7 blog post is ready for review again
>  and awaiting a review on 37:
> Update default docs to point to the 3.7.0 release docs
> 
>
> I also have a WIP for fixing the 3.6 docs in the kafka-site repo
> . This isn't really related
> to the release, but it's good to do.
>
> On Wed, Feb 21, 2024 at 4:55 AM Luke Chen  wrote:
>
> > Hi all,
> >
> > I found there is a bug (KAFKA-16283
> > ) in the built-in
> > `RoundRobinPartitioner`, and it will cause only half of the partitions
> > receiving the records. (I'm surprised our tests didn't catch it!?)
> > After further testing, I found this issue already existed in v3.0.0. (I
> > didn't test 2.x versions)
> > I think this should not be a blocker to v3.7.0 since it's been there for
> > years.
> > But I think we should, at least, document it to notify users about this
> > known issue.
> > I've created 2 PRs to document it:
> > https://github.com/apache/kafka/pull/15400
> > https://github.com/apache/kafka-site/pull/585
> >
> > Let me know what you think.
> >
> > Thanks.
> > Luke
> >
> > On Wed, Feb 21, 2024 at 10:52 AM Proven Provenzano
> >  wrote:
> >
> > > HI,
> > >
> > > I've downloaded, built from source and then validated JBOD with KRaft
> > works
> > > along with migrating a cluster with JBOD from ZK to KRaft works.
> > >
> > > +1 (nonbinding) from me.
> > >
> > > --Proven
> > >
> > > On Tue, Feb 20, 2024 at 2:13 PM Justine Olshan
> > > 
> > > wrote:
> > >
> > > > Hey folks,
> > > >
> > > > I've done the following to validate the release:
> > > >
> > > > -- validated the keys for all the artifacts
> > > > -- built from source and started a ZK cluster -- ran a few workloads on
> > > it.
> > > > -- ran 2.12 Kraft cluster and ran a few workloads on it
> > > >
> > > > I see there is a lot of ongoing discussion about the upgrade notes. +1
> > > > (binding) from me given Mickael is voting +1 as well.
> > > >
> > > > Justine
> > > >
> > > > On Tue, Feb 20, 2024 at 6:18 AM Divij Vaidya 
> > > > wrote:
> > > >
> > > > > > I am a bit unclear on the precise process regarding what parts of
> > > this
> > > > > get merged at what time, and whether the release first needs to be
> > done
> > > > or
> > > > > not.
> > > > >
> > > > > The order is as follows:
> > > > >
> > > > > 1. Release approved as part of this vote. After this we follow the
> > > > > steps from here:
> > > > >
> > > > >
> > > >
> > >
> > https://cwiki.apache.org/confluence/display/KAFKA/Release+Process#ReleaseProcess-Afterthevotepasses
> > > > >
> > > > > 2. Upload artifacts to maven etc. These artifacts do not have RC
> > suffix
> > > > in
> > > > > them. You need a PMC member to mark these artifacts as "production"
> > in
> > > > > apache svn.
> > > > > 3. Update website changes (docs, blog etc.). This is where your PRs
> > > > > on kafka-site repo get merged.
> > > > > 4. Send a release announcement by email.
> > > > >
> > > > > --
> > > > > Divij Vaidya
> > > > >
> > > > >
> > > > >
> > > > > On Tue, Feb 20, 2024 at 3:02 PM Stanislav Kozlovski
> > > > >  wrote:
> > > > >
> > > > > > Thanks for testing the release! And thanks for the review on the
> > > > > > documentation. Good catch on the license too.
> > > > > >
> > > > > > I have addressed the comments in the blog PR, and opened a few
> > other
> > > > PRs
> > > > > to
> > > > > > the website in relation to the release.
> > > > > >
> > > > > > - 37: Add download section for the latest 3.7 release
> > > > > > 
> > > > > > - 37: Update default docs to point to the 3.7.0 release docs
> > > > > > 
> > > > > > - 3.7: Add blog post for Kafka 3.7
> > > > > > 
> > > > > > - MINOR: Update stale upgrade_3_6_0 header links in documentation
> > > > > > 
> > > > > > - 37:

Re: Request to assign an issue (KAFKA-4094)

2024-02-25 Thread Divij Vaidya 
Hey Vaibhav

I have provided you with contributor permission to the JIRA. You should be
able to assign the JIRA to yourself now.

--
Divij Vaidya



On Sun, Feb 25, 2024 at 12:23 AM Vaibhav Kushwaha 
wrote:

> Hi team!
>
> I was going through the list of starter bugs and found one I could pick up
> and contribute to, but it seems that the reporter of the issue is inactive
> for a long time now. Can somebody else help me in getting the assignment
> for this ticket, or guide me if there's any other way to do so?
>
> JIRA username: fourpointfour
> https://issues.apache.org/jira/browse/KAFKA-4094
>
> Thank you
>
> Regards
> Vaibhav Kushwaha
>

Re: [REVIEW REQUEST] LogCleaner, ZkConfig moved to java

2024-02-25 Thread Николай Ижиков 
Hello.

Please, help me with the review of these PR's
They are pretty simple and can be reviewed easily.

Will help us to move config classes from the ‘core’ module.


> 20 февр. 2024 г., в 10:33, Николай Ижиков  написал(а):
> 
> Hello.
> 
> I prepared two PRs that moves parts of KafkaConfig to java.
> 
> [1] https://github.com/apache/kafka/pull/15387 - Log cleaner configuration 
> moved to CleanerConfig
> [2] https://github.com/apache/kafka/pull/15075 - ZooKeeper configuration 
> moved to ZkConfig
> 
> Please, take a look.

Re: [REVIEW REQUEST] Tests of ConsoleGroupCommand moved to tools

2024-02-25 Thread Николай Ижиков 
Hello!

Please, help me with the review.
One of PR’s is relatively simple and short so can be reviewed easily.
After finishing this PR’s all tests of `ConsoleGroupCommand` lands in `tools` 
module and the next step is review of command itself.

> 20 февр. 2024 г., в 11:32, Николай Ижиков  написал(а):
> 
> Hello. 
> 
> I’m working on moving `ConsoleGroupCommand` to `tools`.
> There are two PR’s that moves all tests of ConsoleGroupCommand to tools.
> Please, take a look.
> 
> [1] https://github.com/apache/kafka/pull/15365
> [2] https://github.com/apache/kafka/pull/15363
> 
> BIG PR here - https://github.com/apache/kafka/pull/14471
>