[jira] [Created] (KAFKA-13945) Add task-level metrics to Streams for bytes/records Produced

2022-05-28 Thread A. Sophie Blee-Goldman (Jira)
A. Sophie Blee-Goldman created KAFKA-13945:
--

 Summary: Add task-level metrics to Streams for bytes/records 
Produced
 Key: KAFKA-13945
 URL: https://issues.apache.org/jira/browse/KAFKA-13945
 Project: Kafka
  Issue Type: Improvement
  Components: streams
Reporter: A. Sophie Blee-Goldman






--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[DISCUSS] KIP-846: Task-level Streams metrics for bytes/records Produced

2022-05-28 Thread Sophie Blee-Goldman
Hey all,

I'd like to propose a very small KIP to add two metrics that will help fill
a gap in the derivable produced and consumed metrics. Please take a look
and reply here with any questions or concerns.

KIP-846: Task-level Streams metrics for bytes/records Produced


Given the small nature of this I'm going to call for a vote soon, but
please don't hesitate to raise anything you feel should be discussed in
more detail first.

Thanks!
Sophie


Re: [VOTE] KIP-843: Adding metricOrElseCreate method to Metrics

2022-05-28 Thread Ismael Juma
Thanks for the KIP. The method makes sense, but the name is a bit verbose.
Have we considered a more concise name?

Ismael

On Tue, May 24, 2022, 4:49 AM Sagar  wrote:

> Hi All,
>
> I would like to open a voting thread for the following KIP:
>
>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-843%3A+Adding+metricOrElseCreate+method+to+Metrics
>
> Thanks!
> Sagar.
>


Re: [VOTE] KIP-843: Adding metricOrElseCreate method to Metrics

2022-05-28 Thread Sagar
Hi Ismael,

Actually Bruno suggested renaming it to getMetricOrElseCreate and we
decided to go ahead with that one. These were the only names that we
considered for the KIP.

Thanks!
Sagar.


On Sat, May 28, 2022 at 8:19 PM Ismael Juma  wrote:

> Thanks for the KIP. The method makes sense, but the name is a bit verbose.
> Have we considered a more concise name?
>
> Ismael
>
> On Tue, May 24, 2022, 4:49 AM Sagar  wrote:
>
> > Hi All,
> >
> > I would like to open a voting thread for the following KIP:
> >
> >
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-843%3A+Adding+metricOrElseCreate+method+to+Metrics
> >
> > Thanks!
> > Sagar.
> >
>


Re: [DISCUSS] KIP-840: Config file option for MessageReader/MessageFormatter in ConsoleProducer/ConsoleConsumer

2022-05-28 Thread Alexandre Garnier
Hi!

Thanks for the feedback.
It's a good point, I updated KIP accordingly and did put the
dot-separated option in rejected alternatives.

Le ven. 27 mai 2022 à 10:22, deng ziming  a écrit :
>
> Thanks for the KIP, this is a good improvement. I only have one minor 
> suggestion.
>
> Currently many command line tools supports config file argument, but their 
> name style is not unified, for example, most newly added tools are using 
> --command-config, but ConsoleConsumer use —consumer.config。 I think we should 
> unify the naming style from now on, I recommend us to use --reader-config and 
> --formatter-config for the newly added arguments.
>
> --
> Best,
> Ziming
>
>
> > On May 26, 2022, at 4:36 PM, Alexandre Garnier  wrote:
> >
> > Hello everyone,
> >
> > Any feedback on this KIP https://cwiki.apache.org/confluence/x/bBqhD?
> > It is a straightforward improvement without any impact on existing users,
> > so not much to discuss besides maybe the option name.
> >
> > --
> > Alex
> >
> >
> > Le mer. 18 mai 2022 à 10:44, Alexandre Garnier  a écrit :
> >
> >> Hi everyone,
> >>
> >> I created a KIP to add a config file option of reader/formatter for
> >> kafka-console-(consumer|producer).sh tools.
> >> https://cwiki.apache.org/confluence/x/bBqhD
> >>
> >> Thanks for your feedback,
> >> --
> >> Alex
> >>
>


Jenkins build is unstable: Kafka » Kafka Branch Builder » trunk #960

2022-05-28 Thread Apache Jenkins Server
See 




Re: [DISCUSS] KIP-846: Task-level Streams metrics for bytes/records Produced

2022-05-28 Thread John Roesler
Thanks for the well motivated and documented KIP, Sophie! I’m in favor of this 
change. 

-John

On Sat, May 28, 2022, at 06:42, Sophie Blee-Goldman wrote:
> Hey all,
>
> I'd like to propose a very small KIP to add two metrics that will help fill
> a gap in the derivable produced and consumed metrics. Please take a look
> and reply here with any questions or concerns.
>
> KIP-846: Task-level Streams metrics for bytes/records Produced
> 
>
> Given the small nature of this I'm going to call for a vote soon, but
> please don't hesitate to raise anything you feel should be discussed in
> more detail first.
>
> Thanks!
> Sophie