PR review

2019-06-30 Thread M. Manna
https://github.com/apache/kafka/pull/6771

Hello,

Could the above PR can be reviewed? This has been waiting for a long time.

Just to mention, the package name should have "internal". Round-robin
partitioning should have been supported without/without a key from the
beginning. It provides user a guaranteed round-robin partitioning without
having to regard for key values (e.g. null/not null). From our business
side, this is a Kafka internal logic. Hence, the placement inside
"internal" package.

Thanks,


[jira] [Created] (KAFKA-8617) Replace EndTxn request/response with automated protocol

2019-06-30 Thread Boyang Chen (JIRA)
Boyang Chen created KAFKA-8617:
--

 Summary: Replace EndTxn request/response with automated protocol
 Key: KAFKA-8617
 URL: https://issues.apache.org/jira/browse/KAFKA-8617
 Project: Kafka
  Issue Type: Sub-task
Reporter: Boyang Chen
Assignee: Boyang Chen






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (KAFKA-8618) Replace WriteTxnMarkers request/response with automated protocol

2019-06-30 Thread Boyang Chen (JIRA)
Boyang Chen created KAFKA-8618:
--

 Summary: Replace WriteTxnMarkers request/response with automated 
protocol
 Key: KAFKA-8618
 URL: https://issues.apache.org/jira/browse/KAFKA-8618
 Project: Kafka
  Issue Type: Sub-task
Reporter: Boyang Chen
Assignee: Boyang Chen






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: [DISCUSS] KIP-221: Repartition Topic Hints in Streams

2019-06-30 Thread Levani Kokhreidze
Hello,

I would like to resurrect discussion around KIP-221. Going through the 
discussion thread, there’s seems to agreement around usefulness of this 
feature. 
Regarding the implementation, as far as I understood, the most optimal solution 
for me seems the following:

1) Add two method overloads to KStream#through method (essentially making topic 
name optional)
2) Enhance Produced class with numOfPartitions configuration field.

Those two changes will allow DSL users to control parallelism and trigger 
re-partition without doing stateful operations.

I will update KIP with interface changes around KStream#through if this changes 
sound sensible.

Kind regards,
Levani