[jira] [Commented] (KAFKA-1377) transient unit test failure in LogOffsetTest

[Manikumar Reddy (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-1377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14059734#comment-14059734
 ] 

Manikumar Reddy commented on KAFKA-1377:


LogOffsetTests are consistently failing on my machine.

kafka.server.LogOffsetTest > testGetOffsetsBeforeLatestTime FAILED
junit.framework.AssertionFailedError: Log for partition [topic,0] should be 
created
at junit.framework.Assert.fail(Assert.java:47)
at kafka.utils.TestUtils$.waitUntilTrue(TestUtils.scala:589)
at 
kafka.server.LogOffsetTest.testGetOffsetsBeforeLatestTime(LogOffsetTest.scala:85)

kafka.server.LogOffsetTest > testGetOffsetsBeforeEarliestTime FAILED
junit.framework.AssertionFailedError: Leader should be elected
at junit.framework.Assert.fail(Assert.java:47)
at kafka.utils.TestUtils$.waitUntilTrue(TestUtils.scala:589)
at 
kafka.server.LogOffsetTest.testGetOffsetsBeforeEarliestTime(LogOffsetTest.scala:188)

kafka.server.LogOffsetTest > testEmptyLogsGetOffsets FAILED
junit.framework.AssertionFailedError: Partition [kafka,0] metadata not 
propagated after 5000 ms
at junit.framework.Assert.fail(Assert.java:47)
at kafka.utils.TestUtils$.waitUntilTrue(TestUtils.scala:589)
at 
kafka.utils.TestUtils$.waitUntilMetadataIsPropagated(TestUtils.scala:629)
at 
kafka.utils.TestUtils$$anonfun$createTopic$1.apply(TestUtils.scala:174)
at 
kafka.utils.TestUtils$$anonfun$createTopic$1.apply(TestUtils.scala:173)
at 
scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:206)
at 
scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:206)
at scala.collection.immutable.Range$ByOne$class.foreach(Range.scala:285)
at scala.collection.immutable.Range$$anon$2.foreach(Range.scala:265)
at scala.collection.TraversableLike$class.map(TraversableLike.scala:206)
at scala.collection.immutable.Range.map(Range.scala:39)
at kafka.utils.TestUtils$.createTopic(TestUtils.scala:173)
at 
kafka.server.LogOffsetTest.testEmptyLogsGetOffsets(LogOffsetTest.scala:122)

kafka.server.LogOffsetTest > testGetOffsetsBeforeNow FAILED
junit.framework.AssertionFailedError: Leader should be elected
at junit.framework.Assert.fail(Assert.java:47)
at kafka.utils.TestUtils$.waitUntilTrue(TestUtils.scala:589)
at 
kafka.server.LogOffsetTest.testGetOffsetsBeforeNow(LogOffsetTest.scala:160)


> transient unit test failure in LogOffsetTest
> 
>
> Key: KAFKA-1377
> URL: https://issues.apache.org/jira/browse/KAFKA-1377
> Project: Kafka
>  Issue Type: Bug
>  Components: core
>Reporter: Jun Rao
>Assignee: Jun Rao
> Fix For: 0.8.2
>
> Attachments: KAFKA-1377.patch, KAFKA-1377_2014-04-11_17:42:13.patch, 
> KAFKA-1377_2014-04-11_18:14:45.patch
>
>
> Saw the following transient unit test failure.
> kafka.server.LogOffsetTest > testGetOffsetsBeforeEarliestTime FAILED
> junit.framework.AssertionFailedError: expected: but 
> was:
> at junit.framework.Assert.fail(Assert.java:47)
> at junit.framework.Assert.failNotEquals(Assert.java:277)
> at junit.framework.Assert.assertEquals(Assert.java:64)
> at junit.framework.Assert.assertEquals(Assert.java:71)
> at 
> kafka.server.LogOffsetTest.testGetOffsetsBeforeEarliestTime(LogOffsetTest.scala:198)



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Review Request 23439: Patch for KAFKA-1258

[Manikumar Reddy O]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23439/
---

Review request for kafka.


Bugs: KAFKA-1258
https://issues.apache.org/jira/browse/KAFKA-1258


Repository: kafka


Description
---

added shutdown hook to TestUtils.tempDir method to delete the  temporary 
directories.


Diffs
-

  core/src/test/scala/unit/kafka/utils/TestUtils.scala 
57b2bd5aefc511773a6a384aaac250b5979c0fa4 

Diff: https://reviews.apache.org/r/23439/diff/


Testing
---


Thanks,

Manikumar Reddy O

[jira] [Commented] (KAFKA-1258) Delete temporary data directory after unit test finishes

[Manikumar Reddy (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14059741#comment-14059741
 ] 

Manikumar Reddy commented on KAFKA-1258:


Created reviewboard https://reviews.apache.org/r/23439/diff/
 against branch origin/trunk

> Delete temporary data directory after unit test finishes
> 
>
> Key: KAFKA-1258
> URL: https://issues.apache.org/jira/browse/KAFKA-1258
> Project: Kafka
>  Issue Type: Bug
>Reporter: Guozhang Wang
>  Labels: newbie
> Fix For: 0.9.0
>
> Attachments: KAFKA-1258.patch
>
>
> Today in unit testsuite most of the time when a test case is setup a 
> temporary directory will be created with a random int as suffix, and will not 
> be deleted after the test. After a few unit tests this will create tons of 
> directories in java.io.tmpdir (/tmp for Linux). Would be better to remove 
> them for clean unit tests.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (KAFKA-1258) Delete temporary data directory after unit test finishes

[Manikumar Reddy (JIRA)]

 [ 
https://issues.apache.org/jira/browse/KAFKA-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Manikumar Reddy updated KAFKA-1258:
---

Attachment: KAFKA-1258.patch

> Delete temporary data directory after unit test finishes
> 
>
> Key: KAFKA-1258
> URL: https://issues.apache.org/jira/browse/KAFKA-1258
> Project: Kafka
>  Issue Type: Bug
>Reporter: Guozhang Wang
>  Labels: newbie
> Fix For: 0.9.0
>
> Attachments: KAFKA-1258.patch
>
>
> Today in unit testsuite most of the time when a test case is setup a 
> temporary directory will be created with a random int as suffix, and will not 
> be deleted after the test. After a few unit tests this will create tons of 
> directories in java.io.tmpdir (/tmp for Linux). Would be better to remove 
> them for clean unit tests.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Assigned] (KAFKA-1258) Delete temporary data directory after unit test finishes

[Manikumar Reddy (JIRA)]

 [ 
https://issues.apache.org/jira/browse/KAFKA-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Manikumar Reddy reassigned KAFKA-1258:
--

Assignee: Manikumar Reddy

> Delete temporary data directory after unit test finishes
> 
>
> Key: KAFKA-1258
> URL: https://issues.apache.org/jira/browse/KAFKA-1258
> Project: Kafka
>  Issue Type: Bug
>Reporter: Guozhang Wang
>Assignee: Manikumar Reddy
>  Labels: newbie
> Fix For: 0.9.0
>
> Attachments: KAFKA-1258.patch
>
>
> Today in unit testsuite most of the time when a test case is setup a 
> temporary directory will be created with a random int as suffix, and will not 
> be deleted after the test. After a few unit tests this will create tons of 
> directories in java.io.tmpdir (/tmp for Linux). Would be better to remove 
> them for clean unit tests.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Commented] (KAFKA-1258) Delete temporary data directory after unit test finishes

[Manikumar Reddy (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14059742#comment-14059742
 ] 

Manikumar Reddy commented on KAFKA-1258:


Junit 4.7 can be used to manage temporary folders. But this  requires
changes in all the test cases and some base test classes.

Submitted patch by adding shutdown hook to TestUtils.tempDir method.

> Delete temporary data directory after unit test finishes
> 
>
> Key: KAFKA-1258
> URL: https://issues.apache.org/jira/browse/KAFKA-1258
> Project: Kafka
>  Issue Type: Bug
>Reporter: Guozhang Wang
>Assignee: Manikumar Reddy
>  Labels: newbie
> Fix For: 0.9.0
>
> Attachments: KAFKA-1258.patch
>
>
> Today in unit testsuite most of the time when a test case is setup a 
> temporary directory will be created with a random int as suffix, and will not 
> be deleted after the test. After a few unit tests this will create tons of 
> directories in java.io.tmpdir (/tmp for Linux). Would be better to remove 
> them for clean unit tests.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (KAFKA-1258) Delete temporary data directory after unit test finishes

[Manikumar Reddy (JIRA)]

 [ 
https://issues.apache.org/jira/browse/KAFKA-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Manikumar Reddy updated KAFKA-1258:
---

Status: Patch Available  (was: Open)

> Delete temporary data directory after unit test finishes
> 
>
> Key: KAFKA-1258
> URL: https://issues.apache.org/jira/browse/KAFKA-1258
> Project: Kafka
>  Issue Type: Bug
>Reporter: Guozhang Wang
>Assignee: Manikumar Reddy
>  Labels: newbie
> Fix For: 0.9.0
>
> Attachments: KAFKA-1258.patch
>
>
> Today in unit testsuite most of the time when a test case is setup a 
> temporary directory will be created with a random int as suffix, and will not 
> be deleted after the test. After a few unit tests this will create tons of 
> directories in java.io.tmpdir (/tmp for Linux). Would be better to remove 
> them for clean unit tests.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (KAFKA-1531) zookeeper.connection.timeout.ms is set to 10000000 in configuration file in Kafka tarball

[Manikumar Reddy (JIRA)]

 [ 
https://issues.apache.org/jira/browse/KAFKA-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Manikumar Reddy updated KAFKA-1531:
---

Status: Patch Available  (was: Open)

> zookeeper.connection.timeout.ms is set to 1000 in configuration file in 
> Kafka tarball
> -
>
> Key: KAFKA-1531
> URL: https://issues.apache.org/jira/browse/KAFKA-1531
> Project: Kafka
>  Issue Type: Bug
>  Components: config
>Affects Versions: 0.8.0, 0.8.1.1
>Reporter: Michał Michalski
>Assignee: Manikumar Reddy
> Attachments: KAFKA-1531.patch, KAFKA-1531.patch
>
>
> I've noticed that Kafka tarball comes with 
> zookeeper.connection.timeout.ms=100 in server.properties while 
> https://kafka.apache.org/08/documentation.html says the default is 6000. This 
> setting was introduced in configuration file in 46b6144a, so quite a long 
> time ago (3 years), which makes it look intentional, but as per Jun Rao's 
> comment on IRC, 6000 sounds more reasonable, so that entry should probably be 
> changed or removed from config at all.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Review Request 23440: Patch for KAFKA-1536

[Manikumar Reddy O]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23440/
---

Review request for kafka.


Bugs: KAFKA-1536
https://issues.apache.org/jira/browse/KAFKA-1536


Repository: kafka


Description
---

JIRA status set to Patch Available in kafka-patch-review script


Diffs
-

  kafka-patch-review.py dc45549f886440f1721c60aab9aa0a4af9b4cbef 

Diff: https://reviews.apache.org/r/23440/diff/


Testing
---


Thanks,

Manikumar Reddy O

[jira] [Updated] (KAFKA-1536) Change the status of the JIRA to "Patch Available" in the kafka-review-tool

[Manikumar Reddy (JIRA)]

 [ 
https://issues.apache.org/jira/browse/KAFKA-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Manikumar Reddy updated KAFKA-1536:
---

Assignee: Manikumar Reddy
  Status: Patch Available  (was: Open)

> Change the status of the JIRA to "Patch Available" in the kafka-review-tool
> ---
>
> Key: KAFKA-1536
> URL: https://issues.apache.org/jira/browse/KAFKA-1536
> Project: Kafka
>  Issue Type: Bug
>Reporter: Guozhang Wang
>Assignee: Manikumar Reddy
> Fix For: 0.9.0
>
> Attachments: KAFKA-1536.patch
>
>
> When using the kafka-review-tool to upload a patch to certain jira, the 
> status remains "OPEN". It makes searching for JIRAs that needs review a bit 
> hard. Would be better to make the tool also change the status of the jira.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Commented] (KAFKA-1536) Change the status of the JIRA to "Patch Available" in the kafka-review-tool

[Manikumar Reddy (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14059791#comment-14059791
 ] 

Manikumar Reddy commented on KAFKA-1536:


Created reviewboard https://reviews.apache.org/r/23440/diff/
 against branch origin/trunk

> Change the status of the JIRA to "Patch Available" in the kafka-review-tool
> ---
>
> Key: KAFKA-1536
> URL: https://issues.apache.org/jira/browse/KAFKA-1536
> Project: Kafka
>  Issue Type: Bug
>Reporter: Guozhang Wang
> Fix For: 0.9.0
>
> Attachments: KAFKA-1536.patch
>
>
> When using the kafka-review-tool to upload a patch to certain jira, the 
> status remains "OPEN". It makes searching for JIRAs that needs review a bit 
> hard. Would be better to make the tool also change the status of the jira.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (KAFKA-1536) Change the status of the JIRA to "Patch Available" in the kafka-review-tool

[Manikumar Reddy (JIRA)]

 [ 
https://issues.apache.org/jira/browse/KAFKA-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Manikumar Reddy updated KAFKA-1536:
---

Attachment: KAFKA-1536.patch

> Change the status of the JIRA to "Patch Available" in the kafka-review-tool
> ---
>
> Key: KAFKA-1536
> URL: https://issues.apache.org/jira/browse/KAFKA-1536
> Project: Kafka
>  Issue Type: Bug
>Reporter: Guozhang Wang
> Fix For: 0.9.0
>
> Attachments: KAFKA-1536.patch
>
>
> When using the kafka-review-tool to upload a patch to certain jira, the 
> status remains "OPEN". It makes searching for JIRAs that needs review a bit 
> hard. Would be better to make the tool also change the status of the jira.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Commented] (KAFKA-1536) Change the status of the JIRA to "Patch Available" in the kafka-review-tool

[Manikumar Reddy (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14059793#comment-14059793
 ] 

Manikumar Reddy commented on KAFKA-1536:


kafka-patch-review.py script updated to set the JIRA status to PATCH AVAILABLE .
Script also updates the assignee field.


> Change the status of the JIRA to "Patch Available" in the kafka-review-tool
> ---
>
> Key: KAFKA-1536
> URL: https://issues.apache.org/jira/browse/KAFKA-1536
> Project: Kafka
>  Issue Type: Bug
>Reporter: Guozhang Wang
>Assignee: Manikumar Reddy
> Fix For: 0.9.0
>
> Attachments: KAFKA-1536.patch
>
>
> When using the kafka-review-tool to upload a patch to certain jira, the 
> status remains "OPEN". It makes searching for JIRAs that needs review a bit 
> hard. Would be better to make the tool also change the status of the jira.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Commented] (KAFKA-167) Move partition assignment to the broker

[nicu marasoiu (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14059796#comment-14059796
 ] 

nicu marasoiu commented on KAFKA-167:
-

Hi,

So I would suggest this: for each consumer group, one broker can be elected as 
partition/replica assignment HA coordinator using a standard election mechanism 
on zookeeper already available in Curator.

I think it is nicer to distribute as much as possible, and, while recognizing 
that the algorithm is more deterministic, stable and convergent when using a 
centralized coordinator, there is no reason to pick the same coordinator for 
different consumer groups.

Apart from the mail discussion thread, can you please indicate any discussion 
on design, implementation, so that I can try to pick a small part and code 
something for it?

Thanks,
Nicu Marasoiu

> Move partition assignment to the broker
> ---
>
> Key: KAFKA-167
> URL: https://issues.apache.org/jira/browse/KAFKA-167
> Project: Kafka
>  Issue Type: New Feature
>Reporter: Jay Kreps
>
> Currently partitions are assigned to consumers for consumption via a 
> co-ordination algorithm by the consumers. This means there is effectively no 
> master broker node, which is nice in a way, but makes the consumer logic 
> complex to implement. It would be good to move the co-ordination to the 
> brokers. This would make implementation of a consumer client much much 
> easier, since only minimal zk interaction would be required. There are a 
> number of details that would  have to be worked out to finalize the protocol. 
> Discussion is here:
> http://mail-archives.apache.org/mod_mbox/incubator-kafka-dev/201109.mbox/%3ccafbh0q2adjxcbcyqgh8tb4jxbas3hq5rlxk9o9w76we-bwa...@mail.gmail.com%3e



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Commented] (KAFKA-264) Change the consumer side load balancing and distributed co-ordination to use a consumer co-ordinator

[nicu marasoiu (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14059798#comment-14059798
 ] 

nicu marasoiu commented on KAFKA-264:
-

https://cwiki.apache.org/confluence/display/KAFKA/Consumer+co-ordinator link 
does not work..

> Change the consumer side load balancing and distributed co-ordination to use 
> a consumer co-ordinator
> 
>
> Key: KAFKA-264
> URL: https://issues.apache.org/jira/browse/KAFKA-264
> Project: Kafka
>  Issue Type: New Feature
>  Components: core
>Affects Versions: 0.7, 0.8.0
>Reporter: Neha Narkhede
>Assignee: Neha Narkhede
> Fix For: 0.9.0
>
> Attachments: KAFKA-264.v1.patch
>
>   Original Estimate: 672h
>  Remaining Estimate: 672h
>
> A high level design for the zookeeper consumer is here - 
> https://cwiki.apache.org/confluence/display/KAFKA/Consumer+co-ordinator



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (KAFKA-1258) Delete temporary data directory after unit test finishes

[Jay Kreps (JIRA)]

 [ 
https://issues.apache.org/jira/browse/KAFKA-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jay Kreps updated KAFKA-1258:
-

Resolution: Fixed
Status: Resolved  (was: Patch Available)

Committed. Thanks!

> Delete temporary data directory after unit test finishes
> 
>
> Key: KAFKA-1258
> URL: https://issues.apache.org/jira/browse/KAFKA-1258
> Project: Kafka
>  Issue Type: Bug
>Reporter: Guozhang Wang
>Assignee: Manikumar Reddy
>  Labels: newbie
> Fix For: 0.9.0
>
> Attachments: KAFKA-1258.patch
>
>
> Today in unit testsuite most of the time when a test case is setup a 
> temporary directory will be created with a random int as suffix, and will not 
> be deleted after the test. After a few unit tests this will create tons of 
> directories in java.io.tmpdir (/tmp for Linux). Would be better to remove 
> them for clean unit tests.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Resolved] (KAFKA-167) Move partition assignment to the broker

[Jay Kreps (JIRA)]

 [ 
https://issues.apache.org/jira/browse/KAFKA-167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jay Kreps resolved KAFKA-167.
-

Resolution: Fixed

This is being done (finally) in the new consumer implementation.

> Move partition assignment to the broker
> ---
>
> Key: KAFKA-167
> URL: https://issues.apache.org/jira/browse/KAFKA-167
> Project: Kafka
>  Issue Type: New Feature
>Reporter: Jay Kreps
>
> Currently partitions are assigned to consumers for consumption via a 
> co-ordination algorithm by the consumers. This means there is effectively no 
> master broker node, which is nice in a way, but makes the consumer logic 
> complex to implement. It would be good to move the co-ordination to the 
> brokers. This would make implementation of a consumer client much much 
> easier, since only minimal zk interaction would be required. There are a 
> number of details that would  have to be worked out to finalize the protocol. 
> Discussion is here:
> http://mail-archives.apache.org/mod_mbox/incubator-kafka-dev/201109.mbox/%3ccafbh0q2adjxcbcyqgh8tb4jxbas3hq5rlxk9o9w76we-bwa...@mail.gmail.com%3e



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Review Request 23442: Patch for KAFKA-1330

[Jay Kreps]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23442/
---

Review request for kafka.


Bugs: KAFKA-1330
https://issues.apache.org/jira/browse/KAFKA-1330


Repository: kafka


Description
---

Draft version of the new consumer.


Diffs
-

  clients/src/main/java/org/apache/kafka/clients/KafkaClient.java 
29658d4a15f112dc0af5ce517eaab93e6f00134b 
  clients/src/main/java/org/apache/kafka/clients/NetworkClient.java 
d8f9ce663ee24d2b0852c974136741280c39f8f8 
  clients/src/main/java/org/apache/kafka/clients/consumer/Consumer.java 
227f5646ee708af1b861c15237eda2140cfd4900 
  clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java 
46efc0c8483acacf42b2984ac3f3b9e0a4566187 
  clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerRecord.java 
436d8a479166eda29f2672b50fc99f288bbe3fa9 
  clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java 
fe93afa24fc20b03830f1d190a276041d15bd3b9 
  clients/src/main/java/org/apache/kafka/clients/consumer/MockConsumer.java 
c3aad3b4d6b677f759583f309061193f2f109250 
  
clients/src/main/java/org/apache/kafka/clients/producer/internals/Metadata.java 
4aa5b01d611631db72df47d50bbe30edb8c478db 
  clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java 
a016269512b6d6d6e0fd3fab997e9c8265024eb4 
  clients/src/main/java/org/apache/kafka/common/Cluster.java 
c62707ab3aba26771fc4b993df28bf8c44f32309 
  clients/src/main/java/org/apache/kafka/common/network/Selectable.java 
b68bbf00ab8eba6c5867d346c91188142593ca6e 
  clients/src/main/java/org/apache/kafka/common/network/Selector.java 
93f2f1c7b229205fc846b4e8bba527dd15355eb0 
  clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java 
6fe7573973832615976defa37fe0dfbb8f911939 
  clients/src/main/java/org/apache/kafka/common/protocol/Protocol.java 
044b03061802ee5e8ea4f1995fb0988e1a70e9a7 
  clients/src/main/java/org/apache/kafka/common/protocol/types/Struct.java 
8cecba50bf067713184208552af36469962cd628 
  clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java 
040e5b91005edb8f015afdfa76fd94e0bf3cb4ca 
  
clients/src/main/java/org/apache/kafka/common/requests/ConsumerMetadataRequest.java
 PRE-CREATION 
  
clients/src/main/java/org/apache/kafka/common/requests/ConsumerMetadataResponse.java
 PRE-CREATION 
  clients/src/main/java/org/apache/kafka/common/requests/FetchRequest.java 
PRE-CREATION 
  clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java 
PRE-CREATION 
  clients/src/main/java/org/apache/kafka/common/utils/Utils.java 
50af60198a3f20933d0e8cf89c3b95d89ee73f35 
  clients/src/test/java/org/apache/kafka/clients/MockClient.java 
aae8d4a1e98279470587d397cc779a9baf6fee6c 
  clients/src/test/java/org/apache/kafka/clients/NetworkClientTest.java 
2f98192b064d1ce7c0779e901293edb8c3801915 
  clients/src/test/java/org/apache/kafka/clients/producer/PartitionerTest.java 
f06e28ce21e80c1265258ad3ac7900b99e61493d 
  clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java 
5c5e3d40819e41cab7b52a0eeaee5f2e7317b7b3 
  clients/src/test/java/org/apache/kafka/test/MockSelector.java 
d61de529173314c044261ad9662bec735d67e97f 
  core/src/test/scala/integration/kafka/api/ConsumerTest.scala PRE-CREATION 
  core/src/test/scala/integration/kafka/api/IntegrationTestHarness.scala 
PRE-CREATION 
  core/src/test/scala/unit/kafka/integration/KafkaServerTestHarness.scala 
194dd70919a5f301d3131c56594e40a0ebb27311 
  core/src/test/scala/unit/kafka/integration/PrimitiveApiTest.scala 
9f04bd38be639cde3e7f402845dbe6ae92e87dc2 
  core/src/test/scala/unit/kafka/utils/TestUtils.scala 
3faa884f8eb83c7c00baab416d0acfb488dc39c1 

Diff: https://reviews.apache.org/r/23442/diff/


Testing
---


Thanks,

Jay Kreps

[jira] [Commented] (KAFKA-1330) Implement subscribe(TopicPartition...partitions) in the new consumer

[Jay Kreps (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14059904#comment-14059904
 ] 

Jay Kreps commented on KAFKA-1330:
--

Created reviewboard https://reviews.apache.org/r/23442/
 against branch trunk

> Implement subscribe(TopicPartition...partitions) in the new consumer
> 
>
> Key: KAFKA-1330
> URL: https://issues.apache.org/jira/browse/KAFKA-1330
> Project: Kafka
>  Issue Type: Sub-task
>  Components: consumer
>Affects Versions: 0.9.0
>Reporter: Neha Narkhede
> Attachments: KAFKA-1330.patch
>
>
> This involves adding basic fetch functionality (equivalent to SimpleConsumer) 
> to the new consumer. Effectively implementing 
> subscribe(TopicPartition...partitions) and 
> unsubscribe(TopicPartition...partitions).



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (KAFKA-1330) Implement subscribe(TopicPartition...partitions) in the new consumer

[Jay Kreps (JIRA)]

 [ 
https://issues.apache.org/jira/browse/KAFKA-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jay Kreps updated KAFKA-1330:
-

Attachment: KAFKA-1330.patch

> Implement subscribe(TopicPartition...partitions) in the new consumer
> 
>
> Key: KAFKA-1330
> URL: https://issues.apache.org/jira/browse/KAFKA-1330
> Project: Kafka
>  Issue Type: Sub-task
>  Components: consumer
>Affects Versions: 0.9.0
>Reporter: Neha Narkhede
> Attachments: KAFKA-1330.patch
>
>
> This involves adding basic fetch functionality (equivalent to SimpleConsumer) 
> to the new consumer. Effectively implementing 
> subscribe(TopicPartition...partitions) and 
> unsubscribe(TopicPartition...partitions).



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Assigned] (KAFKA-1330) Implement subscribe(TopicPartition...partitions) in the new consumer

[Jay Kreps (JIRA)]

 [ 
https://issues.apache.org/jira/browse/KAFKA-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jay Kreps reassigned KAFKA-1330:


Assignee: Jay Kreps

> Implement subscribe(TopicPartition...partitions) in the new consumer
> 
>
> Key: KAFKA-1330
> URL: https://issues.apache.org/jira/browse/KAFKA-1330
> Project: Kafka
>  Issue Type: Sub-task
>  Components: consumer
>Affects Versions: 0.9.0
>Reporter: Neha Narkhede
>Assignee: Jay Kreps
> Attachments: KAFKA-1330.patch
>
>
> This involves adding basic fetch functionality (equivalent to SimpleConsumer) 
> to the new consumer. Effectively implementing 
> subscribe(TopicPartition...partitions) and 
> unsubscribe(TopicPartition...partitions).



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Commented] (KAFKA-1330) Implement subscribe(TopicPartition...partitions) in the new consumer

[Jay Kreps (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14059905#comment-14059905
 ] 

Jay Kreps commented on KAFKA-1330:
--

Hey [~nmarasoi], sorry had actually been working on this for the last week...I 
should have assigned it to myself.

> Implement subscribe(TopicPartition...partitions) in the new consumer
> 
>
> Key: KAFKA-1330
> URL: https://issues.apache.org/jira/browse/KAFKA-1330
> Project: Kafka
>  Issue Type: Sub-task
>  Components: consumer
>Affects Versions: 0.9.0
>Reporter: Neha Narkhede
>Assignee: Jay Kreps
> Attachments: KAFKA-1330.patch
>
>
> This involves adding basic fetch functionality (equivalent to SimpleConsumer) 
> to the new consumer. Effectively implementing 
> subscribe(TopicPartition...partitions) and 
> unsubscribe(TopicPartition...partitions).



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Build failed in Jenkins: Kafka-trunk #221

[Apache Jenkins Server]

See 

Changes:

[jay.kreps] KAFKA-1258 Automatically delete temporary directories with a 
shutdown hook during tests to avoid leaking temp files. Patch by Manikumar 
Reddy.

--
Started by an SCM change
Building remotely on ubuntu-1 (Ubuntu ubuntu) in workspace 

Cloning the remote Git repository
Cloning repository https://git-wip-us.apache.org/repos/asf/kafka.git
 > git init 
Fetching upstream changes from https://git-wip-us.apache.org/repos/asf/kafka.git
 > git --version
 > git fetch --tags --progress 
 > https://git-wip-us.apache.org/repos/asf/kafka.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url 
 > https://git-wip-us.apache.org/repos/asf/kafka.git
 > git config remote.origin.fetch +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url 
 > https://git-wip-us.apache.org/repos/asf/kafka.git
Fetching upstream changes from https://git-wip-us.apache.org/repos/asf/kafka.git
 > git fetch --tags --progress 
 > https://git-wip-us.apache.org/repos/asf/kafka.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse origin/trunk^{commit}
Checking out Revision 4b3d03e8e0d660b27c7823c03dde075d6ce8348b (origin/trunk)
 > git config core.sparsecheckout
 > git checkout -f 4b3d03e8e0d660b27c7823c03dde075d6ce8348b
 > git rev-list 83a9aa55d340f6b2720394a49f01a88509e17e52
[Kafka-trunk] $ /bin/bash -xe /tmp/hudson7753533510060825590.sh
+ ./gradlew -PscalaVersion=2.10.1 test

ERROR: JAVA_HOME is set to an invalid directory: 
/home/hudson/tools/java/latest1.6

Please set the JAVA_HOME variable in your environment to match the
location of your Java installation.

Build step 'Execute shell' marked build as failure

[jira] [Commented] (KAFKA-1330) Implement subscribe(TopicPartition...partitions) in the new consumer

[Jay Kreps (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14059906#comment-14059906
 ] 

Jay Kreps commented on KAFKA-1330:
--

Guys, I posted a very rough draft that implements "simple consumer" 
functionality. I think implementing offset maintainence on top of this will be 
pretty easy and can be done once we have those new request defn's done. I'd 
like to start getting these changes in even though they aren't done to avoid 
keeping large patches against trunk. Specifically what I am hoping is that we 
can do a detailed review on the changes to common code, esp with respect to 
NetworkClient and be a bit lax on KafkaConsumer until we get something more 
complete.

> Implement subscribe(TopicPartition...partitions) in the new consumer
> 
>
> Key: KAFKA-1330
> URL: https://issues.apache.org/jira/browse/KAFKA-1330
> Project: Kafka
>  Issue Type: Sub-task
>  Components: consumer
>Affects Versions: 0.9.0
>Reporter: Neha Narkhede
>Assignee: Jay Kreps
> Attachments: KAFKA-1330.patch
>
>
> This involves adding basic fetch functionality (equivalent to SimpleConsumer) 
> to the new consumer. Effectively implementing 
> subscribe(TopicPartition...partitions) and 
> unsubscribe(TopicPartition...partitions).



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Can I get a review on KAFKA-1512?

[Jay Kreps]

Thx,

-Jay

[jira] [Updated] (KAFKA-1536) Change the status of the JIRA to "Patch Available" in the kafka-review-tool

[Guozhang Wang (JIRA)]

 [ 
https://issues.apache.org/jira/browse/KAFKA-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guozhang Wang updated KAFKA-1536:
-

Status: In Progress  (was: Patch Available)

> Change the status of the JIRA to "Patch Available" in the kafka-review-tool
> ---
>
> Key: KAFKA-1536
> URL: https://issues.apache.org/jira/browse/KAFKA-1536
> Project: Kafka
>  Issue Type: Bug
>Reporter: Guozhang Wang
>Assignee: Manikumar Reddy
> Fix For: 0.9.0
>
> Attachments: KAFKA-1536.patch
>
>
> When using the kafka-review-tool to upload a patch to certain jira, the 
> status remains "OPEN". It makes searching for JIRAs that needs review a bit 
> hard. Would be better to make the tool also change the status of the jira.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Review Request 23444: test

[Guozhang Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23444/
---

Review request for kafka.


Bugs: KAFKA-1536
https://issues.apache.org/jira/browse/KAFKA-1536


Repository: kafka


Description
---

dummy


Diffs
-

  kafka-patch-review.py dc45549f886440f1721c60aab9aa0a4af9b4cbef 

Diff: https://reviews.apache.org/r/23444/diff/


Testing
---


Thanks,

Guozhang Wang

[jira] [Updated] (KAFKA-1536) Change the status of the JIRA to "Patch Available" in the kafka-review-tool

[Guozhang Wang (JIRA)]

 [ 
https://issues.apache.org/jira/browse/KAFKA-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guozhang Wang updated KAFKA-1536:
-

Attachment: KAFKA-1536.patch

> Change the status of the JIRA to "Patch Available" in the kafka-review-tool
> ---
>
> Key: KAFKA-1536
> URL: https://issues.apache.org/jira/browse/KAFKA-1536
> Project: Kafka
>  Issue Type: Bug
>Reporter: Guozhang Wang
>Assignee: Manikumar Reddy
> Fix For: 0.9.0
>
> Attachments: KAFKA-1536.patch, KAFKA-1536.patch
>
>
> When using the kafka-review-tool to upload a patch to certain jira, the 
> status remains "OPEN". It makes searching for JIRAs that needs review a bit 
> hard. Would be better to make the tool also change the status of the jira.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Review Request 23445: test

[Guozhang Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23445/
---

Review request for kafka.


Bugs: KAFKA-1538
https://issues.apache.org/jira/browse/KAFKA-1538


Repository: kafka


Description
---

dummy


Diffs
-

  kafka-patch-review.py dc45549f886440f1721c60aab9aa0a4af9b4cbef 

Diff: https://reviews.apache.org/r/23445/diff/


Testing
---


Thanks,

Guozhang Wang

[jira] [Created] (KAFKA-1538) TEST JIRA for KAFKA-1536

[Guozhang Wang (JIRA)]

Guozhang Wang created KAFKA-1538:


 Summary: TEST JIRA for KAFKA-1536
 Key: KAFKA-1538
 URL: https://issues.apache.org/jira/browse/KAFKA-1538
 Project: Kafka
  Issue Type: Test
Reporter: Guozhang Wang






--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Commented] (KAFKA-1536) Change the status of the JIRA to "Patch Available" in the kafka-review-tool

[Guozhang Wang (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14059974#comment-14059974
 ] 

Guozhang Wang commented on KAFKA-1536:
--

Created reviewboard https://reviews.apache.org/r/23444/
 against branch origin/trunk

> Change the status of the JIRA to "Patch Available" in the kafka-review-tool
> ---
>
> Key: KAFKA-1536
> URL: https://issues.apache.org/jira/browse/KAFKA-1536
> Project: Kafka
>  Issue Type: Bug
>Reporter: Guozhang Wang
>Assignee: Manikumar Reddy
> Fix For: 0.9.0
>
> Attachments: KAFKA-1536.patch, KAFKA-1536.patch
>
>
> When using the kafka-review-tool to upload a patch to certain jira, the 
> status remains "OPEN". It makes searching for JIRAs that needs review a bit 
> hard. Would be better to make the tool also change the status of the jira.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Re: Review Request 23440: Patch for KAFKA-1536

[Guozhang Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23440/#review47688
---

Ship it!


Local test works.

- Guozhang Wang


On July 12, 2014, 1:51 p.m., Manikumar Reddy O wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23440/
> ---
> 
> (Updated July 12, 2014, 1:51 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1536
> https://issues.apache.org/jira/browse/KAFKA-1536
> 
> 
> Repository: kafka
> 
> 
> Description
> ---
> 
> JIRA status set to Patch Available in kafka-patch-review script
> 
> 
> Diffs
> -
> 
>   kafka-patch-review.py dc45549f886440f1721c60aab9aa0a4af9b4cbef 
> 
> Diff: https://reviews.apache.org/r/23440/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Manikumar Reddy O
> 
>

[jira] [Commented] (KAFKA-1538) TEST JIRA for KAFKA-1536

[Guozhang Wang (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-1538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14059975#comment-14059975
 ] 

Guozhang Wang commented on KAFKA-1538:
--

Created reviewboard https://reviews.apache.org/r/23445/
 against branch origin/trunk

> TEST JIRA for KAFKA-1536
> 
>
> Key: KAFKA-1538
> URL: https://issues.apache.org/jira/browse/KAFKA-1538
> Project: Kafka
>  Issue Type: Test
>Reporter: Guozhang Wang
> Attachments: KAFKA-1538.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (KAFKA-1538) TEST JIRA for KAFKA-1536

[Guozhang Wang (JIRA)]

 [ 
https://issues.apache.org/jira/browse/KAFKA-1538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guozhang Wang updated KAFKA-1538:
-

Assignee: Guozhang Wang
  Status: Patch Available  (was: Open)

> TEST JIRA for KAFKA-1536
> 
>
> Key: KAFKA-1538
> URL: https://issues.apache.org/jira/browse/KAFKA-1538
> Project: Kafka
>  Issue Type: Test
>Reporter: Guozhang Wang
>Assignee: Guozhang Wang
> Attachments: KAFKA-1538.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (KAFKA-1538) TEST JIRA for KAFKA-1536

[Guozhang Wang (JIRA)]

 [ 
https://issues.apache.org/jira/browse/KAFKA-1538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guozhang Wang updated KAFKA-1538:
-

Attachment: KAFKA-1538.patch

> TEST JIRA for KAFKA-1536
> 
>
> Key: KAFKA-1538
> URL: https://issues.apache.org/jira/browse/KAFKA-1538
> Project: Kafka
>  Issue Type: Test
>Reporter: Guozhang Wang
> Attachments: KAFKA-1538.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (KAFKA-264) Change the consumer side load balancing and distributed co-ordination to use a consumer co-ordinator

[Guozhang Wang (JIRA)]

 [ 
https://issues.apache.org/jira/browse/KAFKA-264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guozhang Wang updated KAFKA-264:


Description: A high level design for the zookeeper consumer is here - 
https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Detailed+Consumer+Coordinator+Design
  (was: A high level design for the zookeeper consumer is here - 
https://cwiki.apache.org/confluence/display/KAFKA/Consumer+co-ordinator)

> Change the consumer side load balancing and distributed co-ordination to use 
> a consumer co-ordinator
> 
>
> Key: KAFKA-264
> URL: https://issues.apache.org/jira/browse/KAFKA-264
> Project: Kafka
>  Issue Type: New Feature
>  Components: core
>Affects Versions: 0.7, 0.8.0
>Reporter: Neha Narkhede
>Assignee: Neha Narkhede
> Fix For: 0.9.0
>
> Attachments: KAFKA-264.v1.patch
>
>   Original Estimate: 672h
>  Remaining Estimate: 672h
>
> A high level design for the zookeeper consumer is here - 
> https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Detailed+Consumer+Coordinator+Design



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Re: Can I get a review on KAFKA-1512?

[Gwen Shapira]

Looks like Jun's comments on review board were not addressed?
They seem valid to me - especially the points about IPv6 (seen this at some
customers) and InetAddress having both host and port.

Gwen


On Sat, Jul 12, 2014 at 1:21 PM, Jay Kreps  wrote:

> Thx,
>
> -Jay
>