Re: [VOTE] Apache Kafka Release 0.8.1 - Candidate 2

[Martin Kleppmann]

+1. Verified all checksums and GPG signatures. Ran unit tests on source 
package. Tested each of the binary packages by running Samza's hello-samza test 
project on it, and verifying that it works.

There is a spurious zero-length file in that directory: kafka_2.8.0-.8.1.tgz.md5

Martin

On 8 Mar 2014, at 05:05, Jun Rao  wrote:
> +1. Verified quickstart and unit tests.
> 
> Thanks,
> 
> Jun
> 
> 
> On Tue, Mar 4, 2014 at 10:59 PM, Joe Stein  wrote:
> 
>> This is the second candidate for release of Apache Kafka 0.8.1.
>> 
>> This release candidate fixes the following two JIRA
>> KAFKA-1288and
>> KAFKA-1289  and updated
>> release steps with the gradle changes
>> https://cwiki.apache.org/confluence/display/KAFKA/Release+Process for
>> build
>> and verification post build.
>> 
>> Release Notes (updated) for the 0.8.1 release
>> 
>> https://people.apache.org/~joestein/kafka-0.8.1-candidate2/RELEASE_NOTES.html
>> 
>> *** Please download, test and vote by Monday, March 10th, 12pm PT
>> 
>> Kafka's KEYS file containing PGP keys we use to sign the release:
>> http://svn.apache.org/repos/asf/kafka/KEYS in addition to the md5, sha1
>> and
>> sha2 (SHA256) checksum.
>> 
>> * Release artifacts to be voted upon (source and binary):
>> https://people.apache.org/~joestein/kafka-0.8.1-candidate2/
>> 
>> * Maven artifacts to be voted upon prior to release:
>> https://repository.apache.org/content/groups/staging/
>> 
>> * The tag to be voted upon (off the 0.8.1 branch) is the 0.8.1 tag
>> 
>> https://git-wip-us.apache.org/repos/asf?p=kafka.git;a=tag;h=62f8aaf74c9d36d1dd49cc7e572a7289206b6414
>> 
>> /***
>> Joe Stein
>> Founder, Principal Consultant
>> Big Data Open Source Security LLC
>> http://www.stealth.ly
>> Twitter: @allthingshadoop 
>> /
>> 

Re: command line tools

[Michael G. Noll]

I just happen to come across that message.  As someone who is a mere
Kafka user take my feedback with a grain of salt.

On 03/05/2014 05:01 AM, Jay Kreps wrote:
> Personally I don't mind the current approach as it is discoverable and
> works with tab completion.

Having typical shell features such as tab completion are indeed nice.


> I wouldn't be opposed to replacing kafka-run-class.sh with a generic kafka
> script that handles the java and logging options and maintaining a human
> friendly mapping for some of the class names so that e.g.
>   ./kafka topics --list
>   ./kafka console-producer --broker localhost:9092
> would work as a short cut for some fully qualified name:
>   ./kafka kafka.producer.ConsoleProducer
> and
>   ./kafka
> would print a list of known commands. We would probably need a way to
> customize memory settings for each command as we do now, though.

If you decide to go for a `kafka  ...` approach, what about
at least splitting the admin commands (e.g. topic management and such)
from non-admin commands (e.g. starting console producers/consumers)?

$ kafka admin topics --create ...
$ kafka admin topics --list

(Admittedly listing topics is a pretty safe command but should sitll
fall under the admin category IMHO.)

Such a distinction would also give some hints on how dangerous a
potential commandline could be (say, `kafka admin` commands are likely
to change the state of the cluster itself, whereas `kafka
console-producer` would "only" start to read data, which should have a
lesser impact if things go wrong).

What would also be nice is a "[-h|--help]" option (or a `kafka help
` variant) that would describe each command.  But IIRC there
may be a discussion thread/JIRA ticket for that already.

> We would
> need some way to make this typo resistent (e.g. if you type a command wrong
> you should get a reasonable error and not some big class not found stack
> trace).

I agree that such stack traces are irritating.  At 2 AM in the morning
an Ops person does not want filter relevant error messages from the
stacktrack noise.  (See the related thread on "Logging irrelevant
things" from Mar 05).


All the above being said, I'm happy to hear you are discussing how to
improve the current CLI tools!

--Michael






signature.asc
Description: OpenPGP digital signature