[jira] [Created] (KAFKA-679) Phabricator for code review
Neha Narkhede created KAFKA-679: --- Summary: Phabricator for code review Key: KAFKA-679 URL: https://issues.apache.org/jira/browse/KAFKA-679 Project: Kafka Issue Type: New Feature Reporter: Neha Narkhede Sriram proposed adding phabricator support for code reviews. >From http://phabricator.org/ : "Phabricator is a open source collection of web >applications which make it easier to write, review, and share source code. It >is currently available as an early release. Phabricator was developed at >Facebook." It's open source so pretty much anyone could host an instance of this software. To begin with, there will be a public-facing instance located at http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL http://osuosl.org). We can use this JIRA to deal with adding (and ensuring) Apache-friendly support that will allow us to do code reviews with Phabricator for Kafka. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-679) Phabricator for code review
[ https://issues.apache.org/jira/browse/KAFKA-679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13539092#comment-13539092 ] Neha Narkhede commented on KAFKA-679: - Sriram, would you like to take this on ? > Phabricator for code review > --- > > Key: KAFKA-679 > URL: https://issues.apache.org/jira/browse/KAFKA-679 > Project: Kafka > Issue Type: New Feature >Reporter: Neha Narkhede > > Sriram proposed adding phabricator support for code reviews. > From http://phabricator.org/ : "Phabricator is a open source collection of > web applications which make it easier to write, review, and share source > code. It is currently available as an early release. Phabricator was > developed at Facebook." > It's open source so pretty much anyone could host an instance of this > software. > To begin with, there will be a public-facing instance located at > http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL > http://osuosl.org). > We can use this JIRA to deal with adding (and ensuring) Apache-friendly > support that will allow us to do code reviews with Phabricator for Kafka. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-679) Phabricator for code review
[ https://issues.apache.org/jira/browse/KAFKA-679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13539109#comment-13539109 ] Jay Kreps commented on KAFKA-679: - This seems kind of all-encompassing (code review, wiki, bug tracking, etc). Are you saying we would use this for everything or just code reviews. For code reviews, is it better than review board? > Phabricator for code review > --- > > Key: KAFKA-679 > URL: https://issues.apache.org/jira/browse/KAFKA-679 > Project: Kafka > Issue Type: New Feature >Reporter: Neha Narkhede > > Sriram proposed adding phabricator support for code reviews. > From http://phabricator.org/ : "Phabricator is a open source collection of > web applications which make it easier to write, review, and share source > code. It is currently available as an early release. Phabricator was > developed at Facebook." > It's open source so pretty much anyone could host an instance of this > software. > To begin with, there will be a public-facing instance located at > http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL > http://osuosl.org). > We can use this JIRA to deal with adding (and ensuring) Apache-friendly > support that will allow us to do code reviews with Phabricator for Kafka. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-679) Phabricator for code review
[ https://issues.apache.org/jira/browse/KAFKA-679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13539111#comment-13539111 ] Jay Kreps commented on KAFKA-679: - Also how would we host it? We need something we can have someone else administer because it is a huge hassle. > Phabricator for code review > --- > > Key: KAFKA-679 > URL: https://issues.apache.org/jira/browse/KAFKA-679 > Project: Kafka > Issue Type: New Feature >Reporter: Neha Narkhede > > Sriram proposed adding phabricator support for code reviews. > From http://phabricator.org/ : "Phabricator is a open source collection of > web applications which make it easier to write, review, and share source > code. It is currently available as an early release. Phabricator was > developed at Facebook." > It's open source so pretty much anyone could host an instance of this > software. > To begin with, there will be a public-facing instance located at > http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL > http://osuosl.org). > We can use this JIRA to deal with adding (and ensuring) Apache-friendly > support that will allow us to do code reviews with Phabricator for Kafka. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-679) Phabricator for code review
[ https://issues.apache.org/jira/browse/KAFKA-679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13539116#comment-13539116 ] Neha Narkhede commented on KAFKA-679: - For code reviews, it seems to be better than reviewboard. There are a bunch of nifty features like being able to upload diffs from command line, update diffs from command line. There also seems to be integration with Apache JIRA, Hive and Hbase seem to be using it - https://issues.apache.org/jira/browse/HIVE-2486, https://issues.apache.org/jira/browse/HBASE-4611. Regarding hosting, here is what they say - "To begin with, there will be a public-facing instance located at http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL http://osuosl.org)." I'm not saying we just decide to use it, but it will be great to have someone look into how easy it is to use and integrate with Apache. > Phabricator for code review > --- > > Key: KAFKA-679 > URL: https://issues.apache.org/jira/browse/KAFKA-679 > Project: Kafka > Issue Type: New Feature >Reporter: Neha Narkhede > > Sriram proposed adding phabricator support for code reviews. > From http://phabricator.org/ : "Phabricator is a open source collection of > web applications which make it easier to write, review, and share source > code. It is currently available as an early release. Phabricator was > developed at Facebook." > It's open source so pretty much anyone could host an instance of this > software. > To begin with, there will be a public-facing instance located at > http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL > http://osuosl.org). > We can use this JIRA to deal with adding (and ensuring) Apache-friendly > support that will allow us to do code reviews with Phabricator for Kafka. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-679) Phabricator for code review
[ https://issues.apache.org/jira/browse/KAFKA-679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13539122#comment-13539122 ] Sriram Subramanian commented on KAFKA-679: -- It looks promising. I will have a look at it and we can then further discuss on the pros and cons. > Phabricator for code review > --- > > Key: KAFKA-679 > URL: https://issues.apache.org/jira/browse/KAFKA-679 > Project: Kafka > Issue Type: New Feature >Reporter: Neha Narkhede > > Sriram proposed adding phabricator support for code reviews. > From http://phabricator.org/ : "Phabricator is a open source collection of > web applications which make it easier to write, review, and share source > code. It is currently available as an early release. Phabricator was > developed at Facebook." > It's open source so pretty much anyone could host an instance of this > software. > To begin with, there will be a public-facing instance located at > http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL > http://osuosl.org). > We can use this JIRA to deal with adding (and ensuring) Apache-friendly > support that will allow us to do code reviews with Phabricator for Kafka. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (KAFKA-679) Phabricator for code review
[ https://issues.apache.org/jira/browse/KAFKA-679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriram Subramanian reassigned KAFKA-679: Assignee: Sriram Subramanian > Phabricator for code review > --- > > Key: KAFKA-679 > URL: https://issues.apache.org/jira/browse/KAFKA-679 > Project: Kafka > Issue Type: New Feature >Reporter: Neha Narkhede >Assignee: Sriram Subramanian > > Sriram proposed adding phabricator support for code reviews. > From http://phabricator.org/ : "Phabricator is a open source collection of > web applications which make it easier to write, review, and share source > code. It is currently available as an early release. Phabricator was > developed at Facebook." > It's open source so pretty much anyone could host an instance of this > software. > To begin with, there will be a public-facing instance located at > http://reviews.facebook.net (sponsored by Facebook and hosted by the OSUOSL > http://osuosl.org). > We can use this JIRA to deal with adding (and ensuring) Apache-friendly > support that will allow us to do code reviews with Phabricator for Kafka. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-657) Add an API to commit offsets
[ https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13539141#comment-13539141 ] Neha Narkhede commented on KAFKA-657: - +1 on v5. Just a minor comment which I think Jun raised as well - KafkaApis Today, we have a pretty awkward way of handling error codes for the various APIs in the handle() method. We should probably fix that, but until then, it will be good to maintain consistency. The new APIs are missing that error handling. > Add an API to commit offsets > > > Key: KAFKA-657 > URL: https://issues.apache.org/jira/browse/KAFKA-657 > Project: Kafka > Issue Type: New Feature >Reporter: Jay Kreps > Labels: project > Attachments: KAFKA-657v1.patch, KAFKA-657v2.patch, KAFKA-657v3.patch, > KAFKA-657v4.patch, KAFKA-657v5.patch > > > Currently the consumer directly writes their offsets to zookeeper. Two > problems with this: (1) This is a poor use of zookeeper, and we need to > replace it with a more scalable offset store, and (2) it makes it hard to > carry over to clients in other languages. A first step towards accomplishing > that is to add a proper Kafka API for committing offsets. The initial version > of this would just write to zookeeper as we do today, but in the future we > would then have the option of changing this. > This api likely needs to take a sequence of > consumer-group/topic/partition/offset entries and commit them all. > It would be good to do a wiki design on how this would work and consensus on > that first. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KAFKA-671) DelayedProduce requests should not hold full producer request data
[ https://issues.apache.org/jira/browse/KAFKA-671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-671: Priority: Blocker (was: Major) > DelayedProduce requests should not hold full producer request data > -- > > Key: KAFKA-671 > URL: https://issues.apache.org/jira/browse/KAFKA-671 > Project: Kafka > Issue Type: Bug >Affects Versions: 0.8 >Reporter: Joel Koshy >Priority: Blocker > Fix For: 0.8.1 > > > Per summary, this leads to unnecessary memory usage. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KAFKA-624) Add 07 ConsoleConsumer to validate message content for Migration Tool testcases
[ https://issues.apache.org/jira/browse/KAFKA-624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-624: Labels: replication-testing (was: ) > Add 07 ConsoleConsumer to validate message content for Migration Tool > testcases > --- > > Key: KAFKA-624 > URL: https://issues.apache.org/jira/browse/KAFKA-624 > Project: Kafka > Issue Type: Task >Reporter: John Fung >Assignee: John Fung > Labels: replication-testing > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
