Issues Jenkins - release
Hi all I am having issues with the release. Some jobs failed, and I just noticed it. It has been failing since https://github.com/apache/jspwiki/commit/71424cc587c43cd1418e56c99086db06a6b2fb46, which is basically to prepare the release. I also don't understand why it is trying to use version 2.12.13-snapshot when the code has version 2.12.2-snapshot. Any idea? Should I cancel and start over with another version RC2?? Thanks. Arturo
Re: Issues Jenkins - release
Hi! I think everything is ok. The ci building is failing, not the one used to prepare the release (otherwise you wouldn't be able to do the tag). Haven't had the time to look at it closely, but it seems to me that the error is derived from several issues - the sonar scanner requires jdk-17 to run at sonarcloud - b/c of that, we had to split the ci build on 3 steps, mvn package, sq upload, snapshot deployment - that third stage skips tests in order to do it a bit faster - b/c of that, a test-jar dependency isn't built and uploaded, and when that test-jar is needed afterwards makes the build fail We haven't experienced this before b/c we had prior 2.12.2 snapshots at repository.a.o, and probably those were used on the ci builds. In the moment we switched to a new version (the commit you reference) the build doesn't find the required test-jar anywhere, so it fails. The release build hasn't failed b/c it doesn't skip the tests, so the test-jar does get built. I think it's ok to fix this post-release, especially if we switch to JDK-17, that would mean change the Jenkinsfile to one maven build instead of the 3 we have now. Hopefully this makes sense? cheers, juan pablo On Fri, Jun 14, 2024 at 10:15 PM Arturo Bernal wrote: > > Hi all > > I am having issues with the release. Some jobs failed, and I just noticed > it. > It has been failing since > https://github.com/apache/jspwiki/commit/71424cc587c43cd1418e56c99086db06a6b2fb46, > which is basically to prepare the release. I also don't understand why it > is trying to use version 2.12.13-snapshot when the code has version > 2.12.2-snapshot. > > Any idea? Should I cancel and start over with another version RC2?? > > Thanks. > > Arturo
Re: [VOTE] Release JSPWiki version 2.12.2
Hi! +1 just one minor nitpick, regarding the convenience zip of wikipages: I think we should include both flavours of wikipages (jspwiki and markdown) for each language, instead of only the jspwiki ones. As we vote on the source code and convenience binaries/zips are just that, convenience, we don't have to re-spin the release, just commit the markdown zips at https://dist.apache.org/repos/dist/dev/jspwiki/2.12.2-RC1/ and that would be enough cheers, juan pablo On Fri, Jun 14, 2024 at 1:43 AM Murray Altheim wrote: > > +1 > > Looks great, thanks! > > On 14/06/24 04:42, Harry Metske wrote: > > +1 > > > > thanks for all the work, > > Harry > > > > On Thu, 13 Jun 2024 at 00:08, Arturo Bernal wrote: > > > >> This is a release vote for Apache JSPWiki, version 2.12.2. The vote will be > >> open for at least 72 hours from now. > >> > >>It fixes the following issues: > >>https://issues.apache.org/jira/projects/JSPWIKI/versions/12353517 > >>https://github.com/apache/jspwiki/blob/2.12.2-RC1/ChangeLog.md > >> > >>You can see a curated changelog at > >> https://jspwiki-wiki.apache.org/Wiki.jsp?page=NewIn2.12 > >> > >>Note that we are voting upon the source (tag), binaries are provided for > >> convenience. > >> > >>Everybody is encouraged to vote. > >> > >>Source and binary files: > >>https://dist.apache.org/repos/dist/dev/jspwiki/2.12.2-RC1/ > >> > >>Nexus staging repo: > >> https://repository.apache.org/content/repositories/orgapachejspwiki-1032/ > >> > >>The tag to be voted upon > >>https://github.com/apache/jspwiki/tree/2.12.2-RC1 > >> > >>JSPWiki's KEYS file containing PGP keys we use to sign the release: > >>https://www.apache.org/dist/jspwiki/KEYS > >> > >> *** Please download, test and vote: > >> > >> [ ] +1 Approve the release > >> [ ] 0 Don't mind > >> [ ] -1 Disapprove the release (please provide specific comments) > >> > >> Arturo > >> > > > > -- > > ... > Murray Altheim= = === > http://www.altheim.com/murray/ === === > = = === > In the evening > The rice leaves in the garden > Rustle in the autumn wind > That blows through my reed hut. > -- Minamoto no Tsunenobu >
