Re: Failing CI builds (was: Re: [PR] JSPWIKI-925 - Add Missing i18n Literals for Multiple Languages [jspwiki])

2023-10-19 Thread Arturo Bernal 
Hi Juan Pablo,

I apologize for the confusion earlier. Upon further review, I realized that
the job is actually working fine. The issue was on my end; I made the PR
before the fix for the jobs was implemented. That's why I thought there was
a problem.

Thank you for your prompt response and advice. I appreciate your help.

Best regards,

Arturo


On Wed, Oct 18, 2023 at 11:55 PM Juan Pablo Santos Rodríguez <
juanpablo.san...@gmail.com> wrote:

> Hi,
>
> Do you have the failing build at hand? Last build on master [#1] shows it
> finished ok, whereas the invalid file causing the issue [#2] looks ok on
> Nexus.
>
> If the issue is happening on your machine, perhaps that file is malformed
> on your .m2? In that case, deleting it there should be enough to fix the
> issue.
>
>
> Best regards,
> juan pablo
>
>
> [#1]
>
> https://ci-builds.apache.org/job/JSPWiki/job/ci/job/master/lastSuccessfulBuild/
> [#2
> 
> ]
>
> https://repository.apache.org/content/repositories/snapshots/org/apache/jspwiki/wikipages/jspwiki-wikipages-en/maven-metadata.xml
>
> El mié, 18 oct 2023, 23:08, Arturo Bernal  escribió:
>
> > Hi JP, I just checked, and it seems the issue is still occurring.
> >
> > Could you please advise on what I might be doing wrong or what I should
> be
> > looking for?"
> >
> > Kind regards
> >
> > Arturo
> >
> >
> > On Sat, Oct 14, 2023 at 6:57 PM Arturo Bernal 
> wrote:
> >
> > > Tank you JP
> > >
> > > Arturo
> > >
> > >
> > > On Sat, Oct 14, 2023 at 3:47 PM Juan Pablo Santos Rodríguez <
> > > juanpablo.san...@gmail.com> wrote:
> > >
> > >> Hi,
> > >>
> > >> Issue is fixed now, associated Jira had been resolved.
> > >>
> > >>
> > >> Cheers,
> > >> juan pablo
> > >>
> > >> El mié, 11 oct 2023, 10:31, Juan Pablo Santos Rodríguez <
> > >> juanpablo.san...@gmail.com> escribió:
> > >>
> > >> > Hi,
> > >> >
> > >> > yup, noticed a couple of days ago, seems a malformed maven metadata
> > >> > file has been
> > >> > uploaded to the snapshots repository, making impossible to deploy a
> > >> > specific module. As
> > >> > our ci build automatically deploys snapshots, we're stucked there.
> > >> >
> > >> > Contacted infra a couple of days back about this [#1], but no
> answers
> > >> > yet; also opened
> > >> > a jira ticket today ([#2]) to track this.
> > >> >
> > >> >
> > >> > best regards,
> > >> > juan pablo
> > >> >
> > >> > [#1]
> https://lists.apache.org/thread/7w1gmzcr2xhgttssl0s83pv80h1szql8
> > >> > (needs asf login)
> > >> > [#2] https://issues.apache.org/jira/browse/INFRA-25078 (needs asf
> > >> login)
> > >> >
> > >> > On Wed, Oct 11, 2023 at 1:36 AM Murray Altheim <
> murra...@altheim.com>
> > >> > wrote:
> > >> > >
> > >> > > To be clear, in XML, comments are permitted in the XML Prolog
> > >> (Production
> > >> > > 22 in the XML spec) and the doctypedecl (Production 28), but I
> think
> > >> the
> > >> > > POM parser barfs on them.
> > >> > >
> > >> > > On 11/10/23 12:24, Murray Altheim wrote:
> > >> > > > Hi Arturo,
> > >> > > >
> > >> > > > Does there happen to be an XML comment between the 
> > >> declaration
> > >> > > > and the  start tag? That's what the error message
> > suggests.
> > >> > > >
> > >> > > > Cheers,
> > >> > > >
> > >> > > > Murray
> > >> > > >
> > >> > > > On 11/10/23 05:44, arturobernalg (via GitHub) wrote:
> > >> > > >>
> > >> > > >> arturobernalg commented on PR #312:
> > >> > > >> URL:
> > >> > https://github.com/apache/jspwiki/pull/312#issuecomment-1755833207
> > >> > > >>
> > >> > > >> @juanpablo-santos
> > >> > > >> I'm encountering the following error while when the CI is
> > >> running:
> > >> > > >> ```[ERROR] Failed to execute goal
> > >> > org.apache.maven.plugins:maven-deploy-plugin:3.1.1:deploy
> > >> (default-deploy)
> > >> > on project jspwiki-wikipages-en: Failed to update metadata
> > >> > > >>
> > >> org.apache.jspwiki.wikipages:jspwiki-wikipages-en/maven-metadata.xml:
> > >> > Could not parse metadata
> > >> >
> > >>
> >
> /home/jenkins/.m2/repository/org/apache/jspwiki/wikipages/jspwiki-wikipages-en/maven-metadata-apache.snapshots.https.xml:
> > >> > in epilog non
> > >> > > >> whitespace content is not allowed but got t (position: END_TAG
> > seen
> > >> > ...\nt... @12:2) -> [Help 1]
> > >> > > >> ```
> > >> > > >> This isn't the first time I've encountered this issue; I
> > faced
> > >> > the same error in another PR as well. Do you have any insights into
> > what
> > >> > might be causing it?"
> > >> > >
> > >> > >
> > >> >
> > >>
> >
> ...
> > >> > > Murray Altheim 
> >  = =
> > >> > ===
> > >> > > http://www.altheim.com/murray/
> > >>  ===
> > >> > ===
> > >> > >
> >  =
> > >> =
> > >> > ===
> > >> > >  In the evening
> > >> > >  The rice leaves in the garden
> > >> > >  Rustle in the autumn wind
> > >> > >  That blows through my reed hut.
> > >> > > --

Re: [PR] Replace 'size() == 0' with 'isEmpty()' [jspwiki]

2023-10-19 Thread via GitHub 


arturobernalg merged PR #314:
URL: https://github.com/apache/jspwiki/pull/314


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Proposal to Implement New GitHub Actions Workflows for CI/CD

2023-10-19 Thread Arturo Bernal 
Dear Team,

I'd like to propose the addition of three new GitHub Actions workflows to
enhance our CI/CD pipeline for the Apache JSPWiki project. Below are the
details:

   1.

   *Java CI Workflow*: Provides continuous integration support across
   multiple OS (Ubuntu, macOS) and Java versions (11, 17). It also caches
   Maven dependencies for optimized build times.
   2.

   *Dependency Review Workflow*: Triggered on pull requests to review and
   ensure that dependencies are safe.
   3.

   *CodeQL Workflow*: Provides continuous integration and code quality
   checks.

These workflows are designed to automate and streamline our development
process, making it more efficient. They will run on every push to the
master branch and on every pull request, ensuring that our code is
continuously tested and dependencies are reviewed.

I've already created a pull request with these changes, which you can
review here .

Here are the key files to be added:

   - CodeQL (codeql.yml) for continuous integration and code quality checks.
   - Dependency Review (dependency-review.yml) for dependency checks.
   - Java CI (maven.yml) for continuous integration across multiple OS and
   Java versions.

I'd appreciate your thoughts and feedback on this proposal. Are there any
concerns or suggestions you'd like to share?

Best regards,
Arturo

Re: [PR] Avoid method that assume default platform encoding is suitable. [jspwiki]

2023-10-19 Thread via GitHub 


arturobernalg commented on PR #232:
URL: https://github.com/apache/jspwiki/pull/232#issuecomment-1771658384

   Hi @juanpablo-santos,
   
   I've made changes to avoid reliance on default platform encoding,  I think 
this would be a nice addition to the 2.12.2 release. Please take a look.
   
   Best,
   Arturo 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org