[GitHub] [jspwiki] juanpablo-santos commented on pull request #44: JSPWIKI-1117
juanpablo-santos commented on pull request #44: URL: https://github.com/apache/jspwiki/pull/44#issuecomment-792273694 Hi @brushed , thanks for the detailed response! Given that I think we can close both JSPWIKI-1117 and JSPWIKI-1147 with "Won't fix". @takalat since you seem to know finnish :-) one quick contribution that could be made, and would be greatly appreciated, is to complete the associated [i18n fi files](https://jspwiki-wiki.apache.org/Wiki.jsp?page=HowToI18n). According to the [translation status page](https://jspwiki.apache.org/development/i18n.html) they're a bit behind.. thx + best regards, juan pablo This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [jspwiki] juanpablo-santos closed pull request #44: JSPWIKI-1117
juanpablo-santos closed pull request #44: URL: https://github.com/apache/jspwiki/pull/44 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (JSPWIKI-1117) Wiki pages don't allow cookies to be rejected
[
https://issues.apache.org/jira/browse/JSPWIKI-1117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Juan Pablo Santos Rodríguez resolved JSPWIKI-1117.
--
Resolution: Won't Fix
As noted on the [associated
PR|https://github.com/apache/jspwiki/pull/44#issuecomment-791912513],
{quote}
JSPWiki always uses Cookies, a user cannot turn it 100% off. 2 Cookies are
always present: one to keep track of your SESSION (needed for editing), and one
to store the user's preferences.
The initial user preference cookie values are determined by the admin setting
of your site,
and are changed whenever the user modifies them.
This means that a user can never "opt-out". A user has to accept ("ok
understood" button) or click the ('learn more") button.
Other cookies managed by JSPWiki (eg created by other InsertPage plugins with a
show='once') can be viewed or deleted on the User Preferences page.
{quote}
As on first visit, the user preferences cookie is created with values obtained
from the backend. By design it's mandatory for JSPWiki in order to behave as
intended, and given that the other cookies can be deleted within JSPWiki we're
setting the issue as won't fix (note that JSPWIKI-1447 states a different,
related to cookie handling bug, that will be fixed).
> Wiki pages don't allow cookies to be rejected
> -
>
> Key: JSPWIKI-1117
> URL: https://issues.apache.org/jira/browse/JSPWIKI-1117
> Project: JSPWiki
> Issue Type: Bug
>Reporter: Sebb
>Priority: Major
> Labels: pull-request-available
>
> The wiki pages pop up a message about cookies.
> However there is no option to reject cookies, and it looks like some cookies
> are set before the user agrees to the use of cookies.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (JSPWIKI-1147) The button "Clear user preferences" doesn't clear user preferences.
[ https://issues.apache.org/jira/browse/JSPWIKI-1147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17296983#comment-17296983 ] Juan Pablo Santos Rodríguez commented on JSPWIKI-1147: -- Confirmed the bug; will fix it on next commit, if no one beats me to it.. > The button "Clear user preferences" doesn't clear user preferences. > --- > > Key: JSPWIKI-1147 > URL: https://issues.apache.org/jira/browse/JSPWIKI-1147 > Project: JSPWiki > Issue Type: Bug > Environment: Java version: 15.0.2, vendor: Oracle Corporation, > runtime: C:\Program Files\Java\jdk-15.0.2 > OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" > > Apache Tomcat 9.0.43 > JSPWiki 2.11 >Reporter: Jung Jun >Priority: Major > Original Estimate: 10h > Remaining Estimate: 10h > > I built JSPWiki using the command "mvn clean package" and the WAR file is > running on Tomcat version 9.0. > In the "User Preferences" page, the button "Clear User Preferences" doesn't > remove the user preferences which are stored in the cookie > "JSPWikiUserPrefs". Only "JSPWikiAssertedName" is removed from the cookies. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [jspwiki] juanpablo-santos commented on pull request #44: JSPWIKI-1117
juanpablo-santos commented on pull request #44: URL: https://github.com/apache/jspwiki/pull/44#issuecomment-792357329 closed JSPWIKI-1117 with won't fix; after looking closely at JSPWIKI-1147. it is unrelated to the cookie noted before and it's a different bug on its own.. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
